On Tue, 2010-02-02 at 19:20 +0100, Stefan Sperling wrote: > On Tue, Feb 02, 2010 at 06:46:46PM +0100, Bert Huijben wrote: > > I like this change for my uses of 'svn' as '*' is handled by the > > shell, but I don't think the new functionality is logical at the > > svn_client_add() layer. In most gui clients I use, I see some svn > > status output containing the not added files and then these clients > > allow adding all or some of the files via the explicit variant. > > > > Just notifying that you skipped a few files that would have been added > > before, would make it very hard for api users to replicate the old > > behavior via the new api. (Using the notify handler to check for error > > conditions is not so easy for most api users) > > Right now, the no_ignore parameter only disables global ignores, > and svn:ignore ignores are always ignored.
No, that's not right. I just tried it with a trunk build. I set 'svn:ignore' to ignore the file named 'F', and then I try an 'svn add --force' that encounters a file named 'F', without and then with '--no-ignores'. [[[ $ svn mkdir --parents a/b/c A a A a/b A a/b/c $ echo hello > a/F $ echo hello > a/b/G $ svn ps svn:ignore F a a/b a/b/c property 'svn:ignore' set on 'a' property 'svn:ignore' set on 'a/b' property 'svn:ignore' set on 'a/b/c' $ svn add --force a A a/b/G $ svn add --force a $ svn add --force --no-ignore a A a/F ]]] So it looks like your new "no_svn_ignores" parameter is not needed. If you find it does what you said in a different scenario (e.g. if the svn:ignore property is committed versus uncommitted) then clearly that would be a bug. - Julian
