Stack overflow in checksum.c

2015-01-26 Thread Hyrum K Wright
There's a stack overflow bug in subversion/libsubr/checksum.c. The functions svn_checksum__from_digest_fnv1a_32x4() and svn_checksum__from_digest_fnv1a_32() both look something like this: svn_checksum_t * svn_checksum__from_digest_fnv1a_32x4(const unsigned char *digest, apr_pool_t *result

Re: BuildBots

2014-02-18 Thread Hyrum K Wright
On Tue, Feb 18, 2014 at 12:51 PM, Ben Reser wrote: > On 2/17/14, 12:38 PM, Hyrum K Wright wrote: > > I know that on the svn-x64-ubuntu-gcc slave (currently residing in my > > basement), the scripts are updated manually. I may even have local > edits that > > aren't

Re: BuildBots

2014-02-17 Thread Hyrum K Wright
On Fri, Feb 14, 2014 at 6:49 PM, Ben Reser wrote: > We need our buildbots to work for branches. I propose the following > changes, > in decreasing order of priority. > > 1) If something like bindings is broken on a build bot for branches then > disable the test on that buildbot. It is far bette

Re: 1.8.0 release timing

2013-05-30 Thread Hyrum K Wright
On Thu, May 30, 2013 at 2:48 PM, Johan Corveleyn wrote: > On Thu, May 30, 2013 at 11:23 PM, Ben Reser wrote: > > On Thu, May 30, 2013 at 2:00 PM, Greg Stein wrote: > >> As noted elsewhere, press releases are ideally on a Tuesday. I'd really > like > >> to see the release/announce go out, coordi

Re: C++ thoughts for Berlin

2013-05-30 Thread Hyrum K Wright
On Wed, May 29, 2013 at 6:27 PM, Branko Čibej wrote: > On 30.05.2013 03:03, Blair Zajac wrote: > > ... one could stop thinking about memory management. > > Ha, ha, ha. > > I've heard that argument any number of times from C++ enthusiasts. I > still get a kick from seeing their faces after they r

Re: branch 1.8 or at least start making alpha releases?

2013-02-14 Thread Hyrum K Wright
On Thu, Feb 14, 2013 at 12:45 PM, Stefan Sperling wrote: > On Thu, Feb 14, 2013 at 12:36:13PM -0500, C. Michael Pilato wrote: > > As such -- and assuming no one else has a feature waiting in the wings > and > > can make a compelling case for further delaying the release to > accommodate > > it --

Re: packages tree

2013-01-29 Thread Hyrum K Wright
On Tue, Jan 29, 2013 at 6:41 PM, Justin Erenkrantz wrote: > On Tue, Jan 29, 2013 at 1:04 PM, Ben Reser wrote: > >> If we're not going to keep these things up to date then I think we >> should just remove them. >> > > +1 to remove. (It's all version-controlled anyway!) -- justin +1

Re: Running gdb in the build tree Re: OWP: Introduction for Gabriela Gibson

2013-01-21 Thread Hyrum K Wright
On Mon, Jan 21, 2013 at 6:41 AM, Gabriela Gibson wrote: > On 21/01/13 11:05, Daniel Shahaf wrote: > >> On Mon, Dec 10, 2012 at 11:02:22PM -0500, C. Michael Pilato wrote: >> >>> On 12/10/2012 07:32 PM, Daniel Shahaf wrote: >>> Gabriela Gibson wrote on Tue, Dec 11, 2012 at 00:21:19 +:

Re: Diff Project compilation problem

2013-01-09 Thread Hyrum K Wright
On Wed, Jan 9, 2013 at 11:37 AM, Branko Čibej wrote: > On 09.01.2013 17:31, Gabriela Gibson wrote: > > I added a new option to the command structure and the compile error I > > get is this: > > > > ../../subversion/libsvn_client/.libs/libsvn_client-1.so: undefined > > reference to `svn_wc__get_wc

Re: [RFC] Deprecate Berkelety DB filesystem backend

2013-01-05 Thread Hyrum K Wright
+1 -Hyrum On Sat, Jan 5, 2013 at 12:53 PM, Justin Erenkrantz wrote: > +1! -- justin > On Jan 5, 2013 10:40 AM, "Greg Stein" wrote: > >> Is "+1" too short of a response? >> >> :-) >> On Jan 4, 2013 7:35 PM, "Branko Čibej" wrote: >> >>> For the following reasons >>> >>>- FSFS has been the

Re: svn commit: r1425778 - in /subversion/trunk: build.conf tools/dev/fsfs-access-map.c

2012-12-26 Thread Hyrum K Wright
On Wed, Dec 26, 2012 at 8:31 AM, Stefan Fuhrmann < stefanfuhrm...@alice-dsl.de> wrote: > On 12/26/2012 12:54 PM, Bert Huijben wrote: > > One of the build.conf changes applies to __ALL_TESTS__, not to libs. > (There is no such section). > > > I took that from the diff output "libs = __ALL__". > C

Re: RFC: Build system changes

2012-12-13 Thread Hyrum K Wright
On Thu, Dec 13, 2012 at 1:13 PM, Branko Čibej wrote: > The attached patch makes several changes to how we discover compilers > and set flags on *nix: > > * Search for clang as well as the default gcc/cc, and prefer clang(++) > over gcc/g++. > * Set standards-compliance mode (C90/C++11) ev

Re: trunk 'svn merge' takes a very long time to respond.

2012-12-04 Thread Hyrum K Wright
On Tue, Dec 4, 2012 at 8:53 AM, Julian Foad wrote: > Hyrum K Wright wrote: > > > 'svn merge' appears to hang when running a simple merge: > > > > [[[ > > $ svnd merge ^/subversion/trunk/ > > ^Csubversion/svn/util.c:913: (apr_err=4) > > subver

trunk 'svn merge' takes a very long time to respond.

2012-12-03 Thread Hyrum K Wright
'svn merge' appears to hang when running a simple merge: [[[ $ svnd merge ^/subversion/trunk/ ^Csubversion/svn/util.c:913: (apr_err=4) subversion/svn/merge-cmd.c:163: (apr_err=4) subversion/libsvn_client/merge.c:11856: (apr_err=4) subversion/libsvn_client/merge.c:11829: (apr_err=4) subversion/libs

Re: SQLite vacuum or auto_vacuum?

2012-12-03 Thread Hyrum K Wright
On Mon, Dec 3, 2012 at 7:08 AM, Philip Martin wrote: > Prompted by a question on users I wondered how SQLite's vacuum > (http://sqlite.org/lang_vacuum.html) would affect wc.db size. On a > Subversion trunk working copy I have been using for months the size was > reduced from 2.3MB to 1.3MB which

Re: Start the process for releasing 1.7.8 (Was: FW: 1.7.7 svn client x64 crashes while committing with credentials provided on the command line.)

2012-12-03 Thread Hyrum K Wright
On Mon, Dec 3, 2012 at 5:10 AM, Bert Huijben wrote: > > > > -Original Message- > > From: Thorsten Schöning [mailto:tschoen...@am-soft.de] > > Sent: maandag 3 december 2012 07:48 > > To: us...@subversion.apache.org > > Subject: Re: 1.7.7 svn client x64 crashes while committing with > crede

Re: 1.8 Progress

2012-12-01 Thread Hyrum K Wright
On Thu, Nov 29, 2012 at 4:52 PM, C. Michael Pilato wrote: > > > 2) Ev2. The notes say this is believed to be in a releasable state? Is > > there any work needed to verify this? Do we need to remove the use of > Ev2 > > in any place to avoid releasing with compatibility shims in use? Are we > > c

Re: svn commit: r1414728 - in /subversion/trunk: ./ build/generator/ subversion/bindings/cxxhl/ subversion/bindings/cxxhl/include/ subversion/bindings/cxxhl/include/types/ subversion/bindings/cxxhl/sr

2012-11-29 Thread Hyrum K Wright
On Wed, Nov 28, 2012 at 3:10 PM, Branko Čibej wrote: > On 28.11.2012 17:15, Philip Martin wrote: > > Branko Čibej writes: > > > >> On 28.11.2012 15:39, br...@apache.org wrote: > >>> Author: brane > >>> Date: Wed Nov 28 14:39:42 2012 > >>> New Revision: 1414728 > >>> > >>> URL: http://svn.apache.

Re: [RFC] Ev2 implementations in ev2 subdirectory

2012-11-27 Thread Hyrum K Wright
On Tue, Nov 27, 2012 at 9:21 AM, Daniel Shahaf wrote: > Hyrum K Wright wrote on Tue, Nov 27, 2012 at 09:11:50 -0500: > > On Tue, Nov 27, 2012 at 9:07 AM, Daniel Shahaf >wrote: > > > > > Hyrum K Wright wrote on Tue, Nov 27, 2012 at 07:49:04 -0500: > > > >

Re: [RFC] Ev2 implementations in ev2 subdirectory

2012-11-27 Thread Hyrum K Wright
On Tue, Nov 27, 2012 at 9:07 AM, Daniel Shahaf wrote: > Hyrum K Wright wrote on Tue, Nov 27, 2012 at 07:49:04 -0500: > > Instead, I propose subdirectories named ev2 in the various libsvn_foo > > directories which would hold Ev2 implementations. They would eventually > go &

[RFC] Ev2 implementations in ev2 subdirectory

2012-11-27 Thread Hyrum K Wright
Greetings all! r1413184 introduced the --enable-ev2-impl flag to configure on trunk to allow interested users to compile with the Ev2 implementations of various operations. While the set of things that supports Ev2 is not nearly complete, it is (slowly) growing, and I'd like to do that developmen

Re: Test code coverage

2012-11-26 Thread Hyrum K Wright
On Sun, Nov 25, 2012 at 5:17 PM, Stefan Fuhrmann < stefan.fuhrm...@wandisco.com> wrote: > Hi there, > > I was wondering whether we could have one or two of > our UNIX build bots create a code coverage profile > and make the results available online. > > Here is what I use in my test runner script:

Re: svn commit: r1413109 - in /subversion/trunk: ./ subversion/svnrdump/svnrdump.c subversion/svnrdump/svnrdump.h

2012-11-24 Thread Hyrum K Wright
On Fri, Nov 23, 2012 at 7:44 PM, Branko Čibej wrote: > On 24.11.2012 01:39, hwri...@apache.org wrote: > > Author: hwright > > Date: Sat Nov 24 00:39:38 2012 > > New Revision: 1413109 > > > > URL: http://svn.apache.org/viewvc?rev=1413109&view=rev > > Log: > > Cherrypick r1413107 from the ev2-expor

Re: svn commit: r1411629 - /subversion/trunk/subversion/tests/libsvn_fs/fs-test.c

2012-11-24 Thread Hyrum K Wright
Sure, if philip thinks it's appropriate. On Sat, Nov 24, 2012 at 1:08 AM, Daniel Shahaf wrote: > Revert r1412515 then? > > Hyrum K Wright wrote on Fri, Nov 23, 2012 at 15:29:32 -0500: > > I did a little poking and fixed this in r1413046. > > > > > > On

Re: svn commit: r1411629 - /subversion/trunk/subversion/tests/libsvn_fs/fs-test.c

2012-11-23 Thread Hyrum K Wright
I did a little poking and fixed this in r1413046. On Fri, Nov 23, 2012 at 2:18 PM, Hyrum K Wright wrote: > This test isn't cleaning up after itself (or before a subsequent run). > The first time I run it in a working copy, it passes, but the next time, I > get the following err

Re: svn commit: r1411629 - /subversion/trunk/subversion/tests/libsvn_fs/fs-test.c

2012-11-23 Thread Hyrum K Wright
This test isn't cleaning up after itself (or before a subsequent run). The first time I run it in a working copy, it passes, but the next time, I get the following error: $ ./fs-test 37 subversion/tests/libsvn_fs/fs-test.c:4908: (apr_err=160033) subversion/tests/svn_test_fs.c:183: (apr_err=160033

Re: 1.8 Progress

2012-11-01 Thread Hyrum K Wright
On Thu, Nov 1, 2012 at 3:11 PM, C. Michael Pilato wrote: > On 11/01/2012 02:42 PM, Ben Reser wrote: >> 2) Ev2. The notes say this is believed to be in a releasable state? Is >> there any work needed to verify this? Do we need to remove the use of Ev2 >> in any place to avoid releasing with comp

Re: [Subversion Wiki] Update of "FS2_Design" by brane

2012-10-24 Thread Hyrum K Wright
On Wed, Oct 24, 2012 at 11:25 PM, Apache subversion Wiki wrote: > Dear Wiki user, > > You have subscribed to a wiki page or wiki category on "Subversion Wiki" for > change notification. > > The "FS2_Design" page has been changed by brane: > http://wiki.apache.org/subversion/FS2_Design?action=diff

Re: svn commit: r1400545 - /subversion/trunk/subversion/libsvn_ra/ra_loader.c

2012-10-22 Thread Hyrum K Wright
On Mon, Oct 22, 2012 at 11:46 AM, Philip Martin wrote: > Hyrum K Wright writes: > >> On Mon, Oct 22, 2012 at 7:55 AM, Philip Martin >> wrote: >>> hwri...@apache.org writes: >>> >>>> Author: hwright >>>> Date: Sun Oct 21

Re: svn commit: r1400545 - /subversion/trunk/subversion/libsvn_ra/ra_loader.c

2012-10-22 Thread Hyrum K Wright
On Mon, Oct 22, 2012 at 7:55 AM, Philip Martin wrote: > hwri...@apache.org writes: > >> Author: hwright >> Date: Sun Oct 21 01:18:26 2012 >> New Revision: 1400545 >> >> URL: http://svn.apache.org/viewvc?rev=1400545&view=rev >> Log: >> Refactor the pre-1.5 fallback code for replay_ranges into a sep

Re: Sparse Externals

2012-10-18 Thread Hyrum K Wright
On Thu, Oct 18, 2012 at 5:30 PM, Ben Reser wrote: > Regarding this issue: http://subversion.tigris.org/issues/show_bug.cgi?id=3311 > > We don't support using --depth options other than infinity with > externals. Bert mentions that wc-ng should make it easier to > implement this. > > However, give

Re: Regular expressions in Subversion

2012-10-17 Thread Hyrum K Wright
On Wed, Oct 17, 2012 at 1:22 PM, Daniel Shahaf wrote: > Hyrum K Wright wrote on Wed, Oct 17, 2012 at 12:20:20 -0400: >> These come at the expenses of a couple of less-used regex features, > > PLease be objective/specific: it doesn't support backreferences and > zero-widt

Regular expressions in Subversion

2012-10-17 Thread Hyrum K Wright
There are several places where regular expressions would be useful in Subversion. Off hand, the new log --search feature and svn:ignore properties feel like they'd be use candidates for regexs, and they could probably also apply to authz rules eventually. I'm sure there are more. Historically, t

Re: svn commit: r1399064 - in /subversion/trunk/subversion/bindings/javahl: native/ src/org/apache/subversion/javahl/

2012-10-16 Thread Hyrum K Wright
On Tue, Oct 16, 2012 at 9:36 PM, Mark Phippard wrote: >> >> On Oct 16, 2012, at 9:25 PM, "Hyrum Wright" wrote: >> >>> On Tue, Oct 16, 2012 at 9:19 PM, wrote: Author: hwright Date: Wed Oct 17 01:19:21 2012 New Revision: 1399064 URL: http://svn.apache.org/viewvc?rev=13990

Re: svn commit: r1387696 - /subversion/trunk/subversion/libsvn_wc/conflicts.c

2012-10-11 Thread Hyrum K Wright
On Thu, Oct 11, 2012 at 7:15 PM, Stefan Sperling wrote: > On Thu, Oct 11, 2012 at 05:25:03PM -0400, Hyrum K Wright wrote: >> Does this (untested) patch make sense? > > Oh yes, very much! Thanks! r1397425 -Hyrum > >> [[[ >> Index: su

Re: svn commit: r1396826 - /subversion/trunk/subversion/libsvn_fs_fs/tree.c

2012-10-11 Thread Hyrum K Wright
Updated in r1397331. On Thu, Oct 11, 2012 at 1:09 AM, Ben Reser wrote: > They are indeed. It's always bothered me that we didn't use a stable > type for our revnums: > > $ grep svn_revnum_t subversion/include/svn_types.h | grep typedef > typedef long int svn_revnum_t; > > On Wed, Oct 10, 2012 at

Re: svn commit: r1387696 - /subversion/trunk/subversion/libsvn_wc/conflicts.c

2012-10-11 Thread Hyrum K Wright
On Thu, Oct 11, 2012 at 3:01 PM, Stefan Sperling wrote: > On Thu, Oct 11, 2012 at 12:20:32PM -0400, Hyrum K Wright wrote: >> > + /* Compute the incoming side of the conflict ('action'). */ >> > + if (their_value == NULL) >> > +desc

Re: svn commit: r1390438 - in /subversion/trunk: ./ subversion/include/private/ subversion/libsvn_ra_svn/ subversion/libsvn_subr/ tools/client-side/svn-bench/ tools/dist/

2012-10-11 Thread Hyrum K Wright
On Wed, Oct 10, 2012 at 1:46 PM, Hyrum K Wright wrote: > On Wed, Sep 26, 2012 at 8:39 AM, wrote: >> Author: stefan2 >> Date: Wed Sep 26 12:38:59 2012 >> New Revision: 1390438 >> >> URL: http://svn.apache.org/viewvc?rev=1390438&view=rev >> Log: >

Re: svn commit: r1387696 - /subversion/trunk/subversion/libsvn_wc/conflicts.c

2012-10-11 Thread Hyrum K Wright
On Wed, Sep 19, 2012 at 2:06 PM, wrote: > Author: stsp > Date: Wed Sep 19 18:06:13 2012 > New Revision: 1387696 > > URL: http://svn.apache.org/viewvc?rev=1387696&view=rev > Log: > * subversion/libsvn_wc/conflicts.c > (read_prop_conflicts): New helper to prepare for the times when new > conf

Re: Request svn.a.o upgrade from 1.7.0 to 1.7.7?

2012-10-10 Thread Hyrum K Wright
On Wed, Oct 10, 2012 at 4:06 PM, Julian Foad wrote: > I just noticed asf.a.o is running 1.7.0, according to the footer on pages > like . > > Shall we request infra upgrade it to 1.7.7? Seems like a good idea to me > (eating our own dogfood), but not su

Re: Subversion 1.8 -- where are we?

2012-10-10 Thread Hyrum K Wright
On Wed, Oct 10, 2012 at 11:30 AM, C. Michael Pilato wrote: > It's been a bit since I prodded the community for a status check on > Subversion 1.8, so here we go. > > Let's start with roadmap.html. We've got several "green lights" on the > grid. We've got several yellows, too: > > - Improved hand

Re: svn commit: r1390438 - in /subversion/trunk: ./ subversion/include/private/ subversion/libsvn_ra_svn/ subversion/libsvn_subr/ tools/client-side/svn-bench/ tools/dist/

2012-10-10 Thread Hyrum K Wright
On Wed, Sep 26, 2012 at 8:39 AM, wrote: > Author: stefan2 > Date: Wed Sep 26 12:38:59 2012 > New Revision: 1390438 > > URL: http://svn.apache.org/viewvc?rev=1390438&view=rev > Log: > Merge second batch of changes from the 10Gb branch. These add the > svn-bench tool. ... > Modified: subversion/tru

Re: Dead code or bug in gpg_agent.c

2012-10-10 Thread Hyrum K Wright
On Tue, Oct 9, 2012 at 4:34 AM, Daniel Shahaf wrote: > Hyrum K Wright wrote on Mon, Oct 08, 2012 at 21:51:02 -0400: >> Poking around subversion/libsvn_subr/gpg_agent.c I found this snippet >> (at around line 325): >> >> [[[ >> /* Send DISPLAY to the gpg-agent

Dead code or bug in gpg_agent.c

2012-10-08 Thread Hyrum K Wright
Poking around subversion/libsvn_subr/gpg_agent.c I found this snippet (at around line 325): [[[ /* Send DISPLAY to the gpg-agent daemon. */ display = getenv("DISPLAY"); if (display != NULL) { request = apr_psprintf(pool, "OPTION display=%s\n", display); if (!send_option(sd, b

Re: PGP Keys

2012-10-08 Thread Hyrum K Wright
On Fri, Oct 5, 2012 at 6:10 PM, Ben Reser wrote: > Given that we're coming up on a couple of opportunities for various > developers to get together an potentially sign keys I thought I'd > bring this subject up. > > 1) SHA-1 based keys should be migrated off of. The US Government's > requirement

Re: buildbot failure in ASF Buildbot on svn-x64-ubuntu-gcc

2012-09-25 Thread Hyrum K Wright
On Tue, Sep 25, 2012 at 12:29 AM, Ben Reser wrote: > On Mon, Sep 24, 2012 at 8:27 PM, Hyrum K Wright wrote: >> For the time being, the Ruby build step and tests have been commented >> out of the relevant scripts. >> >> I think there is value in running a bot on a stoc

Re: buildbot failure in ASF Buildbot on svn-x64-ubuntu-gcc

2012-09-24 Thread Hyrum K Wright
On Mon, Sep 24, 2012 at 11:15 PM, Ben Reser wrote: > On Mon, Sep 24, 2012 at 7:38 PM, Hyrum K Wright wrote: >> The svn-x64-ubuntu-gcc bot currently lives in my basement, and was >> recently upgraded to the latest Ubuntu beta release, which bumped a >> number of dependency v

Re: [svnbench] Revision: 1389172 compiled Sep 24 2012, 00:21:39 on x86_64-unknown-linux-gnu

2012-09-24 Thread Hyrum K Wright
On Mon, Sep 24, 2012 at 7:26 PM, Ivan Zhakov wrote: > On Mon, Sep 24, 2012 at 10:03 PM, Stefan Sperling wrote: >> On Mon, Sep 24, 2012 at 01:50:36PM -0400, C. Michael Pilato wrote: >>> That's correct. >>> >>> And Philip, I see this as really two issues: >>> >>> 1. we auto-upgrade working copies (

Re: buildbot failure in ASF Buildbot on svn-x64-ubuntu-gcc

2012-09-24 Thread Hyrum K Wright
On Mon, Sep 24, 2012 at 8:02 PM, Ben Reser wrote: > On Wed, Sep 19, 2012 at 2:14 AM, Philip Martin > wrote: >> In build/ac-macros/swig.m4 the -ansi flag is explicltly removed for the >> Ruby bindings so that gcc accepts things like that. > > Thanks, that worked. I've committed something to that

Re: Finalizing the definition of 1.8.0

2012-08-16 Thread Hyrum K Wright
On Wed, Aug 15, 2012 at 12:21 PM, C. Michael Pilato wrote: > Hello, all. > > Echoing in the back of my head are promises we devs have made to avoid long > release cycles, and 1.7.0 recently turned 10 months old. There are a few > ongoing bits of feature work happening on branches or in various st

Re: Is there a way to post a comment to a subversion issue without agreeing to colabnet terms?

2012-08-14 Thread Hyrum K Wright
On Sat, Aug 11, 2012 at 2:11 AM, Greg Stein wrote: > To be fair, Apache Bloodhound (incubating) is just one option. We > could preserve issue numbers with a migration to Bugzilla, Jira, or > Google Code. (not sure if other options have been raised as options, > in the past) > > My leanings are tow

Re: 1.7.6 Candidates

2012-08-08 Thread Hyrum K Wright
On Wed, Aug 8, 2012 at 1:40 PM, Philip Martin wrote: > Subversion 1.7.6 tarballs are now available for testing/signing by > committers. To obtain them please check out a working copy from > https://dist.apache.org/repos/dist/dev/subversion > > Please add your signatures to the .asc files there. >

Re: 1.7.6 Plan?

2012-08-03 Thread Hyrum K Wright
On Fri, Aug 3, 2012 at 4:41 AM, Greg Stein wrote: > > On Aug 3, 2012 4:31 AM, "Philip Martin" wrote: >> >> Justin Erenkrantz writes: >> >> > On Thu, Aug 2, 2012 at 6:10 PM, Hyrum K Wright >> > wrote: >> >> So, I'm still on s

1.7.6 Plan?

2012-08-02 Thread Hyrum K Wright
So, I'm still on semi-hiatus, but I've been seeing all this stuff being merged to 1.7.x and I can't help but wonder what the plan for the 1.7.6 release is. I haven't found any discussion on list. The release process has changed enough since I RM'd that I'm not quite confident I can volunteer to s

Re: Deterministic FSFS revision files

2012-07-30 Thread Hyrum K Wright
On Mon, Jul 30, 2012 at 1:19 PM, C. Michael Pilato wrote: > On 07/30/2012 12:47 PM, Philip Martin wrote: >> I'm considering changing the commit code so that hashes are written in a >> stable order and the revision files are repeatable. Does anyone think >> this would be a bad idea? > > I can't th

Re: Format bump for 1.8?

2012-07-13 Thread Hyrum K Wright
On Fri, Jul 13, 2012 at 5:32 AM, Branko Čibej wrote: >... > And really, there's no reason why the Subversion command-line client > shouldn't do the same thing -- in fact, this is by far the easiest way > to support multiple working copy formats, even if it is less than > optimal as far as installe

Re: Format bump for 1.8?

2012-07-11 Thread Hyrum K Wright
On Wed, Jul 11, 2012 at 3:19 PM, Johan Corveleyn wrote: > On Wed, Jul 11, 2012 at 8:07 PM, Hyrum K Wright wrote: >> On Wed, Jul 11, 2012 at 12:25 PM, Johan Corveleyn wrote: >>> On Wed, Jul 11, 2012 at 7:14 PM, Hyrum K Wright >>> wrote: >>>> On Wed, Ju

Re: Format bump for 1.8?

2012-07-11 Thread Hyrum K Wright
On Wed, Jul 11, 2012 at 12:25 PM, Johan Corveleyn wrote: > On Wed, Jul 11, 2012 at 7:14 PM, Hyrum K Wright wrote: >> On Wed, Jul 11, 2012 at 12:09 PM, Johan Corveleyn wrote: >>> ... >>> For instance, we could simply package two set of binaries/libraries in >>

Re: Format bump for 1.8?

2012-07-11 Thread Hyrum K Wright
On Wed, Jul 11, 2012 at 12:09 PM, Johan Corveleyn wrote: > ... > For instance, we could simply package two set of binaries/libraries in > one package (the 1.8.0 version together with 1.7.x (taken from the > corresponding tag)), and implement a main wrapper that delegates > everything to the approp

Re: Format bump for 1.8?

2012-07-11 Thread Hyrum K Wright
On Wed, Jul 11, 2012 at 9:23 AM, C. Michael Pilato wrote: > On 07/11/2012 09:50 AM, Johan Corveleyn wrote: >> Yes, I agree we'd have to make it clear in our docs that feature X >> depends on working copy format Y. That's an additional effort, yes. >> But for the book or the FAQ it's not a lot diff

Re: Revprop packing implemented

2012-07-07 Thread Hyrum K Wright
On Fri, Jul 6, 2012 at 3:32 AM, Stefan Fuhrmann wrote: > Hi devs, > > This week I had one of my "how hard can it be?" moments > and finally implemented revprop packing (did that mainly > offline). It passes all tests and seems to work pretty well. > > It's design deviates from the existing revprop

Re: Format bump for 1.8?

2012-06-27 Thread Hyrum K Wright
On Wed, Jun 27, 2012 at 9:13 PM, Branko Čibej wrote: > On 28.06.2012 01:32, Greg Stein wrote: >> On Wed, Jun 27, 2012 at 7:19 PM, Johan Corveleyn wrote: >>> On Tue, Jun 26, 2012 at 10:51 AM, Stefan Sperling wrote: On Mon, Jun 25, 2012 at 07:51:59PM -0400, Greg Stein wrote: >>> ... I wo

Re: Ev2 design questions

2012-06-27 Thread Hyrum K Wright
On Wed, Jun 27, 2012 at 3:57 AM, Greg Stein wrote: > Let's not over complicate this people. get_commit_ev2() has cancellation > params for no other reason than I was unaware of the session variables. As I suspected. :P -Hyrum

Re: Ev2 design questions

2012-06-26 Thread Hyrum K Wright
On Tue, Jun 26, 2012 at 7:10 PM, Vladimir Berezniker wrote: > On Tue, Jun 26, 2012 at 3:17 PM, Hyrum K Wright > wrote: >> On Sun, Jun 24, 2012 at 6:09 PM, Vladimir Berezniker >> wrote: >>> Hi All, >>> >>> I have been taking a peek at

Re: [PATCH] JavaHL: Support commit callback across method invocations

2012-06-26 Thread Hyrum K Wright
On Sun, Jun 24, 2012 at 8:31 PM, Vladimir Berezniker wrote: > In case of delta editor, commit callback is provided at the time of the editor > creation and used during the close_edit() call. For that there is a need to > keep a global reference to the underlying java object so that it does not get

Re: [RFC] JavaHL: Moving some of the C++ object address logic into Java

2012-06-26 Thread Hyrum K Wright
On Sun, Jun 24, 2012 at 9:20 PM, Vladimir Berezniker wrote: > Hi All, > > In the current JavaHL code the C++ objects are attached via pointer stored in > the long cppAddr field in java object.  The way C++ code gets hold of the > cppAddr value is to read this field using the GetLongField(). In sum

Re: Ev2 design questions

2012-06-26 Thread Hyrum K Wright
On Sun, Jun 24, 2012 at 6:09 PM, Vladimir Berezniker wrote: > Hi All, > > I have been taking a peek at ev2 code to see what it would take for JavaHL > implementation and I have following questions that do not seem do be covered > by the docs: > >   * svn_ra__get_commit_ev2() takes svn_cancel_func_

Re: Bigger --deltas dump with 1.7.5 than with 1.6.17

2012-06-26 Thread Hyrum K Wright
On Sat, Jun 23, 2012 at 9:15 AM, Branko Čibej wrote: > On 23.06.2012 00:23, Vincent Lefevre wrote: >> Thanks for the explanations. >> >> On 2012-06-22 00:18:50 +0200, Stefan Fuhrmann wrote: >>> xdelta uses fixed-size 100kByte deltification windows. >>> The Changelog file in question is >400k, i.e.

Re: Open mailing lists

2012-06-18 Thread Hyrum K Wright
to post here.  I think it's terrible >> practice to openly publish email addresses in easily harvestable form.  I'll >> be /dev/nulling this address and unsubscribing.  I hope you could reconsider >> that policy, >> >> Darren >> >> On Tue, Mar 13, 201

Hyrum limited connectivity for a couple of weeks

2012-06-15 Thread Hyrum K Wright
Hi all, After a great time at the hackathon this week, I need a vacation. I'll be with limited connectivity over the next few weeks as my family and I road trip around the US. I'll probably do mail in batch every few days. That shouldn't stop Ev2 work from continuing though, and I'd encourage fol

Re: [PATCH] JavaHL: New method for creating java objects linked to their C++ counterpart

2012-06-14 Thread Hyrum K Wright
On Thu, Jun 14, 2012 at 3:11 PM, Greg Stein wrote: > On Thu, Jun 14, 2012 at 8:54 AM, Vladimir Berezniker > wrote: >> On Thu, Jun 14, 2012 at 8:48 AM, Hyrum K Wright >> wrote: >>... >>> The RA layer (on trunk) already exposes Ev2 via the >>> svn_ra__

Re: [PATCH] JavaHL: New method for creating java objects linked to their C++ counterpart

2012-06-14 Thread Hyrum K Wright
On Thu, Jun 14, 2012 at 2:40 PM, Vladimir Berezniker wrote: > > > On Thu, Jun 14, 2012 at 8:13 AM, Hyrum K Wright > wrote: >> * We're in the middle of a rather large effort to move from the >> current delta editor to something called Ev2.  Ev2 should be simpler &

Re: [PATCH] JavaHL: New method for creating java objects linked to their C++ counterpart

2012-06-14 Thread Hyrum K Wright
On Mon, Jun 11, 2012 at 2:39 PM, Vladimir Berezniker wrote: > > > On Mon, Jun 11, 2012 at 6:20 AM, Hyrum K Wright > wrote: >> >> On Thu, Jun 7, 2012 at 4:03 AM, Vladimir Berezniker >> wrote: >> > Hi All, >> > >> > The intention if this pa

Re: svn commit: r1349944 - /subversion/trunk/gen-make.py

2012-06-14 Thread Hyrum K Wright
On Thu, Jun 14, 2012 at 11:36 AM, Bert Huijben wrote: > > >> -Original Message- >> From: Greg Stein [mailto:gst...@gmail.com] >> Sent: Thursday, June 14, 2012 10:44 AM >> To: Bert Huijben; Hyrum K Wright >> Cc: dev@subversion.apache.org >> Subje

Re: [PATCH] JavaHL: New method for creating java objects linked to their C++ counterpart

2012-06-14 Thread Hyrum K Wright
On Thu, Jun 14, 2012 at 10:16 AM, Mat Booth wrote: > On 12 June 2012 03:11, Vladimir Berezniker wrote: >> >> >> On Mon, Jun 11, 2012 at 8:39 AM, Vladimir Berezniker >> wrote: >>> >>> >>> >>> On Mon, Jun 11, 2012 at 6:20 AM, Hyru

Re: svn commit: r1349944 - /subversion/trunk/gen-make.py

2012-06-14 Thread Hyrum K Wright
On Thu, Jun 14, 2012 at 1:23 AM, Bert Huijben wrote: > > >> -Original Message----- >> From: Hyrum K Wright [mailto:hyrum.wri...@wandisco.com] >> Sent: Thursday, June 14, 2012 12:33 AM >> To: Bert Huijben >> Cc: Michael Pilato; Subversion Development

Re: svn commit: r1349944 - /subversion/trunk/gen-make.py

2012-06-13 Thread Hyrum K Wright
On Wed, Jun 13, 2012 at 9:45 PM, Bert Huijben wrote: > > >> -Original Message- >> From: C. Michael Pilato [mailto:cmpil...@collab.net] >> Sent: Wednesday, June 13, 2012 9:34 PM >> To: dev@subversion.apache.org >> Cc: Hyrum K Wright; comm...@subversion.a

Re: svn commit: r1349944 - /subversion/trunk/gen-make.py

2012-06-13 Thread Hyrum K Wright
On Wed, Jun 13, 2012 at 6:10 PM, wrote: > Author: rhuijben > Date: Wed Jun 13 16:10:25 2012 > New Revision: 1349944 > > URL: http://svn.apache.org/viewvc?rev=1349944&view=rev > Log: > * gen-make.py >  Make the --with-neon= and --without-neon arguments on gen-make.py optional, >  just like how ./c

Re: Patch to remove libsvn_ra_neon

2012-06-13 Thread Hyrum K Wright
On Wed, Jun 13, 2012 at 9:33 AM, Greg Stein wrote: > On Tue, Jun 12, 2012 at 7:47 AM, Hyrum K Wright > wrote: >> We've had the "should we remove neon?" discussion before, and the >> consensus has felt to resolve in the affirmative.  Now is the time for >>

Re: svn commit: r1349661 - /subversion/trunk/subversion/libsvn_subr/cache-memcache.c

2012-06-13 Thread Hyrum K Wright
On Wed, Jun 13, 2012 at 9:22 AM, wrote: > Author: gstein > Date: Wed Jun 13 07:22:00 2012 > New Revision: 1349661 > > URL: http://svn.apache.org/viewvc?rev=1349661&view=rev > Log: > Followup to r1349277: old APRs do not have APR_INT16_MAX > > * subversion/libsvn_subr/cache-memcache.c: >  (...): d

Re: Patch to remove libsvn_ra_neon

2012-06-12 Thread Hyrum K Wright
On Tue, Jun 12, 2012 at 11:57 PM, Stefan Sperling wrote: > On Tue, Jun 12, 2012 at 01:47:13PM +0200, Hyrum K Wright wrote: >> We've had the "should we remove neon?" discussion before, and the >> consensus has felt to resolve in the affirmative.  Now is the time for

Re: svn commit: r1349316 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2012-06-12 Thread Hyrum K Wright
On Tue, Jun 12, 2012 at 3:22 PM, wrote: > Author: stefan2 > Date: Tue Jun 12 13:22:40 2012 > New Revision: 1349316 > > URL: http://svn.apache.org/viewvc?rev=1349316&view=rev > Log: > Fix "unreachable code" warning under Windows. In the for (i=0;i loop header, the ++i would never be executed. So,

Re: svn commit: r1336833 - in /subversion/trunk/subversion: include/svn_wc.h libsvn_client/merge.c libsvn_wc/deprecated.c libsvn_wc/merge.c

2012-06-12 Thread Hyrum K Wright
On Thu, May 31, 2012 at 4:32 PM, Hyrum K Wright wrote: > On Thu, May 10, 2012 at 2:13 PM,   wrote: >> Author: rhuijben >> Date: Thu May 10 19:13:11 2012 >> New Revision: 1336833 >> >> URL: http://svn.apache.org/viewvc?rev=1336833&view=rev >> Log: >

Patch to remove libsvn_ra_neon

2012-06-12 Thread Hyrum K Wright
We've had the "should we remove neon?" discussion before, and the consensus has felt to resolve in the affirmative. Now is the time for action. I've got a 586 kb patch which removes libsvn_ra_neon from trunk. It doesn't not remove the --http-library runtime option or config file code, but does r

Re: [PATCH] JavaHL: Factor out common context to be shared between SVNClient and SVNRa classes

2012-06-11 Thread Hyrum K Wright
On Mon, Jun 11, 2012 at 2:58 PM, Vladimir Berezniker wrote: > > > On Mon, Jun 11, 2012 at 6:56 AM, Hyrum K Wright > wrote: >> >> On Thu, Jun 7, 2012 at 5:09 AM, Vladimir Berezniker >> wrote: >> > Greetings, >> > >> > This patch signifies

Re: XPASSes in merge symetric tests

2012-06-11 Thread Hyrum K Wright
On Mon, Jun 11, 2012 at 2:13 PM, Philip Martin wrote: > Hyrum K Wright writes: > >> Julian, >> I'm seeing the following XPASSs on trunk: >> At least one test XPASSED, checking /Users/Hyrum/dev/svn-trunk2/tests.log >> XPASS: merge_symmetric_tests.

Re: What mechanisms for code comparison and merge between versions on svn are used?

2012-06-11 Thread Hyrum K Wright
On Sun, Jun 10, 2012 at 8:51 AM, Carlos Andrade wrote: > Hi, > > I was interested on learning more about the mechanisms used on svn to verify > if a certain code has been modified or not and how the merge function works. > Is there any non-code documentation available for this? I would also be > i

XPASSes in merge symetric tests

2012-06-11 Thread Hyrum K Wright
Julian, I'm seeing the following XPASSs on trunk: At least one test XPASSED, checking /Users/Hyrum/dev/svn-trunk2/tests.log XPASS: merge_symmetric_tests.py 7: merge_to_and_fro_1_1 XPASS: merge_symmetric_tests.py 8: merge_to_and_fro_1_2 XPASS: merge_symmetric_tests.py 9: merge_to_and_fro_2_1 XPASS:

Re: [PATCH] JavaHL: Factor out common context to be shared between SVNClient and SVNRa classes

2012-06-11 Thread Hyrum K Wright
On Mon, Jun 11, 2012 at 12:56 PM, Hyrum K Wright wrote: > On Thu, Jun 7, 2012 at 5:09 AM, Vladimir Berezniker > wrote: >> Greetings, >> >> This patch signifies a point post which I can merge the existing logic on >> the >> javahl-ra branch with starting par

Re: [PATCH] JavaHL: Factor out common context to be shared between SVNClient and SVNRa classes

2012-06-11 Thread Hyrum K Wright
On Thu, Jun 7, 2012 at 5:09 AM, Vladimir Berezniker wrote: > Greetings, > > This patch signifies a point post which I can merge the existing logic on > the > javahl-ra branch with starting parts of my proposed enhancements. So I hope > people still have some patience left to review them. > > This

Re: [PATCH] JavaHL: New method for creating java objects linked to their C++ counterpart

2012-06-11 Thread Hyrum K Wright
On Thu, Jun 7, 2012 at 4:03 AM, Vladimir Berezniker wrote: > Hi All, > > The intention if this patch is to introduce reusable logic for creating java > objects from within C++.  This keeps object creation logic fully within C++ > while leaving to java the decision as to when they will be destroyed

Re: svn commit: r1348782 - /subversion/trunk/subversion/tests/cmdline/blame_tests.py

2012-06-11 Thread Hyrum K Wright
Greg, As soon as I do the merge, this will fix the last test failure on the ev2-export branch. It looks like we've got a solid commit editor driving Ev2. My next target, hopefully for this week, is to implement replay using Ev2. Since this is about reading data, and is mainly server-side, I plan

Re: svn commit: r1348770 - /subversion/trunk/subversion/libsvn_subr/pool.c

2012-06-11 Thread Hyrum K Wright
On Mon, Jun 11, 2012 at 11:33 AM, wrote: > Author: ivan > Date: Mon Jun 11 09:33:36 2012 > New Revision: 1348770 > > URL: http://svn.apache.org/viewvc?rev=1348770&view=rev > Log: > Fix compiler warning. > > * subversion/libsvn_subr/pool.c >  (abort_on_pool_failure): Add return statement to make c

Mac OS X buildslaves

2012-06-06 Thread Hyrum K Wright
Hello infra! In the past, the Subversion project has had build slave configured to run our testsuite on Mac OS. These slaves, svn-x64-macosx-gnu-shared, svn-x64-macosx-gnu-shared-daily-ra_serf, were useful, but privately owned and have been dark for several months. What type of resources exist w

Re: [PATCH] JavaHL: Support logging of the static method calls

2012-06-05 Thread Hyrum K Wright
Looks good, +1 to commit to trunk. -Hyrum On Wed, Jun 6, 2012 at 1:39 AM, Vladimir Berezniker wrote: > [[[ > JavaHL: Support logging of the static method calls > > [ in subversion/bindings/javahl/native ] > > * JNIStackElement.cpp >   (JNIStackElement): Add logic to deal with NULL jthis, which h

MacOS buildslave?

2012-06-04 Thread Hyrum K Wright
We used to have a buildslave for MacOS, but it went offline and hasn't been replaced. Do we know if infrastructure has the resources to provide a slave for testing Subversion on MacOS? I consistently see a local failure in stat test 19 on a clean working copy, but since it only appears on MacOS,

Re: validity check error? huh?

2012-06-01 Thread Hyrum K Wright
On Fri, Jun 1, 2012 at 6:19 AM, Bert Huijben wrote: ... > > I don’t see a problem with bumping the requirement to 3.7.9, but that > decision should be made here on this list. Not by me :) We've talked elsewhere about bumping the required version to 3.7.12 to take advantage of further improvements

Re: [PATCH] JavaHL: Reduce amount of duplicate code used to check C++ pointer extracted from the java object

2012-05-31 Thread Hyrum K Wright
On Thu, May 31, 2012 at 4:36 AM, Julian Foad wrote: > > > > > - Original Message - >> From: Greg Stein >> To: Vladimir Berezniker >> Cc: dev@subversion.apache.org >> Sent: Thursday, 31 May 2012, 8:35 >> Subject: Re: [PATCH] JavaHL: Reduce amount of duplicate code used to check >> C++ po

Re: [PATCH] JavaHL: Reduce amount of duplicate code used to check C++ pointer extracted from the java object

2012-05-31 Thread Hyrum K Wright
On Thu, May 31, 2012 at 2:35 AM, Greg Stein wrote: > On Thu, May 31, 2012 at 12:43 AM, Vladimir Berezniker > wrote: >> Patch 01 - Introduce macro >> >> [[[ >> JavaHL: Added CPPADDR_NULL_PTR macro to reduce amount of duplicate code >> checking C++ pointer extracted from the java object >> >> [ in

Re: svn commit: r1336833 - in /subversion/trunk/subversion: include/svn_wc.h libsvn_client/merge.c libsvn_wc/deprecated.c libsvn_wc/merge.c

2012-05-31 Thread Hyrum K Wright
On Thu, May 10, 2012 at 2:13 PM, wrote: > Author: rhuijben > Date: Thu May 10 19:13:11 2012 > New Revision: 1336833 > > URL: http://svn.apache.org/viewvc?rev=1336833&view=rev > Log: > Make the text and property merge handling of 'svn merge' of a single file an > atomic operation by moving the han

  1   2   3   4   5   6   7   8   9   10   >