On Tue, Oct 16, 2012 at 9:36 PM, Mark Phippard <markp...@gmail.com> wrote:
>>
>> On Oct 16, 2012, at 9:25 PM, "Hyrum Wright" <hwri...@apache.org> wrote:
>>
>>> On Tue, Oct 16, 2012 at 9:19 PM,  <hwri...@apache.org> wrote:
>>>> Author: hwright
>>>> Date: Wed Oct 17 01:19:21 2012
>>>> New Revision: 1399064
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1399064&view=rev
>>>> Log:
>>>> JavaHL: Punch additional changelist parameter for property fetching to
>>>> the Java layer.
>>>>
>>>> [ in subversion/bindings/javahl/ ]
>>>> * native/SVNClient.cpp,
>>>>  native/SVNClient.h
>>>>  (SVNClient::propertyGet): Add changelists param.
>>>>
>>>> * native/org_apache_subversion_javahl_SVNClient.cpp
>>>>  (Java_org_apache_subversion_javahl_SVNClient_propertyGet):
>>>>    Add changelists param, pass to C++ layer.
>>>>
>>>> * src/org/apache/subversion/javahl/ISVNClient.java,
>>>>  src/org/apache/subversion/javahl/SVNClient.java
>>>>  (propertyGet): Add overload to accept changelists param.
>>>
>>> Mark,
>>> This revision doesn't provide a way to return the inherited props,
>>> which the underlying API does.  Right now the obvious method is a new
>>> return object which contains both the property and any inherited
>>> props, but I'd hate to create an object with just two fields.  Any
>>> other suggestions?
>
>
> How about returning a Map where the path is key?

Well, we have to return both the existing property *and* the inherited
props.  I don't think a Map will meet those criteria.

-Hyrum

Reply via email to