On Wed, Jun 13, 2012 at 6:10 PM, <rhuij...@apache.org> wrote: > Author: rhuijben > Date: Wed Jun 13 16:10:25 2012 > New Revision: 1349944 > > URL: http://svn.apache.org/viewvc?rev=1349944&view=rev > Log: > * gen-make.py > Make the --with-neon= and --without-neon arguments on gen-make.py optional, > just like how ./configure handles those. Windows doesn't use ./configure and > this breaks tools that are friendly enough to provide hints.
I don't like this change. ./configure *doesn't* work this way: it errors when attempting to provide the now-defunct neon options. Neon is gone, dead, buried. We shouldn't be special casing it in this manner: people who rely on neon will have more work to do than just updating their scripts, and we don't need to coddle them along the way. -Hyrum > > Modified: > subversion/trunk/gen-make.py > > Modified: subversion/trunk/gen-make.py > URL: > http://svn.apache.org/viewvc/subversion/trunk/gen-make.py?rev=1349944&r1=1349943&r2=1349944&view=diff > ============================================================================== > --- subversion/trunk/gen-make.py (original) > +++ subversion/trunk/gen-make.py Wed Jun 13 16:10:25 2012 > @@ -257,6 +257,13 @@ if __name__ == '__main__': > 'disable-shared', > 'installed-libs=', > 'vsnet-version=', > + > + # Keep distributions that help by adding a path > + # working. On unix this would be filtered by > + # configure, but on Windows gen-make.py is used > + # directly. > + 'with-neon=', > + 'without-neon', > ]) > if len(args) > 1: > _usage_exit("Too many arguments") > @@ -281,6 +288,9 @@ if __name__ == '__main__': > if opt != '--debug': > rest.add(opt, val) > del prev_conf > + elif opt == '--with-neon' or opt == '--without-neon': > + # Provide a warning that we ignored these arguments > + print("Ignoring no longer supported argument '%s'" % opt) > else: > rest.add(opt, val) > > > -- uberSVN: Apache Subversion Made Easy http://www.uberSVN.com/
