Re: Closing GitHub PRs - GitHub Triage role

2025-08-02 Thread Daniel Sahlberg
Den tis 29 juli 2025 kl 21:41 skrev Nathan Hartman : > On Tue, Jul 29, 2025 at 2:50 AM Daniel Sahlberg < > daniel.l.sahlb...@gmail.com> wrote: > >> Hi everyone, >> >> (Crossposting to dev@serf and dev@subversion since it is the same for >> both >> com

[VOTE] Formally adopt the ASF Code of Conduct for Subversion

2025-08-02 Thread Daniel Sahlberg
Hi, Official vote thread, referencing the discussion I started earlier this week. The Subversion PMC adopts the ASF Code of Conduct and link to it on the website. [ ] +1: Adopt the CoC [ ] -1: Don't adopt the CoC Since this is a question of procedure I'm suggesting the result being the de

Re: Linking to and adopting the Apache Code of Conduct

2025-08-02 Thread Daniel Sahlberg
Den tors 31 juli 2025 kl 15:24 skrev Nathan Hartman < hartman.nat...@gmail.com>: > On Wed, Jul 30, 2025 at 8:20 AM Daniel Sahlberg < > daniel.l.sahlb...@gmail.com> wrote: > >> Hi, >> >> ASF has an official Code of Conduct[1]. It is my understanding that ea

Re: svn commit: r1927514 - subversion/site/staging/docs/community-guide

2025-07-31 Thread Daniel Sahlberg
Den tors 31 juli 2025 kl 18:58 skrev Nathan Hartman < hartman.nat...@gmail.com>: > On Thu, Jul 31, 2025 at 11:14 AM Daniel Sahlberg < > daniel.l.sahlb...@gmail.com> wrote: > >> Den tors 31 juli 2025 kl 15:46 skrev Nathan Hartman < >> hartman.nat.

Re: svn commit: r1927514 - subversion/site/staging/docs/community-guide

2025-07-31 Thread Daniel Sahlberg
Den tors 31 juli 2025 kl 15:46 skrev Nathan Hartman < hartman.nat...@gmail.com>: > [to -= commits@] > > On Tue, Jul 29, 2025 at 3:12 AM Daniel Sahlberg < > daniel.l.sahlb...@gmail.com> wrote: > >> Den tis 29 juli 2025 kl 09:06 skrev : >> >>> Auth

Linking to and adopting the Apache Code of Conduct

2025-07-30 Thread Daniel Sahlberg
Hi, ASF has an official Code of Conduct[1]. It is my understanding that each community can decide to adopt the CoC to its own project (or to create its own variation). The CoC doesn't have an official escalation policy - ie what happens if/when someone break the policy. In my opinion it is a weak

Re: svn commit: r1926575 - in /subversion/trunk/subversion/bindings/swig/python/tests: mergeinfo.py repository.py

2025-07-29 Thread Daniel Sahlberg
Den mån 28 juli 2025 kl 15:19 skrev Yasuhito FUTATSUKI < futat...@yf.bsdclub.org>: > Hello, > > On 2025/07/28 19:03, Daniel Sahlberg wrote: > > Den sön 27 juli 2025 kl 04:55 skrev Yasuhito FUTATSUKI < > > futat...@yf.bsdclub.org>: > > > >> Hell

Closing GitHub PRs - GitHub Triage role

2025-07-28 Thread Daniel Sahlberg
Hi everyone, (Crossposting to dev@serf and dev@subversion since it is the same for both communities). When we get pull requests in GitHub for either project, we still have to download the patch and commit manually to Subversion. In the log message, we can use the special syntax "This fixes #NNN i

Re: svn commit: r1926575 - in /subversion/trunk/subversion/bindings/swig/python/tests: mergeinfo.py repository.py

2025-07-28 Thread Daniel Sahlberg
Den sön 27 juli 2025 kl 04:55 skrev Yasuhito FUTATSUKI < futat...@yf.bsdclub.org>: > Hello, > > On 2025/07/27 8:22, Daniel Sahlberg wrote: > > > I'm not very fond of the idea of just disabling the tests under 3.14, > > chances are we'll never come

Re: svn commit: r1927483 - subversion/trunk/subversion/bindings/ctypes-python

2025-07-26 Thread Daniel Sahlberg
Den lör 26 juli 2025 kl 22:19 skrev Branko Čibej : > On 26. 7. 25 20:40, dsahlb...@apache.org wrote: > > Author: dsahlberg > Date: Sat Jul 26 18:40:48 2025 > New Revision: 1927483 > > Log: > GitHub removed their SVN server some years ago so getting sources with > svn won't work anymore. > > * subv

Re: svn commit: r1926575 - in /subversion/trunk/subversion/bindings/swig/python/tests: mergeinfo.py repository.py

2025-07-26 Thread Daniel Sahlberg
Den lör 26 juli 2025 kl 07:22 skrev Yasuhito FUTATSUKI < futat...@yf.bsdclub.org>: > Hello, > > On 2025/07/25 22:36, Joe Orton wrote: > > On Fri, Jul 25, 2025 at 12:37:56AM +0900, Yasuhito FUTATSUKI wrote: > >> Thank you for testing. > >> > >> The intention of those tests are detection of extra re

Re: svn commit: r1926575 - in /subversion/trunk/subversion/bindings/swig/python/tests: mergeinfo.py repository.py

2025-07-23 Thread Daniel Sahlberg
Hi, The patch below has been floating in dev@ for about a month. It looks looks like an improvement to me, but it is way out of my comfort zone. @Joe Orton are you able to test this? Cheers, Daniel Den tors 19 juni 2025 kl 14:06 skrev Yasuhito FUTATSUKI < futat...@yf.bsdclub.org>: > Hello,

Re: [GH] (subversion/1.14.x): Workflow run "backportbot" failed!

2025-07-14 Thread Daniel Sahlberg
Den mån 14 juli 2025 kl 06:03 skrev GitBox : > > The GitHub Actions job "backportbot" on subversion.git/1.14.x has failed. > Run started by GitHub user asfgit (triggered by asfgit). > > Head commit for run: > 3534e3cc4c5e8370d7da80233fb770f36fdbf70f / svn-role > Merge r1886358 from trunk: > > * r

Re: svn commit: r1927203 - /subversion/trunk/.github/workflows/cmake.yml

2025-07-13 Thread Daniel Sahlberg
Den sön 13 juli 2025 kl 22:38 skrev : > Author: dsahlberg > Date: Sun Jul 13 20:38:53 2025 > New Revision: 1927203 > > URL: http://svn.apache.org/viewvc?rev=1927203&view=rev > Log: > If we prepare an environment for Linux, better also check that the os is > actually Linux. > > * .github/workflows/

Decomissioning of the svnbook-dev mailing list

2025-07-13 Thread Daniel Sahlberg
Hi, C. Michael Pilato (Mike) sent an e-mail a few days to the subscribers of the svnbook-dev mailing list informing that the list was about to be been decomissioned. Unfortunately, the message didn't manage to make it to the archive[1] and I'm not sure how much of a direct quote I'm allowed to mak

Re: svn commit: r1926599 - /subversion/trunk/.github/workflows/cmake.yml

2025-06-30 Thread Daniel Sahlberg
Den mån 30 juni 2025 kl 14:38 skrev Timofei Zhakov : [...snip...] > > As I understand it, some package distributions provide APR's package > config files with names like apr1 and aprutil1 (without spaces). Since we > are already using a function that supports search for multiple names, we > could

Re: svn commit: r1926599 - /subversion/trunk/.github/workflows/cmake.yml

2025-06-30 Thread Daniel Sahlberg
Den mån 30 juni 2025 kl 08:46 skrev Timofei Zhakov : > On Mon, 30 Jun 2025 at 1:23 AM, Daniel Sahlberg < > daniel.l.sahlb...@gmail.com> wrote: > >> Den fre 27 juni 2025 kl 18:33 skrev Timofei Zhakov : >> >>> >>>> Also, the searching libraries usin

Re: svn commit: r1926599 - /subversion/trunk/.github/workflows/cmake.yml

2025-06-29 Thread Daniel Sahlberg
Den fre 27 juni 2025 kl 18:33 skrev Timofei Zhakov : > >> Also, the searching libraries using pkg-config doesn't work on my >> environment. I think it is caused by the prefix passed to >> pkg_check_modules is wrong. >> >> [[[ >> diff --git a/CMakeLists.txt b/CMakeLists.txt >> index e60809b1e..d94c

Re: Drop support for Python 2.7? (Was: Re: svn commit: r1925717 - in /subversion/trunk: ./ build/ subversion/tests/cmdline/ subversion/tests/cmdline/svntest/)

2025-06-27 Thread Daniel Sahlberg
Den sön 8 juni 2025 kl 16:46 skrev Nathan Hartman : > On Tue, May 20, 2025 at 8:32 AM wrote: > >> Author: brane >> Date: Tue May 20 12:32:49 2025 >> New Revision: 1925717 >> >> URL: http://svn.apache.org/viewvc?rev=1925717&view=rev >> Log: >> Add support for verifying the svn command's XML output

Re: svn commit: r1926599 - /subversion/trunk/.github/workflows/cmake.yml

2025-06-27 Thread Daniel Sahlberg
Den tors 26 juni 2025 kl 23:19 skrev Branko Čibej : > > By the way, I noticed that the CMake build is consistently, intentionally > behaving differently from the autotools build: autotools look for serf-2 > before serf-1 and apr-2 before apr(-util)-1, CMake does the opposite. I > have no idea why,

Re: svn commit: r1926599 - /subversion/trunk/.github/workflows/cmake.yml

2025-06-26 Thread Daniel Sahlberg
Hi Jun, Thanks for testing! Den tors 26 juni 2025 kl 05:02 skrev Jun Omae : > Hi, > > On 2025/06/21 23:38, Timofei Zhakov wrote: > >> In my testing, the whole action completed successfully on Mac OS, except > >> of one test: > >> > >> ``` > >> 24: svn_tests: E26: Expected error SVN_ERR_SQLIT

Re: subversion-trunk + serf: An appropriate version of serf could not be found

2025-06-21 Thread Daniel Sahlberg
tors 19 juni 2025 kl. 14:48 skrev Graham Leggett via dev < dev@subversion.apache.org>: > Hi all, > > Trying a routine build of subversion-trunk on EL9, and have added the > --with-serf=yes option expecting it to find the /usr/lib64/pkgconfig/serf.pc > file. > > No luck: > > [minfrin@rocky9 subvers

Re: Deprecation warnings on trunk

2025-06-17 Thread Daniel Sahlberg
Den mån 16 juni 2025 kl 22:23 skrev Branko Čibej : ... > There used to be a warnings-check builder that would fail in such cases, > but apparently it hasn't been ported to GH actions. > That would probably be my fault... Does it make sense to recreate on GHA? I don't have time right now but proba

Re: svn client: Native support for Windows, native support for MacOS

2025-06-14 Thread Daniel Sahlberg
lör 14 juni 2025 kl. 21:09 skrev Branko Čibej : > On 14. 6. 25 17:58, Graham Leggett via dev wrote: > > Hi all, > > I am having a torrid time trying to get the svn client to work on Windows. In > short, every attempt to connect results in "An error occurred during SSL > communication". > > One a

Re: svn commit: r1926360 - in /subversion/trunk: CMakeLists.txt subversion/include/svn_utf.h

2025-06-13 Thread Daniel Sahlberg
Den fre 13 juni 2025 kl 02:35 skrev Branko Čibej : > On 13. 6. 25 01:14, Timofei Zhakov wrote: > > (...cut...) > > >> Thanks for your explanation! >> >> I'd add a few points from myself. >> >> When a library is linked into another target through >> target_link_libraries(), it can be either PUBLIC,

Re: svn commit: r1926350 - /subversion/trunk/CMakeLists.txt

2025-06-12 Thread Daniel Sahlberg
Den ons 11 juni 2025 kl 17:12 skrev Branko Čibej : > On 11. 6. 25 00:07, rin...@apache.org wrote: > > Author: rinrab > Date: Tue Jun 10 22:07:50 2025 > New Revision: 1926350 > > URL: http://svn.apache.org/viewvc?rev=1926350&view=rev > Log: > cmake: Prevent re-definition of APR and Serf targets by

Re: svn commit: r1926360 - in /subversion/trunk: CMakeLists.txt subversion/include/svn_utf.h

2025-06-12 Thread Daniel Sahlberg
Den tors 12 juni 2025 kl 00:34 skrev Timofei Zhakov : > Revert most of the changes in svn_utf.h from r1926293. Instead, tell the >> CMake build to expose APR and APR-Util include paths everywhere. >> >> (...) > >> >> * CMakeLists.txt: Add APR and APR-Util include paths to the top-level >>direc

Re: svn commit: r1926360 - in /subversion/trunk: CMakeLists.txt subversion/include/svn_utf.h

2025-06-12 Thread Daniel Sahlberg
Den tors 12 juni 2025 kl 09:16 skrev Branko Čibej : > On 12. 6. 25 00:30, Timofei Zhakov wrote: > > Revert most of the changes in svn_utf.h from r1926293. Instead, tell the >> CMake build to expose APR and APR-Util include paths everywhere. >> >> (...) > >> >> * CMakeLists.txt: Add APR and APR-Uti

Re: Binary Patch (xpatch)

2025-06-09 Thread Daniel Sahlberg
Den sön 8 juni 2025 kl 20:55 skrev Nathan Hartman : > On Tue, May 20, 2025 at 2:07 PM Branko Čibej wrote: > >> On 18. 5. 25 21:48, Branko Čibej wrote: >> >> XML has the unenviable distinction of being *both* almost unreadable for >> humans *and* very finicky to parse for machines. >> >> >> There'

Re: svn commit: r1926218 - in /subversion/trunk: ./ subversion/include/private/svn_cmdline_private.h subversion/libsvn_subr/cmdline.c

2025-06-09 Thread Daniel Sahlberg
sön 8 juni 2025 kl. 15:27 skrev Timofei Zhakov : > On Sun, Jun 8, 2025 at 1:03 PM Daniel Sahlberg < > daniel.l.sahlb...@gmail.com> wrote: > >> >> >> sön 8 juni 2025 kl. 12:47 skrev Timofei Zhakov : >> >>> On Sun, Jun 8, 2025 at 2:48 AM Bran

Re: svn commit: r1926218 - in /subversion/trunk: ./ subversion/include/private/svn_cmdline_private.h subversion/libsvn_subr/cmdline.c

2025-06-08 Thread Daniel Sahlberg
sön 8 juni 2025 kl. 12:47 skrev Timofei Zhakov : > On Sun, Jun 8, 2025 at 2:48 AM Branko Čibej wrote: > >> On 7. 6. 25 19:41, rin...@apache.org wrote: >> >> Author: rinrab >> Date: Sat Jun 7 17:41:22 2025 >> New Revision: 1926218 >> >> URL: http://svn.apache.org/viewvc?rev=1926218&view=rev >> Lo

Re: CMake, FindAPR and FindAPRUtil

2025-05-28 Thread Daniel Sahlberg
Den ons 28 maj 2025 kl 14:29 skrev Timofei Zhakov : ... > So, it would be great if serf starts using svn's modules. I can try to > support pkgconfig in them if needed. > > Thoughts? > Outside of my area of expertise but doesn't this concern the build system in Serf? In that case I think we are on

Re: svn commit: r1925722 - in /subversion/branches/utf8-cmdline-prototype/subversion: include/svn_client.h libsvn_client/cmdline.c

2025-05-27 Thread Daniel Sahlberg
Den tis 27 maj 2025 kl 09:37 skrev Branko Čibej : > On 26. 5. 25 23:15, Timofei Zhakov wrote: > > On Mon, May 26, 2025 at 10:07 PM Branko Čibej wrote: > >> On 26. 5. 25 21:25, Timofei Zhakov wrote: >> >> On Mon, May 26, 2025 at 8:29 PM Branko Čibej wrote: >> >>> On 26. 5. 25 14:07, Timofei Zhako

Re: 2FA prototype

2025-05-24 Thread Daniel Sahlberg
ng (ie, all users are required ot use 2FA), we could possibly combine steps 2 and 4 into a single step, saving a roundtrip to the server. (We don't need to know the user before requesting a TOTP - as long as we get the username we can verify it afterwards). Only maybe if it is difficult to send

Re: 2FA prototype

2025-05-23 Thread Daniel Sahlberg
the challenge. The response could then be added as a header field. Would it be possible for the server to return a bearer token (= more or less the same as a Set-Cookie) that we could store client-side to include on future requests? Kind regards, Daniel Sahlberg [1] https://www.rfc-editor.org/rfc/rf

Re: Strange behaviour of svn_client_info4() with WORKING revision

2025-05-05 Thread Daniel Sahlberg
Hi, Your arguments sounds fine from a first reading but it is far from my area of expertise. I'll try to find some time in the next week to review this and to dig further into the background. Cheers, Daniel Den mån 5 maj 2025 kl 17:04 skrev Timofei Zhakov : > Hi again, > > I made several patc

Re: svn: E120171: Error running context: An error occurred during SSL communication

2025-04-29 Thread Daniel Sahlberg
tis 29 apr. 2025 kl. 10:00 skrev Michael Osipov : > On 2025/04/27 13:00:53 Graham Leggett via dev wrote: > > Hi all, > > > > When attempting a routine svn update from svn 1.14.3 on MacOS (via > macports), I'm getting the following sudden failure: > > > > Little-Net-8818:xxx minfrin$ svn update > >

Re: [PR] mod_dav_svn: Use mod_dav's DAVBasePath setting [subversion]

2025-04-09 Thread Daniel Sahlberg
Den mån 24 feb. 2025 kl 16:06 skrev notroj (via GitHub) : > > notroj commented on PR #28: > URL: https://github.com/apache/subversion/pull/28#issuecomment-2678738474 > >> Builds and tests complete successfully with HTTPD 2.4.58. Have not > tested with HTTPD trunk and I don't think we have a te

Re: 2FA prototype

2025-04-05 Thread Daniel Sahlberg
Hi, Den mån 31 mars 2025 kl 13:09 skrev Peter Balogh : > Hi, > > I'm working on a proof of concept to add multi factor authentication to > subversion > I have multiple directions, and I'd like to get some feedback from this > group before I head down the wrong road > Please let me know, if I shou

1.15 release notes

2025-04-02 Thread Daniel Sahlberg
Hi, I've been reviewing the 1.15 release notes on the staging site[1]. We need to complete the New Feature Compatibility Table ¶ [[[ New Feature Minimum Client^1 Minimum Server Minimum Repository Notes Pristines On Demand 1.15 TODO TODO Streamy Checkouts 1

Re: [GH] (subversion): Workflow run "backportbot" is working again!

2025-03-26 Thread Daniel Sahlberg
On 2025/03/01 23:35:22 Daniel Sahlberg wrote: [...] > We still have one job left in Buildbot, the svn-warnings job. (This is the > job that alerted me of the unused variable removed in r1924107). I'd like > to remove that as well, to reduce maintenance burden somewhat. Can we >

Re: Removing BDB support from 1.15

2025-03-18 Thread Daniel Sahlberg
Hi It was discussed last year [1][2] and while not formally voted on I’d say we have consensus to remove it. We never got around to do it though. I checked the bug report quickly and I don’t see anyone advocating for keeping BDB so it wouldn’t hurt you if we remove it. Correct? Thanks, Daniel

Re: [GH] (subversion): Workflow run "autoconf" failed!

2025-03-03 Thread Daniel Sahlberg
Den mån 3 mars 2025 kl 10:05 skrev GitBox : > > The GitHub Actions job "autoconf" on subversion.git has failed. > Run started by GitHub user asfgit (triggered by asfgit). > > Head commit for run: > 33a788665eb139f3c14cc5b18e4abb5622db9ae6 / Stefan Sperling < > s...@apache.org> > Remove optimized u

Re: svn commit: r1924120 - /subversion/trunk/tools/dist/backport/status.py

2025-03-01 Thread Daniel Sahlberg
Hi, As discussed previously[1], the backport.pl/nominate.pl script depend on the Perl-ism when-given which is deprecated and will be remove in the next version of Perl. I've spent a big part of today hacking away on the backport.py scripts to build the foundation for a new interactive script. At

Re: [GH] (subversion): Workflow run "backportbot" is working again!

2025-03-01 Thread Daniel Sahlberg
svn.apache.org/repos/infra/infrastructure/buildbot2/projects Den sön 2 mars 2025 kl 00:17 skrev GitBox : > > The GitHub Actions job "backportbot" on subversion.git has succeeded. > Run started by GitHub user asfgit (triggered by asfgit). > > Head commit for run: > 5

Re: [GH] (subversion): Workflow run "autoconf" is working again!

2025-03-01 Thread Daniel Sahlberg
Thank you Evgeny for looking into this, and thanks for taking the time to explain the reason for the intermittent failure mode. FWIW, the last three builds have been successful, previously it failed on approximately half of the time. Cheers, Daniel Den fre 28 feb. 2025 kl 23:15 skrev Evgeny Ko

Re: Unaligned access in svn_eol__find_eol_start causes crash w/ upcoming GCC 15

2025-02-28 Thread Daniel Sahlberg
Den fre 28 feb. 2025 kl 15:16 skrev Stefan Sperling : > On Fri, Feb 28, 2025 at 02:14:34PM +0100, Branko Čibej wrote: > > This is probably the minimal patch to disable this tweak. > > Thanks, your diff looks good to me. > > > There's a bunch of > > code that needs to be replaced or removed, though

Re: Unaligned access in svn_eol__find_eol_start causes crash w/ upcoming GCC 15

2025-02-26 Thread Daniel Sahlberg
Den ons 26 feb. 2025 kl 14:45 skrev Daniel Sahlberg < daniel.l.sahlb...@gmail.com>: > Den ons 26 feb. 2025 kl 14:30 skrev Stefan Sperling : > >> On Wed, Feb 26, 2025 at 01:24:22PM +0100, Daniel Sahlberg wrote: >> > Looking at the code, I'm assuming that if SVN_UNA

Re: Unaligned access in svn_eol__find_eol_start causes crash w/ upcoming GCC 15

2025-02-26 Thread Daniel Sahlberg
Den ons 26 feb. 2025 kl 14:30 skrev Stefan Sperling : > On Wed, Feb 26, 2025 at 01:24:22PM +0100, Daniel Sahlberg wrote: > > Looking at the code, I'm assuming that if SVN_UNALIGNED_ACCESS_IS_OK was > > set to 0 (so the char by char loop after #endif is used instead), the >

Re: Unaligned access in svn_eol__find_eol_start causes crash w/ upcoming GCC 15

2025-02-26 Thread Daniel Sahlberg
Den ons 26 feb. 2025 kl 12:33 skrev Sam James : > Hi! > Hi, Thanks for the detailed report! > When subversion-1.14.5 is built with upcoming GCC 15 with -O3 -mavx (or > -O2 -mavx -fno-vect-cost-model), it crashes in some cases in > svn_eol__find_eol_start. > > We found `svn checkout https://svn

Re: Testsuite failing to connect to GitHub's SVN bridge

2025-02-25 Thread Daniel Sahlberg
Den tis 25 feb. 2025 kl 21:00 skrev Stefan Sperling : > On Tue, Feb 25, 2025 at 12:54:40PM -0500, Nathan Hartman wrote: > > On Tue, Feb 25, 2025 at 9:50 AM Daniel Sahlberg < > daniel.l.sahlb...@gmail.com> > [...] Thanks to both Nathan and Stefan. I agree with Stefan that

Testsuite failing to connect to GitHub's SVN bridge

2025-02-25 Thread Daniel Sahlberg
Hi, The following test fails, for obvious[1] reasons, since January last year: [[[ $ make check ALLOW_REMOTE_HTTP_CONNECTION=1 TESTS=subversion/tests/cmdline/dav_tests.py#3 [1/1] dav_tests.py...FAILURE At

Re: [GH] (subversion): Workflow run "autoconf" failed!

2025-02-21 Thread Daniel Sahlberg
shortly. Thanks, Daniel > > > > On Fri, Feb 21, 2025 at 6:11 AM Daniel Sahlberg > wrote: > > > > Hi, > > > > There seems to be a failure with the davautocheck on ubuntu-22.04-arm: > > > > [[[ > > At least one test FAILED, checking > /ho

Re: [GH] (subversion): Workflow run "autoconf" is working again!

2025-02-21 Thread Daniel Sahlberg
: > > The GitHub Actions job "autoconf" on subversion.git has succeeded. > Run started by GitHub user asfgit (triggered by asfgit). > > Head commit for run: > e29102d7affe1e87f33cf34108043889926d90a0 / Daniel Sahlberg < > dsahlb...@apache.org> > Follow-up to r1

Re: [GH] (subversion): Workflow run "autoconf" failed!

2025-02-21 Thread Daniel Sahlberg
Den fre 21 feb. 2025 kl 17:04 skrev Mark Phippard : > I noticed the matrix part as I clicked send. > > You probably name to be something like ${{ matrix.check-target }}-logs > Thanks, just saw that r1923964 failed on duplicate name. Renaming tests-${{matrix.os}}-${{matrix.check-target}}.log in

Re: [GH] (subversion): Workflow run "autoconf" failed!

2025-02-21 Thread Daniel Sahlberg
ted by GitHub user asfgit (triggered by asfgit). > > Head commit for run: > a74da7a4bb60f4b6f30483fb0516423906fee1df / Daniel Sahlberg < > dsahlb...@apache.org> > Replace tigris.org url with apache.org. > > * subversion/tests/README > Replace link to issue tra

Re: Propose changes to the Reporting Issues page

2025-01-31 Thread Daniel Sahlberg
Den tors 30 jan. 2025 kl 23:17 skrev Nathan Hartman < hartman.nat...@gmail.com>: > [...] > > Committed to the staging site in r1923465: > > https://subversion-staging.apache.org/reporting-issues.html > > Comments, suggestions, etc., welcome. > Thanks for working on this! I think the /reporting-is

Re: [PR] Display the original name of component. [subversion]

2025-01-08 Thread Daniel Sahlberg
Den tis 31 dec. 2024 kl 10:36 skrev Stefan Sperling : > This change seems to be unnecessary to me. The stated motivation for it, > i.e. translating URLs to local paths in order to decide which local files > were modified, ignores risks which occur beyond the escaping of characters. > > If a mappi

Re: svnserve frequently die at assertion in utf.c

2025-01-07 Thread Daniel Sahlberg
Big thanks to both Sean and Guido for their help in tracking down the issue. It seems indeed to be a bug in the Subversion code. I've added dev@subversion.apache.org for further debugging - this goes out of scope of the users list. I believe several threads are accessing the same "translator" sim

Re: [PR] Fix ra-test execution of svnserve in some build environments. [subversion]

2025-01-07 Thread Daniel Sahlberg
Hi Joe, We are a little bit short on people who actually understand the impact of this PR, but since you are full committer, maybe you want to commit it yourself? If so, please commit the fix to ra-test.c first (while closing the PR). We also believe the GHA fixes are good but they should be commi

Re: [PR] Display the original name of component. [subversion]

2024-12-30 Thread Daniel Sahlberg
Den lör 28 dec. 2024 kl 21:35 skrev Daniel Sahlberg < daniel.l.sahlb...@gmail.com>: > I also made a "review" in Github but it seems that wasn't forwarded to the > list so I'll copy-paste it below: > > Thank you for the patch! > > I understand the ide

Re: svn commit: r1922647 - in /subversion/trunk/subversion: include/private/svn_client_private.h svn/shelf-cmd.c svn/shelf2-cmd.c

2024-12-29 Thread Daniel Sahlberg
Den tis 24 dec. 2024 kl 18:26 skrev Timofei Zhakov : > > Hi Daniel, > > Thanks for this feedback, but probably you didn't fully get this commit. > This is a fix to a stupid bug that I made in the commit, that I follow-up > to. In r1921602 I've introduced a new argument to the function > (use_git_d

Re: Releasing 1.15.0?

2024-12-29 Thread Daniel Sahlberg
Den mån 16 dec. 2024 kl 12:20 skrev Thomas Singer via dev < dev@subversion.apache.org>: > Hi Nathan, > > Could it be a plan to offer scripts that build the binaries in a docker > container? We have our own scripts that do that, but they often break > with new releases. > > -- > Best regards, > Tho

Re: [PR] Display the original name of component. [subversion]

2024-12-28 Thread Daniel Sahlberg
I also made a "review" in Github but it seems that wasn't forwarded to the list so I'll copy-paste it below: Thank you for the patch! I understand the idea of the patch but I'm not sure I think this implementation is a good idea. As noted in the code (lines 169-171) the format is the same as svn

Re: svn commit: r1922647 - in /subversion/trunk/subversion: include/private/svn_client_private.h svn/shelf-cmd.c svn/shelf2-cmd.c

2024-12-23 Thread Daniel Sahlberg
Hi, Den mån 23 dec. 2024 kl 15:42 skrev : > Author: rinrab > Date: Mon Dec 23 14:42:38 2024 > New Revision: 1922647 > > URL: http://svn.apache.org/viewvc?rev=1922647&view=rev > Log: > Follow-up to r1921602: Fix argument sequence of > svn_client__get_diff_writer_svn > to much its declaration with

Re: Releasing 1.15.0?

2024-12-22 Thread Daniel Sahlberg
Den mån 16 dec. 2024 kl 19:56 skrev Timofei Zhakov : > On Sun, Dec 15, 2024 at 5:22 PM Nathan Hartman > wrote: > > > > Hi everyone, > > > > I'd like to start a conversation about getting 1.15.0 released. > > > > Why a 1.15.0 release: Much work has taken place on trunk since 1.14.0 > > and I think

Re: svn commit: r1922638 - in /subversion/site/staging: ./ index.html news.html roadmap.html

2024-12-22 Thread Daniel Sahlberg
Den sön 22 dec. 2024 kl 22:10 skrev Nathan Hartman : > On Sun, Dec 22, 2024 at 2:58 PM wrote: > > > > Author: dsahlberg > > Date: Sun Dec 22 19:58:14 2024 > > New Revision: 1922638 > > > > URL: http://svn.apache.org/viewvc?rev=1922638&view=rev > > Log: > > In site/staging: > > Catchup merge from

Re: Python's removal of asyncore/asynchat in 3.12 affects svnpubsub/client.py

2024-12-22 Thread Daniel Sahlberg
Thank you very much for the review! I'll answer inline below. Den tis 3 dec. 2024 kl 22:31 skrev Jun Omae : > Hi, > > On 2024/11/29 6:47, Daniel Sahlberg wrote: > [snip] > > > > The next step will be to rewrite for asyncio, but I'd like to have a

Re: [PR] Fix ra-test execution of svnserve in some build environments. [subversion]

2024-12-22 Thread Daniel Sahlberg
Den mån 16 dec. 2024 kl 21:18 skrev Timofei Zhakov : > On Fri, Dec 13, 2024 at 10:08 AM notroj (via GitHub) > wrote: > >> >> notroj opened a new pull request, #25: >> URL: https://github.com/apache/subversion/pull/25 >> >>``` >>Fix ra-test execution of svnserve in some build environments.

[SECURITY][ANNOUNCE] Apache Subversion 1.14.5 released

2024-12-08 Thread Daniel Sahlberg
tures: Stefan Sperling [rsa2048/4F7DBAA99A59B973] with fingerprint: 8BC4 DAE0 C5A4 D65F 4044 0107 4F7D BAA9 9A59 B973 Nathan Hartman (CODE SIGNING KEY) [rsa4096/583F00ADF981C39F] with fingerprint: 3F8E 467C B336 6E30 13E1 120D 583F 00AD F981 C39F Daniel Sahlberg [ed

Re: Python's removal of asyncore/asynchat in 3.12 affects svnpubsub/client.py

2024-11-28 Thread Daniel Sahlberg
On 2023/07/03 09:37:01 Yasuhito FUTATSUKI wrote: > Hi, > > On 2023/07/03 3:17, James McCoy wrote: > > Hi all, > > > > Python 3.6 deprecated the asyncore and asynchat modules in favor of the > > asyncio module. Per [PEP 594], that means that the modules > > will be removed in Python 3.12, thus br

Re: Staging site not updating?

2024-11-27 Thread Daniel Sahlberg
Den ons 27 nov. 2024 kl 08:40 skrev Daniel Sahlberg < daniel.l.sahlb...@gmail.com>: > Den ons 27 nov. 2024 kl 06:42 skrev Nathan Hartman < > hartman.nat...@gmail.com>: > A little while ago I committed r1922147 at site/staging to catch-up >> merge from site/publish. H

Re: [GH] (subversion): Workflow run "Build and Test Subversion using autoconf build system" failed!

2024-11-27 Thread Daniel Sahlberg
Hi, It seems we are getting "build failed" messages (for commits on the branch, such as this) sometimes followed by "build succeeded again" messages (from commits on trunk). I'm assuming the notification system mix up the builds between the branches and trunk since they have the same name. Would

Re: Staging site not updating?

2024-11-26 Thread Daniel Sahlberg
Den ons 27 nov. 2024 kl 06:42 skrev Nathan Hartman : > A little while ago I committed r1922147 at site/staging to catch-up > merge from site/publish. However, it appears the site continues to > serve older content. > > It doesn't appear to be a browser caching issue on my end. > > A few hours earl

Re: [GH] (subversion): Workflow run "Build and Test Subversion using autoconf build system" failed!

2024-11-26 Thread Daniel Sahlberg
I had a little chat with Infra over on Slack and Humbedooh. They typically require a R/W Git repo, but he understood my argument that it might be difficult to sell this idea to the community so he did a hard-coded one-off for us. Notifications seems to come in on the notifications@-list right now

Re: xpatch command-line interface (was: Binary Patch (xpatch))

2024-11-26 Thread Daniel Sahlberg
Hi, Thanks for the detailed explanation. Offering some small inputs, but basically I think Nathan has made very good comments. Den tis 26 nov. 2024 kl 19:11 skrev Nathan Hartman : > On Tue, Nov 26, 2024 at 12:23 PM Timofei Zhakov wrote: > > > > On Sun, Nov 24, 2024 at 5:25 PM Daniel Shahaf >

Re: svn commit: r1922086 - /subversion/trunk/CMakeLists.txt

2024-11-26 Thread Daniel Sahlberg
Den mån 25 nov. 2024 kl 15:10 skrev : > ### This makes configure step too slow if the option is enabled. Can we > ### prevent regeneration of the tests list if these files haven't been > ### changed? Probably, I'll look at this a bit more, if we consider this > ### as an issue. > ### > ### However

Re: Binary Patch (xpatch)

2024-11-26 Thread Daniel Sahlberg
Den lör 23 nov. 2024 kl 11:26 skrev Timofei Zhakov : > Hi! > > I am using patches frequently, however, 'svn diff' and 'svn patch' > commands currently have several limitations: > > 1. They do not track tree changes (like copies and moves) > 2. Binary file modifications are not tracked in plain-tex

Re: svn commit: r1922105 - in /subversion/trunk: .asf.yaml tools/dev/unix-build/Makefile.svn

2024-11-26 Thread Daniel Sahlberg
Den tis 26 nov. 2024 kl 10:31 skrev Johan Corveleyn : > On Tue, Nov 26, 2024 at 9:27 AM wrote: > > > > Author: dsahlberg > > Date: Tue Nov 26 08:27:28 2024 > > New Revision: 1922105 > > > > URL: http://svn.apache.org/viewvc?rev=1922105&view=rev > > Log: > > Try to get GitHub Action notifications

Re: Automated build jobs, GitHub Actions and Buildbot Was: [DISCUSS] backport.pl or backport.py

2024-11-26 Thread Daniel Sahlberg
Den mån 25 nov. 2024 kl 14:53 skrev Johan Corveleyn : > On Fri, Nov 22, 2024 at 4:21 PM Nathan Hartman > wrote: > > > > On Fri, Nov 22, 2024 at 9:17 AM Daniel Sahlberg > > wrote: > > > > > > Den fre 22 nov. 2024 kl 09:39 skrev Daniel Sahlberg < >

Re: autoconf out-of-tree builds broken

2024-11-25 Thread Daniel Sahlberg
th('.'))), > > - 'tests/cmdline/svneditor.sh') > > + svneditor_script = os.path.join(sys.path[0], 'svneditor.sh') > > > > # Username and password used by the working copies > > wc_author = 'jrandom' > > ]]] > > > > What do you think? Did it work for you? > > The patch looks good to me (tested in tree and out-of-tree builds). > However, I > think "# This script is in the build tree, ..." comment should be removed > also. > This works for me too and I particularly like that it mirrors behaviour between platforms. Makes it easier to review the code without having to think about why the build system finds the script in different ways in different platforms. Cheers, Daniel Sahlberg

Re: svntest.verify.compare_dump_files() under Python3

2024-11-24 Thread Daniel Sahlberg
Den sön 24 nov. 2024 kl 17:11 skrev Daniel Shahaf : > Daniel Sahlberg wrote on Sat, 23 Nov 2024 16:14 +00:00: > > After reviewing history, I believe the above change is the "obvious fix". > > One could argue if decode() should use some other encoding, I don'

Buildbot/CI: (was: autoconf out-of-tree builds broken (was: svn commit: r1920955 - in /subversion/trunk: configure.ac subversion/tests/cmdline/ subversion/tests/cmdline/svneditor.sh subversion/tests/c

2024-11-24 Thread Daniel Sahlberg
Den sön 24 nov. 2024 kl 18:17 skrev Daniel Shahaf : > P.S. Don't we have a single CI job doing out-of-tree builds? > Not as far as I know. We have an in-tree build at Buildbot: https://ci2.apache.org/#/builders/105 We also have some builds using Github Actions (both for the autoconf and for th

Re: svntest.verify.compare_dump_files() under Python3

2024-11-23 Thread Daniel Sahlberg
aniel/svn_trunk/subversion/tests/cmdline/svnsync_tests.py", line 493, in delete_revprops verify_mirror(dest_sbox, expected_contents) File "/home/daniel/svn_trunk/subversion/tests/cmdline/svnsync_tests.py", line 169, in verify_mirror svntest.verify.compare_dump_files( File "/home/daniel/svn_trunk/subversion/tests/cmdline/svntest/verify.py", line 856, in compare_dump_files print(''.join(ndiff(expected, actual))) File "/usr/lib/python3.11/difflib.py", line 872, in compare yield from g File "/usr/lib/python3.11/difflib.py", line 923, in _fancy_replace cruncher.set_seq2(bj) File "/usr/lib/python3.11/difflib.py", line 248, in set_seq2 self.__chain_b() File "/usr/lib/python3.11/difflib.py", line 289, in __chain_b if isjunk(elt): ^^^ File "/usr/lib/python3.11/difflib.py", line 1077, in IS_CHARACTER_JUNK return ch in ws TypeError: 'in ' requires string as left operand, not int W: Unexpected exception type FAIL: svnsync_tests.py 28: copy-revprops with removals ]]] Thoughts? Cheers, Daniel Sahlberg

Automated build jobs, GitHub Actions and Buildbot Was: [DISCUSS] backport.pl or backport.py

2024-11-22 Thread Daniel Sahlberg
Den fre 22 nov. 2024 kl 09:39 skrev Daniel Sahlberg < daniel.l.sahlb...@gmail.com>: > Den ons 20 nov. 2024 kl 18:15 skrev Daniel Sahlberg < > daniel.l.sahlb...@gmail.com>: > >> So I'd say we have consensus on moving to the Python implementation - >> several +

Re: [DISCUSS] backport.pl or backport.py

2024-11-22 Thread Daniel Sahlberg
Den ons 20 nov. 2024 kl 18:15 skrev Daniel Sahlberg < daniel.l.sahlb...@gmail.com>: > So I'd say we have consensus on moving to the Python implementation - > several +1 and no-one objecting. And since this is far from core code and > it can easily be reverted I don't see

Re: [DISCUSS] backport.pl or backport.py

2024-11-20 Thread Daniel Sahlberg
Den ons 20 nov. 2024 kl 18:15 skrev Daniel Sahlberg < daniel.l.sahlb...@gmail.com>: > Missed [backports_tests_p[yl].py], but I'm looking now. It did't work with > Py3, but I changed a few things in r1921976. It seems a bunch of tests fail > right now, don't know i

Re: [DISCUSS] backport.pl or backport.py

2024-11-20 Thread Daniel Sahlberg
Den ons 20 nov. 2024 kl 14:50 skrev Daniel Shahaf : > Daniel Sahlberg wrote on Mon, 18 Nov 2024 08:52 +00:00: > > backport.pl is a heavy user of "given ... when ..." and given that these > > constructs will be removed[1] when Perl 5.42 is released (pun intended), > we

[DISCUSS] backport.pl or backport.py

2024-11-18 Thread Daniel Sahlberg
Hi, Regarding scripts in tools/dist: backport.pl is a heavy user of "given ... when ..." and given that these constructs will be removed[1] when Perl 5.42 is released (pun intended), we need to take some action. I'm guessing we have about one year before hitting a brick wall. backport.pl is "con

Releasing Subversion 1.14.5

2024-11-17 Thread Daniel Sahlberg
Hi all, There are a bunch of stuff in STATUS waiting for backport that I think would be nice to have released. Following Stefan Sperling's excellent lead during the last release I'd like to take a shot at it when the time comes. I've spent the evening looking through the items and I'll send my no

Re: unix-build/Makefile.svn

2024-10-21 Thread Daniel Sahlberg
Den sön 20 okt. 2024 kl 17:44 skrev Nathan Hartman : > However please note that this makefile is used by creating a symlink to it >>> (see example usage in adjacent readme) so factoring to a separate file may >>> require a second symlink or other handling. Unless we're talking about >>> thousands

Re: unix-build/Makefile.svn

2024-10-20 Thread Daniel Sahlberg
Den sön 20 okt. 2024 kl 07:07 skrev Nathan Hartman : > On Sat, Oct 19, 2024 at 4:18 PM Daniel Sahlberg < > daniel.l.sahlb...@gmail.com> wrote: > >> Hi, >> >> I'd like to make some changes to tools/dev/unix-build/Makefile.svn but >> I'd li

unix-build/Makefile.svn

2024-10-19 Thread Daniel Sahlberg
Hi, I'd like to make some changes to tools/dev/unix-build/Makefile.svn but I'd like to run then by the community before committing. Makefile.svn is currently hard coding a dependency version by setting (for example) RUBY_VER = 2.7.4 and SHA256_${RUBY_DIST} = 3043099089608859fc8cce7f9fdccaa1

Re: release.py

2024-10-12 Thread Daniel Sahlberg
Den fre 4 okt. 2024 kl 09:23 skrev Branko Čibej : > On 25. 9. 24 08:20, Daniel Sahlberg wrote: > (snip) > > However I can't figure out how args.dry_run is set. I was looking in main, > where the parser is setup but no trace of dry_run. Is it missing an > add_argument or

Re: 0x0C character in some source files

2024-10-11 Thread Daniel Sahlberg
Den fre 11 okt. 2024 kl 13:36 skrev Stefan Sperling : > On Fri, Oct 11, 2024 at 01:00:21PM +0200, Thomas Singer via dev wrote: > > Dear C experts, > > > > I've noticed that some source files, e.g. > subversion/libsvn_repos/authz.c, > > subversion/libsvn_subr/config_file.c or > > subversion/libsvn_

Re: Berkely DB precompiled for Windows

2024-09-26 Thread Daniel Sahlberg
Den tors 26 sep. 2024 kl 15:31 skrev Johan Corveleyn : (snip) > +1, definitely. Since BDB support in Subversion is already deprecated > since 1.8 [1], i.e. already more than 10 years! > Thanks, I've done that in r1920956. (...) > Now that you mention it, [1] says: > [[[ > At some point, support

Berkely DB precompiled for Windows

2024-09-26 Thread Daniel Sahlberg
Hi, I was reading through INSTALL and noticed under I,C.9 there is text suggesting to fetch a pre-compiled version of Berkeley DB for Windows from tigris.org. That doesn't work anymore. I'm suggesting to just remove this completely: [[[ Index: INSTALL

release.py

2024-09-24 Thread Daniel Sahlberg
Hi, I'm trying to read up on release.py (planning to make one of the upcoming releases - no promises I'll be done in time for 1.14.4 though). There are quite a few cases where there is a dry_run parameter, for example in run_command: [[[ def run_command(cmd, verbose=True, hide_stderr=False, dry_

Re: Using GitHub Actions for continuous integration

2024-09-19 Thread Daniel Sahlberg
Den ons 18 sep. 2024 kl 14:03 skrev Timofei Zhakov : > On Fri, Sep 6, 2024 at 1:41 PM Timofei Zhakov wrote: > > > > Hi, > > > > I am currently thinking about setting up GitHub Actions in Subversion. > > > > GitHub Actions will help us test every commit in different > > configurations, which, base

Re: svn commit: r1920771 - in /subversion/trunk: CMakeLists.txt build.conf build/generator/extractor.py

2024-09-19 Thread Daniel Sahlberg
Den ons 18 sep. 2024 kl 18:38 skrev : > Author: rinrab > Date: Wed Sep 18 16:38:36 2024 > New Revision: 1920771 > > URL: http://svn.apache.org/viewvc?rev=1920771&view=rev > Log: > build: Export some private functions from libraries, to link tools and > tests which uses them, against shared version

  1   2   3   4   5   6   >