Den mån 16 dec. 2024 kl 21:18 skrev Timofei Zhakov <t...@chemodax.net>:
> On Fri, Dec 13, 2024 at 10:08 AM notroj (via GitHub) <g...@apache.org> > wrote: > >> >> notroj opened a new pull request, #25: >> URL: https://github.com/apache/subversion/pull/25 >> >> ``` >> Fix ra-test execution of svnserve in some build environments. >> >> * subversion/tests/libsvn_ra/ra-test.c >> (open_tunnel): Execute the wrapper with APR_PROGRAM_ENV rather than >> APR_PROGRAM, so the build environment is inherited. The "svnserve" >> executed here may be a libtool wrapper script which can in some cases >> depend on the build environment to execute correctly. >> ``` >> >> >> -- >> This is an automated message from the Apache Git Service. >> To respond to the message, please log on to GitHub and use the >> URL above to go to the specific comment. >> >> To unsubscribe, e-mail: dev-unsubscr...@subversion.apache.org >> >> For queries about this service, please contact Infrastructure at: >> us...@infra.apache.org >> >> > Hi, > > I think that it might be a good idea to commit the `Enable GitHub Actions > workflows in pull requests` [1] commit from this PR into the trunk. > > What do you think? > That sounds like a good idea. We should probably commit this separately from the main change. Did you review the rest of the PR? It looks good to me, but I can't judge if there could be a problem with inheriting the environment. The argument given by Joe is seems reasonable but I'd like to reproduce it first. @Timofei Zhakov <t...@chemodax.net> If you'd like to commit it, remember that we can close the PR directly with a suitable log message, see HACKING [2]. Cheers, Daniel > [1]: > https://github.com/apache/subversion/pull/25/commits/17d645a9c2b2a02fa315044fddc4cdfce559d03f > [2] https://subversion.apache.org/docs/community-guide/conventions.html#github > -- > Timofei Zhakov >
