[l10n] Translation status report for trunk r1057984

2011-01-11 Thread SVN DEV
X-Mailer: l10n-report.py r1055713 Reply-To: dev@subversion.apache.org Mail-Followup-To: dev@subversion.apache.org Auto-Submitted: auto-generated Translation status report for tr...@r1057984 lang trans untrans fuzzy obs -- de2051 126 239

Re: Canonicalizing relative URLs

2011-01-11 Thread Blair Zajac
On 1/11/11 3:21 PM, Bert Huijben wrote: -Original Message- From: C. Michael Pilato [mailto:cmpil...@gmail.com] On Behalf Of C. Michael Pilato Sent: dinsdag 11 januari 2011 22:16 To: Subversion Development Subject: Canonicalizing relative URLs I'm looking at issue #3601, and am reworki

Re: Canonicalizing relative URLs

2011-01-11 Thread C. Michael Pilato
On 01/11/2011 06:21 PM, Bert Huijben wrote: > > >> -Original Message- From: C. Michael Pilato >> [mailto:cmpil...@gmail.com] On Behalf Of C. Michael Pilato Sent: >> dinsdag 11 januari 2011 22:16 To: Subversion Development Subject: >> Canonicalizing relative URLs >> >> I'm looking at issu

RE: Canonicalizing relative URLs

2011-01-11 Thread Bert Huijben
> -Original Message- > From: C. Michael Pilato [mailto:cmpil...@gmail.com] On Behalf Of C. Michael > Pilato > Sent: dinsdag 11 januari 2011 22:16 > To: Subversion Development > Subject: Canonicalizing relative URLs > > I'm looking at issue #3601, and am reworking the way that > svn_uri_c

Re: svn commit: r1057908 - /subversion/trunk/subversion/libsvn_client/patch.c

2011-01-11 Thread Stefan Sperling
On Tue, Jan 11, 2011 at 05:04:45PM -0600, Hyrum K Wright wrote: > On Tue, Jan 11, 2011 at 4:56 PM, wrote: > > @@ -2552,32 +2539,43 @@ delete_empty_dirs(apr_array_header_t *ta > >       /* Rebuild the empty dirs list, replacing empty dirs which have > >        * an empty parent with their parent.

Re: svn commit: r1057908 - /subversion/trunk/subversion/libsvn_client/patch.c

2011-01-11 Thread Hyrum K Wright
On Tue, Jan 11, 2011 at 4:56 PM, wrote: > Author: stsp > Date: Tue Jan 11 22:56:34 2011 > New Revision: 1057908 > > URL: http://svn.apache.org/viewvc?rev=1057908&view=rev > Log: > Significantly reduce the time spent by "svn patch" to figure out whether > there are empty directories to be deleted

Re: [l10n] Translation status report for trunk r1055292

2011-01-11 Thread Hyrum K Wright
On Wed, Jan 5, 2011 at 7:53 AM, Daniel Shahaf wrote: > By the way, as I said on wayita: +1 to Hyrum for heading the translation > efforts; I am annoyed at having to receive mails which *for me* are > information-free (because I follow the commits@ list), not at the larger > picture of someone fina

Canonicalizing relative URLs

2011-01-11 Thread C. Michael Pilato
I'm looking at issue #3601, and am reworking the way that svn_uri_canonicalize() behaves -- namely, I'm teaching it to normalize the case of hex-digit pairs (of the "%AB" variety) for all URIs, not just URLs. (Currently, it does this only for URIs with scheme data.) But I find myself with a small

Re: Feature Request: [Was: Best way to maintain patches to a 3rd party library?]

2011-01-11 Thread Daniel Shahaf
Stefan Sperling wrote on Tue, Jan 11, 2011 at 19:02:00 +0100: > See here: http://subversion.apache.org/faq.html#multi-merge This contains a broken link to .

Re: svn commit: r1004286 - in /subversion/trunk: ./ subversion/libsvn_subr/io.c

2011-01-11 Thread Daniel Shahaf
Daniel Shahaf wrote on Tue, Jan 11, 2011 at 18:34:57 +0200: > Ramkumar Ramachandra wrote on Tue, Jan 11, 2011 at 21:33:33 +0530: > > - /* Get the perms for a newly created file to find out what bits > > -should be set. > > - > > -Normally del_on_close can be problematic because

Re: svn commit: r1004286 - in /subversion/trunk: ./ subversion/libsvn_subr/io.c

2011-01-11 Thread Julian Foad
On Tue, 2011-01-11, Daniel Shahaf wrote: > I believe this is semantically correct. > > Ramkumar, Julian: is the struct still needed? IIRC the reasons for > originally introducing (namely the 'volatile' qualifier) it have since > disappeared. It's not strictly needed but it's a good way to struct

Re: svn commit: r1004286 - in /subversion/trunk: ./ subversion/libsvn_subr/io.c

2011-01-11 Thread Daniel Shahaf
I believe this is semantically correct. Ramkumar, Julian: is the struct still needed? IIRC the reasons for originally introducing (namely the 'volatile' qualifier) it have since disappeared. Daniel Ramkumar Ramachandra wrote on Tue, Jan 11, 2011 at 21:33:33 +0530: > Hi Julian and Daniel, > >

Re: [PATCH in progress] Ref-counting for pristine texts

2011-01-11 Thread Julian Foad
Branko Čibej wrote: > On 11.01.2011 16:01, Julian Foad wrote: > >> I see a different issue here: The close_wcroot() call is normally > >> handled from pool cleanup for users of the svn_client api. (The > >> svn_wc_context_t is cached in the client context, which is only closed > >> on pool cleanup)

Re: svn commit: r1004286 - in /subversion/trunk: ./ subversion/libsvn_subr/io.c

2011-01-11 Thread Ramkumar Ramachandra
Hi Julian and Daniel, Here's another revision after your suggestions on IRC. Thanks. [[[ Determine default perms in an elegant thread-safe way, not racily. * subversion/libsvn_subr/io.c (default_perms_baton, perms_init_state): New struct, variable. (get_default_file_perms): Remove all func

Re: [PATCH] pass NULL instead of an unused parameter

2011-01-11 Thread Daniel Shahaf
C. Michael Pilato wrote on Tue, Jan 11, 2011 at 10:03:23 -0500: > On 01/11/2011 07:17 AM, Prabhu Gnana Sundar wrote: > > Hi Kamesh, > > > > > > On Tuesday 11 January 2011 05:23 PM, Kamesh Jayachandran wrote: > >> Hi Prabhu, > >> > >>>SVN_ERR(svn_config_get_config(&config, opt_state->config_di

Re: [PATCH in progress] Ref-counting for pristine texts

2011-01-11 Thread Branko Čibej
On 11.01.2011 16:01, Julian Foad wrote: >> I see a different issue here: The close_wcroot() call is normally >> handled from pool cleanup for users of the svn_client api. (The >> svn_wc_context_t is cached in the client context, which is only closed >> on pool cleanup). > Thanks for pointing that

Re: [PATCH in progress] Ref-counting for pristine texts

2011-01-11 Thread Julian Foad
On Tue, 2011-01-11, C. Michael Pilato wrote: > On 01/11/2011 09:19 AM, Julian Foad wrote: > > I think it would be an embarrassing regression. Only a few people would > > ever actually bother to read the release notes and do regular "svn > > cleanup"s before their disks fill up. > > I dunno about

Re: [PATCH] pass NULL instead of an unused parameter

2011-01-11 Thread C. Michael Pilato
On 01/11/2011 07:17 AM, Prabhu Gnana Sundar wrote: > Hi Kamesh, > > > On Tuesday 11 January 2011 05:23 PM, Kamesh Jayachandran wrote: >> Hi Prabhu, >> >>>SVN_ERR(svn_config_get_config(&config, opt_state->config_dir, pool)); >>>SVN_ERR(svn_repos_create(&repos, opt_state->repository_path, >

Re: [PATCH in progress] Ref-counting for pristine texts

2011-01-11 Thread Hyrum K Wright
On Tue, Jan 11, 2011 at 8:07 AM, C. Michael Pilato wrote: > On 01/11/2011 09:01 AM, Mark Phippard wrote: >> On Tue, Jan 11, 2011 at 8:43 AM, C. Michael Pilato >> wrote: >>> On 01/11/2011 08:20 AM, Julian Foad wrote: I'm not 100% sure whether close_wcroot() is the best place to delete u

RE: [PATCH in progress] Ref-counting for pristine texts

2011-01-11 Thread Julian Foad
On Tue, 2011-01-11 at 14:56 +0100, Bert Huijben wrote: > > -Original Message- > > From: C. Michael Pilato [mailto:cmpil...@collab.net] > > Sent: dinsdag 11 januari 2011 14:44 > > To: Julian Foad > > Cc: dev@subversion.apache.org; Philip Martin; Hyrum K Wright > > Subject: Re: [PATCH in prog

Re: [PATCH in progress] Ref-counting for pristine texts

2011-01-11 Thread C. Michael Pilato
On 01/11/2011 09:19 AM, Julian Foad wrote: > I think it would be an embarrassing regression. Only a few people would > ever actually bother to read the release notes and do regular "svn > cleanup"s before their disks fill up. I dunno about "regression". My 1.6 working copies routinely have many,

Re: [PATCH in progress] Ref-counting for pristine texts

2011-01-11 Thread Julian Foad
On Tue, 2011-01-11 at 09:01 -0500, Mark Phippard wrote: > On Tue, Jan 11, 2011 at 8:43 AM, C. Michael Pilato > wrote: > > On 01/11/2011 08:20 AM, Julian Foad wrote: > >> I'm not 100% sure whether close_wcroot() is the best place to delete > >> unreferenced pristines. Review of the concept would

Re: [PATCH in progress] Ref-counting for pristine texts

2011-01-11 Thread C. Michael Pilato
On 01/11/2011 09:01 AM, Mark Phippard wrote: > On Tue, Jan 11, 2011 at 8:43 AM, C. Michael Pilato > wrote: >> On 01/11/2011 08:20 AM, Julian Foad wrote: >>> I'm not 100% sure whether close_wcroot() is the best place to delete >>> unreferenced pristines. Review of the concept would be useful here

Re: [PATCH in progress] Ref-counting for pristine texts

2011-01-11 Thread Mark Phippard
On Tue, Jan 11, 2011 at 8:43 AM, C. Michael Pilato wrote: > On 01/11/2011 08:20 AM, Julian Foad wrote: >> I'm not 100% sure whether close_wcroot() is the best place to delete >> unreferenced pristines.  Review of the concept would be useful here, in >> comparison with other options such as deletin

RE: [PATCH in progress] Ref-counting for pristine texts

2011-01-11 Thread Bert Huijben
> -Original Message- > From: C. Michael Pilato [mailto:cmpil...@collab.net] > Sent: dinsdag 11 januari 2011 14:44 > To: Julian Foad > Cc: dev@subversion.apache.org; Philip Martin; Hyrum K Wright > Subject: Re: [PATCH in progress] Ref-counting for pristine texts > > On 01/11/2011 08:20 AM,

Re: [PATCH in progress] Ref-counting for pristine texts

2011-01-11 Thread C. Michael Pilato
On 01/11/2011 08:20 AM, Julian Foad wrote: > I'm not 100% sure whether close_wcroot() is the best place to delete > unreferenced pristines. Review of the concept would be useful here, in > comparison with other options such as deleting after flushing the work > queue or at some other place. Just

Re: [PATCH in progress] Ref-counting for pristine texts

2011-01-11 Thread Julian Foad
On Tue, 2011-01-11, Julian Foad wrote: > The complete patch (with log message) is attached. Any review would be > appreciated. To be more specific: I'm happy with the way this patch uses triggers to inc and dec the ref counts. Review of impl details here would be appreciated. I'm not 100% sure

Re: [RFC] Require SQLite >= 3.6.18

2011-01-11 Thread Hyrum K Wright
On Tue, Jan 11, 2011 at 6:01 AM, Julian Foad wrote: > Any objection to requiring SQLite >= 3.6.18 as in the attached patch? Patch looks good. > WHY? > > In order to use SQLite triggers to automatically update the pristine > text reference counts (see the thread "Ref-counting for pristine texts":

Re: [PATCH in progress] Ref-counting for pristine texts

2011-01-11 Thread Julian Foad
The complete patch (with log message) is attached. Any review would be appreciated. > I have tried some timing comparisons and can't even see a difference. My test WC consisted of 10 identical directories, each containing 1000 different text files, each consisting of a single line "Hello NNN" wh

Re: [PATCH] pass NULL instead of an unused parameter

2011-01-11 Thread Prabhu Gnana Sundar
Hi Kamesh, On Tuesday 11 January 2011 05:23 PM, Kamesh Jayachandran wrote: Hi Prabhu, SVN_ERR(svn_config_get_config(&config, opt_state->config_dir, pool)); SVN_ERR(svn_repos_create(&repos, opt_state->repository_path, NULL, NULL, - co

[RFC] Require SQLite >= 3.6.18

2011-01-11 Thread Julian Foad
Any objection to requiring SQLite >= 3.6.18 as in the attached patch? WHY? In order to use SQLite triggers to automatically update the pristine text reference counts (see the thread "Ref-counting for pristine texts": ), we have to either * en

Re: [PATCH] pass NULL instead of an unused parameter

2011-01-11 Thread Kamesh Jayachandran
On 01/11/2011 05:05 PM, Prabhu Gnana Sundar wrote: Hi all, Currently, when creating a repo, svnadmin accepts the --config-dir option. But clearly, the code does not use the 'config' option being passed. Hence I am passing NULL value instead of sending the 'config' value. This change has pas

[PATCH] pass NULL instead of an unused parameter

2011-01-11 Thread Prabhu Gnana Sundar
Hi all, Currently, when creating a repo, svnadmin accepts the --config-dir option. But clearly, the code does not use the 'config' option being passed. Hence I am passing NULL value instead of sending the 'config' value. This change has passed all the tests and is working fine. I have attache

Re: [PATCH in progress] Ref-counting for pristine texts

2011-01-11 Thread Julian Foad
On Sat, 2011-01-08, Hyrum K Wright wrote: > On Fri, Jan 7, 2011 at 10:06 AM, Julian Foad wrote: > > On Fri, 2011-01-07 at 15:19 +, Philip Martin wrote: > >> Julian Foad writes: > >> > >> > The only case that SQLite doesn't handle automatically is the > >> > replacement part of "INSERT OR REPL