Re: [PATCH] pass NULL instead of an unused parameter

[Kamesh Jayachandran]

On 01/11/2011 05:05 PM, Prabhu Gnana Sundar wrote:

Hi all,

Currently, when creating a repo, svnadmin accepts the --config-dir option. But clearly, the code does not use the 'config' option being passed. Hence I am passing NULL value instead of sending the 'config' value.

This change has passed all the tests and is working fine.

I have attached the patch and the log message with this mail. Please review...

Thanks and regards
Prabhu

Hi Prabhu,

   SVN_ERR(svn_config_get_config(&config, opt_state->config_dir, pool));
   SVN_ERR(svn_repos_create(&repos, opt_state->repository_path,
                            NULL, NULL,
-                           config, fs_config, pool));
+                           NULL, fs_config, pool));

If you do not need 'config' as well you need *not* populate it.


With regards
Kamesh Jayachandran