Hi Kamesh,
On Tuesday 11 January 2011 05:23 PM, Kamesh Jayachandran wrote:
Hi Prabhu,
SVN_ERR(svn_config_get_config(&config, opt_state->config_dir, pool));
SVN_ERR(svn_repos_create(&repos, opt_state->repository_path,
NULL, NULL,
- config, fs_config, pool));
+ NULL, fs_config, pool));
If you do not need 'config' as well you need *not* populate it.
Oh yeah ... now I just did the change by not populating the 'config' and
also undeclared it.
Thanks for the comments... :)
I have attached the recent patch and the log message with this mail.
Thanks and regards
Prabhu
Index: subversion/svnadmin/main.c
===================================================================
--- subversion/svnadmin/main.c (revision 1057570)
+++ subversion/svnadmin/main.c (working copy)
@@ -558,7 +558,6 @@
{
struct svnadmin_opt_state *opt_state = baton;
svn_repos_t *repos;
- apr_hash_t *config;
apr_hash_t *fs_config = apr_hash_make(pool);
apr_hash_set(fs_config, SVN_FS_CONFIG_BDB_TXN_NOSYNC,
@@ -594,10 +593,9 @@
APR_HASH_KEY_STRING,
"1");
- SVN_ERR(svn_config_get_config(&config, opt_state->config_dir, pool));
SVN_ERR(svn_repos_create(&repos, opt_state->repository_path,
NULL, NULL,
- config, fs_config, pool));
+ NULL, fs_config, pool));
svn_fs_set_warning_func(svn_repos_fs(repos), warning_func, NULL);
return SVN_NO_ERROR;
}
[[[
when creating a repo svnadmin sends the 'config' parameter which is never used since the 1.0.x, hence passing NULL
* subversion/svnadmin/main.c
(subcommand_create): passed NULL instead of the 'config' value since it is never used in
subversion/libsvn_repos/repos.c:svn_repos_create()
deleted the 'config' apr_hash and did not populate it since it is never used.
Patch by: Prabhu Gnana Sundar <prabhugs{_AT_}collab.net>
Suggested by: Kamesh Jayachandran <kamesh{_AT_}collab.net>
]]]
