On Sat, 2011-01-08, Hyrum K Wright wrote: > On Fri, Jan 7, 2011 at 10:06 AM, Julian Foad <julian.f...@wandisco.com> wrote: > > On Fri, 2011-01-07 at 15:19 +0000, Philip Martin wrote: > >> Julian Foad <julian.f...@wandisco.com> writes: > >> > >> > The only case that SQLite doesn't handle automatically is the > >> > replacement part of "INSERT OR REPLACE INTO ...": it doesn't fire the > >> > "delete" trigger in that case. > >> > >> http://www.sqlite.org/lang_conflict.html > >> > >> suggests that you need to enable recursive triggers. > > > > Thanks - I missed that. That gets me past all the test failures except > > for upgrade tests, which is great for progress.
Actually it gets me through all the tests, and is working well. I have tried some timing comparisons and can't even see a difference. > However it would mean > > requiring SQLite >= 3.6.18 which is fairly new (16 months old) so we'd > > have to work out the practicalities of that. > > No need to sort it out: just require it. Subversion can easily be > built with an arbitrary SQLite version, independent of whatever > happens to be installed on the system. Of course, if somebody has the > correct version of the SQLite libraries, Subversion can use those, > too. > > If we need a feature of a newer SQLite, just bump the required version, says > I. OK, I'd like to do this, so I'll RFC in a new thread. - Julian
