Hi all,

Currently, when creating a repo, svnadmin accepts the --config-dir option. But clearly, the code does not use the 'config' option being passed. Hence I am passing NULL value instead of sending the 'config' value.

This change has passed all the tests and is working fine.
I have attached the patch and the log message with this mail. Please review...



Thanks and regards
Prabhu
[[[
when creating a repo svnadmin sends the 'config' parameter which is never used since the 1.0.x, hence passing NULL

* subversion/svnadmin/main.c
  (subcommand_create): passed NULL instead of the 'config' value since it is never used in subversion/libsvn_repos/repos.c:svn_repos_create()


Patch by: Prabhu Gnana Sundar <prabhugs{_AT_}collab.net>
Suggested by: Kamesh Jayachandran <kamesh{_AT_}collab.net>
]]]
Index: subversion/svnadmin/main.c
===================================================================
--- subversion/svnadmin/main.c	(revision 1054926)
+++ subversion/svnadmin/main.c	(working copy)
@@ -597,7 +597,7 @@
   SVN_ERR(svn_config_get_config(&config, opt_state->config_dir, pool));
   SVN_ERR(svn_repos_create(&repos, opt_state->repository_path,
                            NULL, NULL,
-                           config, fs_config, pool));
+                           NULL, fs_config, pool));
   svn_fs_set_warning_func(svn_repos_fs(repos), warning_func, NULL);
   return SVN_NO_ERROR;
 }

Reply via email to