Re: [Vote] PIP-245: Make subscriptions of non-persistent topic non-durable

2023-02-22 Thread Rajan Dhabalia
> But for NonPersistentTopic, creating a Durable subscription is meaningless, NonPersistentSubscription doesn't have a ManagedCursor to persistent its data. After its consumer disconnected, the subscription couldn't be removed automatically if we didn't set the value of subscriptionExpirationTimeMi

Re: [Vote] PIP-245: Make subscriptions of non-persistent topic non-durable

2023-02-22 Thread Zike Yang
+1 (non-binding) Thanks, Zike Yang On Wed, Feb 22, 2023 at 10:12 PM Jiuming Tao wrote: > > It makes sense > > > 2023年2月20日 17:32,Zike Yang 写道: > > > > Hi, Jiuming, > > > > Overall looks good to me. Left some comments for the Compatibility section: > > > >> In the next release after 2.11.1, if u

Re: [DISCUSS] Using bouncycastle fips instead bouncycastle non-fips

2023-02-22 Thread Zixuan Liu
Thanks @Michael for the context! > 2020-10-28 01:53:06 UTC - jia zhai: we could consider that in the future. current way is to align with the old manner. usually user will provide their own security jars, such as BouncyCastle, and non-fips version maybe used in a more wide range. That's valuable

Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 3

2023-02-22 Thread Matteo Merli
+1 bindind -- Matteo Merli On Fri, Feb 17, 2023 at 3:27 AM Yunze Xu wrote: > This is the 3rd release candidate for Apache Pulsar Client Python, > version 3.1.0. > > It fixes the following issues: > https://github.com/apache/pulsar-client-python/milestone/2?closed=1 > > *** Please download, tes

Re: [DISCUSS] Using bouncycastle fips instead bouncycastle non-fips

2023-02-22 Thread Michael Marshall
I am +1, but I am not familiar with the nuanced differences of these jars, so it'd be valuable to get other opinions, too. I tried to understand why the default is the way it is, and it looks like Jia Zhai was involved in the initial work [0]. I see in the slack digest on our mailing list that th

Re: [VOTE] PIP-237: Make PulsarAdmin accessible in SinkContext and SourceContext

2023-02-22 Thread Alexander Preuss
I would like to conclude the vote, there are 10 votes on the ML+GitHub of which 3 were binding. Best, Alexander On Thu, Feb 9, 2023 at 10:27 AM PengHui Li wrote: > +1 (binding) > > Penghui > > > On Feb 9, 2023, at 17:26, Nicolò Boschi wrote: > > > > +1 binding > > Nicolò > > > > Il giorno gio

Re: [VOTE] Pulsar Node.js Client Release 1.8.1 Candidate 1

2023-02-22 Thread Yunze Xu
I just noticed the `AuthenticationToken` is used here, so it's not related to #16064. The root cause is only that the prebuilt C++ add-on might have a different CA cert store path with the local env. Thanks, Yunze On Wed, Feb 22, 2023 at 10:30 PM Yunze Xu wrote: > > Hi Enrico and Nicolo, > > The

Re: [DISCUSS] PIP-246: Improved PROTOBUF_NATIVE schema compatibility checks without using avro-protobuf

2023-02-22 Thread SiNan Liu
Sorry, my mistake. I removed the code and described the design to improve the PROTOBUF_NATIVE schema compatibility checks. You can have a look. 😊 Asaf Mesika 于2023年2月22日周三 21:16写道: > I read it but you're almost directly diving into the code - it will take me > hours just to reverse engineer your

[Discuss] PIP-248: Add backlog eviction metric

2023-02-22 Thread 太上玄元道君
Hi all, I've started a PIP to discuss: PIP-248 Add backlog eviction metric ### Motivation: Pulsar has 2 configurations for the backlog eviction: `backlogQuotaDefaultLimitBytes` and `backlogQuotaDefaultLimitSecond`, if topic backlog reaches the threshold of any item, backlog eviction will be trig

Re: [VOTE] Pulsar Node.js Client Release 1.8.1 Candidate 1

2023-02-22 Thread Yunze Xu
Hi Enrico and Nicolo, The Node.js client is based on the C++ client so it requires the C++ Add-on. [1] For 1.7.0 or earlier, when users install the client, the `npm install pulsar-client` command builds the add-on. It means they have to install the C++ compiler. For 1.8.0 or later, we have provid

Re: Does anyone build UI for Pulsar?

2023-02-22 Thread Enrico Olivelli
Asaf, Il giorno mer 22 feb 2023 alle ore 14:19 Asaf Mesika ha scritto: > > Wondering out loud if there are generic UI for message brokers? Unfortunately the only "standard" API to access Messaging services is JMS but it is pretty limited as it allows only to produce and consume. Also a Pulsar U

Re: [Vote] PIP-245: Make subscriptions of non-persistent topic non-durable

2023-02-22 Thread Jiuming Tao
It makes sense > 2023年2月20日 17:32,Zike Yang 写道: > > Hi, Jiuming, > > Overall looks good to me. Left some comments for the Compatibility section: > >> In the next release after 2.11.1, if users want to create Durable >> subscriptions on NonPersistentTopic, will throw an exception. > > I think

Re: [DISCUSS] Using bouncycastle fips instead bouncycastle non-fips

2023-02-22 Thread Zixuan Liu
> 1. What is FIPS? FIPS (Federal Information Processing Standards) are a set of standards that describe document processing, encryption algorithms and other information technology standards for use within non-military government agencies and by government contractors and vendors who work with the

Re: [DISCUSS] PIP-247: Notifications for partitions update

2023-02-22 Thread Asaf Mesika
How about edge cases? In Andra's PIP he took into account cases where updates were lost, so he created a secondary poll. Not saying it's the best situation for your case of course. I'm saying that when a broker sends an update CommandPartitionUpdate, how do you know it arrived successfully? From my

Re: [DISCUSS] Using bouncycastle fips instead bouncycastle non-fips

2023-02-22 Thread Asaf Mesika
Can you elaborate a bit: 1. What is FIPS? 2. Why is the FIPS version safer exactly? 3. What is bouncycastle used exactly in Pulsar? On Wed, Feb 22, 2023 at 11:58 AM Zixuan Liu wrote: > Hi all, > > I would like to discuss using the bouncycastle fips instead of the > bouncycastle non-fips. > > T

Re: Does anyone build UI for Pulsar?

2023-02-22 Thread Asaf Mesika
Wondering out loud if there are generic UI for message brokers? On Tue, Feb 21, 2023 at 6:27 PM Kiryl Valkovich wrote: > Devin, > > The most desired feature I need as an event-driven application developer > is the ability to read and filter messages in topics. > With the NonDurable subscription

Re: [DISCUSS] PIP-246: Improved PROTOBUF_NATIVE schema compatibility checks without using avro-protobuf

2023-02-22 Thread Asaf Mesika
I read it but you're almost directly diving into the code - it will take me hours just to reverse engineer your design. Can you please include a "High Level Design" section in which you explain how you plan to tackle any issue? If I can read that section and explain to someone else how this will w

Re: Force redirect questions from Slack to GitHub Discussions or StackOverflow?

2023-02-22 Thread Asaf Mesika
No Kiryl, I meant the bot will message the user saying - "This message (It opens a thread) looks like a question. You can use the bot to post this question to GitHub for you. Just click the three dots, and choose `Post to GitHub Discussion`" On Mon, Feb 20, 2023 at 5:58 PM Dave Fisher wrote: >

Re: [DISCUSS]Add an internal class to `TransactionBufferStats` to record the snapshot status uniformly.

2023-02-22 Thread Asaf Mesika
How are those stats exposed to the user? On Mon, Feb 20, 2023 at 6:01 AM Xiangying Meng wrote: > Hi, Community, > We plan to add an internal class to `TransactionBufferStats` to record the > snapshot status uniformly. > As we all know, the current transaction buffer(TB) filters the messages > s

Re: [DISCUSS] PIP-247: Notifications for partitions update

2023-02-22 Thread houxiaoyu
Thanks for your great suggestion Enrico. I agreed with you. It's more reasonable to add a `supports_partition_update_watchers` in `FeatureFlags` to detect that the connected broker supporting this feature , and add a new broker configuration property `enableNotificationForPartitionUpdate` with d

Re: [VOTE] Pulsar Node.js Client Release 1.8.1 Candidate 1

2023-02-22 Thread Enrico Olivelli
The problem reported by Nicolò seems a real show stopper -1 (binding) Is there any volunteer on fixing the problem ? I think that most of Production users use TLS and this problem prevent anyone to upgrade from 1.7.x to 1.8.x Enrico Il giorno mer 22 feb 2023 alle ore 10:33 Nicolò Boschi ha scr

[DISCUSS] Using bouncycastle fips instead bouncycastle non-fips

2023-02-22 Thread Zixuan Liu
Hi all, I would like to discuss using the bouncycastle fips instead of the bouncycastle non-fips. The bouncycastle is a Java library that complements the default Java Cryptographic Extension (JCE), which has two versions: fips version and non-fips version. The fips version is safer than non-fips

Re: [VOTE] Pulsar Node.js Client Release 1.8.1 Candidate 1

2023-02-22 Thread Nicolò Boschi
Yes, I'm on MacOS Adding the explicit path to the system CA worked, thanks. I wonder why it wasn't needed in 1.7.0 and now it's required in 1.8.1. This can be problematic for users because the client upgrade requires code changes and redeployment. Maybe it's a regression from 1.8.0, but I think t

Re: [DISCUSS] PIP-247: Notifications for partitions update

2023-02-22 Thread Enrico Olivelli
I support this proposal. Coping here my comments from GH: can't we enable this by default in case we detect that the connected Broker supports it ? I can't find any reason for not using this mechanism if it is available. Maybe we can set the default to "true" and allow users to disable it in case

[DISCUSS] PIP-247: Notifications for partitions update

2023-02-22 Thread houxiaoyu
Hi Pulsar community: I opened a PIP to discuss "Notifications for partitions update" ### Motivation Pulsar client will poll brokers at fix time for checking the partitions update if we publish/subscribe the partitioned topics with `autoUpdatePartitions` as true. This causes unnecessary load for

Re: [VOTE] Pulsar Node.js Client Release 1.8.1 Candidate 1

2023-02-22 Thread Baodi Shi
Hi, @Nicolò Boschi Is your system macOS(arm64)? Maybe you should set tlsTrustCertsFilePath: const client = new Pulsar.Client({ tlsTrustCertsFilePath:'/etc/ssl/cert.pem', }); Thanks, Baodi Shi 在 2023年2月22日 15:59:28 上,Nicolò Boschi 写道: > Hi, > > I'm having issues while validating