It makes sense

> 2023年2月20日 17:32,Zike Yang <z...@apache.org> 写道:
> 
> Hi, Jiuming,
> 
> Overall looks good to me. Left some comments for the Compatibility section:
> 
>> In the next release after 2.11.1, if users want to create Durable 
>> subscriptions on NonPersistentTopic, will throw an exception.
> 
> I think this is an improvement but not a bug fix. Right?
> The next feature release is 3.0.0. I think we should print warn logs
> in 3.0.0 and throw exceptions may be in 3.1.0. Otherwise, it will
> bring the breaking change here in 3.0.0.
> The 2.11.1 is a patch release. I don't recommend cherry-picking this
> PIP to branch-2.11 because it's not a critical bug fix.
> 
> BR,
> Zike Yang
> 
> 
> Zike Yang
> 
> On Fri, Feb 17, 2023 at 12:52 AM Baodi Shi <ba...@apache.org> wrote:
>> 
>> +1 (non-binding)
>> 
>> Thanks,
>> Baodi Shi
>> 
>> 
>> 在 2023年2月16日 21:44:17 上,Asaf Mesika <asaf.mes...@gmail.com> 写道:
>> 
>>> +1 (non-binding)
>>> 
>>> 
>>> On Thu, Feb 16, 2023 at 11:11 AM Jiuming Tao <jm...@streamnative.io.invalid
>>>> 
>>> wrote:
>>> 
>>> 
>>> I’ve added the `Compatibility` selection into the PIP, please help review
>>> 
>>> and vote the PIP
>>> 
>>> 
>>> Thanks,
>>> 
>>> Tao Jiuming
>>> 
>>> 
>>> 
>>> 
>>>> 2023年2月15日 14:58,Zike Yang <z...@apache.org> 写道:
>>> 
>>>> 
>>> 
>>>> Hi, Jiuming
>>> 
>>>> 
>>> 
>>>>> bump
>>> 
>>>> 
>>> 
>>>> As for the discussion here[0], could you add a `Compatibility` section
>>> 
>>>> to talk about compatibility in more detail? WDYT?
>>> 
>>>> Then we could start the vote again.
>>> 
>>>> 
>>> 
>>>> [0] https://lists.apache.org/thread/2bjg39zh7z38bzbnqngbo5l4jzkjttrq
>>> 
>>>> 
>>> 
>>>> Thanks,
>>> 
>>>> Zike Yang
>>> 
>>>> 
>>> 
>>>> On Wed, Feb 15, 2023 at 1:34 PM Tao Jiuming <dao...@apache.org> wrote:
>>> 
>>>>> 
>>> 
>>>>> 
>>> 
>>>>> bump
>>> 
>>>>> 
>>> 
>>>>> On 2023/02/13 06:56:09 Jiuming Tao wrote:
>>> 
>>>>>> Hi all,
>>> 
>>>>>> 
>>> 
>>>>>> I would like to start a VOTE on `PIP-245: Make subscriptions of
>>> 
>>> non-persistent topic non-durable`.
>>> 
>>>>>> 
>>> 
>>>>>> Motivation:
>>> 
>>>>>> 
>>> 
>>>>>> There are two types of subscriptions for a topic: Durable and
>>> 
>>> Non-durable.
>>> 
>>>>>> 
>>> 
>>>>>> We create a Consumer with a Durable subscription and a Reader with a
>>> 
>>> Non-durable subscription.
>>> 
>>>>>> 
>>> 
>>>>>> But for NonPersistentTopic, creating a Durable subscription is
>>> 
>>> meaningless, NonPersistentSubscription doesn't have a ManagedCursor to
>>> 
>>> persistent its data. After its consumer disconnected, the subscription
>>> 
>>> couldn't be removed automatically if we didn't set the value of
>>> 
>>> subscriptionExpirationTimeMinutes greater than 0.
>>> 
>>>>>> 
>>> 
>>>>>> For subscriptionExpirationTimeMinutes, it controls the subscription
>>> 
>>> expiration of NonPersistentTopic and PersistentTopic, if we set the value
>>> 
>>> of subscriptionExpirationTimeMinutes greater than 0, it may lead to data
>>> 
>>> loss(The durable subscriptions of PersistentTopic also can be removed).
>>> 
>>>>>> 
>>> 
>>>>>> And the Non-durable subscriptions will be removed automatically after
>>> 
>>> all the consumers disconnected, it's the existing logic.
>>> 
>>>>>> 
>>> 
>>>>>> For the purpose of removing the subscriptions which have no active
>>> 
>>> consumers of NonPersistentTopic and the above reasons, we can make all the
>>> 
>>> subscriptions of a NonPersistentTopic Non-durable.
>>> 
>>>>>> 
>>> 
>>>>>> 
>>> 
>>>>>> 
>>> 
>>>>>> For more details, you can read:
>>> 
>>> https://github.com/apache/pulsar/issues/19448 <
>>> 
>>> https://github.com/apache/pulsar/issues/19448>
>>> 
>>>>>> 
>>> 
>>>>>> And the discuss thread is available at:
>>> 
>>> https://lists.apache.org/thread/2ltmyglnb25jy8nk58twkwbglws43bst <
>>> 
>>> https://lists.apache.org/thread/2ltmyglnb25jy8nk58twkwbglws43bst>
>>> 
>>>>>> 
>>> 
>>>>>> Thanks,
>>> 
>>>>>> Tao Jiuming
>>> 
>>> 
>>> 
>>> 

Reply via email to