more change is, OvsIpHlprCbVxlan() has been nuked since it is not
used. Not sure if it is worth being resurrected.
Testing done: Ping across Vxlan tunnel and Stt tunnel.
Signed-off-by: Nithin Raju
Reported-by: Eitan Eliahu
Acked-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Actions.c
> On Jun 19, 2015, at 8:59 AM, Alin Serdean
> wrote:
>
> I would rather leave them the way they are until we fix the actual problem
> (disable from userspace, treat the dpif_probe_feature correctly)
Sure, let’s wait for reviews for the dpif_probe_feature() change. Personally, I
feel we shoul
hi Alin,
Do you know what is required to complete the implementation of
dpif_probe_feature() in the Windows datapath? Is it the flow validation logic?
thanks,
-- Nithin
> On Jun 18, 2015, at 6:47 PM, Alin Serdean
> wrote:
>
> This patch disables features which are not currently supported
> i
t; Signed-off-by: Sorin Vinturis
> Reported-by: Nithin Raju
> Reported-at:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openvswitch_ovs-2Dissues_issues_86&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=pNHQcdr7B40b4h6Yb7FIedI1d
> On Jun 19, 2015, at 11:55 AM, Alin Serdean
> wrote:
>
> Hi Nithin,
>
> Thanks for the patch!
>
> I managed to hit the assert again.
>
> Child-SP RetAddr Call Site
> d001`7b8db7f0 f801`4446530b nt!RtlAssert+0xeb
> d001`7b8dbd50 f801`444620df OVSExt!OvsRemov
Hi,
You may have a syntax error in the flow you specified. You can dump existing
flows and try inserting/modifying them with some changes:
An example of a flow that worked is as follows:
ovs-dpctl add-flow "openvswitch"
"in_port(1),eth(src=00:11:22:33:11:02,dst=00:11:22:33:11:01),eth_type(0x0800
On Nov 21, 2014, at 8:23 AM, Eitan Eliahu
wrote:
> Hi Sorin,
> This change applies only for 6.40 drivers. Unless we bump the driver version
> this code has no effect.
> You may want to bump the minor version.
>
> #define NDIS_FILTER_MAJOR_VERSION 6
> #define NDIS_FILTER_MINOR_VERSION 30 <
On Nov 21, 2014, at 5:34 PM, Eitan Eliahu
wrote:
> The pid must be set in the NL header as the driver checks it against the pid
> in
> the instance paired with the socket.
>
> Signed-off-by: Eitan Eliahu
Acked-by: Nithin Raju
___
d
On Nov 21, 2014, at 4:58 PM, Eitan Eliahu
wrote:
> +/* Should not complete a pending IRP unless proceesing is completed */
> +if (status == STATUS_PENDING) {
> +return status;
> +}
> return OvsCompleteIrpRequest(irp, (ULONG_PTR)replyLen, status);
> }
On Nov 21, 2014, at 1:07 AM, Sorin Vinturis
wrote:
> Hi Nithin,
>
> I have only one minor comment. Please see inline.
> Other than that, looks good to me.
>
> Acked-by: Sorin Vinturis
Thanks again for your patient review. I've sent out a v3.
Thanks,
-- Nithin
__
REFERENCED_PARAMETER(msgOut);
DBG_UNREFERENCED_PARAMETER() is better.
LG otherwise.
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
hi Sorin,
In order to call OvsSendNBLIngress() on an NBL, we should have allocated an OVS
external context for it, using OvsInitExternalNBLContext(). Otherwise, on the
completion path, we'll not know how to handle this NBL.
> +PNET_BUFFER_LIST extForwardedNbls = NULL;
> +PNET_BUFFER_LIST
On Nov 21, 2014, at 2:43 PM, Gurucharan Shetty wrote:
> On Thu, Aug 28, 2014 at 6:49 AM, Alin Serdean
> wrote:
>> This commit adds to the automake build system the full build required
>> by the forwarding extension solution.
>>
>> It will help a lot in the future CI to check the full build of
tch.
>
> More details about hybrid forwarding and the necessary NDIS 6.40 support
> is provided in issue #52.
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
In this patch, we update the design document to reflect the netlink
based kernel-userspace interface implementation and a few other changes.
I have covered at a high level.
Please feel free to extend the document with more details that you think
got missed out.
Signed-off-by: Nithin Raju
Acked
On Nov 25, 2014, at 9:09 AM, Alin Serdean
wrote:
> +if (datapath->flowTable == NULL) {
> +status = STATUS_INVALID_PARAMETER;
> +goto dp_unlock;
> +}
Alin,
We allocate the flow table in OvsAllocateFlowTable() when the datapath is
allocated, which is when the 'gOvsSwitchC
Hi Ben,
This change is not good to go. Alin has filed a bug for investigating this.
Sorin or I will address it soon.
Thanks,
-- Nithin
- sent from mobile -
> On Nov 25, 2014, at 14:11, "Ben Pfaff" wrote:
>
>> On Tue, Nov 25, 2014 at 05:09:29PM +, Alin Serdean wrote:
>> Add an additional c
On Dec 2, 2014, at 8:33 PM, Eitan Eliahu
wrote:
> [1] User mode OVS expects to have the PID number in the port state
>notification command
> [2] Fix logic error-for-Windows-user-mode
>
> Signed-off-by: Eitan Eliahu
Acked-by: Nithin Raju
Th
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Flow.c | 22 --
1 files changed, 0 insertions(+), 22 deletions(-)
diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c
index 1257377..f47d469 100644
--- a/datapath-windows/ovsext/Flow.c
+++ b
In this patch, we consolidate code in Netlink.c.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c|2 +-
datapath-windows/ovsext/Flow.c|4 +-
datapath-windows/ovsext/Netlink/Netlink.c | 40 -
datapath-windows/ovsext
Moving the functions that build netlink messages to Netlink.c from
Vport.c
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.h| 14
datapath-windows/ovsext/Netlink/Netlink.c | 37 ++
datapath-windows/ovsext/Netlink/Netlink.h | 13
On Dec 3, 2014, at 10:18 AM, Eitan Eliahu
wrote:
>
> Hi Nithin,
> It may be out of the scope of this change but for consistency reason all NL
> function should return BOOLEAN rather than NTSTATUS.
> This should apply NlFillOvsMsg() and NlFillNlHdr() too.
>
>BOOLEAN ok;
> +ok = NlFillO
Per review comment, in this patch, we update the return values of
NlFillOvsMsg() and NlFillOvsHdr() from NTSTATUS to BOOLEAN to make them
consistent with the Nl* functions.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Flow.c| 31 ++--
datapath
In this patch, we consolidate code in Netlink.c.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c|2 +-
datapath-windows/ovsext/Flow.c|4 +-
datapath-windows/ovsext/Netlink/Netlink.c | 40 -
datapath-windows/ovsext
On Dec 3, 2014, at 10:32 AM, Nithin Raju wrote:
> On Dec 3, 2014, at 10:18 AM, Eitan Eliahu
> wrote:
>
>>
>> Hi Nithin,
>> It may be out of the scope of this change but for consistency reason all NL
>> function should return BOOLEAN rather than NTSTATUS.
Acked-by: Nithin Raju
On Dec 16, 2014, at 9:00 AM, Gurucharan Shetty
wrote:
> Without it, the build on Windows fails.
>
> Signed-off-by: Gurucharan Shetty
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Sorry for the delay. Thanks for making this change.
Acked-by: Nithin Raju
On Dec 11, 2014, at 4:51 AM, Sorin Vinturis
wrote:
> Removed duplicate include of "Switch.h" header.
> Removed useless usage of UNREFERENCED_PARAMETER macro for a
> referenced parameter.
> Added
louts and filters have been removed? You can
address this in a new change if we need to patch this.
Acked-by: Nithin Raju
thanks,
-- Nithin
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Dec 23, 2014, at 10:54 PM, Sorin Vinturis
wrote:
> Hi Nithin,
>
> The callout is not deleted after the session to the engine is closed, i.e.
> FwpmEngineClose. As you can see, the engine handle is not necessary for
> unregistering the callout. So it's OK to unregister the callout after th
On Dec 22, 2014, at 7:06 AM, Sorin Vinturis
wrote:
> This patch was enforced by the WHCK logo testing. In order to pass the
> Windows Filtering Platform tests we need to add a persistent system
> provider.
>
> Signed-off-by: Sorin Vinturis
hi Sorin,
Sorry the delay in the review.
The code m
On Jan 5, 2015, at 11:17 AM, Alin Serdean
wrote:
> Move the the tail of the netlink buffer accordingly to the input data.
> Currently _MapFlowStatsToNlStats overrides the netlink header information.
>
>
> Signed-off-by: Alin Gabriel Serdean
Acked-by: Nithin Raju
Thanks for
omments.
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
> On Jan 22, 2015, at 6:12 AM, Sorin Vinturis
> wrote:
>
> If the OVS extension was previously enabled and the driver unloaded,
> when the driver is loaded again a BSOD is triggered.
>
> This happens because the OVS extension registers its FilterXxx routines
> to NDIS, by calling NdisFRegisterF
ng OVS FilterXxx routines.
>
> If device object creation fails, all allocated resources during init
> phase are released by calling OvsCleanup and NdisFDeregisterFilterDriver
> functions.
>
> Signed-off-by: Sorin Vinturis
> Reported-by: Sorin V
Eitan,
Like we discussed offline, I am not comfortable with a netlink call waiting on
another thread in a synchronous context. For what it is worth, all the calls
from userspace to kernel are non-blocking. It would be great if we can not have
a separate thread, and instead use some primitives su
hi Alin,
Thanks for the patch.
From my reading, it seems that you are attempting to add support in the kernel
datapath to not handle the UFID attribute gracefully, even though there’s no
support for it in the kernel datapath. It would be useful to add a comment in
the code to this effect that U
> On Feb 4, 2015, at 11:42 AM, Gurucharan Shetty wrote:
>
> On Fri, Jan 23, 2015 at 9:33 AM, Gurucharan Shetty wrote:
>> On Thu, Jan 22, 2015 at 9:19 PM, Ben Pfaff wrote:
>>> The travis autobuilder has been pretty awesome for GNU/Linux continuous
>>> integration. I'd like to have autobuilders
> On Feb 4, 2015, at 12:27 PM, Gurucharan Shetty wrote:
>
>> I had a question regarding the machines that they provide. Have they been
>> installed with the Visual studio packages for building the kernel datapath.
>> We mostly need WDK 8.1.
> These are the pre-installed software in the machine:
> On Feb 5, 2015, at 11:00 AM, Gurucharan Shetty wrote:
>
>> From other discussions, it looks like they are quite prompt in
>> installing new software.
> They added WDK 8.1 support today. I will send in the patch for
> userspace integration. If you help me a bit, I will follow it up with
> a Wind
> On Feb 5, 2015, at 11:02 AM, Nithin Raju wrote:
>
>> On Feb 5, 2015, at 11:00 AM, Gurucharan Shetty wrote:
>>
>>> From other discussions, it looks like they are quite prompt in
>>> installing new software.
>> They added WDK 8.1 support today.
nstead of updating INSTALL.Windows
> everytime there is a change in latest version, leave it to
> user's discretion to download the latest version.
>
> Signed-off-by: Gurucharan Shetty
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch
> +AppVeyor (appveyor.com) provides a free Windows autobuild service for
> +opensource projects. Open vSwitch has integration with AppVeyor for
> +continuous build. A developer can build test his changes for Windows by
Guru,
I have a minor question. Does the yml file you added do testing as wel
In a previous commit, support had been added to support building
the kernel datapath from command line. In this patch, we document
it.
---
INSTALL.Windows.md | 28 +++-
1 files changed, 23 insertions(+), 5 deletions(-)
diff --git a/INSTALL.Windows.md b/INSTALL.Windows.md
> On Feb 5, 2015, at 2:29 PM, Alin Serdean
> wrote:
>
> Ok will update it first things tomorrow.
>
> Thanks,
> Alin.
Alin,
I had been working on this patch when I was trying to respond to:
http://openvswitch.org/pipermail/dev/2015-February/051073.html
Looks like both of us intended to work on
In a previous commit, support had been added to support building
the kernel datapath from command line. In this patch, we document
it.
Signed-off-by: Nithin Raju
---
INSTALL.Windows.md | 28 +++-
1 files changed, 23 insertions(+), 5 deletions(-)
diff --git a
> On Feb 5, 2015, at 6:36 PM, Gurucharan Shetty wrote:
>
>> Guru,
>> I have a minor question. Does the yml file you added do testing as well? I
>> see there’s a command to run configure and ‘make’ but, does it run tests
>> also? You mentioned “build test”. Hence I asked.
>
> I used the term "b
nks for the patch.
Only comment I had was to was to prefer to use "Win8.1 Debug” rather than
“Win8.1 Release”. It doesn’t make any practical difference though, but it might
be best to do “Debug” builds rather than “Release” in a build-test setup.
Acked-by: Nithin Raju
__
Caveat: Unit tests are running and not complete yet. I’ll reply back once they
are complete.
thanks,
-- Nithin
> On Feb 10, 2015, at 4:38 PM, Nithin Raju wrote:
>
> _BitScanForward() and friends are part of the Windows API and
> take DWORD as parameter type. DWORD is defined to
On Feb 10, 2015, at 4:50 PM, Nithin Raju wrote:
>
> Caveat: Unit tests are running and not complete yet. I’ll reply back once
> they are complete.
>
> thanks,
> -- Nithin
>
>> On Feb 10, 2015, at 4:38 PM, Nithin Raju wrote:
>>
>> _BitScanForward() a
nit_dword(DWORD *)' : cannot convert argument
1 from 'uint32_t *' to 'DWORD *'
Types pointed to are unrelated; conversion requires reinterpret_cast,
C-style cast or function-style cast
---
Signed-off-by: Nithin Raju
Co-Authored-by: Linda Sun
---
lib/util.h
he test.
>
> Also, provide a keyword for the test.
>
> Reported-by: Nithin Raju
> Signed-off-by: Gurucharan Shetty
Acked-by: Nithin Raju
Tested-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
o
'unsigned int'. This incompatiblity causes failures when we compile
the code as C++ code or with warnings enabled, when compiled as C
code.
The fix is to use 'unsigned long' rather than fixed size type.
Signed-off-by: Nithin Raju
Signed-off-by: Linda Sun
Co-Authored
> On Feb 16, 2015, at 4:40 AM, Sorin Vinturis
> wrote:
>
> Nithin, in a NEW NL command, when the WFP filter needs to be created for a
> new tunnel port, the code runs at dispatch IRQL. At dispatch IRQL any WFP
> call fails. That is why I have created a thread for postponing WFP-based work
> w
Sorin,
I’m treating this change as a continuation of the other changed titled “support
for custom VXLAN tunnel port”.
High level comment is:
There may be a STT port and UDP port with the same destination port number. We
might need to specify the tunneling protocol or the L4 protocol as key as we
> On Mar 5, 2015, at 6:58 AM, Gurucharan Shetty wrote:
>
> Signed-off-by: Gurucharan Shetty
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
> On Mar 5, 2015, at 7:30 AM, Gurucharan Shetty wrote:
>
> Commit 6fd6ed71cb9f(ofpbuf: Simplify ofpbuf API.) removed ofpbuf_size
> and ofpbuf_data. They still had reference from netdev-windows. Fix them.
>
> Signed-off-by: Gurucharan Shetty
Thanks for the fix.
Ack
Thanks Ben for reporting this. One of the Hyper-V developers will provide a
fix, if not for Jarno.
-- Nithin
> On Mar 13, 2015, at 1:57 PM, Ben Pfaff wrote:
>
> The appveyor build on Windows failed (see
> https://urldefense.proofpoint.com/v2/url?u=https-3A__ci.appveyor.com_project_blp_ovs_buil
> udpHdr = (UDPHdr *)((PCHAR)ipHdr + sizeof *ipHdr);
> udpHdr->source = htons(tunKey->flow_hash | 32768);
> -udpHdr->dest = VXLAN_UDP_PORT_NBO;
> +udpHdr->dest = htons(tunKey->dst_port);
Tunnel key is generally in Network order already. Why do we
> On Mar 12, 2015, at 5:42 PM, Sorin Vinturis
> wrote:
>
> Modified 'nl_sock_transact_multiple__' function to send asynchronous
> I/O requests to the kernel driver.
>
> Signed-off-by: Sorin Vinturis
> Reported-by: Alin Gabriel Serdean
> Reported-at:
> https://urldefense.proofpoint.com/v2/url
Alessandro,
Thanks for putting out the installer in the open. This is great.
A few more questions from me to the list that Guru has. I had written an MSI
installer long ago, but nothing which involved services and such. So, my
questions may be trivial.
1. How do we handle dependencies? Eg. pthr
> On Mar 15, 2015, at 7:54 PM, Alessandro Pilotti
> wrote:
>
>
>
>
>> On 16 mar. 2015, at 03:30, Eitan Eliahu wrote:
>>
>>
>> Alessandro,
>> Yes, no problem of having the installer separate. But, I am confused as I
>> see the two services are there but the driver and the INF file are not
Thanks Jarno.
> On Mar 16, 2015, at 3:27 PM, Jarno Rajahalme wrote:
>
> This is now reverted in master,
>
> Jarno
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
hi Sorin,
Thanks for the change. Looks good mostly. I had a couple of minor comments that
are inlined.
> On Sep 11, 2015, at 4:09 AM, Sorin Vinturis
> wrote:
>
> The internal/external vports will have the actual OS-based names, which
> represent the NIC interface alias that is displayed by run
> On Sep 14, 2015, at 7:51 PM, Alin Serdean
> wrote:
>
> For this to work in the case for the internal port change you also need to
> change the following lines:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openvswitch_ovs_blob_master_datapath-2Dwindows_ovsext_Vport.c-23L21
to make sure that 15’s tunnel context gets saved after processing 15, so
that 16 and 17 can use it. So, you’ll have to save ovsFwdCxt->tunKey.
In any case, your patch is an improvement over existing code, so I’m ACKing it.
Acked-by: Nithin Raju
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/User.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/datapath-windows/ovsext/User.c b/datapath-windows/ovsext/User.c
index 0bbf690..d6139b8 100644
--- a/datapath-windows/ovsext/User.c
+++ b/datapath
Simple code motion.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c | 118 ++---
datapath-windows/ovsext/User.c | 108 +
datapath-windows/ovsext/User.h | 7 +++
3 files changed, 120 insertions(+), 113
igned-off-by: Nithin Raju
---
lib/netlink-socket.c | 27 ++-
1 file changed, 18 insertions(+), 9 deletions(-)
diff --git a/lib/netlink-socket.c b/lib/netlink-socket.c
index 42eb232..35c115a 100644
--- a/lib/netlink-socket.c
+++ b/lib/netlink-socket.c
@@ -1178,10 +11
, there's no input buffer associated
with the request. So, we use a temporary input buffer to be able to
call the Netlink APIs for constructing the output NL error message.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c | 17 -
1 file changed, 16 insertions(
hi Sorin,
The change looks good overall. I have one comment in
OvsInitConfiguredSwitchNics() which I had asked in the review for the v1 patch
as well. Not sure if you got a chance to address that.
thanks,
-- Nithin
> On Sep 18, 2015, at 2:31 AM, Sorin Vinturis
> wrote:
>
> The internal/exte
hi Sai,
Thanks for implementing this.
I had a few minor comments. I should be able to ack the v4.
thanks,
-- Nithin
> On Sep 18, 2015, at 5:20 PM, Sairam Venugopal wrote:
>
> Enable support for Checksum offloads in STT if it's enabled in the Windows
> VM. Set the Checksum Partial and Checksum
ned-off-by: Sairam Venugopal
Thanks for addressing the comments.
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Sound good. Thanks for the explanation. If you don’t mind, can you pls. add a
comment to this effect? The code in Vport.c is kind of complex, and comments
would really help.
Acked-by: Nithin Raju
> On Sep 21, 2015, at 10:40 PM, Sorin Vinturis
> wrote:
>
> Hi Nithin,
>
represent the NIC interface alias that is displayed by running
>>> 'Get-NetAdapter' Hyper-V PS command.
>>>
>>> Signed-off-by: Sorin Vinturis
>>> Acked-by: Nithin Raju
>>
>> Applied, thanks!
>
> Let me know if this should go on branch-
> On Sep 22, 2015, at 9:07 AM, Ben Pfaff wrote:
>
> Thanks Sairam and Nithin, I applied this to master.
Ben,
Can you pls. apply this to 2.4 as well?
thanks,
-- Nithin
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/de
Acked-by: Nithin Raju
> On Sep 22, 2015, at 12:35 PM, Alin Serdean
> wrote:
>
> Change variable name to fix compiling.
>
> Signed-off-by: Alin Gabriel Serdean
> ---
> This patch is intended only for the branch-2.4
> ---
> datapath-windows/ovsext/Flow.c | 10
precautions
for it.
Pls. let us know if you have concerns.
thanks,
-- Nithin
> On Sep 22, 2015, at 7:11 PM, Jesse Gross wrote:
>
> On Tue, Sep 22, 2015 at 9:18 AM, Nithin Raju wrote:
>>
>>> On Sep 22, 2015, at 9:07 AM, Ben Pfaff wrote:
>>>
>>> Thanks S
> On Sep 23, 2015, at 8:33 AM, Jesse Gross wrote:
>
> On Tue, Sep 22, 2015 at 11:04 PM, Nithin Raju wrote:
>> hi Jesse,
>> We are getting the Hyper-V solution to a state with the following goals:
>> - Work “out of the box” ie. no need to make special settings suc
-Mesaj original-
>> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
>> Trimis: Tuesday, September 15, 2015 9:52 PM
>> Către: dev@openvswitch.org
>> Subiect: [ovs-dev] [PATCH 1/4] datapath-windows: move packet read code
>> to User
> On Sep 23, 2015, at 8:23 AM, Alin Serdean
> wrote:
>
> You could probably use NlFillNlHdr to prepare the netlink message.
Done in the v2.
>
> Shouldn't this be apply to OVS_IOCTL_READ also?
OVS_IOCTL_READ is used for dump operations, in which case we’d have cached the
msgIn from the dump
Signed-off-by: Nithin Raju
Acked-by: Sairam Venugopal
Acked-by: Alin Gabriel Serdean
---
v2: collected acks
---
datapath-windows/ovsext/User.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/datapath-windows/ovsext/User.c b/datapath-windows/ovsext/User.c
igned-off-by: Nithin Raju
Acked-by: Sairam Venugopal
---
v2: collected ACks
---
lib/netlink-socket.c | 27 ++-
1 file changed, 18 insertions(+), 9 deletions(-)
diff --git a/lib/netlink-socket.c b/lib/netlink-socket.c
index 42eb232..35c115a 100644
--- a/lib/netlink-socket.c
, there's no input buffer associated
with the request. So, we use a temporary input buffer to be able to
call the Netlink APIs for constructing the output NL error message.
Signed-off-by: Nithin Raju
Acked-by: Sairam Venugopal
---
v2: addressed ALin's review comments
---
datapath-wind
Simple code motion.
Signed-off-by: Nithin Raju
Acked-by: Sairam Venugopal
---
v2: addressed Alin's review comments
---
datapath-windows/ovsext/Datapath.c | 115 ++---
datapath-windows/ovsext/User.c | 108 ++
datapath-wi
> On Sep 23, 2015, at 9:13 AM, Alin Serdean
> wrote:
>
> Looks good to me just two small things:
> When poll_wevent_wait finishes could you use GetOverlappedResult to see if
> there were no error codes.
poll_wevent_wait() is not a blocking function, and when it returns it is not
necessary th
igned-off-by: Alin Gabriel Serdean
Thanks for doing this.
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
> On 9/22/15, 3:18 PM, "Alin Serdean"
> wrote:
>
>> This patch adds the file DpInternal.h to the ovsetx.sln.
>>
>> Signed-off-by: Alin Gabriel Serdean
>> ---
>> This patch is meant for branch-2.4 as well
Acked-by: Nithin Raju
___
s the values used in the common
> header of the datapath.
>
> Signed-off-by: Alin Gabriel Serdean
> ---
> This patch is intended for branch-2.4 as well
> ---
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
> On Sep 29, 2015, at 5:01 PM, Ben Pfaff wrote:
>
> On Tue, Sep 29, 2015 at 01:05:33PM -0700, Jesse Gross wrote:
>> On Tuesday, September 29, 2015, Ben Pfaff > > wrote:
>>
>>> On Wed, Sep 23, 2015 at 08:49:49AM -0700, Jesse Gross wrote:
>>>> On
hi Alin,
The change looks good. However I have a few minor comments. Pls. take a look.
> On Sep 22, 2015, at 5:00 PM, Alin Serdean
> wrote:
>
> This patch adds OVS_KEY_ATTR_TCP_FLAGS to our flow mechanism.
>
> Also clean unecesarry parts of code.
>
> Signed-off-by: Alin Gabriel Serdean
> ---
Hi Sorin/Alin,
Is this an optimization or a fix?
Can you pls. add more details?
We do two flow lookups for a reason - once for the inner packet from the
VIF, and once more after encapsulation. There¹s nothing to avoid here.
The only way to avoid the second lookup is by handing off the packet to
End result is that "mac_in_use" column gets populated in
OVSDB for internal and external NICs.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Vport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovse
Thanks for incorporating all the review comments.
Acked-by: Nithin Raju
-Original Message-
From: Sorin Vinturis
Date: Thursday, October 15, 2015 at 4:58 AM
To: "dev@openvswitch.org"
Subject: [ovs-dev] [PATCH v2] datapath-windows: Support attribute
OVS_KEY_ATTR_TCP_FLAGS
&
Acked-by: Nithin Raju
-Original Message-
From: Sairam Venugopal
Date: Monday, October 26, 2015 at 4:48 PM
To: "dev@openvswitch.org"
Subject: [ovs-dev] [PATCH v2 1/3] datapath-windows:
MoveOvsAllocateNBLFromBuffer to BufferMgmt
>Move the functionality around creatin
Acked-by: Nithin Raju
-Original Message-
From: Sairam Venugopal
Date: Saturday, October 24, 2015 at 1:40 PM
To: "dev@openvswitch.org"
Subject: [ovs-dev] [PATCH 2/3] datapath-windows: STT - Add support for
TCP Segmentation Offload
>Create and initialize the backgrou
Thanks for working on this. It is really awesome to have TSO support with
STT now!
Acked-by: Nithin Raju
-Original Message-
From: Sairam Venugopal
Date: Tuesday, October 27, 2015 at 10:20 AM
To: Nithin Raju
Subject: Fw: [PATCH v2 3/3] datapath-windows: STT - Enable support for TCP
Thanks for doing this!
Acked-by: Nithin Raju
-Original Message-
From: Sairam Venugopal
Date: Tuesday, October 27, 2015 at 2:36 PM
To: "dev@openvswitch.org"
Subject: [ovs-dev] [PATCH] datapath-windows: STT - Offload inner
checksumcalculation
>Offload the i
vport
>tunnel type which is not supported by the kernel extension.
>
>Signed-off-by: Alin Gabriel Serdean
>
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Just a minor detail, but ConvertInterfaceLuidToAlias() seems to be
returning something of type NETIO_STATUS, with NO_ERROR indicating
success. We should probably use the appropriate type.
Looks good otherwise. Thanks for doing this.
Acked-by: Nithin Raju
-Original Message-
From
We already have functions HvCreatePort() and HvCreateNic() to
do the work. Might as well use that during port enumeration.
More refactoring in later patches.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Switch.c | 6 ++-
datapath-windows/ovsext/Vport.c | 89
801 - 900 of 936 matches
Mail list logo
