hi Sorin,
Thanks for making the change.

I had a couple of minor comments.

> @@ -288,12 +346,13 @@ Exit:
> VOID
> OvsTunnelUnregisterCallouts(VOID)
> {
> +    OvsTunnelRemoveFilter(&OVS_TUNNEL_FILTER_KEY,
> +                          &OVS_TUNNEL_SUBLAYER);
>     FwpmEngineClose(gEngineHandle);
>     gEngineHandle = NULL;
>     FwpsCalloutUnregisterById(gCalloutIdV4);

This is not related to your change - but should we be doing FwpmEngineClose() 
after FwpsCalloutUnregisterById()? ie. shouldn't we be closing the handle to 
the engine after all the callouts and filters have been removed? You can 
address this in a new change if we need to patch this.

Acked-by: Nithin Raju <nit...@vmware.com>

thanks,
-- Nithin

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to