On Dec 3, 2014, at 10:32 AM, Nithin Raju <nit...@vmware.com> wrote: > On Dec 3, 2014, at 10:18 AM, Eitan Eliahu <elia...@vmware.com> > wrote: > >> >> Hi Nithin, >> It may be out of the scope of this change but for consistency reason all NL >> function should return BOOLEAN rather than NTSTATUS. >> This should apply NlFillOvsMsg() and NlFillNlHdr() too. >> >> BOOLEAN ok; >> + ok = NlFillOvsMsg(&nlBuffer, msgIn->nlMsg.nlmsgType, NLM_F_MULTI, >> >> But the function signature is >> NTSTATUS NlFillOvsMsg(PNL_BUFFER nlBuf, UINT16 nlmsgType,: > > Not a problem. Thanks for the suggestion. I'll send out a v2 with the > suggested change.
Eitan, I created a new patch for the change you suggested, and sent it for review. It is a 2 part series. thanks, -- Nithin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
