Alessandro, Thanks for putting out the installer in the open. This is great.
A few more questions from me to the list that Guru has. I had written an MSI installer long ago, but nothing which involved services and such. So, my questions may be trivial. 1. How do we handle dependencies? Eg. pthread DLL are required. Are they packaged into the installer? 2. Does the OVS extension get enabled on one of the Hyper-V vswitches? If not, then is there any plan to have an “OVS Setup Wizard”, or do we plan to reply on a README document? 3. Is there a initial setup script that sets up things like “br-pif”, and “br-int”, and connects up the internal port, and external port to the bridges? Regarding where the installer code should be located, my vote would be to keep this within the OVS repo. A good reason to keep it outside is if this code gets reused for installing or packaging non-OVS executables. At the Openstack summit we had discussed that the Cloudbase Neutron plugin installer can also install OVS in the future. If we are talking of such an installer, then it makes sense to put it in a different repo. Since this installer is specific to OVS, I think we should keep it within the OVS repo. (I am probably restating what Ben already said). That said, we have to work out the location of the code etc. thanks, -- Nithin > On Mar 16, 2015, at 10:37 AM, Gurucharan Shetty <shet...@nicira.com> wrote: > > On Sun, Mar 15, 2015 at 5:33 PM, Alessandro Pilotti > <apilo...@cloudbasesolutions.com> wrote: >> Hi guys, >> >> As discussed on IRC, here's the Windows MSI installer project that we’d like >> to >> submit for upstream inclusion: >> >> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_cloudbase_ovs-2Dwindows-2Dinstaller&d=AwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=pNHQcdr7B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80&m=jRW3GdRlPnccumoK5koB1aLyNAgA1dUFpe2AqYg4-Uk&s=0m_U_AYPESD1MBZ9_uNrgcIgD2h6oqnd-KrkIMsNiM8&e= >> > > Thank you for the contribution, Alessandro! > > I have a few questions after a quick browsing of the above repo. I > have never written a Windows installer before, so some of my questions > may look trivial. > > 1. What are the 2 executables in the below link? > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_cloudbase_ovs-2Dwindows-2Dinstaller_tree_master_ovs-2Dwindows-2Dinstaller_Services&d=AwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=pNHQcdr7B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80&m=jRW3GdRlPnccumoK5koB1aLyNAgA1dUFpe2AqYg4-Uk&s=OlfTWEPzJr-ouhOH9MPJhF0tdHIa2yClpsD0Xnp_v_k&e= > > > Why do we need them? The way services handling code has been written > in OVS is that it will need a workflow like this (example taken from > tests/daemon.at): > sc create ovsdb-server binpath="$abs_path/ovsdb-server `pwd`/db > --log-file=`pwd`/ovsdb-server.log --pidfile=`pwd`/pid > --remote=punix:`pwd`/socket --unixctl=`pwd`/unixctl --service > --service-monitor" > sc start ovsdb-server > > 2. I do not see anywhere in the repo where we run OVS initialization, > like handling OVS database creation and initialization. > (See start_ovsdb function in utilities/ovs-ctl.in on how we do it in Linux.) > > 3. Where do the log files get written? > > 4. How do we restart OVS services? (e.g. on Linux: > /etc/init,d/openvswitch-switch restart). This would mean the need to > upgrade the database with a different schema. Do we have an analogous > thing to startup scripts in Windows? > >> >> The included README.rst provides information on how to generate the MSI and >> I’ll also be happy to answer any question and review. >> >> In terms of location of the code, we could IMO either include the installer >> as >> a separate project on >> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openvswitch&d=AwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=pNHQcdr7B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80&m=jRW3GdRlPnccumoK5koB1aLyNAgA1dUFpe2AqYg4-Uk&s=PDDRV6-o5xOKEL39hUYLZCqAaYAdCQC16owmi9Vpasw&e= >> or as a subfolder under >> the >> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openvswitch_ovs&d=AwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=pNHQcdr7B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80&m=jRW3GdRlPnccumoK5koB1aLyNAgA1dUFpe2AqYg4-Uk&s=0rvuMNAIsfcYMsxbs3y0DDa5XjiOgKWIY3fbyjhYZZE&e= >> project itself. >> My vote is for the first option, but if you guys prefer the second I’ll be >> happy to send the full patchset on the ML for review. > > An ideal solution would be similar to how we create rpms and deb files > for RHEL (rhel/* ) and Ubuntu (debian/* ). They are both in-tree in > the OVS repo. So, in the ideal solution, we can create a MSI installer > by running a command after running the 'make'. The command would > automatically pick up all the required components (available through > previous ./configure run) and create an installer out of it. It looks > like it would be possible to do that (based on your README). It would > also mean that it would be a OVS specific installer (I think your > current code is a general purpose installer that you could use for > multiple projects). Having a OVS specific installer may eventually be > needed anyway because managing a OVS installation well would need all > the things that we currently do in utilities/ovs-ctl.in for Linux. > > > Thanks, > Guru > > >> _______________________________________________ >> dev mailing list >> dev@openvswitch.org >> https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailman_listinfo_dev&d=AwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=pNHQcdr7B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80&m=jRW3GdRlPnccumoK5koB1aLyNAgA1dUFpe2AqYg4-Uk&s=gmZq5wPHgdKJ8x-UmyTyU36vYTDaL6d5xJVNHUBhnEg&e= >> > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailman_listinfo_dev&d=AwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=pNHQcdr7B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80&m=jRW3GdRlPnccumoK5koB1aLyNAgA1dUFpe2AqYg4-Uk&s=gmZq5wPHgdKJ8x-UmyTyU36vYTDaL6d5xJVNHUBhnEg&e= > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
