> On Sep 23, 2015, at 9:13 AM, Alin Serdean <aserd...@cloudbasesolutions.com> > wrote: > > Looks good to me just two small things: > When poll_wevent_wait finishes could you use GetOverlappedResult to see if > there were no error codes.
poll_wevent_wait() is not a blocking function, and when it returns it is not necessary that the overlapped IO has completed. I am not sure what you mean by “use GetOverlappedResult() to see if there are no error codes”. If the kernel indicated an error for the overlapped IO, userspace poll will fire. Moreover, the next time nl_sock_wait() is called, ‘sock->overlapped.Internal’ would be set to the error code, upon which we’ll setup a new overlapped IO with pend_io_request(). So, it is not like we’ll be wedged if there’s an error. > The function pend_io_request could be Boolean; we do not take into acquire > other values. sure. updated the code in the v3. -- Nithin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
