[ovs-dev] datapath-windows: define a version number in DP extensions

We need a version number for the datapath interface extensions that we can leverage at some point. Signed-off-by: Nithin Raju --- datapath-windows/include/OvsDpInterfaceExt.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/datapath-windows/include/OvsDpInterfaceExt.h

Re: [ovs-dev] [PATCH] Create a NBL for each NB when required

while a NET_BUFFER_LIST as param > constraints the use of an OvsGetTcp call to a specific scenario / usage only. > > Regarding braces, sorry for that. It will be fixed. > > Sam > > From: Nithin Raju [nit...@vmware.com] > Sent: Thursda

[ovs-dev] [PATCH 2/2] netlink-socket.c: add support for nl_lookup_genl_mcgroup()

While we work out whether nl_sock_join_mcgroup() will be the mechanism to support VPORT events, it is easy to add support for nl_lookup_genl_mcgroup() and make progress on the other commands. In this patch, we implement support for nl_lookup_genl_mcgroup() only for the VPORT family though, which i

[ovs-dev] [PATCH 1/2] datapath-windows: define mcgroup IDs for VPORT and other families

nl_lookup_genl_mcgroup(). and make progress with the other simpler commands. In this patch, we define a ID for the VPORT MC group and other groups. The plan is to use only the VPORT MC group though. Signed-off-by: Nithin Raju --- datapath-windows/include/OvsDpInterfaceExt.h |8 1 files

[ovs-dev] [PATCH 1/2 v2] datapath-windows: define mcgroup IDs for VPORT and other families

nl_lookup_genl_mcgroup(). and make progress with the other simpler commands. In this patch, we define a ID for the VPORT MC group and other groups. The plan is to use only the VPORT MC group though. Signed-off-by: Nithin Raju --- datapath-windows/include/OvsDpInterfaceExt.h |8 1 files

[ovs-dev] [PATCH 2/2 v2] netlink-socket.c: add support for nl_lookup_genl_mcgroup()

While we work out whether nl_sock_join_mcgroup() will be the mechanism to support VPORT events, it is easy to add support for nl_lookup_genl_mcgroup() and make progress on the other commands. In this patch, we implement support for nl_lookup_genl_mcgroup() only for the VPORT family though, which i

[ovs-dev] [PATCH] datapath-windows: trivial formatting changes in Netlink.c

--- datapath-windows/ovsext/Netlink.c | 16 +--- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/datapath-windows/ovsext/Netlink.c b/datapath-windows/ovsext/Netlink.c index 1c8d054..7b50221 100644 --- a/datapath-windows/ovsext/Netlink.c +++ b/datapath-windows/ovsext/N

[ovs-dev] [PATCH] netlink-socket.c: fix typo to get_sock_pid_from_kernel()

A typo crept in while respinning get_sock_pid_from_kernel() in the previous patch. Fixing it now. Also, get_sock_pid_from_kernel() doesn't need an OUT argument. Fixing that too. --- lib/netlink-socket.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/netlink-s

[ovs-dev] [PATCH] datapath-windows: Update netlink family IDs

I didn't realize earlier while defining OvsDpInterfaceExt.h that there are special values defined in netlink-protocol.h for nlmsg_type. For Eg. NLMSG_ERROR is defined to be 2. In this patch, we update the values of the family IDs to not clash with the special defines. I'm using NLMSG_MIN_TYPE as a

[ovs-dev] OVS-on-HyperV: Agenda for IRC meeting on 8/27

hi Alin/Sam, These were the items we wanted to discuss: 1. Netlink implementation: * status * work has been spread out now, and issues have been created for each individual task. There should be no confusion now. This was the plan all along, BTW. We'll discuss anything that is not clear. 2.

Re: [ovs-dev] [PATCH 1/2] datapath-windows: define mcgroup IDs for VPORT and other families

; [PATCH] > #define OVS_WIN_NL_INVALID_MCGRP_ID 0 > > /* only the VPORT multicast group is used. */ > #define OVS_WIN_NL_VPORT_MCGRP_ID104 > [/PATCH] > > Thanks, > Sam > ________ > Date: Fri, 22 Aug 2014 21:51:22 -0700

[ovs-dev] [PATCH 2/2 v2] netlink-socket.c: add support for nl_lookup_genl_mcgroup()

is all what dpif-linux.c needs. Validation: - A ported dpif-linux.c with epoll code commented out went so far as to call dp_enumerate! DP Dump commands can be implemented next. Signed-off-by: Nithin Raju --- lib/netlink-socket.c | 21 + 1 files changed, 21 insertions(+), 0

[ovs-dev] [PATCH 1/2 v2] datapath-windows: define mcgroup IDs for VPORT and other families

nl_lookup_genl_mcgroup(). and make progress with the other simpler commands. In this patch, we define a ID for the VPORT MC group and use it. The IDs for other families were also defined, but without usage, were seen as unclear. Hence we define only the VPORT group. Signed-off-by: Nithin Raju

[ovs-dev] [PATCH v2] netlink-socket.c: fix typo to get_sock_pid_from_kernel()

A typo crept in while respinning get_sock_pid_from_kernel() in the previous patch. Fixing it now. Also, get_sock_pid_from_kernel() doesn't need an OUT argument. Fixing that too. Signed-off-by: Nithin Raju --- lib/netlink-socket.c | 10 +- 1 files changed, 5 insertions(+), 5 dele

[ovs-dev] [PATCH v2] datapath-windows: Update netlink family IDs

_TYPE as a reference. All this points to doing family ID lookup from the kernel rather than returning values from netlink-socket.c. We should move to that model after we get through the first round of netlink commands. Signed-off-by: Nithin Raju --- datapath-windows/include/OvsDpInterfaceEx

[ovs-dev] [PATCH] netlink-socket.c: use read/write ioctl instead of ReadFile/WriteFile

nl_sock_transact_multiple__() has not been touched since it is not needed yet. Main motive for this change is to be able to unblock the DP Dump workflow. Signed-off-by: Nithin Raju --- lib/netlink-socket.c | 46 ++ 1 files changed, 26 insertions(+), 20

Re: [ovs-dev] OVS-on-HyperV: Agenda for IRC meeting on 8/27

ding patches: --- We all agreed that pending patches need to be reviewed soon, esp. the multiple NB patch. thanks, Nithin On Aug 26, 2014, at 10:20 AM, Nithin Raju mailto:nit...@vmware.com>> wrote: hi Alin/Sam, These were the items we wanted to discuss: 1. Netlink imple

Re: [ovs-dev] [PATCH] netlink-socket.c: use read/write ioctl instead of ReadFile/WriteFile

On Aug 27, 2014, at 11:19 AM, Eitan Eliahu wrote: > > +if (!DeviceIoControl(sock->handle, OVS_IOCTL_READ, > + NULL, 0, tail, sizeof tail, &bytes, NULL)) > ... > +memcpy(ofpbuf_data(buf), tail, retval); > +ofpbuf_set_size(buf, r

[ovs-dev] [PATCH 1/4] datapath-windows: Data structures and functions for dump state

Signed-off-by: Nithin Raju --- datapath-windows/ovsext/Datapath.h | 54 ++-- 1 files changed, 45 insertions(+), 9 deletions(-) diff --git a/datapath-windows/ovsext/Datapath.h b/datapath-windows/ovsext/Datapath.h index 6d8a6db..0b303a2 100644 --- a/datapath

[ovs-dev] [PATCH 4/4] datapath-windows: add support for GET_DP command to dump datpaths

: - With a hacked up dpif-linux.c to work on Windows, dpif_linux_enumerate() successfully enumerated the datapaths in the kernel. Signed-off-by: Nithin Raju --- datapath-windows/ovsext/Datapath.c | 220 ++-- 1 files changed, 186 insertions(+), 34 deletions

[ovs-dev] [PATCH 2/4] datapath-windows: make NL version a UIN8 and add a validateDp arg

I didn't realize earlier that version in a netlink message was a UINT8. So, fixing that here. Also, some of the commands don't pass a valid DP value. Hence adding a field to identify such commands. Signed-off-by: Nithin Raju --- datapath-windows/ovsext/Datapat

[ovs-dev] [PATCH 3/4] datapath-windows: add a context structure for user parameters

keeps the code clean, IMO. Signed-off-by: Nithin Raju --- datapath-windows/ovsext/Datapath.c | 72 ++- datapath-windows/ovsext/Datapath.h | 37 ++ 2 files changed, 58 insertions(+), 51 deletions(-) diff --git a/datapath-windows/ovsext

Re: [ovs-dev] [PATCH 1/4] datapath-windows: Data structures and functions for dump state

On Aug 28, 2014, at 4:16 PM, Ankur Sharma wrote: > Hi NIthin, > > Changes are fine. > One very minor comment would be that we should improve the formatting of > InitUserDumpState function. But this can be handled later, we are good for > checkin. hi Ankur, Thanks for the review. InitUserDum

Re: [ovs-dev] [PATCH 3/4] datapath-windows: add a context structure for user parameters

On Aug 28, 2014, at 4:17 PM, Ankur Sharma wrote: > Add a description for each member of OVS_USER_PARAMS_CONTEXT Done. I'll be sending out a patch for this. thanks, Nithin ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listin

Re: [ovs-dev] [PATCH 4/4] datapath-windows: add support for GET_DP command to dump datpaths

On Aug 28, 2014, at 4:19 PM, Ankur Sharma wrote: > One minor comment: > 1. In function OvsGetDpCmdHandler, we should check for devOp at line 830 > rather than dump_state. Done. I'll incorporate in the patch I'll send out. thanks for the review. -- Nithin _

Re: [ovs-dev] [PATCH 1/4] datapath-windows: Data structures and functions for dump state (Nithin Raju)

On Aug 28, 2014, at 6:40 PM, Samuel Ghinet wrote: > Hello Nithin, > > I have a few notes regarding the patch: > >>struct { >>POVS_MESSAGE ovsMsg;/* OVS message passed during dump start. */ >>UINT32 index[8];/* markers to continue dump from. One or more >>

Re: [ovs-dev] dev Digest, Vol 61, Issue 395

On Aug 28, 2014, at 6:52 PM, Samuel Ghinet wrote: > Hello Nithin, > >> BOOLEAN validateDp; /* Does command require a valid DP argument. */ >> } NETLINK_CMD, *PNETLINK_CMD; > > Perhaps a better name would be validateDpIfIndex? Or, is there going to be > something more to be validate

Re: [ovs-dev] [PATCH 4/4] datapath-windows: add support for GET_DP command to dump datpaths (Nithin Raju)

On Aug 28, 2014, at 7:22 PM, Samuel Ghinet wrote: > Hello Nithin, > >> /* Netlink datapath family. */ >> NETLINK_CMD nlDatapathFamilyCmdOps[] = { >>{ OVS_DP_CMD_GET, OvsGetDpCmdHandler, >> OVS_WRITE_DEV_OP | OVS_READ_DEV_OP, FALSE } >> }; > > Could you make the NETLINK_CMD variable in

[ovs-dev] [PATCH 2/9 v2] datapath-windows: make NL version a UIN8 and add a validateDp arg

I didn't realize earlier that version in a netlink message was a UINT8. So, fixing that here. Also, some of the commands don't pass a valid DP value. Hence adding a field to identify such commands. Signed-off-by: Nithin Raju Acked-by: Ankur Sharma Acked-by: Samuel Ghinet --- datapa

[ovs-dev] [PATCH 1/9 v2] datapath-windows: Data structures and functions for dump state

Signed-off-by: Nithin Raju Acked-by: Ankur Sharma Acked-by: Samuel Ghinet --- datapath-windows/ovsext/Datapath.h | 54 ++-- 1 files changed, 45 insertions(+), 9 deletions(-) diff --git a/datapath-windows/ovsext/Datapath.h b/datapath-windows/ovsext/Datapath.h

[ovs-dev] [PATCH 8/9 v2] datpath-windows: fix the dp index check in ValidateNetlinkCmd()

Also renamed the validateDp boolean to a more meaningful name. Signed-off-by: Nithin Raju Acked-by: Ankur Sharma Acked-by: Samuel Ghinet --- datapath-windows/ovsext/Datapath.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/datapath-windows/ovsext/Datapath.c b

[ovs-dev] [PATCH 9/9 v2] datapath-windows: refactor code to setup dump start state

refactor that too. Signed-off-by: Nithin Raju Acked-by: Ankur Sharma Acked-by: Samuel Ghinet --- datapath-windows/ovsext/Datapath.c | 66 ++-- 1 files changed, 40 insertions(+), 26 deletions(-) diff --git a/datapath-windows/ovsext/Datapath.c b/datapath-windows

[ovs-dev] [PATCH 6/9 v2] datapath-windows: Check for device operation in OvsGetDpCmdHandler

A review comment was that we should check for device operation rather than whether the dump context while deciding if the operation is a dump start or a dump continue. Signed-off-by: Nithin Raju Acked-by: Ankur Sharma Acked-by: Samuel Ghinet --- datapath-windows/ovsext/Datapath.c | 18

[ovs-dev] [PATCH 3/9 v2] datapath-windows: add a context structure for user parameters

keeps the code clean, IMO. Signed-off-by: Nithin Raju Acked-by: Ankur Sharma Acked-by: Samuel Ghinet --- datapath-windows/ovsext/Datapath.c | 72 ++- datapath-windows/ovsext/Datapath.h | 37 ++ 2 files changed, 58 insertions(+), 51 deletions

[ovs-dev] [PATCH 4/9 v2] datapath-windows: add support for GET_DP command to dump datpaths

: - With a hacked up dpif-linux.c to work on Windows, dpif_linux_enumerate() successfully enumerated the datapaths in the kernel. Signed-off-by: Nithin Raju Acked-by: Ankur Sharma Acked-by: Samuel Ghinet --- datapath-windows/ovsext/Datapath.c | 220 ++-- 1 files

[ovs-dev] [PATCH 7/9 v2] datapath-windows: add clarifications to markers in dump state

Signed-off-by: Nithin Raju Acked-by: Ankur Sharma Acked-by: Samuel Ghinet --- datapath-windows/ovsext/Datapath.h | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/datapath-windows/ovsext/Datapath.h b/datapath-windows/ovsext/Datapath.h index d0b6d19..8d69f09

[ovs-dev] [PATCH 5/9 v2] datapath-windows: add description to members of OVS_USER_PARAMS_CONTEXT

Signed-off-by: Nithin Raju Acked-by: Ankur Sharma Acked-by: Samuel Ghinet --- datapath-windows/ovsext/Datapath.h | 17 + 1 files changed, 9 insertions(+), 8 deletions(-) diff --git a/datapath-windows/ovsext/Datapath.h b/datapath-windows/ovsext/Datapath.h index e796e8c

Re: [ovs-dev] [PATCH] Create a NBL for each NB when required

hi Sam/Alin, Thanks for working on this. In general, it would have been better if the two changes: 1. handle NBL with multiple NBs 2. Optimizing the parsing code to handle NBs rather than NBLs. could have been split into different review. I was not a big fan of split up changes into multiple rev

Re: [ovs-dev] [PATCH] Create a NBL for each NB when required

hi Sam/Alin, Thanks for working on this. In general, it would have been better if the two changes: 1. handle NBL with multiple NBs 2. Optimizing the parsing code to handle NBs rather than NBLs. could have been split into different review. I was not a big fan of split up changes into multiple rev

Re: [ovs-dev] [PATCH] Create a NBL for each NB when required

hi Sam, Pls. find my answers inlined. Pls. feel free to repost the patches for the two different functionalities. On Sep 6, 2014, at 2:39 PM, Samuel Ghinet wrote: > Yes, you were right with the TSO. I'll send a new version of the patch, > though I am not sure how it would be easier for you to

[ovs-dev] [PATCH] datapath-windows: update CodingStyle guideline for variable names

During a review, it seemed that some of the conventions were not clear. Fixing them in this patch. Signed-off-by: Nithin Raju --- datapath-windows/CodingStyle | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/datapath-windows/CodingStyle b/datapath-windows

[ovs-dev] [PATCH v2] datapath-windows: update CodingStyle guideline for variable names

During a review, it seemed that some of the conventions were not clear. Fixing them in this patch. Signed-off-by: Nithin Raju Reported-by: Samuel Ghinet --- datapath-windows/CodingStyle | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/datapath-windows

Re: [ovs-dev] [PATCH] Create a NBL for each NB when required

On Aug 29, 2014, at 1:20 PM, Saurabh Shah wrote: >> Generally, we have not used '_' prefix for function parameter names. We >> use them for macros etc, but not for functions. Do you prefer it this way? I >> am not against it, but I don't think it is necessary. For a macro, it is >> necessary >>

Re: [ovs-dev] [PATCH 9/9 v2] datapath-windows: refactor code to setup dump start state

tor). > > c) If, later in the future, some refactor code or documentation is added, > such a thing can go very well with "review comment in another patch" > aforementioned. > > Regards, > Sam > > > From: Ankur Sharma [ankursha...@vmware.com] > Se

[ovs-dev] datapath-windows: refactor code to setup dump start state (Was: Re: [PATCH 9/9 v3] datapath-windows: refactor code to setup dump start state)

an be leveraged by dump functions in the > future. I have not refactored the code that continues the dump > operation primarily since it is not final yet. Once the netlink set > APIs are in place, we can refactor that too. > > Signed-off-by: Nithin Raju > Signed-of

[ovs-dev] [PATCH] datapath-windows: refactor code to setup dump start state

refactor that too. Signed-off-by: Nithin Raju Acked-by: Ankur Sharma Acked-by: Samuel Ghinet --- datapath-windows/ovsext/Datapath.c | 66 ++-- 1 files changed, 40 insertions(+), 26 deletions(-) diff --git a/datapath-windows/ovsext/Datapath.c b/datapath-windows

Re: [ovs-dev] netlink-socket.c: add support for do_lookup_genl_family on Windows

On Sep 9, 2014, at 1:09 PM, Gurucharan Shetty wrote: > Gives an "uninitialized local variable 'sock' used". Can you take care > of it in an upcoming patch? Sure. Thanks for point this out. -- Nithin ___ dev mailing list dev@openvswitch.org http://ope

[ovs-dev] [PATCH] netlink-socket.c: remove local variable in do_lookup_genl_family

'sock' is not initialized and hence should not be un-initialized as well in the failure path. Signed-off-by: Nithin Raju Reported-by: Gurucharan Shetty --- lib/netlink-socket.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/lib/netlink-socket.c b/lib/netlin

Re: [ovs-dev] [PATCH] Create a NBL for each NB when required

ggers the completion of the original NBL that came from NDIS. The >> existing code is correct in that sense. If you see any discrepancy, please >> feel free to point > it out. We'll fix it. > So, technically, in the NDIS Send callback, I should call at every exit point > OvsComp

Re: [ovs-dev] [PATCH v4] Windows NetLink Socket - Support for asynchronous event notification

This is already committed, but LG to me as well. Will look forward to the kernel implementation. Only comment I had was w.r.t alignment in the following code: > +int ovs_msg_size = sizeof (struct nlmsghdr) + sizeof (struct genlmsghdr) > + > + sizeof (struct ovs

Re: [ovs-dev] [PATCH] Netlink_socket.c Join/Unjoin an MC group for event subscription

Eitan, Thanks for doing this. I had some minor comments. LG otherwise. Acked-by: Nithin Raju > +OVS_NL_ATTR_MCAST_JOIN, /*1/0 - Join/Unjoin */ minor: need a space before '1/0'. > +nl_msg_put_genlmsghdr(&request, 0, OVS_WIN_

Re: [ovs-dev] [PATCH] Netlink_socket.c Join/Unjoin an MC group for event subscription

On Sep 10, 2014, at 12:40 PM, Eitan Eliahu wrote: > Nithin, I can't align it since if aligned this line will go over the 80 > character limit. You could do one of these two options. Either way is fine: a) +nl_msg_put_genlmsghdr(&request, 0, OVS_WIN_NL_CTRL_FAMILY_ID, 0, +

[ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

Signed-off-by: Nithin Raju --- datapath-windows/ovsext/Datapath.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/datapath-windows/ovsext/Datapath.c b/datapath-windows/ovsext/Datapath.c index c145d00..d1f4b9d 100644 --- a/datapath-windows/ovsext/Datapath.c +++ b

Re: [ovs-dev] [PATCH v1 2/2] datapath-windows/Netlink: Nested attributes put/parse.

hi Ankur, I had minor comments, but LG otherwise. Acked-by: Nithin Raju > +VOID > +NlMsgPutNested(PNL_BUFFER buf, UINT16 type, > + const PVOID data, UINT32 size) > +{ > +UINT32 offset = NlMsgStartNested(buf, type); > + > +UNREFE

Re: [ovs-dev] [PATCH v1 1/2] datapath-windows/NetlinkBuf.h: Added NlBufSize

> Added an inline function to return used size in the buffer. > > Signed-off-by: Ankur Sharma Acked-by: Nithin Raju Thanks, -- Nithin ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] datapath-windows: adding vport from userspace to kernel

hi Sam/Alin, This is a followup to the discussion we had over IRC this morning about adding vports. The question was about what should happen in the kernel if userspace tries to add a VIF port that is not existent on the hyper-v switch. Should we support it? In general, you cannot add a vport t

Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

On Sep 10, 2014, at 4:15 PM, Samuel Ghinet wrote: > Hey Nithin, > > AFAIK OvsCleanupOpenInstance is called by OvsCleanupDevice, which is a > callback called by NDIS when an IO is pending and the file must be closed. > FreeUserDumpState is only for dump operations. > > Is it possible that an I

Re: [ovs-dev] [PATCH] datapath-windows: Handle NBLs with multiple NBs

hi Sam, Thanks for the updating the patch to make it specific to "handle NBLs with multiple NBs". In general it looks good. There are a few bugs w.r.t NBL completion that I have highlighted. More than that I was a little concerned about the changes in OvsTunnelTx to split a TSOed NBL (with mul

Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

ket or file handle is > used for event notifications and for packet read. > I hope I answered your question. > Eitan > > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Samuel Ghinet > Sent: Wednesday, September 10, 2014 4:15 PM > To:

Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

On Sep 12, 2014, at 12:46 PM, Eitan Eliahu mailto:elia...@vmware.com>> wrote: Sorry for coming late on this one. We should free the dump state when the system calls the driver on cleanup as you did. But, the cleanup IOCTL can be (actually will be) executed from a different thread context. This

[ovs-dev] [PATCH 1/2] datapath-windows: fix bug in NlBufCopyAtTailUninit

We should be returning value of tail before the increment and not after. Signed-off-by: Nithin Raju --- datapath-windows/ovsext/Netlink/NetlinkBuf.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/datapath-windows/ovsext/Netlink/NetlinkBuf.c b/datapath-windows

[ovs-dev] [PATCH 2/2] datapath-windows: use the Netlink set API and need new APIs

In this change: 1. we refactor the code that fills up information about the DP into a seprate function. 2. use the netlink set APIs to fill up the netlink attributes. Signed-off-by: Nithin Raju --- datapath-windows/ovsext/Datapath.c | 123 +++- 1 files changed

Re: [ovs-dev] [PATCH 2/2] datapath-windows: use the Netlink set API and need new APIs

On Sep 14, 2014, at 8:36 PM, Samuel Ghinet wrote: > Hello Nithin, > > Overall, it looks ok. > > Very minor things, though: > (OvsDpFillInfo) > o) could you please rename nlWrite into something more boolean-like, like > "ok" or whatever you prefer? > When I first read that piece of code, I wa

Re: [ovs-dev] [PATCH 1/2] datapath-windows: fix bug in NlBufCopyAtTailUninit

On Sep 14, 2014, at 8:18 PM, Samuel Ghinet wrote: > At first on reading this code, I was wondering "why?" > Now I think I understand: the function zeroes memory, and must return the ptr > to 'next' item to be filled (which is called "tail"). Am I correct? Yes, that is the bug. The pointer ret

Re: [ovs-dev] datapath-windows: adding vport from userspace to kernel

On Sep 14, 2014, at 7:34 PM, Samuel Ghinet wrote: > This netdev check on windows, I understand, would translate to a km-um / > netlink communication by which it will be checked if the hyper-v switch does > have a port with friendly name X. > The only thing that remains is to be sure that when

Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

On Sep 14, 2014, at 7:38 PM, Samuel Ghinet wrote: > I meant in the sense, if it is necessary. AFAIK, the IO pending can only > happen in non-dump operations (and here, non-dump netlink pids). > Therefore, I don't know if it is really useful to FreeDumpState in a pending > IO cancel callback f

Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

On Sep 14, 2014, at 8:03 PM, Samuel Ghinet mailto:sghi...@cloudbasesolutions.com>> wrote: I have a question here, is a file HANDLE normally used by only one userspace thread at a time (so that if you have multiple threads, each thread will have its own unique file HANDLEs), or each thread may

[ovs-dev] [PATCH 1/2 v2] datapath-windows: fix bug in NlBufCopyAtTailUninit

We should be returning value of tail before the increment and not after. Signed-off-by: Nithin Raju Acked-by: Ankur Sharma --- datapath-windows/ovsext/Netlink/NetlinkBuf.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/datapath-windows/ovsext/Netlink

[ovs-dev] [PATCH 2/2 v2] datapath-windows: use the Netlink set API and need new APIs

s. Signed-off-by: Nithin Raju --- datapath-windows/include/OvsDpInterfaceExt.h |2 + datapath-windows/ovsext/Datapath.c | 124 ++ 2 files changed, 68 insertions(+), 58 deletions(-) diff --git a/datapath-windows/include/OvsDpInterfaceExt.h b/datapath-windo

[ovs-dev] [PATCH 2/2 v3] datapath-windows: use the Netlink set API and need new APIs

ons. 4. In the absence of netlink set API, I had put in an ASSERT earlier that the output buffer should be limited to 512 bytes. This is not true anymore. The netlink set API checks for bounds of the buffer. Hence removed the ASSERT. Signed-off-by: Nithin Raju --- datapath-windows/include/OvsDpInte

[ovs-dev] [PATCH 1/2 v3] datapath-windows: fix bug in NlBufCopyAtTailUninit

We should be returning value of tail before the increment and not after. Signed-off-by: Nithin Raju Acked-by: Ankur Sharma --- datapath-windows/ovsext/Netlink/NetlinkBuf.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/datapath-windows/ovsext/Netlink

Re: [ovs-dev] [PATCH v1 1/3] datapath-windows/Netlink: Added support for variable length attributes in validation.

On Sep 15, 2014, at 5:51 PM, Ankur Sharma wrote: > Added minor fix for allowing support for variable lenghth attributes in > parsing policy. > > Signed-off-by: Ankur Sharma Acked-by: Nithin Raju ___ dev mailing list dev@openvswi

Re: [ovs-dev] [PATCH v1 3/3] datapath-windows/Netlink: Add optional flag in policy.

On Sep 15, 2014, at 5:51 PM, Ankur Sharma wrote: > Added the optional flag in policy structure. This would allow > caller to avoid checks for mandatory attributes if parsing > succeeds. Missing Signed-off-by, and also I don't see the 2/3 patch. Thanks, -- Nithin _

Re: [ovs-dev] [PATCH v1 2/3] datapath-windows: Add support for getting 64 and 16 bit attributes.

: Ankur Sharma Thanks for sending this mail directly to me. Assuming this was seen on the ML: Acked-by: Nithin Raju -- Nithin ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH 1/5 v1] datapath-windows: return TRUE on success in NlAttrValidate

Signed-off-by: Nithin Raju --- datapath-windows/ovsext/Netlink/Netlink.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/datapath-windows/ovsext/Netlink/Netlink.c b/datapath-windows/ovsext/Netlink/Netlink.c index 5faf07f..f6ee4c4 100644 --- a/datapath-windows/ovsext

[ovs-dev] [PATCH 4/5 v1] extract-odp-netlink-windows-dp-h: add definition of IFNAMSIZ

The Windows kernel datapath needs the definition of 'IFNAMSIZ' for specifying attribute sizes in netlink policies. Adding the definition of 'IFNAMSIZ' to be part of OvsDpInterface.h similar to ETH_ADDR_LEN. Signed-off-by: Nithin Raju --- build-aux/extract-odp-netlink-window

[ovs-dev] [PATCH 2/5 v1] datapath-windows: add OvsComareString() to compare strings

Turns out that there's no convenient equivalent of strncmp() in the Windows kernel. RtlEqualString() works on STRING * pointers which are different from the CHAR * pointers. In this patch, we add support for such a function for comparing strings. Signed-off-by: Nithin Raju --- datapath-wi

[ovs-dev] [PATCH 5/5 v1] datapath-windows: add OVS_DP_CMD_SET and OVS_DP_CMD_GET transaction support

flows: 0 - I got so far as to hit the PORT_DUMP command which is currently not implemented. Signed-off-by: Nithin Raju Tested-by: Nithin Raju Reported-at: https://github.com/openvswitch/ovs-issues/issues/38 --- datapath-windows/ovsext/Datapath.c | 151

[ovs-dev] [PATCH 3/5 v1] lib/netlink-socket.c: add support for nl_transact() on Windows

cases and error coditions similar to Linux. Some of it is not applicable yet. Eg. the Windows kernel does not send embed an error in the netlink message itself. There's userspace code nevertheless for this. Signed-off-by: Nithin Raju --- lib/netlink-socket.c |

[ovs-dev] OVS-on-Hyper-v: items to discuss for 9/16 IRC meeting

hi Sam/Alin, These were the items we wanted to bring up from our side: 1. statuses: DP commands, VPORT commands, Flow commands, Event commands 2. dpif-linux.c porting to Windows 3. netdev for windows 4. Pending reviews Pls. feel free to add any new items. Thanks, -- Nithin __

Re: [ovs-dev] [PATCH 2/5 v1] datapath-windows: add OvsComareString() to compare strings

On Sep 17, 2014, at 6:16 AM, Samuel Ghinet wrote: > I don't think there's a need to implement such a function. > You can use memcmp, which behaves quite like strncmp. hi Samuel, Thanks for the pointer. I was trying to use Rtl* functions, but if memcmp() works, that is great. I have a couple o

Re: [ovs-dev] [PATCH v3] datapath-windows: Add Connection Tracking Support

to Thanks for incorporating the review comments. Acked-by: Nithin Raju ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] datapath-windows: Refactor Conntrack Module in Hyper-V

Instead of using OvsConntrack*, it might be better to use OvsCt*. But, not a big deal. Acked-by: Nithin Raju -Original Message- From: dev on behalf of Sairam Venugopal Date: Thursday, April 14, 2016 at 12:07 PM To: "dev@openvswitch.org" Subject: [ovs-dev] [PATCH] datapa

Re: [ovs-dev] [PATCH] datapath-windows: Add ICMP types in NetProto.h

r to >keep it consistent with KVM. Add UDP and ICMP min length definitions. > >Signed-off-by: Sairam Venugopal Acked-by: Nithin Raju ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] datapath-windows: remove OvsAllocateForwardingContextForNBL

dead code. Signed-off-by: Nithin Raju --- datapath-windows/ovsext/User.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/datapath-windows/ovsext/User.c b/datapath-windows/ovsext/User.c index 04d2294..d2ff236 100644 --- a/datapath-windows/ovsext/User.c +++ b/datapath-windows

Re: [ovs-dev] [PATCH 2/3] datapath-windows: Removed double initialization on local variables

up. Acked-by: Nithin Raju ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 3/3] datapath-windows: Removed always true condition in VXLAN

Paul, If you are sure that tunKey->tunnelId will always be set, it would be a good idea to mark .optional as FALSE in definition of nlFlowTunnelKeyPolicy. -- Nithin -Original Message- From: dev on behalf of Paul Boca Date: Friday, April 15, 2016 at 8:04 AM To: "dev@openvswitch.org" Sub

Re: [ovs-dev] [PATCH 3/3] datapath-windows: Removed always true condition in VXLAN

-Original Message- From: Jesse Gross Date: Friday, April 15, 2016 at 10:40 AM To: Nithin Raju Cc: Paul Boca , "dev@openvswitch.org" Subject: Re: [ovs-dev] [PATCH 3/3] datapath-windows: Removed always true condition in VXLAN >On Fri, Apr 15, 2016 at 10:27 AM, Nithin Raju w

Re: [ovs-dev] [PATCH] datapath-windows: Fixed buffer overflow in OvsInitVportWithNicParam

Why do we need ethernet address to be macAddress to be 32 bytes? We should just make sure that when we copy, we use sizeof () and in this case, it is sizeof (vport->macAddress). -- Nithin -Original Message- From: dev on behalf of Paul Boca Date: Monday, April 18, 2016 at 12:52 AM To: "

Re: [ovs-dev] [PATCH] datapath-windows: Add paranthesis to fix error C2275

Acked-by: Nithin Raju -Original Message- From: dev on behalf of Sairam Venugopal Date: Thursday, April 21, 2016 at 10:44 PM To: "dev@openvswitch.org" Subject: [ovs-dev] [PATCH] datapath-windows: Add paranthesis to fix error C2275 >Add braces around the if conditi

Re: [ovs-dev] [PATCH] datapath-windows: Fixed buffer overflow in OvsInitVportWithNicParam

Thanks for digging this up. -Original Message- From: Paul Boca Date: Thursday, April 21, 2016 at 11:58 PM To: Nithin Raju , "dev@openvswitch.org" Subject: RE: [ovs-dev] [PATCH] datapath-windows: Fixed buffer overflow in OvsInitVportWithNicParam >Thanks for review! &g

Re: [ovs-dev] [PATCH V2] datapath-windows: Fixed buffer overflow in OvsInitVportWithNicParam

->permMacAddress is 6 >bytes > >Signed-off-by: Paul-Daniel Boca Acked-by: Nithin Raju ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2] datapath-windows: Pause switch state on PnP event

Acked-by: Nithin Raju -Original Message- From: dev on behalf of Sairam Venugopal Date: Monday, April 25, 2016 at 2:38 PM To: Alin Serdean , "dev@openvswitch.org" Subject: Re: [ovs-dev] [PATCH v2] datapath-windows: Pause switch state on PnP event >Thanks for incorporati

Re: [ovs-dev] [PATCH] datapath-windows: Fix recirculation when it is not the last attribute

Thans for the fix. Acked-by: Nithin Raju -Original Message- From: dev on behalf of Sairam Venugopal Date: Tuesday, April 26, 2016 at 4:53 PM To: "dev@openvswitch.org" Subject: [ovs-dev] [PATCH] datapath-windows: Fix recirculation when it is not the last attribute

Re: [ovs-dev] [PATCH v2] datapath-windows: Add support for UDP and ICMP to Conntrack Module

I'm also in the process of reviewing this. I'll send out my comments soon. Sent from Outlook Mobile On Mon, May 9, 2016 at 1:09 AM -0700, "Paul Boca" mailto:pb...@cloudbasesolutions.com>> wrote: Acked-by: Paul-Daniel Boca > -Original Message- > From: dev [

[ovs-dev] [PATCH 1/3] datapath-windows: add nlMsgHdr to OvsPacketExecute

We'll need this for parsing nested attributes. Signed-off-by: Nithin Raju --- datapath-windows/ovsext/DpInternal.h | 1 + datapath-windows/ovsext/User.c | 13 - 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/datapath-windows/ovsext/DpInternal.h b/dat

[ovs-dev] [PATCH 3/3] datapath-windows: Use l2 port and tunkey during execute

attributes sent down from userspace. Signed-off-by: Nithin Raju --- datapath-windows/ovsext/User.c | 32 ++-- 1 file changed, 30 insertions(+), 2 deletions(-) diff --git a/datapath-windows/ovsext/User.c b/datapath-windows/ovsext/User.c index 3b3f662..2312940 100644 --- a

[ovs-dev] [PATCH 2/3] datapath-windows: Make _MapTunAttrToFlowPut() global

Move this function out from file scope. Signed-off-by: Nithin Raju --- datapath-windows/ovsext/Flow.c | 16 +++- datapath-windows/ovsext/Flow.h | 2 ++ 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c

[ovs-dev] [PATCH 1/4 v2] datapath-windows: add nlMsgHdr to OvsPacketExecute

We'll need this for parsing nested attributes. Signed-off-by: Nithin Raju --- datapath-windows/ovsext/DpInternal.h | 1 + datapath-windows/ovsext/User.c | 13 - 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/datapath-windows/ovsext/DpInternal.h b/dat

[ovs-dev] [PATCH 2/4 v2] datapath-windows: Make _MapTunAttrToFlowPut() global

Move this function out from file scope. Signed-off-by: Nithin Raju --- datapath-windows/ovsext/Flow.c | 16 +++- datapath-windows/ovsext/Flow.h | 2 ++ 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c

<    1   2   3   4   5   6   7   8   9   10   >