hi Ankur, I had minor comments, but LG otherwise. Acked-by: Nithin Raju <nit...@vmware.com>
> +VOID > +NlMsgPutNested(PNL_BUFFER buf, UINT16 type, > + const PVOID data, UINT32 size) > +{ > + UINT32 offset = NlMsgStartNested(buf, type); > + > + UNREFERENCED_PARAMETER(data); > + UNREFERENCED_PARAMETER(size); > + > + ASSERT(offset); > + > + ASSERT(NlMsgPutTail(buf, data, size)); > + > + NlMsgEndNested(buf, offset); > + > + return; > +} minor: return is not necessary for a VOID function. Also, it might be better to pack the code and get rid of the extra new lines. Eg. you can group the ASSERTs(). Thanks, -- Nithin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev