On Aug 29, 2014, at 1:20 PM, Saurabh Shah <ssaur...@vmware.com> wrote:
>> Generally, we have not used '_' prefix for function parameter names. We >> use them for macros etc, but not for functions. Do you prefer it this way? I >> am not against it, but I don't think it is necessary. For a macro, it is >> necessary >> to avoid conflicts in variable names. > > Hey Nithin, > I had the same comment but realized that this was an existing code, so I > thought we can clean in up later. But, if Alin/Samuel are ok making the > change now, that would be great too. > > Saurabh hi Saurabh, I agree this is existing code, and I have indicated the same later in the review. I'm quoting my comments here: > -const VOID* OvsGetPacketBytes(const NET_BUFFER_LIST *_pNB, UINT32 len, > +const VOID* OvsGetPacketBytes(const NET_BUFFER *_pNB, UINT32 len, '_' is not necessary maybe. I see that the existing code did it as well :) So, not to blame you :) thanks, Nithin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
