We should be returning value of tail before the increment
and not after.

Signed-off-by: Nithin Raju <[email protected]>
Acked-by: Ankur Sharma <[email protected]>
---
 datapath-windows/ovsext/Netlink/NetlinkBuf.c |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/datapath-windows/ovsext/Netlink/NetlinkBuf.c 
b/datapath-windows/ovsext/Netlink/NetlinkBuf.c
index ba10d83..918bddd 100644
--- a/datapath-windows/ovsext/Netlink/NetlinkBuf.c
+++ b/datapath-windows/ovsext/Netlink/NetlinkBuf.c
@@ -213,15 +213,13 @@ done:
 PCHAR
 NlBufCopyAtTailUninit(PNL_BUFFER nlBuf, UINT32 len)
 {
-    PCHAR ret = NULL;
+    PCHAR ret;
 
+    ret = nlBuf->tail;
     if ((NlBufCopyAtTail(nlBuf, NULL, len)) == FALSE) {
-        goto done;
+        ret = NULL;
     }
 
-    ret = nlBuf->tail;
-
-done:
     return ret;
 }
 
-- 
1.7.4.1

_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to