On Tue, Sep 1, 2015 at 7:14 PM, Pravin Shelar wrote:
> On Tue, Sep 1, 2015 at 4:56 PM, Ben Pfaff wrote:
>> I think I've come across a bug in OVS native tunneling, or at any rate
>> an important difference between Linux kernel and OVS native tunneling.
>> In Linux kernel tunneling, a tunnel packet
On Wed, Sep 2, 2015 at 6:44 AM, Jesse Gross wrote:
> On Tue, Sep 1, 2015 at 7:14 PM, Pravin Shelar wrote:
>> On Tue, Sep 1, 2015 at 4:56 PM, Ben Pfaff wrote:
>>> I think I've come across a bug in OVS native tunneling, or at any rate
>>> an important differe
On Wed, Sep 2, 2015 at 3:40 PM, Jason Kölker wrote:
> `csum_ipv6_magic` is an asm inline on most platforms. However if it is
> not defined (like on ppc64le) including will fall
> back to the c implementation by wrapping it in an
> `#ifndef _HAVE_ARCH_IPV6_CSUM`.
>
> Signed-off-by: Jason Kölker
On Thu, Sep 3, 2015 at 6:53 AM, Anoob Soman wrote:
> Check if ethtool flags is already set on a netdev, before trying to set it.
>
> This patch works around issues with some older verison of ethernet drivers,
> which tend to reset the NIC when call to disable LRO is made, even if LRO is
> already
On Tue, Sep 8, 2015 at 2:11 PM, Ben Pfaff wrote:
> On Mon, Aug 31, 2015 at 07:57:06PM -0700, Jesse Gross wrote:
>> In cases where we don't have a map of tunnel metadata options (such
>> as with ovs-ofctl) we dynamically allocate them as part of the match.
>> However, dyn
On Tue, Sep 8, 2015 at 1:54 PM, Ben Pfaff wrote:
> On Mon, Aug 31, 2015 at 07:57:05PM -0700, Jesse Gross wrote:
>> It is supposed to be possible to allow ovs-ofctl to filter flows
>> it is monitoring based on a match string. However, the parser will
>> reject expressions
On Tue, Sep 8, 2015 at 1:48 PM, Ben Pfaff wrote:
> On Mon, Aug 31, 2015 at 07:57:04PM -0700, Jesse Gross wrote:
>> Currently, each token in an OpenFlow match field is treated separately -
>> whether this is a name, a value, or a single identifier. However, this
>> means tha
On Wed, Sep 9, 2015 at 4:20 AM, Na Zhu wrote:
> Hi,
>
> The OVS 2.4 claims it supports DPDK tunneling, I am confused about how it
> support, because native OVS vxlan depends on linux kernel vxlan module, but
> OVS dpdk runs on user space, does OVS 2.4 include a user space vxlan module?
Yes.
> I
On Wed, Sep 9, 2015 at 6:05 PM, Na Zhu wrote:
> Hi Jesse,
>
> Thanks your reply.
> Is the user space vxlan module copy from the linux kernel vxlan module?
It's not a copy.
> The tunnel usage is the same to me if I upgrade ovs 2.3 to ovs 2.4, right?
Considering that DPDK tunneling is new in OVS
On Fri, Apr 18, 2014 at 2:50 AM, Andy Zhou wrote:
> Rename hash_bias to hash_basis to make it consistent with similar
> usages.
>
> Signed-off-by: Andy Zhou
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
http://openvswitch
On Fri, Apr 18, 2014 at 2:51 AM, Andy Zhou wrote:
> diff --git a/datapath/actions.c b/datapath/actions.c
> index 82cfd2d..87a8a40 100644
> --- a/datapath/actions.c
> +++ b/datapath/actions.c
> @@ -460,6 +460,20 @@ static int sample(struct datapath *dp, struct sk_buff
> *skb,
>
On Fri, Apr 18, 2014 at 10:39 AM, Andy Zhou wrote:
> On Fri, Apr 18, 2014 at 9:28 AM, Jesse Gross wrote:
>> I don't understand the other change about accepting a hash mask even
>> when there isn't a hash value. Can you explain this?
> It is not necessary now. I was
On Fri, Apr 18, 2014 at 2:51 AM, Andy Zhou wrote:
> diff --git a/datapath/actions.c b/datapath/actions.c
> index 87a8a40..fdcd576 100644
> --- a/datapath/actions.c
> +++ b/datapath/actions.c
> +static int execute_recirc(struct datapath *dp, struct sk_buff *skb,
> +c
ue. Value 0 indicates the hash
> + is not computed by the datpath. */
There's a typo in "datpath" but otherwise looks good.
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Sun, Apr 20, 2014 at 11:06 PM, Andy Zhou wrote:
> Recirculation implementation for Linux kernel data path.
>
> Signed-off-by: Andy Zhou
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Sun, Apr 20, 2014 at 2:19 AM, Rami Rosen wrote:
> This patch removes the new_vport() forward declaration in datapath.c
> as it is not needed.
>
> Signed-off-by: Rami Rosen
Applied.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mail
On Thu, Apr 24, 2014 at 8:38 AM, Thomas F Herbert
wrote:
> Hi,
>
> I think there is a problem with parsing out the OVS ATTRIBUTE nesting in the
> NL message in the datapath and I am having trouble finding the cause. I
> think the nl msg is built up wrong in the case of the vlan push action.
>
> I
as F Herbert
> wrote:
>> On 4/24/2014 1:47 PM, Jesse Gross wrote:
>>>
>>> On Thu, Apr 24, 2014 at 8:38 AM, Thomas F Herbert
>>> wrote:
>>>>
>>>> Hi,
>>>>
>>>> I think there is a problem with parsing out the OVS ATTR
On Thu, Apr 24, 2014 at 1:31 PM, Ben Pfaff wrote:
> diff --git a/INSTALL b/INSTALL
> index f43c65b..71ce963 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -164,10 +164,6 @@ Prerequisites section, follow the procedure below to
> build.
> To use a specific C compiler for compiling Open vSwitch use
and most likely involving some netlink
> changes. Since netlink message design is your forte, any suggestions?
>
> On Thu, Apr 24, 2014 at 2:22 PM, Jesse Gross wrote:
>> That's a good point, I didn't think about that. I wonder if there is a
>> way to avoid the error mess
On Thu, Apr 24, 2014 at 3:32 PM, Ben Pfaff wrote:
> On Thu, Apr 24, 2014 at 02:57:28PM -0700, Jesse Gross wrote:
>> I suppose the other possibility is to pass some kind of flag attribute
>> with messages indicating that this is a test probe and would silence
>> logging. E
On Thu, Apr 24, 2014 at 4:14 PM, Ben Pfaff wrote:
> On Thu, Apr 24, 2014 at 4:01 PM, Jesse Gross wrote:
>> On Thu, Apr 24, 2014 at 3:32 PM, Ben Pfaff wrote:
>>> On Thu, Apr 24, 2014 at 02:57:28PM -0700, Jesse Gross wrote:
>>>> I suppose the other possibilit
On Tue, Apr 22, 2014 at 2:08 PM, Pritesh Kothari
wrote:
> diff --git a/acinclude.m4 b/acinclude.m4
> index 4269620..06983cb 100644
> --- a/acinclude.m4
> +++ b/acinclude.m4
> @@ -244,6 +244,9 @@ AC_DEFUN([OVS_CHECK_LINUX_COMPAT], [
>OVS_GREP_IFELSE([$KSRC/include/linux/err.h], [ERR_CAST])
>
>
On Tue, Apr 22, 2014 at 2:08 PM, Pritesh Kothari
wrote:
> diff --git a/datapath/linux/compat/include/linux/skbuff.h
> b/datapath/linux/compat/include/linux/skbuff.h
> index b0d0190..f47ccfe 100644
> --- a/datapath/linux/compat/include/linux/skbuff.h
> +++ b/datapath/linux/compat/include/linux/skb
On Thu, Apr 24, 2014 at 4:30 PM, Jarno Rajahalme wrote:
>
> On Apr 24, 2014, at 3:32 PM, Ben Pfaff wrote:
>
>> On Thu, Apr 24, 2014 at 02:57:28PM -0700, Jesse Gross wrote:
>>> I suppose the other possibility is to pass some kind of flag attribute
>>> with messag
On Wed, Apr 16, 2014 at 12:18 PM, Lori Jakab wrote:
> On 4/16/14, 2:57 AM, Jesse Gross wrote:
>>
>> On Fri, Apr 11, 2014 at 4:30 AM, Lori Jakab wrote:
>>>
>>> On 4/11/14, 1:47 AM, Jesse Gross wrote:
>>>>
>>>> On Thu, Mar 20, 2014 at 4
On Fri, Apr 25, 2014 at 12:16 PM, Pritesh Kothari (pritkoth)
wrote:
> Hi Jesse,
>
>>>
>>> diff --git a/datapath/linux/compat/include/linux/etherdevice.h
>>> b/datapath/linux/compat/include/linux/etherdevice.h
>>> index 556729d..c6e8e92 100644
>>> --- a/datapath/linux/compat/include/linux/etherdev
cted key attributes once? We can
> use a u64 bit fields to keep track the flow key attributes in the
> kernel module.
>
> On Thu, Apr 24, 2014 at 6:30 PM, Jesse Gross wrote:
>> On Thu, Apr 24, 2014 at 4:30 PM, Jarno Rajahalme
>> wrote:
>>>
>>> On Apr 2
On Fri, Apr 25, 2014 at 1:06 AM, YAMAMOTO Takashi
wrote:
>> On Thu, Apr 24, 2014 at 05:57:29PM +0900, YAMAMOTO Takashi wrote:
>>> hi,
>>>
>>> > + * Due to the sample action there may be multiple possible eth types.
>>> > + * In order to correctly validate actions all possible types are tracked
>>>
On Thu, Apr 17, 2014 at 2:54 AM, wrote:
> Hi Lori, all,
>
> While I've attempted to adapt the layer 3 port patch to GRE tunneling,
> and obtained nice results for IP-over-GRE (as I reported last week),
> I've had a harder time reusing this framework for -over-GRE, in
> particular for MPLS-over-GR
t;
> Signed-off-by: Jarno Rajahalme
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, Apr 11, 2014 at 4:29 PM, Jarno Rajahalme wrote:
> Key attributes relating to actual packet headers are ignored for
> OVS_PACKET_CMD_EXECUTE as the header key attributes are retrieved
> from the packet itself.
>
> Signed-off-by: Jarno Rajahalme
Acked-
On Sun, Apr 27, 2014 at 7:07 PM, Joe Stringer wrote:
> This was causing build failures on debian wheezy. Check for the feature
> rather than the version.
>
> Signed-off-by: Joe Stringer
Acked-by: Jesse Gross
___
dev mailing list
dev@ope
On Mon, Apr 28, 2014 at 12:00 AM, Simon Horman wrote:
> On Fri, Apr 25, 2014 at 12:57:20PM -0700, Jesse Gross wrote:
>> On Fri, Apr 25, 2014 at 1:06 AM, YAMAMOTO Takashi
>> wrote:
>> >> On Thu, Apr 24, 2014 at 05:57:29PM +0900, YAMAMOTO Takashi wrote:
>> >&
On Mon, Apr 28, 2014 at 5:13 PM, Simon Horman wrote:
> On Mon, Apr 28, 2014 at 02:37:47PM -0700, Jesse Gross wrote:
>> On Mon, Apr 28, 2014 at 12:00 AM, Simon Horman wrote:
>> > On Fri, Apr 25, 2014 at 12:57:20PM -0700, Jesse Gross wrote:
>> >> On Fri, Apr 25, 201
f
> Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Apr 29, 2014 at 3:24 PM, Pritesh Kothari
wrote:
> diff --git a/datapath/linux/compat/include/linux/skbuff.h
> b/datapath/linux/compat/include/linux/skbuff.h
> index 714c955..de9b29d 100644
> --- a/datapath/linux/compat/include/linux/skbuff.h
> +++ b/datapath/linux/compat/include/linux/skb
On Tue, Apr 29, 2014 at 10:58 PM, Simon Horman wrote:
> On Tue, Apr 29, 2014 at 11:41:57AM -0700, Jesse Gross wrote:
>> On Mon, Apr 28, 2014 at 5:13 PM, Simon Horman wrote:
>> > On Mon, Apr 28, 2014 at 02:37:47PM -0700, Jesse Gross wrote:
>> >> On Mon, Apr 28,
On Fri, Apr 25, 2014 at 1:52 PM, wrote:
> Hi Jesse,
>
> 2014-04-25, Jesse Gross:
>>> Practically speaking, making your layer 3 port code work for
>>> MPLS-over-GRE is not entirely trivial:
>>> - on emission, compose_output_action__ pops the Ethernet header b
On Thu, May 1, 2014 at 2:00 AM, Suresh Kumar Reddy Reddygari
wrote:
> Hi,
>
> Is MacVTap support there in OVS. If not, is there any plan to support it.
No.
What are you trying to do?
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailm
On Thu, May 1, 2014 at 1:54 AM, Simon Horman wrote:
> On Wed, Apr 30, 2014 at 03:56:44PM -0700, Jesse Gross wrote:
>> On Tue, Apr 29, 2014 at 10:58 PM, Simon Horman wrote:
>> > On Tue, Apr 29, 2014 at 11:41:57AM -0700, Jesse Gross wrote:
>> >> On Mon, Apr 28, 2014 a
pr_warn("%s: flow looped detected, dropping\n",
> + ovs_dp_name(dp));
I think the message should read "flow loop detected" i.e. present
tense but otherwise this looks good to me.
Acked-by: Jesse Gross
___
On Thu, May 1, 2014 at 3:50 PM, Pritesh Kothari
wrote:
> Signed-off-by: Pritesh Kothari
> ---
> v7: change a specific version to HAVE_RXHASH,
> fix skb_clear_hash to include l4_rxhash.
> v6: rebase for changes in datapath/datapath.c
> v5: move skb_clear_rxhash() from compat.h to skbuff.h,
>
On Fri, May 2, 2014 at 3:04 AM, Suresh Kumar Reddy Reddygari
wrote:
>
>
>> -Original Message-----
>> From: Jesse Gross [mailto:je...@nicira.com]
>> Sent: Thursday, May 01, 2014 10:07 PM
>> To: Suresh Kumar Reddy Reddygari
>> Cc: dev@openvswitch.org
>>
On Thu, May 8, 2014 at 3:04 AM, balaj...@freescale.com
wrote:
> Hi Jesse,
>
> IMHO, MacVTap support in OVS will give a performance boost for the VM traffic.
Why?
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Thu, May 8, 2014 at 1:54 AM, Suresh Kumar Reddy Reddygari
wrote:
>
>
>> -Original Message-----
>> From: Jesse Gross [mailto:je...@nicira.com]
>> Sent: Friday, May 02, 2014 11:33 PM
>> To: Suresh Kumar Reddy Reddygari
>> Cc: dev@openvswitch.org
>>
On Fri, Apr 11, 2014 at 4:29 PM, Jarno Rajahalme wrote:
> Masked set action allows more megaflow wildcarding. Masked set action
> is now supported for all writeable key types, except for the tunnel
> key.
The logic for the tunnel restriction is that it is always cleared at
the start of the pipel
On Fri, Apr 25, 2014 at 2:55 AM, Lori Jakab wrote:
> On 4/25/14, 5:19 AM, Jesse Gross wrote:
>>>>>>>>>
>>>>>>>>> +noethernet:
>>>>>>>>> if (nla_put_be16(skb, OVS_KEY_ATTR_ETHERTYPE,
>>>>>
On Fri, Apr 25, 2014 at 4:56 AM, wrote:
> Hi Jesse,
>
> (inlined below)
>
> Jesse Gross :
>>>>>>>>>>>
>>>>>>>>>>> In general, I think it would be a good idea for the flow key to
>>>>>>>>>
On Sat, May 10, 2014 at 7:46 PM, Simon Horman wrote:
> It is my understanding that on error execute_recirc() does not free the
> skb passed to it.
>
> Assuming this is true then on error skb should always be freed
> if an error occurs in execute_recirc().
>
> And if recirc_skb differs from skb, be
On Sat, May 10, 2014 at 7:46 PM, Simon Horman wrote:
> diff --git a/datapath/actions.c b/datapath/actions.c
> index 56d..4dc7c3e 100644
> --- a/datapath/actions.c
> +++ b/datapath/actions.c
> @@ -456,8 +462,27 @@ static int sample(struct datapath *dp, struct sk_buff
> *skb,
>
On Mon, May 12, 2014 at 4:06 PM, Daniele Di Proietto
wrote:
> If I understand correctly, the new code frees the skb only if
> execute_recirc() _returns_ an error and this can happen only if
> ovs_flow_extract() returns an error, in which case recirc_skb only gets freed
> once, but maybe I’m wro
On Mon, May 12, 2014 at 10:46 PM, Simon Horman wrote:
> On Mon, May 12, 2014 at 04:32:29PM -0700, Daniele Di Proietto wrote:
>> You’re right, of course.
>>
>> Sorry I didn’t see it the first time.
>>
>> On May 12, 2014, at 4:28 PM, Jesse Gross wrote:
>&g
On Wed, May 14, 2014 at 5:05 PM, Simon Horman wrote:
> The sample action is rather generic, allowing arbitrary actions to be
> executed based on a probability. However its use, within the Open vSwitch
> code-base is limited: only a single user-space action is ever nested.
>
> A consequence of the
On Wed, May 14, 2014 at 6:59 PM, longguang.yue wrote:
> hi,all
> can ovs work with sr-iov?
No.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, May 14, 2014 at 5:39 PM, Simon Horman wrote:
> On Wed, May 14, 2014 at 05:22:21PM -0700, Jesse Gross wrote:
>> On Wed, May 14, 2014 at 5:05 PM, Simon Horman wrote:
>> > The sample action is rather generic, allowing arbitrary actions to be
>> > executed based on
On Thu, May 15, 2014 at 1:28 AM, wrote:
> Hi Jesse,
>
> (below)
>
> 2014-05-09, Jesse Gross:
>> On Fri, Apr 25, 2014 at 4:56 AM, wrote:
>>> Hi Jesse,
>>>
>>> (inlined below)
>>>
>>> Jesse Gross :
>>>>>>&
From: Daniele Di Proietto
This is necessary, since u64 is not unsigned long long
in all architectures: u64 could be also uint64_t.
Signed-off-by: Daniele Di Proietto
Signed-off-by: Jesse Gross
---
net/openvswitch/flow_netlink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
From: Joe Perches
Each use of pr__once has a per-site flag.
Some of the OVS_NLERR messages look as if seeing them
multiple times could be useful, so use net_ratelimit()
instead of pr_info_once.
Signed-off-by: Joe Perches
Signed-off-by: Jesse Gross
---
net/openvswitch/datapath.h | 8
From: Daniele Di Proietto
In few functions, const formal parameters are assigned or cast to
non-const.
These changes suppress warnings if compiled with -Wcast-qual.
Signed-off-by: Daniele Di Proietto
Signed-off-by: Jesse Gross
---
net/openvswitch/flow_netlink.c | 6 --
net/openvswitch
A set of OVS changes for net-next/3.16.
The major change here is a switch from per-CPU to per-NUMA flow
statistics. This improves scalability by reducing kernel overhead
in flow setup and maintenance.
The following changes since commit a188a54d11629bef2169052297e61f3767ca8ce5:
macvlan: simplif
From: Joe Perches
Add "openvswitch: " prefix to OVS_NLERR output
to match the other OVS_NLERR output of datapath.c
Signed-off-by: Joe Perches
Signed-off-by: Jesse Gross
---
net/openvswitch/flow_netlink.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/openvswitch/flow_n
From: Daniele Di Proietto
This function must cast a const value to a non const value.
By adding an uintptr_t cast the warning is suppressed.
To avoid the cast (proper solution) several function signatures
must be changed.
Signed-off-by: Daniele Di Proietto
Signed-off-by: Jesse Gross
---
net
initialize.
So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p,
NULL)
Signed-off-by: Monam Agarwal
Signed-off-by: Jesse Gross
---
net/openvswitch/vport-gre.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/openvswitch/vport-gre.c b/net/openvswitch
From: Jarno Rajahalme
We already extract the TCP flags for the key, might as well use that
for stats.
Signed-off-by: Jarno Rajahalme
Acked-by: Pravin B Shelar
Signed-off-by: Jesse Gross
---
net/openvswitch/flow.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git
From: Joe Perches
It's slightly smaller/faster for some architectures.
Signed-off-by: Joe Perches
Signed-off-by: Jesse Gross
---
net/openvswitch/actions.c | 4 ++--
net/openvswitch/flow.c | 16
net/openvswitch/flow_netlink.c | 12 ++--
3 files ch
From: Jarno Rajahalme
The 5-tuple optimization becomes unnecessary with a later per-NUMA
node stats patch. Remove it first to make the changes easier to
grasp.
Signed-off-by: Jarno Rajahalme
Signed-off-by: Jesse Gross
---
net/openvswitch/datapath.c | 11
net/openvswitch/flow.c
flow key instead
of the mask.
Signed-off-by: Jarno Rajahalme
Acked-by: Pravin B Shelar
Signed-off-by: Jesse Gross
---
net/openvswitch/flow_netlink.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c
in
Signed-off-by: Jesse Gross
---
net/openvswitch/vport.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/openvswitch/vport.h b/net/openvswitch/vport.h
index d7e50a1..3e12940 100644
--- a/net/openvswitch/vport.h
+++ b/net/openvswitch/vport.h
@@ -185,9 +185,9 @@ static inline
eliminates the need to pre-allocate stats instances that will not be
used, also relieving the stats reader from the burden of reading stats
that are never used.
Signed-off-by: Jarno Rajahalme
Acked-by: Pravin B Shelar
Signed-off-by: Jesse Gross
---
net/openvswitch/flow.c | 119
On Fri, May 16, 2014 at 1:48 AM, Simon Horman wrote:
> On Fri, May 16, 2014 at 08:07:07AM +0900, Simon Horman wrote:
>> Allow datapath to recognize and extract MPLS labels into flow keys
>> and execute actions which push, pop, and set labels on packets.
>
> [snip]
>
>> diff --git a/datapath/linux/
On Fri, May 16, 2014 at 2:48 PM, Thomas Graf wrote:
> On 05/16/14 at 02:29pm, Jesse Gross wrote:
>> On Fri, May 16, 2014 at 1:48 AM, Simon Horman wrote:
>> > On Fri, May 16, 2014 at 08:07:07AM +0900, Simon Horman wrote:
>> >> Allow datapath to recognize and extr
Pravin will be maintaining Open vSwitch going forward.
CC: Pravin Shelar
Signed-off-by: Jesse Gross
---
I'll continue to be very much involved (especially with the outstanding
patchsets). However, Pravin has been doing a significant amount of the
work involved in maintaining OVS alrea
On Fri, May 16, 2014 at 8:08 AM, wrote:
> 2014-05-16, Jesse Gross:
>> On Thu, May 15, 2014 at 1:28 AM, wrote:
>>> Hi Jesse,
>>>
>>> (below)
>>>
>>> 2014-05-09, Jesse Gross:
>>>> On Fri, Apr 25, 2014 at 4:56 AM, wrote:
&
I have some miscellaneous comments on things that I noticed, all of
which are pretty small. I will probably have a few more tomorrow but
my hope is that we can get this in soon.
On Thu, May 15, 2014 at 4:07 PM, Simon Horman wrote:
> diff --git a/datapath/actions.c b/datapath/actions.c
> index 603
On Tue, May 20, 2014 at 4:26 AM, Ajay Singh (HM0001261)
wrote:
> Hi,
>
>
>
> I have compiled and installed openvswitch-2.1.2 source code on Fedora
> machine version 3.11.10-301.fc20.x86_64. As I can see gre module is getting
> loaded but I need vxlan module to be loaded which is not coming.
OVS d
On Tue, May 20, 2014 at 3:41 AM, Simon Horman wrote:
> diff --git a/datapath/linux/compat/gso.h b/datapath/linux/compat/gso.h
> index b83a4c3..f459c18 100644
> --- a/datapath/linux/compat/gso.h
> +++ b/datapath/linux/compat/gso.h
> #ifdef NET_SKBUFF_DATA_USES_OFFSET
> -#define skb_inner_network_h
On Tue, May 20, 2014 at 4:31 PM, Simon Horman wrote:
> On Tue, May 20, 2014 at 12:54:32PM -0700, Jesse Gross wrote:
>> On Tue, May 20, 2014 at 3:41 AM, Simon Horman wrote:
>> > diff --git a/datapath/linux/compat/gso.h b/datapath/linux/compat/gso.h
>> > index b83a4c3
On Tue, May 13, 2014 at 7:02 AM, Lorand Jakab wrote:
> Implementation of the pop_eth and push_eth actions in the kernel, and
> layer 3 flow support.
>
> Signed-off-by: Lorand Jakab
Lori, can you take a look at the thread with Thomas Morin and see if
the outcome is reasonable to you? It seems lik
On Tue, May 20, 2014 at 3:48 AM, Simon Horman wrote:
> On Mon, May 19, 2014 at 06:34:05PM -0700, Jesse Gross wrote:
>> On Thu, May 15, 2014 at 4:07 PM, Simon Horman wrote:
>> > diff --git a/datapath/actions.c b/datapath/actions.c
>> > index 603c7cb..7c3ae0c 100644
&g
On Thu, May 15, 2014 at 4:07 PM, Simon Horman wrote:
> diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c
> index 9ded17c..d9b4485 100644
> --- a/datapath/linux/compat/gso.c
> +++ b/datapath/linux/compat/gso.c
> -#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,37)
> +#if LINUX_VERS
On Wed, May 21, 2014 at 8:15 AM, Anoob Soman wrote:
> Hi,
>
> I encountered softlockup (in stats_read@datapath/flow.c), while playing with
> OVS-2.1.2. I used change set 4f647e0a3c37b8d5086214128614a136064110c3 from
> linux-stable to fix the problem. I was wondering, if this changeset can be
> ap
On Wed, May 21, 2014 at 8:31 AM, Simon Horman wrote:
> On Tue, May 20, 2014 at 07:30:38PM -0700, Jesse Gross wrote:
>> On Thu, May 15, 2014 at 4:07 PM, Simon Horman wrote:
>> > diff --git a/datapath/linux/compat/include/linux/netdevice.h
>> > b/datapath/linux/compa
On Wednesday, May 21, 2014, Simon Horman wrote:
> On Wed, May 21, 2014 at 01:31:55PM -0700, Jesse Gross wrote:
> > On Wed, May 21, 2014 at 8:31 AM, Simon Horman
> > >
> wrote:
> > > On Tue, May 20, 2014 at 07:30:38PM -0700, Jesse Gross wrote:
> > >> On
On Tue, May 20, 2014 at 9:47 PM, Ajay Singh (HM0001261)
wrote:
> Hi Jesse,
>
> Can you suggest the correct version of Fedora on which I can install
> openvswitch and make use of VXLAN.
> It is a blocker for me. Please give me some pointer.
I see, you are using the upstream module. You can use th
Reported-by: Ben Pfaff
Signed-off-by: Jesse Gross
---
FAQ | 21 +
1 file changed, 21 insertions(+)
diff --git a/FAQ b/FAQ
index cac9fcb..79d905d 100644
--- a/FAQ
+++ b/FAQ
@@ -190,6 +190,27 @@ A: The kernel module in upstream Linux does not include
support for
Linux
On Tue, May 20, 2014 at 8:26 AM, Ben Pfaff wrote:
> On Tue, May 20, 2014 at 08:21:10AM -0700, Jesse Gross wrote:
>> On Tue, May 20, 2014 at 4:26 AM, Ajay Singh (HM0001261)
>> wrote:
>> > Hi,
>> >
>> >
>> >
>> > I have compiled and in
On Wed, May 21, 2014 at 5:38 AM, wrote:
> Hi Jesse,
>
> 2014-05-19, Jesse Gross:
> [...snip...]
>>>> I actually have much less of a problem with including an EtherType
>>>> from a GRE tunnel. For one thing it actually exists in the packet
>>>> ra
On Wed, May 21, 2014 at 9:00 PM, Ben Pfaff wrote:
> On Wed, May 21, 2014 at 07:06:05PM -0700, Jesse Gross wrote:
>> Reported-by: Ben Pfaff
>> Signed-off-by: Jesse Gross
>
> Thanks Jesse, I think that this will help. (At the very least it's easy
> to find and p
On Thu, May 22, 2014 at 11:34 AM, Ben Pfaff wrote:
> On Tue, May 13, 2014 at 05:02:14PM +0300, Lorand Jakab wrote:
>> These actions will allow L2->L3 and L3->L2 switching, and are supposed
>> to be added to flows installed in the datapath transparently by
>> ovs-vswitchd.
>>
>> Signed-off-by: Lora
On Thu, May 22, 2014 at 1:39 PM, Justin Pettit wrote:
> Connection Tracking
> ---
> The new connection tracking action is defined as follows:
>
> /* Action structure for NXAST_CONNTRACK.
> *
> * Pass traffic to the connection tracker. If 'flags' is NXACF_RESUBMIT,
>
On Thu, May 22, 2014 at 2:06 PM, Justin Pettit wrote:
> On May 22, 2014 at 1:58:28 PM, Jesse Gross (je...@nicira.com) wrote:
>> On Thu, May 22, 2014 at 1:39 PM, Justin Pettit wrote:
>
>> Is it possible to make the zone a register or accessible from a
>> register? I
On Tue, May 20, 2014 at 9:27 PM, Lori Jakab wrote:
> On 5/21/14, 4:10 AM, Jesse Gross wrote:
>>
>> On Tue, May 13, 2014 at 7:02 AM, Lorand Jakab wrote:
>>>
>>> Implementation of the pop_eth and push_eth actions in the kernel, and
>>> layer 3 flow su
We shouldn't restrict printf specifiers in kernel or third party
code.
Signed-off-by: Jesse Gross
---
Makefile.am | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index 0b59280..a98541f 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -209,7 +
On Fri, May 23, 2014 at 9:15 AM, Ben Pfaff wrote:
> On Fri, May 23, 2014 at 09:03:35AM -0700, Jesse Gross wrote:
>> We shouldn't restrict printf specifiers in kernel or third party
>> code.
>>
>> Signed-off-by: Jesse Gross
>
>
> case for most drivers). Thus Thus software segmentation was activated by
> skb_gso_ok().
>
> Thanks to Jesse Gross for prompting me to investigate this.
>
> Cc: Jesse Gross
> Signed-off-by: Simon Horman
Acked-by: Jesse Gross
__
On Wed, May 28, 2014 at 11:48 AM, Madhu Challa wrote:
> These come from dpif_flow_put() in check_max_mpls_depth() when adding a
> datapath. The key length is variable depending on number of MPLS labels. By
> initializing to -1 kmod will not check for the key length.
> Signed-off-by: Madhu Challa
ks.
>
>
> On Wed, May 28, 2014 at 5:08 PM, Jesse Gross wrote:
>>
>> On Wed, May 28, 2014 at 11:48 AM, Madhu Challa
>> wrote:
>> > These come from dpif_flow_put() in check_max_mpls_depth() when adding a
>> > datapath. The key length is variable dependi
On Mon, May 26, 2014 at 3:13 AM, wrote:
> 2014-05-22, Jesse Gross:
>>> 2014-05-19, Jesse Gross:
>>> - what about other link layers than ethernet that may have an ethertype
>>> ? (thinking Infiniband at least for IP and ARP payloads, ATM too,...)
>>
>>
On Mon, Jun 2, 2014 at 5:16 PM, Simon Horman wrote:
> On Mon, Jun 02, 2014 at 05:21:45PM +0100, Thomas Graf wrote:
>> On 06/02/14 at 01:43pm, Simon Horman wrote:
>> > +#ifdef CONFIG_NET_MPLS_GSO
>> > +static netdev_features_t net_mpls_features(struct sk_buff *skb,
>> > +
501 - 600 of 3414 matches
Mail list logo
