[ovs-dev] [PATCH 1/3] ofproto-dpif-upcall: Translate input port as part of upcall translation.

2016-06-09 Thread Jesse Gross
this stage. Signed-off-by: Jesse Gross --- ofproto/ofproto-dpif-upcall.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c index a18fc5a..9400ef9 100644 --- a/ofproto/ofproto-dpif-upcall.c +++ b/ofproto

Re: [ovs-dev] [PATCH v2 0/5] create tunnel devices using rtnetlink interface

2016-06-09 Thread Jesse Gross
On Wed, Jun 8, 2016 at 11:21 AM, Thadeu Lima de Souza Cascardo wrote: > This series adds support for the creation of tunnels using the rtnetlink > interface. This will open the possibility for new features and flags on those > vports without the need to change vport compatibility code. > > Support

Re: [ovs-dev] [PATCH v2 0/5] create tunnel devices using rtnetlink interface

2016-06-10 Thread Jesse Gross
On Fri, Jun 10, 2016 at 2:37 AM, Thadeu Lima de Souza Cascardo wrote: > On Thu, Jun 09, 2016 at 09:49:15PM -0700, Jesse Gross wrote: >> On Wed, Jun 8, 2016 at 11:21 AM, Thadeu Lima de Souza Cascardo >> wrote: >> > This series adds support for the creation of tun

Re: [ovs-dev] [PATCH v2 0/5] create tunnel devices using rtnetlink interface

2016-06-10 Thread Jesse Gross
On Fri, Jun 10, 2016 at 12:04 PM, Thadeu Lima de Souza Cascardo wrote: > On Fri, Jun 10, 2016 at 09:11:39AM -0700, Jesse Gross wrote: > [...] >> 2016-06-10T03:53:14.768Z|00034|dpif|WARN|system@ovs-system: failed to >> add tun0 as port: File exists >> [...] >> >

Re: [ovs-dev] [PATCH 1/3] ofproto-dpif-upcall: Translate input port as part of upcall translation.

2016-06-13 Thread Jesse Gross
On Mon, Jun 13, 2016 at 1:16 PM, Daniele Di Proietto wrote: > > 2016-06-09 17:46 GMT-07:00 Jesse Gross : >> >> When we generate wildcards for upcalled flows, the flows and therefore >> the wildcards, are in OpenFlow format. These are mostly the same but >> one except

Re: [ovs-dev] [PATCH 00/10] datapath: NAT backports

2016-06-13 Thread Jesse Gross
On Thu, Jun 9, 2016 at 3:45 PM, Jarno Rajahalme wrote: > This series adds the conntrack NAT integration upstreamed in Linux 4.6 > to the OVS tree kernel module. Main code is the same as upstream, > backports are provided for Linux kernels 3.10 - 4.3. Code compiles on > the latest release of each

Re: [ovs-dev] [RFC PATCH 02/14] Add NSH fields for Openvswitch flow key

2016-06-14 Thread Jesse Gross
On Tue, Jun 14, 2016 at 5:37 AM, Johnson Li wrote: > Openvswitch could use the fields of Network Serivce Header(NSH) > as key to steer traffic to the Virtual Network Functions(VNF). > > Signed-off-by: Johnson Li I only see patch 2/14. Are there supposed to be more? __

Re: [ovs-dev] [RFC PATCH 02/14] Add NSH fields for Openvswitch flowkey

2016-06-14 Thread Jesse Gross
On Tue, Jun 14, 2016 at 9:53 AM, Ryan Moats wrote: > "dev" wrote on 06/14/2016 11:34:50 AM: > >> From: Jesse Gross >> To: Johnson Li >> Cc: ovs dev >> Date: 06/14/2016 11:35 AM >> Subject: Re: [ovs-dev] [RFC PATCH 02/14] Add NSH field

Re: [ovs-dev] [PATCH v6] datapath-windows: Add Geneve support

2016-06-15 Thread Jesse Gross
On Wed, Jun 15, 2016 at 3:43 PM, Nithin Raju wrote: > -Original Message- > From: Yin Lin > Date: Monday, June 13, 2016 at 1:39 PM > To: "dev@openvswitch.org" , Nithin Raju > > Subject: [PATCH v6] datapath-windows: Add Geneve suppor > >>diff --git a/datapath-windows/ovsext/DpInternal.h >>

Re: [ovs-dev] [PATCH v2 01/16] datapath: Allow compiling older kernels with GCC 5.

2016-06-15 Thread Jesse Gross
On Tue, Jun 14, 2016 at 3:25 PM, Jarno Rajahalme wrote: > Older kernels don't have , which causes > compilation to fail on GCC 5. > > Signed-off-by: Jarno Rajahalme Is this something that we really want to support? I mean, if the kernel itself can't be compiled with GCC 5 I'm not sure that it's

Re: [ovs-dev] [PATCH v6] datapath-windows: Add Geneve support

2016-06-16 Thread Jesse Gross
On Wed, Jun 15, 2016 at 10:12 PM, Nithin Raju wrote: diff --git a/datapath-windows/ovsext/Geneve.c b/datapath-windows/ovsext/Geneve.c new file mode 100644 index 000..8190a15 --- /dev/null +++ b/datapath-windows/ovsext/Geneve.c >>[...] +geneveHdr = (GeneveHdr *)(

Re: [ovs-dev] [PATCH v2 0/5] create tunnel devices using rtnetlink interface

2016-06-16 Thread Jesse Gross
On Thu, Jun 16, 2016 at 12:40 PM, Thadeu Lima de Souza Cascardo wrote: > On Wed, Jun 08, 2016 at 03:21:58PM -0300, Thadeu Lima de Souza Cascardo wrote: >> This series adds support for the creation of tunnels using the rtnetlink >> interface. This will open the possibility for new features and flag

Re: [ovs-dev] [PATCH v2 03/16] datapath: compat for NAT.

2016-06-16 Thread Jesse Gross
On Tue, Jun 14, 2016 at 3:25 PM, Jarno Rajahalme wrote: > diff --git a/datapath/linux/compat/include/linux/netfilter/nf_nat.h > b/datapath/linux/compat/include/linux/netfilter/nf_nat.h > new file mode 100644 > index 000..210b9a7 > --- /dev/null > +++ b/datapath/linux/compat/include/linux/netf

Re: [ovs-dev] [PATCH v2 00/16] datapath: NAT backports

2016-06-17 Thread Jesse Gross
On Tue, Jun 14, 2016 at 3:25 PM, Jarno Rajahalme wrote: > This series adds the conntrack NAT integration upstreamed in Linux 4.6 > to the OVS tree kernel module. Main code is the same as upstream > net-next, backports are provided for Linux kernels 3.10 - 4.6. Code > compiles on each Linux versi

Re: [ovs-dev] [PATCH v2 0/5] create tunnel devices using rtnetlink interface

2016-06-17 Thread Jesse Gross
On Fri, Jun 17, 2016 at 6:46 AM, Thadeu Lima de Souza Cascardo wrote: > On Thu, Jun 16, 2016 at 03:53:12PM -0700, Jesse Gross wrote: >> On Thu, Jun 16, 2016 at 12:40 PM, Thadeu Lima de Souza Cascardo >> wrote: >> > The reason we have the first patch in the se

Re: [ovs-dev] [PATCH v6] datapath-windows: Add Geneve support

2016-06-17 Thread Jesse Gross
On Fri, Jun 17, 2016 at 5:10 PM, Yin Lin wrote: > Thanks Alin and Nithin for the review and Jesse for the clarification. > > I've addressed all the comments except this one: > > "One general comment is that we are validating the tunnel options in the > hot path - basically for each packet when we

Re: [ovs-dev] [PATCH v3 11/18] datapath: conntrack NAT helper compat code for Linux 4.5 and earlier.

2016-06-20 Thread Jesse Gross
On Fri, Jun 17, 2016 at 6:44 PM, Jarno Rajahalme wrote: > diff --git a/datapath/conntrack.c b/datapath/conntrack.c > index 4b3b78e..40e9843 100644 > --- a/datapath/conntrack.c > +++ b/datapath/conntrack.c > @@ -337,6 +338,38 @@ static int ovs_ct_helper(struct sk_buff *skb, u16 proto) >

Re: [ovs-dev] [PATCH v3 11/18] datapath: conntrack NAT helper compat code for Linux 4.5 and earlier.

2016-06-20 Thread Jesse Gross
On Mon, Jun 20, 2016 at 2:58 PM, Jarno Rajahalme wrote: > Thanks for the review Jesse, responses below: > >> On Jun 20, 2016, at 2:39 PM, Jesse Gross wrote: >> >> On Fri, Jun 17, 2016 at 6:44 PM, Jarno Rajahalme wrote: >>> diff --git a/datapath/conntrack.c

Re: [ovs-dev] [PATCH v3 00/18] datapath: NAT backports.

2016-06-20 Thread Jesse Gross
gt; this series. This tells me that the problem is not related to the NAT > backports. With the comments noted on the one patch: Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2] VxLAN-gpe implementation

2016-06-20 Thread Jesse Gross
On Mon, Jun 20, 2016 at 6:39 PM, Yang, Yi wrote: > On Mon, Jun 20, 2016 at 10:11:14AM -0300, Thadeu Lima de Souza Cascardo wrote: >> On Mon, Jun 20, 2016 at 08:36:43PM +0800, Yi Yang wrote: >> > Current Linux kernel git tree has included VxLAN-gpe implementation >> > >> > author Jiri Benc >> > c

Re: [ovs-dev] [PATCH v2] VxLAN-gpe implementation

2016-06-21 Thread Jesse Gross
On Mon, Jun 20, 2016 at 7:30 PM, Yang, Yi wrote: > On Mon, Jun 20, 2016 at 07:00:56PM -0700, Jesse Gross wrote: >> >> >> >> Hi, Yi Yang. >> >> >> >> Before adding the OVS_VXLAN_EXT_GPE extension to the out-of-tree module, >> >> you &

Re: [ovs-dev] [PATCH] tun-metadata: Use correct offset when accessing fragmented metadata.

2016-06-21 Thread Jesse Gross
Thanks for the review, I applied to this master and branch-2.5. On Tue, Jun 21, 2016 at 10:08 AM, Jarno Rajahalme wrote: > [Google filtered by ack as spam, so I'm trying again.] > > Acked-by: Jarno Rajahalme > >> On Jun 9, 2016, at 11:50 AM, Jesse Gross wrote: >>

Re: [ovs-dev] [RFC PATCH 07/14] Add APIs to set NSH keys for match fields

2016-06-21 Thread Jesse Gross
On Mon, Jun 20, 2016 at 9:02 PM, Li, Johnson wrote: > 2) Add framework codes (or full implementation) for MD type 2 support of > the NSH header. According to the discussion at > http://comments.gmane.org/gmane.network.openvswitch.devel/53788 > I will reuse the definitions for M

Re: [ovs-dev] TCP MSS clamping for VXLAN over Internet ( draft patch attached )

2016-06-21 Thread Jesse Gross
On Mon, Jun 20, 2016 at 8:40 AM, Jeroen van Bemmel wrote: > Hello, > > When using VXLAN over Internet connections, Openvswitch TCP > performance is currently limited due to IP fragmentation: The Internet > MTU is (at most) 1500 bytes, and the typical TCP MSS value of 1460 > bytes used by clients b

Re: [ovs-dev] The way SDN controllers deal with MTU

2016-06-21 Thread Jesse Gross
On Mon, Jun 20, 2016 at 5:16 AM, Ihar Hrachyshka wrote: > So back to MTU. When I boot a VM using a VXLAN backed network, the tap device > of MTU=1450 is plugged into the br-int bridge, which lowers the bridge MTU to > 1450. Then when I plug a device that belongs to a GRE network (MTU = 1458) >

Re: [ovs-dev] [PATCH v2] VxLAN-gpe implementation

2016-06-21 Thread Jesse Gross
On Tue, Jun 21, 2016 at 5:53 PM, Yang, Yi wrote: > On Tue, Jun 21, 2016 at 09:26:58AM -0700, Jesse Gross wrote: >> On Mon, Jun 20, 2016 at 7:30 PM, Yang, Yi wrote: >> > On Mon, Jun 20, 2016 at 07:00:56PM -0700, Jesse Gross wrote: >> >> >> >> >> >

Re: [ovs-dev] [RFC PATCH 07/14] Add APIs to set NSH keys for match fields

2016-06-21 Thread Jesse Gross
On Tue, Jun 21, 2016 at 6:50 PM, Li, Johnson wrote: >> On Mon, Jun 20, 2016 at 9:02 PM, Li, Johnson wrote: >> > 2) Add framework codes (or full implementation) for MD type 2 support of >> > the NSH header. According to the discussion at >> > http://comments.gmane.org/gmane.network.o

Re: [ovs-dev] [PATCH v2] VxLAN-gpe implementation

2016-06-22 Thread Jesse Gross
On Wed, Jun 22, 2016 at 5:10 AM, Thadeu Lima de Souza Cascardo wrote: > On Tue, Jun 21, 2016 at 07:07:49PM -0700, Jesse Gross wrote: >> On Tue, Jun 21, 2016 at 5:53 PM, Yang, Yi wrote: >> > On Tue, Jun 21, 2016 at 09:26:58AM -0700, Jesse Gross wrote: >> >> On Mon,

Re: [ovs-dev] [RFC PATCH 07/14] Add APIs to set NSH keys for match fields

2016-06-22 Thread Jesse Gross
On Tue, Jun 21, 2016 at 7:40 PM, Li, Johnson wrote: >> On Tue, Jun 21, 2016 at 6:50 PM, Li, Johnson wrote: >> >> Please make a generalized push/pop Ethernet header rather than a >> >> specialized one for this case. There are other use cases that involve >> >> this and they should be consistent (i

Re: [ovs-dev] TCP MSS clamping for VXLAN over Internet ( draft patch attached )

2016-06-22 Thread Jesse Gross
On Wed, Jun 22, 2016 at 10:32 AM, Jeroen van Bemmel wrote: > Hi Jesse, > > Thanks for responding. I also found > http://discuss.openvswitch.narkive.com/WvgqV9fj/ovs-discuss-tunnel-path-mtu-discovery-deprecated-in-1-9-and-what-t-the-substitution > about Path MTU discovery, 3 years ago. It seems lik

Re: [ovs-dev] [PATCH 2/4] compat: ipv4: Pass struct net through ip_fragment.

2016-06-24 Thread Jesse Gross
On Wed, Jun 22, 2016 at 6:00 PM, Joe Stringer wrote: > diff --git a/acinclude.m4 b/acinclude.m4 > index 52d0209ab88a..8760948fcf9b 100644 > --- a/acinclude.m4 > +++ b/acinclude.m4 > @@ -408,7 +408,8 @@ AC_DEFUN([OVS_CHECK_LINUX_COMPAT], [ >[OVS_DEFINE([HAVE_INET_GET_LOCAL_PORT_

Re: [ovs-dev] [PATCH 3/4] compat: Backport ip_do_fragment().

2016-06-24 Thread Jesse Gross
On Wed, Jun 22, 2016 at 6:00 PM, Joe Stringer wrote: > diff --git a/datapath/linux/compat/include/net/ip.h > b/datapath/linux/compat/include/net/ip.h > index 29a4d43a1151..581e912cf2dd 100644 > --- a/datapath/linux/compat/include/net/ip.h > +++ b/datapath/linux/compat/include/net/ip.h [...] > +st

Re: [ovs-dev] [PATCH 0/4] Fix IP refragmentation in upcall/execute path.

2016-06-24 Thread Jesse Gross
lready commented on (which are pretty trivial), this all looks reasonable to me: Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] FAQ: Update support for NAT and Geneve.

2016-06-24 Thread Jesse Gross
Signed-off-by: Jesse Gross --- FAQ.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/FAQ.md b/FAQ.md index cc4fdf6..9f3dc61 100644 --- a/FAQ.md +++ b/FAQ.md @@ -192,13 +192,13 @@ A: Open vSwitch supports different datapaths on different platforms. Each Feature

Re: [ovs-dev] [PATCH] FAQ: Update support for NAT and Geneve.

2016-06-24 Thread Jesse Gross
Thanks, applied to master. On Fri, Jun 24, 2016 at 3:07 PM, Nithin Raju wrote: > Acked-by: Nithin Raju > > -Original Message- > From: dev on behalf of Jesse Gross > > Date: Friday, June 24, 2016 at 2:58 PM > To: "dev@openvswitch.org" > Subject: [ov

Re: [ovs-dev] [PATCHv2] bridge: allow OVS to interact with controller through sockets outside run dir

2016-06-27 Thread Jesse Gross
On Sat, Jun 25, 2016 at 4:38 PM, Ansis Atteka wrote: > diff --git a/lib/daemon.h b/lib/daemon.h > index 4990415..742f382 100644 > --- a/lib/daemon.h > +++ b/lib/daemon.h [...] > +extern bool self_confine; I don't really like that this is global to everything - it seems too easy to accidentally as

Re: [ovs-dev] [PATCH v3 1/9] Windows: Add netfilter-conntrack header files to Include folder

2016-06-27 Thread Jesse Gross
On Mon, Jun 27, 2016 at 11:57 AM, Nithin Raju wrote: > Only comment is to add the OVS license on top of each non-empty file. > Looks like the original code does not have any licence, but it would still > make sense to add a license I think. Looks good otherwise, > Acked-by: Nithin Raju > > Ben or

Re: [ovs-dev] [ovs-discuss] Request for comments on Open vSwitch joining the Linux Foundation

2016-06-27 Thread Jesse Gross
On Mon, Jun 27, 2016 at 1:03 PM, Flavio Leitner wrote: > On Sun, Jun 19, 2016 at 12:35:34PM -0700, Ben Pfaff wrote: >> On Sun, Jun 19, 2016 at 09:36:47AM -0700, Ben Pfaff wrote: >> > LF expects OVS to be a rather small budgetary burden, due to the >> > project's simple structure. The TSC will coo

Re: [ovs-dev] [PATCH v3 1/9] Windows: Add netfilter-conntrack header files to Include folder

2016-06-27 Thread Jesse Gross
On Mon, Jun 27, 2016 at 1:24 PM, Nithin Raju wrote: > >>On Mon, Jun 27, 2016 at 11:57 AM, Nithin Raju wrote: >>> Only comment is to add the OVS license on top of each non-empty file. >>> Looks like the original code does not have any licence, but it would >>>still >>> make sense to add a license

Re: [ovs-dev] The way SDN controllers deal with MTU

2016-06-27 Thread Jesse Gross
On Tue, Jun 21, 2016 at 10:16 PM, Ihar Hrachyshka wrote: >> On 21 Jun 2016, at 23:46, Jesse Gross wrote: >> On Mon, Jun 20, 2016 at 5:16 AM, Ihar Hrachyshka wrote: >>> So back to MTU. When I boot a VM using a VXLAN backed network, the tap >>> device of MTU=1

Re: [ovs-dev] [ovs-discuss] Request for comments on Open vSwitch joining the Linux Foundation

2016-06-27 Thread Jesse Gross
On Mon, Jun 27, 2016 at 4:51 PM, Flavio Leitner wrote: > On Mon, Jun 27, 2016 at 01:30:03PM -0700, Jesse Gross wrote: >> On Mon, Jun 27, 2016 at 1:03 PM, Flavio Leitner wrote: >> > On Sun, Jun 19, 2016 at 12:35:34PM -0700, Ben Pfaff wrote: >> >> On Sun, Jun 19,

Re: [ovs-dev] [PATCHv3] bridge: allow OVS to interact with controller through sockets outside run dir

2016-06-27 Thread Jesse Gross
l use-case for this patch is to allow to connect to OpenFlow > controller that has its socket outside OVS run directory. However, > in the future it could be generalized to allow to disable self-confinement > for other things like DPDK vhost-user sockets or anything else > that is spe

Re: [ovs-dev] [PATCH] datapath: Drop debug code in handle_fragments().

2016-06-28 Thread Jesse Gross
On Tue, Jun 28, 2016 at 2:17 AM, Joe Stringer wrote: > This piece of debug code was introduced during the backport of > conntrack, but is unnecessary and not upstream. Drop it to bring the > code more inline with upstream. > > Reported-by: Jesse Gross > Signed-off-by: Joe S

Re: [ovs-dev] The way SDN controllers deal with MTU

2016-06-28 Thread Jesse Gross
On Tue, Jun 28, 2016 at 1:37 AM, Ihar Hrachyshka wrote: > >> On 27 Jun 2016, at 23:57, Jesse Gross wrote: >> >> On Tue, Jun 21, 2016 at 10:16 PM, Ihar Hrachyshka >> wrote: >>>> On 21 Jun 2016, at 23:46, Jesse Gross wrote: >>>> On Mon, Ju

Re: [ovs-dev] The way SDN controllers deal with MTU

2016-06-28 Thread Jesse Gross
On Tue, Jun 28, 2016 at 8:53 AM, Ihar Hrachyshka wrote: > >> On 28 Jun 2016, at 17:41, Jesse Gross wrote: >> >> On Tue, Jun 28, 2016 at 1:37 AM, Ihar Hrachyshka wrote: >>> >>>> On 27 Jun 2016, at 23:57, Jesse Gross wrote: >>>> >>>&

[ovs-dev] [PATCH] bfd: Allow setting OAM bit when encapsulated in tunnel.

2016-06-28 Thread Jesse Gross
. Signed-off-by: Jesse Gross --- lib/bfd.c | 7 ++- lib/bfd.h | 2 +- ofproto/ofproto-dpif-monitor.c | 10 ++ ofproto/ofproto-dpif-xlate.c | 26 ++ ofproto/ofproto-dpif-xlate.h | 2 +- ofproto/ofproto-dpif.c

Re: [ovs-dev] Sampling in datapath

2016-06-29 Thread Jesse Gross
On Wed, Jun 29, 2016 at 7:45 AM, Marcelo Caggiani Luizelli wrote: > Hi, > > I've seen that there is an implementation of sampling function in the ovs > linux datapath (in file datapath/actions.c). The issue is that this > functions is sending the packet to userspace (usually used by ipix/sflow > s

Re: [ovs-dev] Sampling in datapath

2016-06-29 Thread Jesse Gross
It's the same. On Wed, Jun 29, 2016 at 11:34 AM, Marcelo Caggiani Luizelli wrote: > Hi, > > Thanks. What about the DPDK implementation? Is the datapath implementation > the same? Just running in userspace? > > Marcelo. > > On Wed, Jun 29, 2016 at 6:09 PM, Jesse Gross

Re: [ovs-dev] [PATCH] bfd: Allow setting OAM bit when encapsulated in tunnel.

2016-06-29 Thread Jesse Gross
On Wed, Jun 29, 2016 at 2:41 PM, pravin shelar wrote: > On Tue, Jun 28, 2016 at 10:28 PM, Jesse Gross wrote: >> Some tunnel protocols, such as Geneve, have a bit in the tunnel >> header to indicate that it is an OAM packet. This means that the >> packet should be processe

Re: [ovs-dev] [PATCH v3 0/5] create tunnel devices using rtnetlink interface

2016-06-29 Thread Jesse Gross
On Wed, Jun 22, 2016 at 8:47 AM, Thadeu Lima de Souza Cascardo wrote: > This series adds support for the creation of tunnels using the rtnetlink > interface. This will open the possibility for new features and flags on those > vports without the need to change vport compatibility code. > > Support

Re: [ovs-dev] [PATCH v2 01/24] datapath: compat: Refactor egress tunnel info

2016-06-30 Thread Jesse Gross
On Thu, Jun 30, 2016 at 1:06 AM, Pravin B Shelar wrote: > diff --git a/datapath/linux/compat/geneve.c b/datapath/linux/compat/geneve.c > index 0399de7..884ea53 100644 > --- a/datapath/linux/compat/geneve.c > +++ b/datapath/linux/compat/geneve.c > @@ -669,7 +667,6 @@ netdev_tx_t rpl_geneve_xmit(str

Re: [ovs-dev] [PATCH v2 02/24] datapath: compat: update iptunnel_pull_header()

2016-06-30 Thread Jesse Gross
On Thu, Jun 30, 2016 at 1:06 AM, Pravin B Shelar wrote: > Introduce xnet parameter to iptunnel_pull_header(). > > Signed-off-by: Pravin B Shelar I think this is essentially 7f290c94352e59b1d720055fce760a69a63bd0a1 ("iptunnel: scrub packet in iptunnel_pull_header") but it is missing some pieces,

Re: [ovs-dev] [PATCH v2 03/24] datapath: backport: tunnels: Remove encapsulation offloads on decap.

2016-06-30 Thread Jesse Gross
On Thu, Jun 30, 2016 at 1:06 AM, Pravin B Shelar wrote: > Following patch backports updated iptunnel pull function. > Also brings in following upstream fix: > > commit a09a4c8dd1ec7f830e1fb9e59eb72bddc965d168 > Author: Jesse Gross > > tunnels: Remove encapsulat

Re: [ovs-dev] [PATCH v2 04/24] datapath: backport: net: add dst_cache support

2016-06-30 Thread Jesse Gross
nfiguration values. > > Since the refresh_ts is updated only on dst_cache lookup, the > cached value in the above scenario will be discarded on the next > lookup. > > Signed-off-by: Paolo Abeni > Suggested-and-acked-by: Hannes F

Re: [ovs-dev] [PATCH v2 07/24] datapath: compat: Remove unnecessary iptunnel_xmit() declaration.

2016-06-30 Thread Jesse Gross
On Thu, Jun 30, 2016 at 1:06 AM, Pravin B Shelar wrote: > Signed-off-by: Pravin B Shelar > --- > datapath/linux/compat/include/net/ip_tunnels.h | 10 -- > 1 file changed, 10 deletions(-) Acked-by: Jesse Gross ___ dev mail

Re: [ovs-dev] [PATCH v2 05/24] datapath: backport: ip_tunnel_core: iptunnel_handle_offloads returns int and doesn't free skb

2016-06-30 Thread Jesse Gross
On Thu, Jun 30, 2016 at 1:06 AM, Pravin B Shelar wrote: > diff --git a/datapath/linux/compat/utils.c b/datapath/linux/compat/utils.c > index 7008ecf..7113e09 100644 > --- a/datapath/linux/compat/utils.c > +++ b/datapath/linux/compat/utils.c > @@ -72,6 +72,9 @@ void __percpu *__alloc_percpu_gfp(siz

Re: [ovs-dev] [PATCH v2 08/24] datapath: backport: ip_tunnel: add support for setting flow label via collect metadata

2016-06-30 Thread Jesse Gross
might be time to rename HAVE_METADATA_DST to something like USE_TUNNEL_BACKPORTS since it doesn't have too much to do with tunnel metadata anymore. But otherwise this looks good: Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2 10/24] datapath: compat: Update IPv6 in setup_udp_tunnel_sock()

2016-06-30 Thread Jesse Gross
On Thu, Jun 30, 2016 at 1:06 AM, Pravin B Shelar wrote: > Update setup_udp_tunnel_sock() to handle ipv6 sockets. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman

Re: [ovs-dev] [PATCH v2 11/24] datapath: backport: udp: Add socket based GRO and config

2016-06-30 Thread Jesse Gross
> > Signed-off-by: Tom Herbert > Signed-off-by: David S. Miller > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2 06/24] datapath: backport: tunnel: introduce ipv6_tun_rx_dst()

2016-06-30 Thread Jesse Gross
On Thu, Jun 30, 2016 at 1:06 AM, Pravin B Shelar wrote: > Update ovs_udp_tun_rx_dst() to handle ipv6 tunnels. > > This commit partially backports c29a70d2c ("tunnel: introduce > udp_tun_rx_dst()") > > Signed-off-by: Pravin B Sh

Re: [ovs-dev] [PATCH v2 09/24] datapath: compat: Update udp_sock_create

2016-06-30 Thread Jesse Gross
On Thu, Jun 30, 2016 at 1:06 AM, Pravin B Shelar wrote: > diff --git a/datapath/linux/compat/include/net/udp.h > b/datapath/linux/compat/include/net/udp.h > index 41254aa..fc46d89 100644 > --- a/datapath/linux/compat/include/net/udp.h > +++ b/datapath/linux/compat/include/net/udp.h [...] > +stati

Re: [ovs-dev] [PATCH v3 0/5] create tunnel devices using rtnetlink interface

2016-06-30 Thread Jesse Gross
On Thu, Jun 30, 2016 at 12:25 PM, Thadeu Lima de Souza Cascardo wrote: > On Wed, Jun 29, 2016 at 09:38:00PM -0700, Jesse Gross wrote: >> On Wed, Jun 22, 2016 at 8:47 AM, Thadeu Lima de Souza Cascardo >> wrote: >> > This series adds support for the creation of tun

Re: [ovs-dev] [PATCH v2 13/24] datapath: compat: Add support for IPv6 UDP tunnel segmentation.

2016-06-30 Thread Jesse Gross
Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2 16/24] datapath: backport: openvswitch: correct encoding of set tunnel action attributes

2016-06-30 Thread Jesse Gross
> Signed-off-by: Simon Horman > Signed-off-by: David S. Miller > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2 17/24] datapath: compat: get rid of OVS_CB inner header offsets.

2016-06-30 Thread Jesse Gross
these > old kernel, So none of the supported kernel needs this > comapt code. Following patch removes it. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2 18/24] datapath: backport: geneve: add IPv6 bits to geneve_fill_metadata_dst

2016-06-30 Thread Jesse Gross
On Thu, Jun 30, 2016 at 1:06 AM, Pravin B Shelar wrote: > Upstream commit: > commit b8812fa88371ae567c907448d9a7ba62d09b90c9 > Author: John W. Linville > > geneve: add IPv6 bits to geneve_fill_metadata_dst > > Signed-off-by: John W. Linville >

Re: [ovs-dev] [PATCH v2 19/24] datapath: backport: udp_offload: Set encapsulation before inner completes.

2016-06-30 Thread Jesse Gross
e(struct sk_buff *skb, int > nhoff, > err = ptype->callbacks.gro_complete(skb, nhoff + gh_len); > > rcu_read_unlock(); > + > + skb_set_inner_mac_header(skb, nhoff + gh_len); > return err; > } > #endif This commit also adds a comment to

Re: [ovs-dev] [PATCH v2 20/24] datapath: backport: udp: prevent skbs lingering in tunnel socket queues

2016-06-30 Thread Jesse Gross
shouldn't put the skb back into the socket queue, no one will pick > them up there. Instead we can simply discard them in the respective > encap_recv functions. > > Signed-off-by: Hannes Frederic Sowa > Signed-off-by: David S. Miller

Re: [ovs-dev] [PATCH v2 21/24] datapath: backport: geneve: fix tx_errors statistics

2016-06-30 Thread Jesse Gross
mitting > packets. > > Signed-off-by: Haishuang Yan > Signed-off-by: David S. Miller > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2 22/24] datapath: backport: ovs/gre, geneve: fix error path when creating an iface

2016-06-30 Thread Jesse Gross
) call, the netdev is registered. > > Fixes: 7e059158d57b ("vxlan, gre, geneve: Set a large MTU on ovs-created > tunnel devices") > CC: David Wragg > Signed-off-by: Nicolas Dichtel > Signed-off-by: David S. Miller > >

Re: [ovs-dev] [PATCH v2 23/24] datapath: backport: ovs/geneve: fix rtnl notifications on iface deletion

2016-06-30 Thread Jesse Gross
> RTNL_LINK_INITIALIZED. > > Fixes: e305ac6cf5a1 ("geneve: Add support to collect tunnel metadata.") > CC: Pravin B Shelar > CC: Jesse Gross > CC: Thomas Graf > Signed-off-by: Nicolas Dichtel > Signed-off-by: Da

Re: [ovs-dev] [PATCH v2 24/24] datapath: backport: ovs/vxlan: fix rtnl notifications on iface deletion

2016-06-30 Thread Jesse Gross
: Pravin B Shelar > Signed-off-by: Nicolas Dichtel > Signed-off-by: David S. Miller > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2 15/24] datapath: Add support for IPv6 tunnels.

2016-06-30 Thread Jesse Gross
On Thu, Jun 30, 2016 at 1:06 AM, Pravin B Shelar wrote: > diff --git a/NEWS b/NEWS > index 802e7f8..e91f8d1 100644 > --- a/NEWS > +++ b/NEWS > @@ -67,6 +67,7 @@ Post-v2.5.0 > * Dropped support for kernel older than 3.10. > * Removed VLAN splinters feature. > * Support for truncat

Re: [ovs-dev] [PATCH v2 14/24] datapath: compat: Update Geneve and VxLAN modules.

2016-06-30 Thread Jesse Gross
gt; current net branch. > > Signed-off-by: Pravin B Shelar Can you give the git commit ID that this is syncing to? But otherwise, I am happy with this: Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2 00/24] datapath: compat: Add support for IPv6 Geneve and VxLAN tunnels.

2016-06-30 Thread Jesse Gross
On Thu, Jun 30, 2016 at 1:06 AM, Pravin B Shelar wrote: > This patch series update OVS compat layer to handle IPv6 UDP based > tunnels. While doing this various fixes and updates to tunnel code > are also brought in. This series sync OVS tunnel compat codebase upto > latest net branch (commit 9a0f

Re: [ovs-dev] [PATCH v3 0/5] create tunnel devices using rtnetlink interface

2016-07-01 Thread Jesse Gross
On Fri, Jul 1, 2016 at 10:53 AM, Thadeu Lima de Souza Cascardo wrote: > On Thu, Jun 30, 2016 at 03:44:37PM -0700, Jesse Gross wrote: >> On Thu, Jun 30, 2016 at 12:25 PM, Thadeu Lima de Souza Cascardo >> wrote: >> > On Wed, Jun 29, 2016 at 09:38:00PM -0700, Jesse Gross wro

Re: [ovs-dev] [PATCH v2 19/24] datapath: backport: udp_offload: Set encapsulation before inner completes.

2016-07-05 Thread Jesse Gross
I guess it's not applicable in the sense that the fix is not really in OVS. Kernels with that bug will continue to have it even after this backport. I think it would be pretty challenging to fully backport this through the OVS tree - it would likely require pulling in the whole UDP offloads module

Re: [ovs-dev] [PATCH v3 01/28] datapath: compat: Refactor egress tunnel info

2016-07-05 Thread Jesse Gross
On Fri, Jul 1, 2016 at 5:58 PM, Pravin B Shelar wrote: > diff --git a/datapath/linux/compat/geneve.c b/datapath/linux/compat/geneve.c > index 0399de7..b6c091c 100644 > --- a/datapath/linux/compat/geneve.c > +++ b/datapath/linux/compat/geneve.c > @@ -669,7 +667,6 @@ netdev_tx_t rpl_geneve_xmit(stru

Re: [ovs-dev] [PATCH v3 02/28] datapath: compat: update iptunnel_pull_header()

2016-07-05 Thread Jesse Gross
;) and perhaps some other commits to the commit message? Otherwise looks good though: Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v3 09/28] datapath: compat: rename HAVE_METADATA_DST to USE_UPSTREAM_TUNNEL

2016-07-05 Thread Jesse Gross
On Fri, Jul 1, 2016 at 5:58 PM, Pravin B Shelar wrote: > To better represent the meaning of symbol. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v3 28/28] datapath: backport: iptunnel: make rx/tx bytes counters consistent

2016-07-05 Thread Jesse Gross
s packets errors dropped carrier collsns > 84 10 0 0 0 > > Reported-by: Julien Meunier > Signed-off-by: Nicolas Dichtel > Signed-off-by: David S. Miller > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross

Re: [ovs-dev] [PATCH v3 05/28] datapath: backport: ip_tunnel_core: iptunnel_handle_offloads returns int and doesn't free skb

2016-07-05 Thread Jesse Gross
On Fri, Jul 1, 2016 at 5:58 PM, Pravin B Shelar wrote: > diff --git a/datapath/linux/compat/geneve.c b/datapath/linux/compat/geneve.c > index db1c713..a7229c8 100644 > --- a/datapath/linux/compat/geneve.c > +++ b/datapath/linux/compat/geneve.c > @@ -578,6 +574,7 @@ static int geneve_build_skb(stru

Re: [ovs-dev] [PATCH v3 10/28] datapath: compat: Update udp_sock_create

2016-07-05 Thread Jesse Gross
On Fri, Jul 1, 2016 at 5:59 PM, Pravin B Shelar wrote: > diff --git a/datapath/linux/compat/include/linux/udp.h > b/datapath/linux/compat/include/linux/udp.h > new file mode 100644 > index 000..65cb77c > --- /dev/null > +++ b/datapath/linux/compat/include/linux/udp.h [...] > +static inline vo

Re: [ovs-dev] [PATCH v3 17/28] datapath: Add support for IPv6 tunnels.

2016-07-05 Thread Jesse Gross
o the last column of the last line doesn't look right to me. Otherwise: Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v3 13/28] datapath: backport: ip_tunnel: Move stats update to iptunnel_xmit()

2016-07-05 Thread Jesse Gross
On Fri, Jul 1, 2016 at 5:59 PM, Pravin B Shelar wrote: > diff --git a/datapath/linux/compat/include/net/ip6_tunnel.h > b/datapath/linux/compat/include/net/ip6_tunnel.h > index ce65087..565b69b 100644 > --- a/datapath/linux/compat/include/net/ip6_tunnel.h > +++ b/datapath/linux/compat/include/net/

Re: [ovs-dev] [PATCH v3 04/28] datapath: backport: net: add dst_cache support

2016-07-05 Thread Jesse Gross
On Fri, Jul 1, 2016 at 5:58 PM, Pravin B Shelar wrote: > diff --git a/acinclude.m4 b/acinclude.m4 > index 263c31d..05b5f48 100644 > --- a/acinclude.m4 > +++ b/acinclude.m4 > @@ -556,6 +556,7 @@ AC_DEFUN([OVS_CHECK_LINUX_COMPAT], [ > >OVS_GREP_IFELSE([$KSRC/include/net/dst.h], [dst_discard_sk])

Re: [ovs-dev] [PATCH v3 18/28] datapath: compat: Use dst-cache for Geneve and VxLAN tunnels.

2016-07-05 Thread Jesse Gross
On Fri, Jul 1, 2016 at 5:59 PM, Pravin B Shelar wrote: > diff --git a/datapath/linux/compat/geneve.c b/datapath/linux/compat/geneve.c > index 2ed9ad1..dbb220f 100644 > --- a/datapath/linux/compat/geneve.c > +++ b/datapath/linux/compat/geneve.c I think it would probably be nice to mention that the

Re: [ovs-dev] [PATCH] bridge: open_type should be used for netdev_open

2016-07-06 Thread Jesse Gross
On Mon, Jul 4, 2016 at 11:19 AM, Thadeu Lima de Souza Cascardo wrote: > ofproto_port_open_type should be used for netdev_open, but not for other > tests. > For example, STP/RSTP check for interfaces of internal type, but that check > will > fail when the netdev datapath is used. > > The same thi

Re: [ovs-dev] [PATCH v3 04/28] datapath: backport: net: add dst_cache support

2016-07-06 Thread Jesse Gross
On Wed, Jul 6, 2016 at 3:44 PM, pravin shelar wrote: > On Tue, Jul 5, 2016 at 6:54 PM, Jesse Gross wrote: >> On Fri, Jul 1, 2016 at 5:58 PM, Pravin B Shelar wrote: >>> diff --git a/acinclude.m4 b/acinclude.m4 >>> index 263c31d..05b5f48 100644 >>> --- a

Re: [ovs-dev] [PATCH v4 04/28] datapath: backport: net: add dst_cache support

2016-07-07 Thread Jesse Gross
nfiguration values. > > Since the refresh_ts is updated only on dst_cache lookup, the > cached value in the above scenario will be discarded on the next > lookup. > > Signed-off-by: Paolo Abeni > Suggested-and-acked-by: Hannes Frederic Sowa > Signed-off

Re: [ovs-dev] [PATCH v4 01/28] datapath: compat: Refactor egress tunnel info

2016-07-07 Thread Jesse Gross
On Thu, Jul 7, 2016 at 5:23 PM, Pravin B Shelar wrote: > diff --git a/datapath/linux/compat/dev-openvswitch.c > b/datapath/linux/compat/dev-openvswitch.c > index 0d2088b..544c5e1 100644 > --- a/datapath/linux/compat/dev-openvswitch.c > +++ b/datapath/linux/compat/dev-openvswitch.c > +#ifndef HAVE

Re: [ovs-dev] [PATCH v4 13/28] datapath: backport: ip_tunnel: Move stats update to iptunnel_xmit()

2016-07-07 Thread Jesse Gross
it(), we can simplify > iptunnel_xmit() usage. With this change there is no need to > call another function (iptunnel_xmit_stats()) to update stats > in tunnel xmit code path. > > Signed-off-by: Pravin B Shelar > Signed-off-by: David S. Miller > > Signed-of

Re: [ovs-dev] [PATCH v4 04/28] datapath: backport: net: add dst_cache support

2016-07-07 Thread Jesse Gross
On Thu, Jul 7, 2016 at 6:38 PM, pravin shelar wrote: > On Thu, Jul 7, 2016 at 6:04 PM, Jesse Gross wrote: >> On Thu, Jul 7, 2016 at 5:23 PM, Pravin B Shelar wrote: >>> This backports dst-cache implementation from upstream implementation.

Re: [ovs-dev] [PATCH v4 05/28] datapath: backport: ip_tunnel_core: iptunnel_handle_offloads returns int and doesn't free skb

2016-07-07 Thread Jesse Gross
ee skb") > I have also removed duplicate definitions of tunnel_handle_offloads() > from ip-tunnel header. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v4 10/28] datapath: compat: Update udp_sock_create

2016-07-07 Thread Jesse Gross
On Thu, Jul 7, 2016 at 5:23 PM, Pravin B Shelar wrote: > diff --git a/datapath/linux/compat/include/linux/udp.h > b/datapath/linux/compat/include/linux/udp.h > new file mode 100644 > index 000..31ae022 > --- /dev/null > +++ b/datapath/linux/compat/include/linux/udp.h > @@ -0,0 +1,33 @@ > +#if

Re: [ovs-dev] [PATCH v4 10/28] datapath: compat: Update udp_sock_create

2016-07-07 Thread Jesse Gross
On Thu, Jul 7, 2016 at 7:13 PM, Jesse Gross wrote: > On Thu, Jul 7, 2016 at 5:23 PM, Pravin B Shelar wrote: >> diff --git a/datapath/linux/compat/include/linux/udp.h >> b/datapath/linux/compat/include/linux/udp.h >> new file mode 100644 >> index 000..31ae02

Re: [ovs-dev] [PATCH v4 10/28] datapath: compat: Update udp_sock_create

2016-07-07 Thread Jesse Gross
On Thu, Jul 7, 2016 at 7:17 PM, pravin shelar wrote: > On Thu, Jul 7, 2016 at 7:16 PM, Jesse Gross wrote: >> On Thu, Jul 7, 2016 at 7:13 PM, Jesse Gross wrote: >>> On Thu, Jul 7, 2016 at 5:23 PM, Pravin B Shelar wrote: >>>> diff --git a/datapath/linux/comp

Re: [ovs-dev] [PATCH v4 18/28] datapath: compat: Use dst-cache for Geneve and VxLAN tunnels.

2016-07-07 Thread Jesse Gross
c6139e6e ("bpf, vxlan, geneve, gre: fix usage of > dst_cache on xmit"). is also included. Geneve changes > were added in 468dfffcd762cbb2777ec5a76bc21e3748ebf47e ("geneve: add > dst caching support") > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross __

Re: [ovs-dev] [PATCH v5 04/28] datapath: backport: net: add dst_cache support

2016-07-08 Thread Jesse Gross
nfiguration values. > > Since the refresh_ts is updated only on dst_cache lookup, the > cached value in the above scenario will be discarded on the next > lookup. > > Signed-off-by: Paolo Abeni > Suggested-and-acked-by: Hannes F

Re: [ovs-dev] [PATCH v4 06/28] datapath: backport: tunnel: introduce ipv6_tun_rx_dst()

2016-07-08 Thread Jesse Gross
On Thu, Jul 7, 2016 at 5:23 PM, Pravin B Shelar wrote: > diff --git a/datapath/linux/compat/include/net/dst_metadata.h > b/datapath/linux/compat/include/net/dst_metadata.h > index f15bb03..b54cfc0 100644 > --- a/datapath/linux/compat/include/net/dst_metadata.h > +++ b/datapath/linux/compat/includ

<    1   2   3   4   5   6   7   8   9   10   >