On Mon, Jun 20, 2016 at 6:39 PM, Yang, Yi <yi.y.y...@intel.com> wrote: > On Mon, Jun 20, 2016 at 10:11:14AM -0300, Thadeu Lima de Souza Cascardo wrote: >> On Mon, Jun 20, 2016 at 08:36:43PM +0800, Yi Yang wrote: >> > Current Linux kernel git tree has included VxLAN-gpe implementation >> > >> > author Jiri Benc <jb...@redhat.com> >> > committer David S. Miller <da...@davemloft.net> >> > commit e1e5314de08ba6003b358125eafc9ad9e75a950c (patch) >> > tree 1e18cdabf1c9d9ef17e26c6480e629465447f77f /drivers/net/vxlan.c >> > parent a6d5bbf34efa8330af7b0b1dba0f38148516ed97 (diff) >> > vxlan: implement GPE >> > >> > This patch is to port it to ovs in order that people also can use VxLAN-gpe >> > even if they don't replace their kernels with latest Linux kernel. >> > >> > Signed-off-by: Johnson Li <johnson...@intel.com> >> > Signed-off-by: Yi Yang <yi.y.y...@intel.com> >> >> >> Hi, Yi Yang. >> >> Before adding the OVS_VXLAN_EXT_GPE extension to the out-of-tree module, you >> should send it to the mainline kernel. Besides, you need a very good >> justification why you can't wait for my patchset to be accepted and have >> VXLAN-GPE enabled using rtnetlink. > > Will add VS_VXLAN_EXT_GPE to include/uapi/linux/openvswitch.h and send a > kernel patch, but ovs and net-next kernel also can work together.
I think that you might have misunderstood the gist of the suggestion - please do not add this extension. This is pure compatibility code for existing, old features and should not be extended with new things unless there is a very, very good reason (which would almost certainly be related to fixing bugs, not new functionality) - especially since there's already an existing mechanism to do this. >> Also, I would split any changes to the datapath and userspace parts of the >> code >> into multiple commits. >> >> Meanwhile, you could backport only the upstreamed portions of VXLAN-GPE and >> send >> that as a single commit, no userspace changes. > > VxLAN-gpe part depends on some new changes in vxlan module, we have to > backport them into ovs, this patch has been VxLAN-gpe only, current ovs > vxlan is much older than vxlan kernel module, Jesse mentioned we should > backport all the new changes in vxlan kernel module, but the effort will > be very huge, ovs vxlan needs to be compatible with some the old > kernels, that makes backporting must be very careful, Jesse also > mentioned Pravin is backporting them. This patch is just to make sure > your patch set, Simon's patch set and VxLAN-gpe can work correctly as > expected. If a patch is not ready to be merged, it's nice if you mark it as an RFC. > You can take the part for netlink and merge it to your next patch set > version if needed. Changes are not big, our email system will result in > some patches loss if multiple patches are sent, so we prefer one patch > including all the stuff. One option to deal with mail problems is to put the patches up on github (though please at least try to send a copy to the mailing list as well). _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
