On Fri, Jul 1, 2016 at 5:58 PM, Pravin B Shelar <pshe...@ovn.org> wrote: > diff --git a/acinclude.m4 b/acinclude.m4 > index 263c31d..05b5f48 100644 > --- a/acinclude.m4 > +++ b/acinclude.m4 > @@ -556,6 +556,7 @@ AC_DEFUN([OVS_CHECK_LINUX_COMPAT], [ > > OVS_GREP_IFELSE([$KSRC/include/net/dst.h], [dst_discard_sk]) > OVS_GREP_IFELSE([$KSRC/include/net/dst.h], [__skb_dst_copy]) > + OVS_GREP_IFELSE([$KSRC/include/net/dst_cache.h], [dst_cache])
Looking at this some more, is the symbol created by this check actually used anywhere? Unless I am missing something, it seems like we unconditionally replace the dst cache with ours. It seems to me that we might want to make the use of the dst cache follow whether we are using upstream tunnels or not. If the upstream dst cache is available then it should be fine to use that with the OVS tunnel implementation as well. However, if we end up using upstream tunnels and the OVS dst cache (because of inconsistent backports) then that probably won't work very well. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
