On Fri, Jun 17, 2016 at 5:10 PM, Yin Lin <yinli...@gmail.com> wrote: > Thanks Alin and Nithin for the review and Jesse for the clarification. > > I've addressed all the comments except this one: > > "One general comment is that we are validating the tunnel options in the > hot path - basically for each packet when we execute the actions for the > flow. Obvious solution for this is to validate the flow ONLY during flow > add. Can you add a flag to OvsTunnelAttrToGeneveOptions() that tells the > function to validate only during flow add?" > > In order to address this we need to propagate the flag all the way down. > Besides, there are other callers to this function such as > OvsExecuteSetAction. > We need to evaluate whether validation is required in such cases. > Can I address the optimization in a separate patch? It looks like we always > do the validation on Linux and didn't optimize either.
Linux does this on flow setup. If it finds a critical option it sets a flag as part of the flow and then doesn't do any further scanning on options for each packet, either on transmit or receive. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
