On Thu, Jun 30, 2016 at 1:06 AM, Pravin B Shelar <pshe...@ovn.org> wrote:
> diff --git a/datapath/linux/compat/geneve.c b/datapath/linux/compat/geneve.c
> index 0399de7..884ea53 100644
> --- a/datapath/linux/compat/geneve.c
> +++ b/datapath/linux/compat/geneve.c
> @@ -669,7 +667,6 @@ netdev_tx_t rpl_geneve_xmit(struct sk_buff *skb)
> rt = geneve_get_rt(skb, dev, &fl4, info);
> if (IS_ERR(rt)) {
> netdev_dbg(dev, "no route to %pI4\n", &fl4.daddr);
> - dev->stats.tx_carrier_errors++;
> goto tx_error;
> }
It looks like we're missing a piece from this patch that initializes
err to -EINVAL.
> diff --git a/datapath/linux/compat/lisp.c b/datapath/linux/compat/lisp.c
> index f1f50ae..0a9a227 100644
> --- a/datapath/linux/compat/lisp.c
> +++ b/datapath/linux/compat/lisp.c
> +int ovs_lisp_fill_metadata_dst(struct net_device *dev, struct sk_buff *skb)
> +{
> + struct lisp_dev *lisp = netdev_priv(dev);
> + struct ip_tunnel_info *info = skb_tunnel_info(skb);
> + __be16 sport, dport;
> +
> + sport = udp_flow_src_port(dev_net(dev), skb, 1, USHRT_MAX, true);
> + dport = info->key.tp_dst ? : lisp->dst_port;
LISP is using it's own source port calculation function so it won't
match the one calculated here. The dest port is also unconditionally
taken from the configuration rather than the skb tunnel info.
> diff --git a/manpages.mk b/manpages.mk
> index fa9e59b..ea98d0f 100644
> --- a/manpages.mk
> +++ b/manpages.mk
> @@ -168,12 +168,6 @@ utilities/ovs-pki.8: \
> utilities/ovs-pki.8.in
> utilities/ovs-pki.8.in:
>
> -utilities/ovs-tcpdump.8: \
> - utilities/ovs-tcpdump.8.in \
> - lib/common.man
> -utilities/ovs-tcpdump.8.in:
> -lib/common.man:
Is this an unrelated change?
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
