Mickey, Can you give a first shot at the review. You had some issues with
the my code structure and looks like Steve decided to use something
similar.
On 19 April 2016 at 02:36, steve.ruan wrote:
> From: Guru Shetty
>
Steve,
You should be the author (when you respin after Mickey&#x
On 20 April 2016 at 18:38, steve.ruan wrote:
> From: Guru Shetty
>
Run the following command (with your name added) for your next respin:
git commit --amend --author="Author Name "
>
> static routes are useful when connecting multiple
> routers with each other.
>
On 24 April 2016 at 02:49, steve.ruan wrote:
Thank you for working through this. I have a few comments.
With this patch, your author name becomes "steve.ruan". Did you intend it
to be Steve Ruan instead? Your email address in the author name (gmail) is
different than the email address in your sign
>
>
> +
> +
> +
> +Nexthop of this route, nexthop can be a IP address of logical
> router
> +port, or IP address which has been learnt by dynamic ARP.
>
Can you explain how a nexthop IP address specified is anything other than
the IP address of a logical router (based on c
>
> [Resending as the previous reply got rejected by the mailing list].
>
Thanks for the explanation. I intend to add the following stylistic and
needed changes and apply this to master after some time.
diff --git a/AUTHORS b/AUTHORS
index 3f05a02..5290ef5 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -21
>
>
>
> Thanks for the ack.
>
> Guru, I mostly wrote this up for you, does this solve the problem you
> saw?
>
Sorry, I completely missed this. Yes, it does solve the problem for me.
>
> Thanks,
>
> Ben.
> ___
> dev mailing list
> dev@openvswitch.org
>
On 9 May 2016 at 14:51, Darrell Ball wrote:
> I have some initial clarifications first before review
>
> On Fri, May 6, 2016 at 9:21 AM, Gurucharan Shetty wrote:
>
>> Currently we can connect routers via "peer"ing. This limits
>> the number of routers that can be connected with each other
>> dir
On 9 May 2016 at 23:57, Mickey Spiegel wrote:
> The big issue for me is your last comment:
>
> If you add bob2 on hv1, would bob2 be able to reach alice1?
>
> No; take foo1 which is already on hv1 for this example;
> if I try to send b/w foo1 and alice1, I have “no route to alice
>
>
>
> Some reasons why having a “transit LS” is “undesirable” is:
>
> 1)1) It creates additional requirements at the CMS layer for setting
> up networks; i.e. additional programming is required at the OVN northbound
> interface for the special transit LSs, interactions with the logical route
> On May 11, 2016, at 10:45 PM, Darrell Ball wrote:
>
>
>
>> On Wed, May 11, 2016 at 8:51 PM, Guru Shetty wrote:
>>
>>
>>
>>
>> > On May 11, 2016, at 8:45 PM, Darrell Ball wrote:
>> >
>> >> On Wed, May 11, 2016 at
Thank you William and Ryan. I pushed this to master.
On 12 May 2016 at 09:32, William Tu wrote:
> Thanks for adding this, I will re-run the OVN-related valgrind tests.
>
> On Thu, May 12, 2016 at 9:14 AM, Ryan Moats wrote:
>
> >
> >
> > "dev" wrote on 05/12/2016 10:23:39 AM:
> >
> > > From: Gu
>
>
>>
>> I think one of the main discussion points was needing thousands of arp
>> flows and thousands of subnets, and it was on an incorrect logical
>> topology, I am glad that it is not an issue any more.
>>
>
> I think you misunderstood - having one or more gateway per tenant does not
> make Tr
>
>
> I think you misunderstood - having one or more gateway per tenant does not
> make Transit LS better in flow scale.
> The size of a Transit LS subnet and management across Transit LSs is one
> the 5 issues I mentioned and it remains the same
> as do the other issues.
>
> Based on the example w
>
>
>
> Completely agree that you need to go through a common point in both
> directions
> in the same chassis.
>
> Why does this require a separate gateway router?
>
The primary reason to choose a separate gateway router was to support
multiple physical gateways for k8s to which you can loadbalan
On 12 May 2016 at 16:34, Darrell Ball wrote:
> On Thu, May 12, 2016 at 10:54 AM, Guru Shetty wrote:
>
> >
> >> I think you misunderstood - having one or more gateway per tenant does
> >> not make Transit LS better in flow scale.
> >> The size of a Transit
>
>
> >>
> >> With respect to the other questions, I think its best approach would be
> to
> >> ask direct questions so those
> >> direct questions get answered.
> >>
> >> 1) With 1000 HVs, 1000 HVs/tenant, 1 distributed router per tenant, you
> >> choose the number of gateways/tenant:
> >>
> >> a)
>
>
>
> There was an in-person meeting yesterday at VMware with Mickey (from
> that thread) and some other IBMers. I couldn't attend the whole meeting
> but I assume that some conclusions were reached. I guess that we'll
> know more soon.
>
The conclusion of the meeting was that we will go ahead
On 19 May 2016 at 03:57, Salvatore Orlando wrote:
> [Accidentally sent message before completing, resuming here]
>
> Hello,
>
> I have been working for a while on integration with kubernetes with a CNI
> plugin for OVN.
> The work in [1] is forked by Guru's repository by the same name [2].
>
> Mo
On 20 May 2016 at 09:07, D M, Vikas wrote:
> Hi ,
>
> We are using ovsdb hardware vtep schema in openstack l2gateway project [1]
>
> ovsdb server initiates the connection to l2gateway agent with the entries
> in manager table in ovsdb hardware vtep schema[3].
> Already tcp connection for manager
vsdb-server: I/O error: open:
> /usr/local/etc/openvswitch/vtep.db failed (No such file or directory))
>
> So searched the entire / dir to locate vtep.db file. But vtep.db doesn’t
> exist.
>
> Thanks,
> Vikas
>
>
>
>
>
>
>
>
>
> Fr
On 21 May 2016 at 11:48, Darrell Ball wrote:
> I made some modifications to code in Patches 1 and 2 to remove the Transit
> LS
> requirements.
>
These are the reasons for the need of a LS to be able to be connected to
multiple routers.
1. I think it should be left to the upstream user on how the
On 14 March 2016 at 14:36, Ben Pfaff wrote:
> On Mon, Mar 14, 2016 at 01:57:57PM -0700, Jarno Rajahalme wrote:
> >
> > > On Mar 14, 2016, at 10:42 AM, Ben Pfaff wrote:
> > >
> > > On Sun, Feb 28, 2016 at 10:33:17PM -0800, Gurucharan Shetty wrote:
> > >> From: Jarno Rajahalme
> > >>
> > >> Signe
On 26 May 2016 at 07:13, Kyle Mestery wrote:
> Greetings!
>
> I was looking for some L3 related items and came across the following
> patch on patchworks [1]. This was some work done to add L3 routing to
> the vtep emulator. Guru had commented on this indicating the
> usefulness for using the vte
On 26 MaVTEP schema based L3 gateway in particular?
>
> >
> Thanks Guru. I was looking at the VTEP schema based L3 GW as well, and
> wondering if this patch had pretty much been abandoned. I can see some
> use for using VTEP as an L3 edge device.
>
The patch has been abandoned for the time being.
>
>
> OK, I'm going to play with this a bit. I was mostly interested in
> feedback from others. We're interested in this approach and so if we
> take the patch up does it stand a chance of merging?
>
If I remember correctly, the main problem was around ARP handling when the
destination's mac addre
On 2 June 2016 at 13:06, Ben Pfaff wrote:
> On Thu, May 19, 2016 at 01:02:30PM -0700, Gurucharan Shetty wrote:
> > Currently we can connect routers via "peer"ing. This limits
> > the number of routers that can be connected with each other
> > directly to 2.
> >
> > One of the design goals for L3
On 2 June 2016 at 13:23, Ben Pfaff wrote:
> On Thu, May 19, 2016 at 01:02:31PM -0700, Gurucharan Shetty wrote:
> > Currently OVN has distributed switches and routers. When a packet
> > exits a container or a VM, the entire lifecycle of the packet
> > through multiple switches and routers are calc
On 2 June 2016 at 13:31, Ben Pfaff wrote:
> On Thu, May 19, 2016 at 01:02:32PM -0700, Gurucharan Shetty wrote:
> > We currently allocate conntrack zones in binding.c. It fits
> > in nicely there because we currently only allocate conntrack
> > zones to logical ports and binding.c is where we figu
On 2 June 2016 at 14:19, Ben Pfaff wrote:
> On Thu, May 19, 2016 at 01:02:33PM -0700, Gurucharan Shetty wrote:
> > OVS NAT currently cannot do snat and dnat in the same zone.
> > So we need two zones per gateway router.
> >
> > Signed-off-by: Gurucharan Shetty
>
> We're running out of registers
>
>
>
> Looking at the code, it looks like any IP packet matches the priority-50
> flow. Something like:
> For all IP packets, a priority-50 flow with an action
> ct_dnat;.
>
Agreed. Will fix this as part of the next version.
>
>
> >index 7852d83..3ce88a7 100644
> >--- a/ovn/northd/ovn-northd.c
>
On 3 June 2016 at 08:18, Ben Pfaff wrote:
> On Thu, Jun 02, 2016 at 10:22:05PM -0700, Guru Shetty wrote:
> > On 2 June 2016 at 14:19, Ben Pfaff wrote:
> >
> > > On Thu, May 19, 2016 at 01:02:33PM -0700, Gurucharan Shetty wrote:
> > > > OVS NAT currently cann
On 3 June 2016 at 09:10, Ben Pfaff wrote:
> I've seen users make this error several times. This FAQ will provide a
> useful answer to pass along.
>
> Signed-off-by: Ben Pfaff
>
Acked-by: Gurucharan Shetty
___
dev mailing list
dev@openvswitch.org
http
>
>
>> As mentioned above, in OpenStack, if the source IP address is a fixed IP
>> that has a corresponding floating IP, then the source IP address should be
>> mapped to the floating IP address rather than the router gateway address.
>>
>> Separate dnat and snat lists as defined here can be made t
On 12 July 2016 at 17:56, Joe Stringer wrote:
> On 11 July 2016 at 23:35, Gurucharan Shetty wrote:
> > This unit test adds a basic OVN NAT test that tests north-south
> > DNAT, south-north SNAT and east-west DNAT and SNAT. It uses network
> > namespaces connected to br-int using veth pairs to ac
On 12 July 2016 at 17:57, Joe Stringer wrote:
> On 11 July 2016 at 23:35, Gurucharan Shetty wrote:
> > Signed-off-by: Gurucharan Shetty
> > ---
>
> Looks good, thanks. Only comment is if you add this file to
> check-system-userspace then it should also get a CHECK_CONNTRACK() at
> the start.
>
On 13 July 2016 at 13:02, Ben Pfaff wrote:
> Fixes a number of warnings from "sparse".
>
> Fixes: 4685e523695c ("ovn: Support multiple addresses on a single logical
> router port.")
> Signed-off-by: Ben Pfaff
>
Acked-by: Gurucharan Shetty
> ---
> ovn/northd/ovn-northd.c | 2 +-
> 1 file chan
On 13 July 2016 at 07:49, Alin Serdean
wrote:
> > -Mesaj original-
> > De la: Paul Boca
> > Trimis: Wednesday, July 13, 2016 11:24 AM
> > Către: Alin Serdean ;
> > dev@openvswitch.org
> > Subiect: RE: [ovs-dev] [PATCH V6 12/17] python tests: Ported Python
> > daemon to Windows
> >
> > Hi
On 12 July 2016 at 08:36, Alin Serdean
wrote:
> Testing out the named pipe implementation revealed a problem in
> "daemon --detach startup errors". If the daemon actually started nobody
> is stopping it.
> In the case of test failure kill the daemon.
>
> Signed-off-by: Alin Gabriel Serdean
>
Tha
On 13 July 2016 at 10:35, Paul Boca wrote:
> If the PID file isn't locked then appctl.py detects it as stale and
> bails out without doing anything. Because of this lots of Python tests
> fail.
> Also this protects the PID file from being overwritten.
>
> I used only shared lock, in order to be c
On 12 July 2016 at 20:32, Alin Serdean
wrote:
> Currently in the case of command line arguments punix/unix, on Windows
> we create a file, write a TCP port number to connect. This is a security
> concern.
>
> This patch adds support for the command line arguments punix/unix trying
> to mimic AF_U
On 14 July 2016 at 19:00, Alin Serdean
wrote:
> Thanks for the review! Comments inlined.
>
>
>
> Thanks,
>
> Alin.
>
>
>
> *De la:* Guru Shetty [mailto:g...@ovn.org]
> *Trimis:* Friday, July 15, 2016 1:27 AM
> *Către:* Alin Serdean
> *Cc:* dev@openvsw
On 14 July 2016 at 15:52, Alin Serdean
wrote:
> > > +flock(filep_pidfile, LOCK_EX);
> > >
> > Won't the above call block indefinitely if the lock has already been
> taken by
> > someone else? We don't want the behavior when someone starts a daemon
> > and it simply hang there.
> [Alin Gabriel
On 14 July 2016 at 19:25, Alin Serdean
wrote:
>
> [Alin Gabriel Serdean: ]
> https://msdn.microsoft.com/en-us/library/windows/desktop/aa365203(v=vs.85).aspx
> The part:
> "If the same range is locked with an exclusive and a shared lock, two
> unlock operations are necessary to unlock the region;
On 14 July 2016 at 19:57, Alin Serdean
wrote:
> On 12 July 2016 at 20:32, Alin Serdean
> wrote:
>
> Currently in the case of command line arguments punix/unix, on Windows
> we create a file, write a TCP port number to connect. This is a security
> concern.
>
> This patch adds support for the com
On 14 July 2016 at 20:42, Guru Shetty wrote:
>
>
> On 14 July 2016 at 19:57, Alin Serdean
> wrote:
>
>> On 12 July 2016 at 20:32, Alin Serdean
>> wrote:
>>
>> Currently in the case of command line arguments punix/unix, on Windows
>> we create a file
On 14 July 2016 at 20:03, Alin Serdean
wrote:
>
>
> De la: Guru Shetty [mailto:g...@ovn.org]
> Trimis: Friday, July 15, 2016 5:49 AM
> Către: Alin Serdean
> Cc: Paul Boca ; dev@openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH V7] windows: Added lockf function and lock
>
>
>> -Original Message-
>> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Guru Shetty
>> Sent: Friday, July 15, 2016 6:58 AM
>> To: Alin Serdean
>> Cc: dev@openvswitch.org
>> Subject: Re: [ovs-dev] [PATCH V7] windows: Added lockf function
On 18 July 2016 at 05:22, Chandra S Vejendla wrote:
> When router ip is used as SNAT IP, traffic destined to router
> ip should not be dropped
>
Thank you for the fix. You will need to add your Signed-off-by. Can you
also add a "Fixes:" tag in commit message. Since this is a regression, I
wonder
On 18 July 2016 at 10:35, Ben Pfaff wrote:
> On Mon, Jul 18, 2016 at 12:00:30AM -0700, Gurucharan Shetty wrote:
> > We should not use "peer" while connecting a router to a switch.
> > (Doing so, will cause ovn-northd to constantly create and destroy
> > port_binding records which causes CPU utili
On 18 July 2016 at 11:44, Ryan Moats wrote:
> "dev" wrote on 07/18/2016 03:39:56 AM:
>
> > From: Gurucharan Shetty
> > To: dev@openvswitch.org
> > Date: 07/18/2016 01:39 PM
> > Subject: [ovs-dev] [PATCH] ovn-northd: Warn when the peer of a
> > router port is a switch port.
> > Sent by: "dev"
>
On 18 July 2016 at 13:11, Ben Pfaff wrote:
> On Mon, Jul 18, 2016 at 11:34:54AM -0700, Guru Shetty wrote:
> > On 18 July 2016 at 10:35, Ben Pfaff wrote:
> >
> > > On Mon, Jul 18, 2016 at 12:00:30AM -0700, Gurucharan Shetty wrote:
> > > > We should not use &
On 13 July 2016 at 20:21, Yin Lin wrote:
> Signed-off-by: Yin Lin
>
Thank you, applied.
> ---
> datapath-windows/ovsext/Flow.c | 2 +-
> datapath-windows/ovsext/Vport.c | 3 ++-
> datapath-windows/ovsext/Vport.h | 5 +
> 3 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/d
On 21 July 2016 at 23:02, nickcooper-zhangtonghao <
nickcooper-zhangtong...@opencloud.tech> wrote:
> Hi all,
> When setting the logical switch port as the peer of logical router,
> I found a large number of ovn-northd log. The process of ovn-northd write
> quickly the log
> all the time. The worse
On 19 July 2016 at 09:07, Ben Pfaff wrote:
> A router port's "peer", if set, must point to another router port, but the
> code as written also accepted switch ports. This caused problems when
> switch ports were actually specified.
>
> Reported-by: Gurucharan Shetty
> Reported-at: http://openvs
On 19 July 2016 at 09:07, Ben Pfaff wrote:
> An ovn_port keeps track of its peer in its 'peer' member, but the code
> updated by this commit instead did a redundant lookup of the peer.
>
> Signed-off-by: Ben Pfaff
>
Acked-by: Gurucharan Shetty
> ---
> ovn/northd/ovn-northd.c | 11 +++
On 21 July 2016 at 06:05, Ryan Moats wrote:
> "dev" wrote on 07/21/2016 06:32:02 AM:
>
> > From: Lance Richardson
> > To: ovs dev
> > Date: 07/21/2016 06:32 AM
> > Subject: [ovs-dev] ovn test failures
> > Sent by: "dev"
> >
> > It seems the failure rate for OVN end-to-end tests went up signif
On 25 July 2016 at 05:50, Paul Boca wrote:
> If the PID file isn't locked then appctl.py detects it as stale and
> bails out without doing anything. Because of this lots of Python tests
> fail.
> Also this protects the PID file from being overwritten.
>
> I used only shared lock, in order to be c
On 25 July 2016 at 14:58, Alin Serdean
wrote:
> _get_osfhandle returns an errno value not a GetLastErrorValue.
> (https://msdn.microsoft.com/en-us/library/ks2530z6(v=vs.120).aspx)
>
> Signed-off-by: Alin Gabriel Serdean
>
Thank you. Applied to master.
> ---
> lib/daemon-windows.c | 2 +-
> 1
On 26 July 2016 at 10:19, Ben Pfaff wrote:
> On Wed, Jul 13, 2016 at 04:20:36AM -0700, Gurucharan Shetty wrote:
> > Signed-off-by: Gurucharan Shetty
> > ---
> > ovn/northd/ovn-northd.c | 47
> ++-
> > 1 file changed, 14 insertions(+), 33 deletions(-)
On 24 July 2016 at 10:07, Ryan Moats wrote:
> In the physical processing of ovn-controller, there are two
> sets of OF flows that are still fully recalculated every cycle:
>
> Flows that aren't associated with any logical flow, and
> Flows calculated based on multicast groups
>
> Because thes
On 24 July 2016 at 10:07, Ryan Moats wrote:
> In the physical processing of ovn-controller, there are two
> sets of OF flows that are still fully recalculated every cycle:
>
> Flows that aren't associated with any logical flow, and
> Flows calculated based on multicast groups
>
> Because thes
On 26 July 2016 at 15:54, Ryan Moats wrote:
>
>
>
> Guru Shetty wrote on 07/26/2016 03:54:29 PM:
>
> > From: Guru Shetty
> > To: Ryan Moats/Omaha/IBM@IBMUS
> > Cc: ovs dev
> > Date: 07/26/2016 03:54 PM
> > Subject: Re: [ovs-dev] [PATCH] ovn-co
> On Jul 26, 2016, at 5:30 PM, Ryan Moats wrote:
>
> Guru Shetty wrote on 07/26/2016 06:05:47 PM:
>
> > From: Guru Shetty
> > To: Ryan Moats/Omaha/IBM@IBMUS
> > Cc: ovs dev
> > Date: 07/26/2016 06:06 PM
> > Subject: Re: [ovs-dev] [PATCH] ovn-contro
> On Jul 26, 2016, at 6:13 PM, Russell Bryant wrote:
>
>> On Tue, Jul 26, 2016 at 6:46 AM, wrote:
>>
>> From: Babu Shanmugam
>>
>> Commit 263064a (Convert binding_run to incremental processing.) removed
>> the usage
>> of all_lports from binding_run, but it is infact used in the context of
On 27 July 2016 at 10:40, Kyle Mestery wrote:
> While reading this document, the title stood out to me as not
> accurate. The title indicates it will discuss how to use
> Open vSwitch with Docker, but in reality, it's about using
> Open Virtual Networking with Docker.
>
> This change updates the
On 27 July 2016 at 23:30, Dongjun wrote:
> Signed-off-by: Dongjun
>
Usually, we have a test with the corresponding code change. Can you have a
look at https://www.mail-archive.com/dev@openvswitch.org/msg66099.html and
see whether you are happy with the code change?
> ---
> tests/system-ovn.a
On 26 July 2016 at 13:49, Russell Bryant wrote:
> When L3 gateway support was added, it introduced a port type called
> "gateway" and a corresponding option called "gateway-chassis". Since
> that time, we also have an L2 gateway port type called "l2gateway" and a
> corresponding option called "l
On 18 July 2016 at 09:57, Chandra S Vejendla wrote:
> When router ip is used as SNAT IP, traffic destined to router
> ip should not be dropped
>
> Fixes: 4685e523695c ("ovn: Support multiple addresses on a single logical
> router port.")
> Signed-off-by: Chandra Sekhar Vejendla
>
I applied this
unit test and also added you in AUTHORS.
I did look at your second patch of the series. Please read CodingStyle.md
for any future contributions.
>
> On 2016/7/28 21:31, Guru Shetty wrote:
>
>>
>>
>> On 27 July 2016 at 23:30, Dongjun > do...@dtdream.com>> wrot
On 28 July 2016 at 07:48, Guru Shetty wrote:
>
>
> On 28 July 2016 at 06:55, Dong Jun wrote:
>
>> Yes, this test case fail currently and success with the modification.
>> If there is another same test case, ignore this patch is OK.
>>
>
> Thank you for the
On 26 July 2016 at 12:57, Alin Serdean
wrote:
> Currently in the case of command line arguments punix/unix, on Windows
> we create a file, write a TCP port number to connect. This is a security
> concern.
>
> This patch adds support for the command line arguments punix/unix trying
> to mimic AF_U
On 28 July 2016 at 10:48, Joe Stringer wrote:
> Recent changes to the dump-conntrack command provide more info
> (type,code), but the system-ovn tests weren't updated for this.
> Update the tests.
>
> Signed-off-by: Joe Stringer
>
Acked-by: Gurucharan Shetty
> ---
> tests/system-ovn.at | 10
On 28 July 2016 at 11:37, Ben Pfaff wrote:
> On Wed, Jul 27, 2016 at 11:28:24AM -0700, Nimay Desai wrote:
> > Added an IPv4 and MAC addresses management system to ovn-northd. When a
> logical
> > switch's other_config:subnet field is set, logical ports attached to that
> > switch that have the ke
On 25 July 2016 at 17:04, Sairam Venugopal wrote:
> OVS_EVENT_ENTRY currently handles only Vport related events. Updating the
> name of the struct to OVS_VPORT_EVENT_ENTRY. Remove OVS_EVENT_STATUS since
> it's currently not in use. Update the datapath to refer to events as
> vportEvents. This wil
Thank you for the series. If I apply this series, 2 unit tests around
python fail on Linux. Please see whats going on.
On 26 July 2016 at 04:49, Paul Boca wrote:
> This series of patches ports the python damons to Windows and
> fixes the tests to work on Windows.
> There are still some python te
On 2 August 2016 at 10:23, Mickey Spiegel wrote:
> On Tue, Aug 2, 2016 at 9:26 AM, Darrell Ball wrote:
>
> >
> >
> > On Tue, Aug 2, 2016 at 4:52 AM, Russell Bryant wrote:
> >
> >> On Sat, Jul 30, 2016 at 4:19 PM, Mickey Spiegel
> >> wrote:
> >>
> >> > On Fri, Jul 29, 2016 at 10:28 AM, Mickey S
On 2 August 2016 at 12:01, Russell Bryant wrote:
>
> On Tue, Aug 2, 2016 at 1:29 PM, Guru Shetty wrote:
>
>> The 2 ct_commit for deletion of firewall rules will likely be tricky. This
>> will need unit tests.
>>
>
> I don't think I understand the conc
On 2 August 2016 at 12:27, Russell Bryant wrote:
>
>
> On Tue, Aug 2, 2016 at 3:17 PM, Guru Shetty wrote:
>
>>
>>
>> On 2 August 2016 at 12:01, Russell Bryant wrote:
>>
>>>
>>> On Tue, Aug 2, 2016 at 1:29 PM, Guru Shetty wrote:
>&g
On 2 August 2016 at 11:19, Alin Serdean
wrote:
> Currently in the case of command line arguments punix/unix, on Windows
> we create a file, write a TCP port number to connect. This is a security
> concern.
>
> This patch adds support for the command line arguments punix/unix trying
> to mimic AF_
On 2 August 2016 at 10:45, Paul Boca wrote:
> signal.alarm is not available in Windows and would trigger an exception
> when called. Implemented this to mentain compatibility between
> Windows and Linux for python tests.
>
> Signed-off-by: Paul-Daniel Boca
> Acked-by: Alin Gabriel Serdean
> ---
On 2 August 2016 at 10:45, Paul Boca wrote:
> SIGHUP and SIGALRM are not available on Windows.
>
> Signed-off-by: Paul-Daniel Boca
> Acked-by: Alin Gabriel Serdean
>
Applied.
> ---
> V2: Fixed Python function inet_open_active, treat WSAEWOULDBLOCK error as
> EINPROGRESS on Windows
> V3: N
On 1 August 2016 at 02:29, Paul Boca wrote:
> For bogus pid file path, use a windows-like file path.
>
> Signed-off-by: Paul-Daniel Boca
> Acked-by: Alin Gabriel Serdean
>
Applied.
> ---
> V2: No changes
> V3: No changes
> V4: No changes
> V5: No changes
> V6: No changes
> V7: No changes
> V8
On 2 August 2016 at 10:45, Paul Boca wrote:
> On Windows the CTL filename doesn't contain the pid of the process.
>
> Signed-off-by: Paul-Daniel Boca
> Acked-by: Alin Gabriel Serdean
> ---
> V2: No changes
> V3: No changes
> V4: No changes
> V5: No changes
> V6: No changes
> V7: Fixed flake8 er
On 2 August 2016 at 10:45, Paul Boca wrote:
> There is a difference between POSIX pid and Windows pid, not all the time
> are equal.
> On Windows when a python script is started, a sh command is triggered as
> the parent
> for script. So when we try to get the daemon pid with 'echo $!', this will
On 2 August 2016 at 10:45, Paul Boca wrote:
> On Windows if this exception is triggered then it will raise an exception
> while in the
> exception handler.
>
> Signed-off-by: Paul-Daniel Boca
> Acked-by: Alin Gabriel Serdean
>
I added the following incremental and applied this.
diff --git a/py
On 2 August 2016 at 10:45, Paul Boca wrote:
> AF_UNIX sockets are not supported on Windows.
> Instead of an AF_UNIX socket use localhost tcp connections to communicate
> between components. This makes the python sockets compatible with
> the ones used in Windows applications.
>
> In case the sock
On 2 August 2016 at 10:45, Paul Boca wrote:
> Renamed daemon.py to daemon_unix.py and implemented a wrapper over it.
>
> Signed-off-by: Paul-Daniel Boca
> Acked-by: Alin Gabriel Serdean
>
As a standalone commit, this likely fails because it
calls ovs.daemon_windows which does not exist. I also
On 2 August 2016 at 10:45, Paul Boca wrote:
> On Windows if a file is opened by an application for writing, we cannot
> move
> it until all handles to that file are closed.
>
> Signed-off-by: Paul-Daniel Boca
> Acked-by: Alin Gabriel Serdean
>
I skipped the patches till here (starting from the
On 7 June 2016 at 01:00, Paul Boca wrote:
> If an absolute path is given to --pidfile parameter (not containing ':')
> then the application name is used for PID file, ignoring the given name.
>
What is an example of absolute path that does not include ":"? Would that
be something like "/foo/bar/
>
>
>
> I am always a little nervous about putting things in schema that I know
> will change later,
> especially when it comes to the structure of the config.
>
> I am thinking of ovn-nb.ovsschema changes along the following lines:
>
> "Logical_Router": {
> "columns": {
>
On 8 June 2016 at 09:16, Amitabha Biswas wrote:
> Hi Brian,
>
> The each gateway router only has a single transit network attached to it,
> and each gateway router to connected to the common provider/external
> network as well. We can probably do away with the transit network if we use
> router p
"internal_ip"/"external_ip"?
>
I decided to use "logical_ip"/"external_ip". logical_ip feels like a good
term as I can easily associate it with logical_port.
>
> Mickey
>
> -Guru Shetty wrote: -
> To: Mickey Spiegel/San Jose/IBM@IBMUS
> Fr
On 2 June 2016 at 14:48, Ben Pfaff wrote:
> On Thu, May 19, 2016 at 01:02:34PM -0700, Gurucharan Shetty wrote:
> > For traffic from physical space to virtual space we need DNAT.
> > The DNAT happens in the gateway router and reaches the logical
> > port. The return traffic should be unDNATed.
> >
>
>
>
> All of these didn't appear to make the patchworks queue,
> so the following is an ack of the whole series - I've
> looked at all of them and they look good...
>
> Acked-by: Ryan Moats
>
> Thank you Ryan! I applied the series.
___
dev mailing list
> On Thu, Jun 9, 2016 at 11:06 AM, Guru Shetty wrote:
>
>> >
>> >
>> >
>> > All of these didn't appear to make the patchworks queue,
>> > so the following is an ack of the whole series - I've
>> > looked at all of them and they
On 9 June 2016 at 13:22, Russell Bryant wrote:
> A previous commit added this file to be checked by flake8, but the file
> failed a number of checks done by the 'hacking' flake8 plugin.
>
> Fixes: b00bdc728e7a ("automake: Add ovs-bugtool.in to flake8-check.")
> Signed-off-by: Russell Bryant
>
On 9 June 2016 at 13:27, Russell Bryant wrote:
> On Thu, Jun 9, 2016 at 4:20 PM, Guru Shetty wrote:
>
> > On 9 June 2016 at 13:14, Aaron Rosen wrote:
> >
> > > This patch seemed to break the build with some flake8 python3 errors
> for
> > >
On 11 June 2016 at 05:28, Brian Turek wrote:
> Signed-off-by: Brian Turek
>
Thank you for your contribution. How did you send this patch? I couldn't
apply it on my local tree using 'git am'. Sending it via 'git send-email'
usually gets it right.
The change in the patch itself is not much, so I
Hello Flavio,
It does exist in the archives:
http://openvswitch.org/pipermail/dev/2016-June/072565.html
Probably ended up in your spam folder?
Thanks,
Guru
On 13 June 2016 at 13:12, Flaviof wrote:
> Hi Guru,
>
> For some odd reason the v4 of your changes in patchwork [v4]
> does not seem to b
On 9 June 2016 at 00:37, Gurucharan Shetty wrote:
> For traffic from physical space to virtual space we need DNAT.
> The DNAT happens in the gateway router and reaches the logical
> port. The return traffic should be unDNATed.
>
> Traffic originating in virtual space heading to physical space
> s
1 - 100 of 345 matches
Mail list logo
