On 26 July 2016 at 10:19, Ben Pfaff <b...@ovn.org> wrote:

> On Wed, Jul 13, 2016 at 04:20:36AM -0700, Gurucharan Shetty wrote:
> > Signed-off-by: Gurucharan Shetty <g...@ovn.org>
> > ---
> >  ovn/northd/ovn-northd.c | 47
> ++++++++++++++---------------------------------
> >  1 file changed, 14 insertions(+), 33 deletions(-)
> >
> > diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
> > index b1c2c6c..52e3229 100644
> > --- a/ovn/northd/ovn-northd.c
> > +++ b/ovn/northd/ovn-northd.c
> > @@ -2330,27 +2330,30 @@ build_lrouter_flows(struct hmap *datapaths,
> struct hmap *ports,
> >                            ds_cstr(&match), ds_cstr(&actions));
> >          }
> >
> > -        /* ARP handling for external IP addresses.
> > -         *
> > -         * DNAT IP addresses are external IP addresses that need ARP
> > -         * handling. */
> > +        ovs_be32 *nat_ips = xmalloc(sizeof *nat_ips *
> op->od->nbr->n_nat);
> > +        size_t n_snat_ips = 0;
>
> The code might be a little clearer with s/nat_ips/snat_ips/, to match
> the name of n_snat_ips.
>

Thanks, I made the change as suggested and applied this.


>
> Acked-by: Ben Pfaff <b...@ovn.org>
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to