On 7 June 2016 at 01:00, Paul Boca <pb...@cloudbasesolutions.com> wrote:
> If an absolute path is given to --pidfile parameter (not containing ':')
> then the application name is used for PID file, ignoring the given name.
>
What is an example of absolute path that does not include ":"? Would that
be something like "/foo/bar/name.pid"? If so, doesn't your patch return
something like "/var/run/openvswitch/foo/bar/name.pid" ? That looks wrong
to me.
>
> Signed-off-by: Paul-Daniel Boca <pb...@cloudbasesolutions.com>
> ---
> V2: Updated commit message
> ---
> lib/daemon-windows.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/lib/daemon-windows.c b/lib/daemon-windows.c
> index ac71aa1..8cf0fea 100644
> --- a/lib/daemon-windows.c
> +++ b/lib/daemon-windows.c
> @@ -485,8 +485,12 @@ daemon_become_new_user(bool access_datapath
> OVS_UNUSED)
> char *
> make_pidfile_name(const char *name)
> {
> - if (name && strchr(name, ':')) {
> - return xstrdup(name);
> + if (name) {
> + if (strchr(name, ':')) {
> + return xstrdup(name);
> + } else {
> + return xasprintf("%s/%s", ovs_rundir(), name);
> + }
> } else {
> return xasprintf("%s/%s.pid", ovs_rundir(), program_name);
> }
> --
> 2.7.2.windows.1
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
