On 13 July 2016 at 07:49, Alin Serdean <aserd...@cloudbasesolutions.com> wrote:
> > -----Mesaj original----- > > De la: Paul Boca > > Trimis: Wednesday, July 13, 2016 11:24 AM > > Către: Alin Serdean <aserd...@cloudbasesolutions.com>; > > dev@openvswitch.org > > Subiect: RE: [ovs-dev] [PATCH V6 12/17] python tests: Ported Python > > daemon to Windows > > > > Hi Alin, > > > > It was easier for me to call Windows APIs from python, that mimics > > detach_process, and to be in a better control on what's happening, than > > creating a *DLL and loading it in order to call this function. > > *On Windows the LIB file cannot be loaded as-is; a DLL with entry point > > needs to be created, allowing the ntdll loader to resolve the imported > > functions. > [Alin Gabriel Serdean: ] I understand the concern but we can deal with > that pretty easily from the build system. > I understand the reasoning behind it, but in my opinion it seems we are > duplicating the effort and in case of problems it will mean another codebase > to maintain. > Adding Ben and Guru to the thread extra opinions are always welcomed :). > I think so far we have tried to keep Python code independent of OVS C libraries. My opinion is that we keep the problem space limited with this patch series ( and if there is time on anyone's hand, try and work on what Alin is suggesting to see whether it fits well with all the linux packaging and build system variations.) So far, python daemonization code hasn't seen any bugs for a few years on Linux, so I don't think there will be a lot of maintenance burden. The windows ones probably will start with some bugs.. > > > > I don't say it isn't doable, but this seemed to be the right solution > for this. > > Also, creating a DLL loaded by python would add a dependency between > > python and C components. > > > > Regarding the *unix side, maybe a Linux guy can add his opinion about > this. > > > > Thanks, > > Paul > > > > > -----Original Message----- > > > From: Alin Serdean > > > Sent: Tuesday, July 12, 2016 10:54 PM > > > To: Paul Boca; dev@openvswitch.org > > > Subject: RE: [ovs-dev] [PATCH V6 12/17] python tests: Ported Python > > > daemon to Windows > > > > > > I am wondering if it is better if we could just import the shared > > > library and call the detach function > > > (https://github.com/openvswitch/ovs/blob/master/lib/daemon- > > > windows.c#L342) instead of duplicating the effort. > > > > > > I wonder if the same could be applied un the *unix side as well. > > > > > > Thanks, > > > Alin. > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
