Hi Nithin,
I have only one minor comment. Please see inline.
Other than that, looks good to me.
Acked-by: Sorin Vinturis
Thanks,
Sorin
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Nithin Raju
Sent: Friday, 21 November, 2014 02:28
To: dev@openvswitch.o
Acked-by: Sorin Vinturis
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Nithin Raju
Sent: Friday, 21 November, 2014 02:52
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH] datapath-windows: move vport code from Datapath.c to
Vport.c
Plain code motion. No
Hi Ben,
Thank you for reviewing the patch.
>"sparse" reported these warnings:
All the sparse warnings have been resolved
>The config field in a table description is a collection of bit-fields,
>but some of this code, such as ofp_print_table_config() and
>ofputil_append_table_desc_reply(), treat
undefined
=-=-=
Notice: The information contained in this e-mail
message and/or attachments to it may contain
confidential or privileged information. If you are
not the intended recipient, any dissemination, use,
review, distribution, printing or copying of the
information c
undefined
=-=-=
Notice: The information contained in this e-mail
message and/or attachments to it may contain
confidential or privileged information. If you are
not the intended recipient, any dissemination, use,
review, distribution, printing or copying of the
information c
Hi Team,
Please ignore previous mail for the patch " [ovs-dev] [PATCH] ovs-ofctl:
Implementation of eviction on the basis of Importance" containing text
"undefined".
Due to some mail server problem, the patch was not sent correctly.
We will resend the patch from "rishi.ba...@tcs.com" mail-id.
From: Saloni Jain
This commit enables the eviction mechanism on the basis of importance as
per the openflow specification 1.4.
ovs-ofctl -O OpenFlow14 mod-table evict
-Enable eviction on of . Eviction adds a mechanism
enabling the switch to automatically eliminate entries of lower
i
LGTM,
Acked-by: Jarno Rajahalme
Thanks,
Jarno
> On Nov 20, 2014, at 4:37 PM, Alex Wang wrote:
>
> On current master, the exact match cache entry can keep reference to
> 'struct dp_netdev_flow' even after the flow is removed from the flow
> table. This means the free of allocated memory o
Thx applied to master~
On Fri, Nov 21, 2014 at 7:48 AM, Jarno Rajahalme
wrote:
> LGTM,
>
> Acked-by: Jarno Rajahalme
>
> Thanks,
>
> Jarno
>
>
> > On Nov 20, 2014, at 4:37 PM, Alex Wang wrote:
> >
> > On current master, the exact match cache entry can keep reference to
> > 'struct dp_netdev_
In a hybrid forwarding environment, there are two types of packets that
enter and leave the Hyper-V extensible switch: NVGRE packets and non-NVGRE
packets. Hybrid forwarding involves filtering the incoming traffic based
on packet type.
Thus, we must split the incoming traffic into NVGRE and non-NV
Hi Sorin,
This change applies only for 6.40 drivers. Unless we bump the driver version
this code has no effect.
You may want to bump the minor version.
#define NDIS_FILTER_MAJOR_VERSION 6
#define NDIS_FILTER_MINOR_VERSION 30 < 40
driverChars.MajorNdisVersion = NDIS_FILTER_MAJOR_
On Thu, Nov 20, 2014 at 10:11:46PM -0800, Alex Wang wrote:
> This commit adds check in cmap_remove() and shrinks the cmap by half
> if the load factor is below 20%. This is to reduce the memory
> utilization of cmap and to avoid the allocated cmap memory occupying
> the top of heap memory, prevent
The driver completes a pending IRP, the IRP is being marked free by the
I/O manager which causes a system crash when the IRP is completed at
the second time.
The driver should not complete a pending IRP in the context of the
Device I/O control thread.
*** Fatal System Error: 0x0044
On Nov 21, 2014, at 8:23 AM, Eitan Eliahu
wrote:
> Hi Sorin,
> This change applies only for 6.40 drivers. Unless we bump the driver version
> this code has no effect.
> You may want to bump the minor version.
>
> #define NDIS_FILTER_MAJOR_VERSION 6
> #define NDIS_FILTER_MINOR_VERSION 30 <
The pid must be set in the NL header as the driver checks it against the pid in
the instance paired with the socket.
Signed-off-by: Eitan Eliahu
---
lib/netlink-socket.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/netlink-socket.c b/lib/netlink-socket.c
index d46c831..2e02c43 100644
On Thu, Nov 20, 2014 at 4:33 PM, Joe Stringer wrote:
> On 19 November 2014 15:34, Pravin Shelar wrote:
>> On Thu, Nov 13, 2014 at 11:17 AM, Joe Stringer
>> wrote:
>>> @@ -684,33 +691,43 @@ static size_t ovs_flow_cmd_msg_size(const struct
>>> sw_flow_actions *acts)
>>>
>>> /* Called with ovs_m
On Nov 21, 2014, at 5:34 PM, Eitan Eliahu
wrote:
> The pid must be set in the NL header as the driver checks it against the pid
> in
> the instance paired with the socket.
>
> Signed-off-by: Eitan Eliahu
Acked-by: Nithin Raju
___
dev mailing list
On Thu, Nov 20, 2014 at 4:15 PM, Joe Stringer wrote:
> On 13 November 2014 11:17, Joe Stringer wrote:
>> This function previously hid the 'is_mask' parameter from the callers,
>> which actually have better knowledge about whether it is serializing a
>> mask or not. Expose this parameter to the ca
On Nov 21, 2014, at 4:58 PM, Eitan Eliahu
wrote:
> +/* Should not complete a pending IRP unless proceesing is completed */
> +if (status == STATUS_PENDING) {
> +return status;
> +}
> return OvsCompleteIrpRequest(irp, (ULONG_PTR)replyLen, status);
> }
Acked-by: Nithin Raj
This commit conducts similar operations as commit 2fd84d5e5
(rhel: Include pkgconfig and update header install in
Fedora/RHEL spec.) to xenserver spec file to prevent the
following rpmbuild failure.
RPM build errors:
Installed (but unpackaged) file(s) found:
/usr/include/openfl
On Nov 21, 2014, at 1:07 AM, Sorin Vinturis
wrote:
> Hi Nithin,
>
> I have only one minor comment. Please see inline.
> Other than that, looks good to me.
>
> Acked-by: Sorin Vinturis
Thanks again for your patient review. I've sent out a v3.
Thanks,
-- Nithin
__
Thx!, applied to master,
On Fri, Nov 21, 2014 at 8:36 AM, Ben Pfaff wrote:
> On Thu, Nov 20, 2014 at 10:11:46PM -0800, Alex Wang wrote:
> > This commit adds check in cmap_remove() and shrinks the cmap by half
> > if the load factor is below 20%. This is to reduce the memory
> > utilization of c
On Fri, Nov 21, 2014 at 11:06 AM, Alex Wang wrote:
> This commit conducts similar operations as commit 2fd84d5e5
> (rhel: Include pkgconfig and update header install in
> Fedora/RHEL spec.) to xenserver spec file to prevent the
> following rpmbuild failure.
>
> RPM build errors:
>Install
On Fri, Nov 21, 2014 at 11:10 AM, Gurucharan Shetty
wrote:
> Acked-by: Gurucharan Shetty
>
Thx for the review,
I have tested it,
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
The test case current fails and shows a bug when OF1.4 is used between
the controller and the switch, the packet-in message still uses OF1.3
wire protocol version.
Signed-off-by: Shu Shen
---
tests/ofproto-dpif.at | 44
1 file changed, 44 insertions(+
Previously even when OF1.4 is used between the controller and the
switch, packet-in messages has OF1.3 as wire protocol version.
Signed-off-by: Shu Shen
---
lib/ofp-msgs.h | 2 +-
lib/ofp-util.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/ofp-msgs.h b/lib/ofp-msg
From: Joe Stringer
Date: Wed, 19 Nov 2014 13:54:49 -0800
> When userspace doesn't provide a mask, OVS datapath generates a fully
> unwildcarded mask for the flow by copying the flow and setting all bits
> in all fields. For IPv6 label, this creates a mask that matches on the
> upper 12 bits, caus
Jarno, do you have time to look at this?
On 13 November 2014 11:17, Joe Stringer wrote:
> This patch adds a new 'ovs-appctl revalidator/purge' command which
> flushes all flows from all datapaths, and updates the revalidator
> udpif_key cache at the same time.
>
> Update the ofproto-dpif fragment
Looks good to me,
Jarno
Acked-by: Jarno Rajahalme
> On Nov 21, 2014, at 12:52 PM, Joe Stringer wrote:
>
> Jarno, do you have time to look at this?
>
>> On 13 November 2014 11:17, Joe Stringer wrote:
>> This patch adds a new 'ovs-appctl revalidator/purge' command which
>> flushes all flows
Hi all,
No need to change any macro regarding minor version. In ndis.h header we have
the following:
#if (defined(NDIS640))
#define NDIS_FILTER_MAJOR_VERSION 6
#define NDIS_FILTER_MINOR_VERSION 40
I have set the preprocessor macro NDIS640=1 in the project properties, so the
NDIS_FILTER_MINOR_V
Hi Sorin,
Thanks for explaining that. Do we need to have a new VS project (and driver
name) for 6.40 driver?
Eitan
-Original Message-
From: Sorin Vinturis [mailto:svintu...@cloudbasesolutions.com]
Sent: Friday, November 21, 2014 1:21 PM
To: Nithin Raju; Eitan Eliahu
Cc: dev@openvswitch.o
Jarno, Can you review this patch?
On Wed, Nov 19, 2014 at 10:12 PM, Pravin B Shelar wrote:
> ovs-dpctl crashed due to uninitialized router classifier. To
> fix this issue move ovs router initialization to route table
> module.
>
> Reported-by: Madhu Challa
> Signed-off-by: Pravin B Shelar
> ---
Jarno, Can you review this patch?
Thanks.
On Thu, Nov 13, 2014 at 3:03 PM, Pravin B Shelar wrote:
> odp_execute_actions() already handles hash execution part.
>
> Signed-off-by: Pravin B Shelar
> ---
> lib/dpif-netdev.c | 29 +
> 1 files changed, 1 insertions(+),
Hi Eitan,
We already have defined in VS build configurations for Windows 8 Debug/Release
and Windows 8.1 Debug/Release, which will create the corresponding NDIS driver,
6.30 or 6.40. There is no need to change the driver name. Both versions will be
in its corresponding directory, Win8Release or
Where/how are user actions translated to actions that kernel understands?
Looking at datapath/actions.c, it seems the kernel only understands
OVS_ACTION_ATTR_* from netlink messages.
At the userside it seems that ofproto-dpif-xlate.c:xlate_actions__()
looks for the rule by calling rule_dpif_l
Nithin, I will send a v2 patch to with the necessary conditional code. Thanks!
From: nithinrajub [mailto:notificati...@github.com]
Sent: Friday, 21 November, 2014 23:54
To: openvswitch/ovs-issues
Cc: Sorin Vinturis
Subject: Re: [ovs-issues] Account for hybrid networking in the OVS Hyper-V
switch
On Mon, Nov 17, 2014 at 04:38:27PM +0100, Jonathan Dupart wrote:
> Hi,
>
> I have been bittend by this bug.
>
> I am raising this bug severity to grave, as it renders openvswitch
> unusable after upgrading to the last stable kernel.
>
> I tested the patch and it works flawlessly. It should be qu
Acked-by: Jarno Rajahalme
With a small nit below,
Jarno
On Nov 19, 2014, at 10:12 PM, Pravin B Shelar wrote:
> ovs-dpctl crashed due to uninitialized router classifier. To
> fix this issue move ovs router initialization to route table
> module.
>
> Reported-by: Madhu Challa
> Signed-off-
Acked-by: Jarno Rajahalme
On Nov 13, 2014, at 3:03 PM, Pravin B Shelar wrote:
> odp_execute_actions() already handles hash execution part.
>
> Signed-off-by: Pravin B Shelar
> ---
> lib/dpif-netdev.c | 29 +
> 1 files changed, 1 insertions(+), 28 deletions(-)
>
>
OpenFlow actions are initially translated by ofproto-dpif-xlate functions. The
kernel actions are generated by the various commit_* functions in
lib/odp-util.c, called by the xlate functions.
Regards,
Jarno
On Nov 21, 2014, at 2:00 PM, Masoud Moshref Javadi wrote:
> Where/how are user acti
On Wed, Nov 19, 2014 at 12:17:53PM +0900, YAMAMOTO Takashi wrote:
> > On Wed, Nov 19, 2014 at 11:53:53AM +0900, YAMAMOTO Takashi wrote:
> >> hi,
> >>
> >> > I am unsure of the reason for escaping '-' inside of control
> >> > sequences but regardless this patch makes the group documentation
> >> >
Pravin,
Would you mind reviewing this?
Jarno
On Nov 20, 2014, at 2:13 PM, Jarno Rajahalme wrote:
> Using the '-march=native' broke this test in a i7 laptop, most likely
> due to a different hash implementation, which resulted in different
> datapath port number assignment accross different c
On Thu, Aug 28, 2014 at 6:49 AM, Alin Serdean
wrote:
> This commit adds to the automake build system the full build required
> by the forwarding extension solution.
>
> It will help a lot in the future CI to check the full build of the project.
>
> To configure the forwarding extension to be built
In a hybrid forwarding environment, there are two types of packets that
enter and leave the Hyper-V extensible switch: NVGRE packets and non-NVGRE
packets. Hybrid forwarding involves filtering the incoming traffic based
on packet type.
Thus, we must split the incoming traffic into NVGRE and non-NV
On Fri, Nov 21, 2014 at 04:58:54PM -0800, Eitan Eliahu wrote:
> The driver completes a pending IRP, the IRP is being marked free by the
> I/O manager which causes a system crash when the IRP is completed at
> the second time.
> The driver should not complete a pending IRP in the context of the
> De
On Thu, Nov 20, 2014 at 2:13 PM, Jarno Rajahalme wrote:
> Using the '-march=native' broke this test in a i7 laptop, most likely
> due to a different hash implementation, which resulted in different
> datapath port number assignment accross different compilations.
>
> Break up the ports setup so th
On Fri, Nov 21, 2014 at 05:34:56PM -0800, Eitan Eliahu wrote:
> The pid must be set in the NL header as the driver checks it against the pid
> in
> the instance paired with the socket.
>
> Signed-off-by: Eitan Eliahu
Thanks, applied!
___
dev mailing l
On Nov 21, 2014, at 3:22 PM, Pravin Shelar wrote:
> On Thu, Nov 20, 2014 at 2:13 PM, Jarno Rajahalme
> wrote:
>> Using the '-march=native' broke this test in a i7 laptop, most likely
>> due to a different hash implementation, which resulted in different
>> datapath port number assignment accro
The check shall use wire protool reasons, which could be different from
the internal packet-in reason.
Signed-off-by: Shu Shen
---
ofproto/connmgr.c | 2 +-
tests/ofproto-dpif.at | 62 +++
2 files changed, 63 insertions(+), 1 deletion(-)
diff
Hi,
I'd like to withdraw the previous submission. I'm trying to improve it by
splitting into smaller commits.
Please see the first few patches that add tests and fix current bugs related to
Packet-In:
- [ovs-dev] [PATCH 1/2] ofproto-dpif: add test case for OF1.4 packet-in,
http://openvswitch.o
Thanks, pushed to master.
On 21 November 2014 13:05, Jarno Rajahalme wrote:
> Looks good to me,
>
> Jarno
>
> Acked-by: Jarno Rajahalme
>
>> On Nov 21, 2014, at 12:52 PM, Joe Stringer wrote:
>>
>> Jarno, do you have time to look at this?
>>
>>> On 13 November 2014 11:17, Joe Stringer wrote:
51 matches
Mail list logo
