Hi Eitan, We already have defined in VS build configurations for Windows 8 Debug/Release and Windows 8.1 Debug/Release, which will create the corresponding NDIS driver, 6.30 or 6.40. There is no need to change the driver name. Both versions will be in its corresponding directory, Win8Release or Win8.1Release, and the installed will be configured to install the correct driver, depending on the OS version.
Regarding driver certification process, we will submit a driver package containing the driver file, install file and catalog file for each OS version we want to certify the OVS driver for. -Sorin -----Original Message----- From: Eitan Eliahu [mailto:elia...@vmware.com] Sent: Friday, 21 November, 2014 23:29 To: Sorin Vinturis; Nithin Raju Cc: dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH] datapath-windows: Support for hybrid forwarding Hi Sorin, Thanks for explaining that. Do we need to have a new VS project (and driver name) for 6.40 driver? Eitan -----Original Message----- From: Sorin Vinturis [mailto:svintu...@cloudbasesolutions.com] Sent: Friday, November 21, 2014 1:21 PM To: Nithin Raju; Eitan Eliahu Cc: dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH] datapath-windows: Support for hybrid forwarding Hi all, No need to change any macro regarding minor version. In ndis.h header we have the following: #if (defined(NDIS640)) #define NDIS_FILTER_MAJOR_VERSION 6 #define NDIS_FILTER_MINOR_VERSION 40 I have set the preprocessor macro NDIS640=1 in the project properties, so the NDIS_FILTER_MINOR_VERSION macro is 40. Also, the NDIS_SUPPORT_NDIS640 macro is set to 1 by the same NDIS640 definition. If the NDIS_SUPPORT_NDIS640 define didn't exist the code won't compile. And it does correctly compile. Thanks, Sorin -----Original Message----- From: Nithin Raju [mailto:nit...@vmware.com] Sent: Friday, 21 November, 2014 19:22 To: Eitan Eliahu Cc: Sorin Vinturis; dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] datapath-windows: Support for hybrid forwarding On Nov 21, 2014, at 8:23 AM, Eitan Eliahu <elia...@vmware.com> wrote: > Hi Sorin, > This change applies only for 6.40 drivers. Unless we bump the driver version > this code has no effect. > You may want to bump the minor version. > > #define NDIS_FILTER_MAJOR_VERSION 6 > #define NDIS_FILTER_MINOR_VERSION 30 <------------ 40 > > driverChars.MajorNdisVersion = NDIS_FILTER_MAJOR_VERSION; > driverChars.MinorNdisVersion = NDIS_FILTER_MINOR_VERSION; +1 to that. Also, we should use the following macro around the new code being added. Also, when we bump up the version, we should use the macro. #if (NDIS_SUPPORT_NDIS640) #endif Thanks for the patch Sorin! I'll review it once the macros are added to make the code conditional. -- Nithin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
