On Thu, Nov 20, 2014 at 4:15 PM, Joe Stringer <[email protected]> wrote: > On 13 November 2014 11:17, Joe Stringer <[email protected]> wrote: >> This function previously hid the 'is_mask' parameter from the callers, >> which actually have better knowledge about whether it is serializing a >> mask or not. Expose this parameter to the callers. This allows the same >> function to be called to serialize masked keys as well as masked keys. >> >> To serialize an unmasked key: >> ovs_nla_put_flow(key, key, skb, false); >> >> To serialize a masked key: >> ovs_nla_put_flow(mask, key, skb, false); >> >> To serialize a mask: >> ovs_nla_put_flow(key, mask, skb, true); > > I'll add helpers for each of these functions: > ovs_nla_put_{un,}masked_key(), ovs_nla_put_mask() in the next version.
sounds good to me. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
