Jarno, Can you review this patch?
Thanks.
On Thu, Nov 13, 2014 at 3:03 PM, Pravin B Shelar <pshe...@nicira.com> wrote:
> odp_execute_actions() already handles hash execution part.
>
> Signed-off-by: Pravin B Shelar <pshe...@nicira.com>
> ---
> lib/dpif-netdev.c | 29 +----------------------------
> 1 files changed, 1 insertions(+), 28 deletions(-)
>
> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
> index 65df19b..2afe71d 100644
> --- a/lib/dpif-netdev.c
> +++ b/lib/dpif-netdev.c
> @@ -3111,34 +3111,6 @@ dp_execute_cb(void *aux_, struct dpif_packet
> **packets, int cnt,
> }
> break;
>
> - case OVS_ACTION_ATTR_HASH: {
> - const struct ovs_action_hash *hash_act;
> - uint32_t hash;
> -
> - hash_act = nl_attr_get(a);
> -
> - for (i = 0; i < cnt; i++) {
> -
> - if (hash_act->hash_alg == OVS_HASH_ALG_L4) {
> - /* Hash need not be symmetric, nor does it need to include
> - * L2 fields. */
> - hash = hash_2words(dpif_packet_get_dp_hash(packets[i]),
> - hash_act->hash_basis);
> - } else {
> - VLOG_WARN("Unknown hash algorithm specified "
> - "for the hash action.");
> - hash = 2;
> - }
> -
> - if (!hash) {
> - hash = 1; /* 0 is not valid */
> - }
> -
> - dpif_packet_set_dp_hash(packets[i], hash);
> - }
> - return;
> - }
> -
> case OVS_ACTION_ATTR_RECIRC:
> if (*depth < MAX_RECIRC_DEPTH) {
>
> @@ -3171,6 +3143,7 @@ dp_execute_cb(void *aux_, struct dpif_packet **packets,
> int cnt,
> case OVS_ACTION_ATTR_SET:
> case OVS_ACTION_ATTR_SET_MASKED:
> case OVS_ACTION_ATTR_SAMPLE:
> + case OVS_ACTION_ATTR_HASH:
> case OVS_ACTION_ATTR_UNSPEC:
> case __OVS_ACTION_ATTR_MAX:
> OVS_NOT_REACHED();
> --
> 1.7.1
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
