Hi all, No need to change any macro regarding minor version. In ndis.h header we have the following:
#if (defined(NDIS640)) #define NDIS_FILTER_MAJOR_VERSION 6 #define NDIS_FILTER_MINOR_VERSION 40 I have set the preprocessor macro NDIS640=1 in the project properties, so the NDIS_FILTER_MINOR_VERSION macro is 40. Also, the NDIS_SUPPORT_NDIS640 macro is set to 1 by the same NDIS640 definition. If the NDIS_SUPPORT_NDIS640 define didn't exist the code won't compile. And it does correctly compile. Thanks, Sorin -----Original Message----- From: Nithin Raju [mailto:nit...@vmware.com] Sent: Friday, 21 November, 2014 19:22 To: Eitan Eliahu Cc: Sorin Vinturis; dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] datapath-windows: Support for hybrid forwarding On Nov 21, 2014, at 8:23 AM, Eitan Eliahu <elia...@vmware.com> wrote: > Hi Sorin, > This change applies only for 6.40 drivers. Unless we bump the driver version > this code has no effect. > You may want to bump the minor version. > > #define NDIS_FILTER_MAJOR_VERSION 6 > #define NDIS_FILTER_MINOR_VERSION 30 <------------ 40 > > driverChars.MajorNdisVersion = NDIS_FILTER_MAJOR_VERSION; > driverChars.MinorNdisVersion = NDIS_FILTER_MINOR_VERSION; +1 to that. Also, we should use the following macro around the new code being added. Also, when we bump up the version, we should use the macro. #if (NDIS_SUPPORT_NDIS640) #endif Thanks for the patch Sorin! I'll review it once the macros are added to make the code conditional. -- Nithin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
