On Mon, Oct 31, 2016 at 1:30 PM, Justin Pettit wrote:
>
>> On Oct 31, 2016, at 6:10 AM, Richard Theis wrote:
>>
>> > So, it turns out my fix does not introduce any new problems. I have
>> > just posted
>> > it, so consider if you want to wait to apply it before releasing.
>>
>> Just checking on t
On Tue, Nov 1, 2016 at 11:41 AM, Joe Stringer wrote:
> On 1 November 2016 at 11:35, Pravin B Shelar wrote:
>> The compat vlan code ignores vlan tag for inner packet
>> on egress path. Following patch fixes this by inserting the
>> tag for inner packet before tunnel encapsulation.
>>
>> Signed-off
On Tue, Nov 1, 2016 at 11:06 AM, Joe Stringer wrote:
> On 1 November 2016 at 10:48, Pravin Shelar wrote:
>> On Tue, Nov 1, 2016 at 10:30 AM, Joe Stringer wrote:
>>> On 31 October 2016 at 22:00, Pravin B Shelar wrote:
>>>> The compat vlan code ignores vlan tag f
On Tue, Nov 1, 2016 at 10:30 AM, Joe Stringer wrote:
> On 31 October 2016 at 22:00, Pravin B Shelar wrote:
>> The compat vlan code ignores vlan tag for inner packet
>> on egress path. Following patch fixes this by inserting the
>> tag for inner packet before tunnel encapsulation.
>>
>> Signed-off
On Mon, Oct 31, 2016 at 5:24 PM, Joe Stringer wrote:
> On 31 October 2016 at 14:36, Pravin B Shelar wrote:
>> Upstream commit:
>> commit c6fcc4fc5f8b592600c7409e769ab68da0fb1eca
>> Author: pravin shelar
>> Date: Fri Oct 28 09:59:15 2016 -0700
>>
On Mon, Oct 31, 2016 at 2:05 PM, Joe Stringer wrote:
> On 29 October 2016 at 21:33, Pravin B Shelar wrote:
>> Upstream commit:
>> commit c6fcc4fc5f8b592600c7409e769ab68da0fb1eca
>> Author: pravin shelar
>> Date: Fri Oct 28 09:59:15 2016 -0700
>>
On Mon, Oct 31, 2016 at 9:57 AM, Justin Pettit wrote:
>
>> On Oct 18, 2016, at 10:14 PM, Pravin Shelar wrote:
>>
>> On Tue, Oct 18, 2016 at 8:35 AM, Justin Pettit wrote:
>>>
>>>> On Oct 18, 2016, at 5:31 PM, Russell Bryant wrote:
>>>>
>&
On Wed, Oct 26, 2016 at 2:55 AM, Thadeu Lima de Souza Cascardo
wrote:
> On Tue, Oct 25, 2016 at 08:21:55PM -0700, Pravin Shelar wrote:
>> > The fallback option should already work, then. We can make sure during
>> > testing
>> > that is the case, so there would be
On Tue, Oct 25, 2016 at 11:00 AM, Thadeu Lima de Souza Cascardo
wrote:
> On Thu, Oct 20, 2016 at 10:30:41AM -0700, Pravin Shelar wrote:
>> On Tue, Sep 20, 2016 at 7:01 AM, Thadeu Lima de Souza Cascardo
>> wrote:
>> > In order to use rtnetlink to create new tunne
On Fri, Oct 21, 2016 at 11:39 AM, Joe Stringer wrote:
> On 21 October 2016 at 11:37, Joe Stringer wrote:
>> On 21 October 2016 at 10:55, Pravin B Shelar wrote:
>>> On upstream kernel datapath OVS make use of networking devices
>>> where networking stack does check if device is UP. following
>>>
On Fri, Oct 21, 2016 at 11:37 AM, Joe Stringer wrote:
> On 21 October 2016 at 10:55, Pravin B Shelar wrote:
>> On upstream kernel datapath OVS make use of networking devices
>> where networking stack does check if device is UP. following
>> patch adds same check in case of compat tunneling implem
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote:
> Allow ARPHRD_NONE interfaces to be added to ovs bridge.
>
> Based on previous versions by Lorand Jakab and Simon Horman.
>
> Signed-off-by: Lorand Jakab
> Signed-off-by: Simon Horman
> Signed-off-by: Jiri Benc
Acked-by: Pravin B Shelar
_
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote:
> It's not allowed to push Ethernet header in front of another Ethernet
> header.
>
> It's not allowed to pop Ethernet header if there's a vlan tag. This
> preserves the invariant that L3 packet never has a vlan tag.
>
> Based on previous versions
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote:
> Extend the ovs flow netlink protocol to support L3 packets. Packets without
> OVS_KEY_ATTR_ETHERNET attribute specify L3 packets; for those, the
> OVS_KEY_ATTR_ETHERTYPE attribute is mandatory.
>
> Push/pop vlan actions are only supported for Eth
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote:
> Support receiving, extracting flow key and sending of L3 packets (packets
> without an Ethernet header).
>
> Note that even after this patch, non-Ethernet interfaces are still not
> allowed to be added to bridges. Similarly, netlink interface for
On Thu, Oct 20, 2016 at 6:49 PM, Joe Stringer wrote:
> On 19 October 2016 at 11:27, Pravin B Shelar wrote:
>> On upstream kernel datapath OVS make use of networking devices
>> where networking stack does check if device is UP. following
>> patch adds same check in case of compat tunneling impleme
On Tue, Oct 18, 2016 at 5:01 PM, Jarno Rajahalme wrote:
> Port upstream change in conntrack labels extension. Add a new
> configure macro HAVE_NF_CONN_LABELS_WITH_WORDS to detect the old
> definition. Unfortunately there is no conntrack API to hide the
> difference, so the this makes conntrack.c
On Tue, Oct 18, 2016 at 5:01 PM, Jarno Rajahalme wrote:
> Datapath should now compile and work with Linux 4.8.
>
> Signed-off-by: Jarno Rajahalme
Acked-by: Pravin B Shelar
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo
On Wed, Oct 19, 2016 at 9:52 AM, Jiri Benc wrote:
> On Tue, 18 Oct 2016 22:13:45 -0700, Pravin Shelar wrote:
>> On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote:
>> > - skb_reset_network_header(skb);
>> > + skb->protocol = parse_ethertype(s
On Tue, Sep 20, 2016 at 7:01 AM, Thadeu Lima de Souza Cascardo
wrote:
> In order to use rtnetlink to create new tunnel vports, the backported
> tunnels require some code that was removed from their upstream version,
> mainly the necessary code for newlink and for start_xmit.
>
> This patch adds ba
On Fri, Oct 14, 2016 at 7:12 AM, Thadeu Lima de Souza Cascardo
wrote:
> There were leaks on netdev_close references. Whenever an address was removed
> from an interface, it was possible that a race would make the netlink message
> be
> processed and no address be found on the interface, causing i
On Wed, Oct 19, 2016 at 2:26 AM, Jiri Benc wrote:
> ovs_vport_deferred_free is not used anywhere. It's the only caller of
> free_vport_rcu thus this one can be removed, too.
>
> Signed-off-by: Jiri Benc
Acked-by: Pravin B Shelar
___
dev mailing list
d
On Wed, Oct 19, 2016 at 2:26 AM, Jiri Benc wrote:
> Some symbols exported to other modules are really used only by
> openvswitch.ko. Remove the exports.
>
> Tested by loading all 4 openvswitch modules, nothing breaks.
>
> Signed-off-by: Jiri Benc
Acked-by: Pravin B Shelar
__
On Tue, Oct 18, 2016 at 8:35 AM, Justin Pettit wrote:
>
>> On Oct 18, 2016, at 5:31 PM, Russell Bryant wrote:
>>
>>> On Tue, Oct 18, 2016 at 4:54 AM, Justin Pettit wrote:
>>> > On Oct 17, 2016, at 5:54 PM, Ben Pfaff wrote:
>>> >
>>> >> On Mon, Oct 17, 2016 at 09:14:33AM -0400, Russell Bryant wr
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote:
> On tx, use hard_header_len while deciding whether to refragment or drop the
> packet. That way, all combinations are calculated correctly:
>
> * L2 packet going to L2 interface (the L2 header len is subtracted),
> * L2 packet going to L3 interfac
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote:
> From: Simon Horman
>
> This allows GRE tunnels to send and receive both
> layer 2 packets (packets with an ethernet header) and
> layer 3 packets (packets without an ethernet header).
>
> Signed-off-by: Simon Horman
> Signed-off-by: Jiri Benc
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote:
> Support receiving, extracting flow key and sending of L3 packets (packets
> without an Ethernet header).
>
> Note that even after this patch, non-Ethernet interfaces are still not
> allowed to be added to bridges. Similarly, netlink interface for
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote:
> We'll need it to alter packets sent to ARPHRD_NONE interfaces.
>
> Change do_output() to use the actual L2 header size of the packet when
> deciding on the minimum cutlen. The assumption here is that what matters is
> not the output interface har
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote:
> Use a hole in the structure. We support only Ethernet so far and will add
> a support for L2-less packets shortly. We could use a bool to indicate
> whether the Ethernet header is present or not but the approach with the
> mac_proto field is more
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote:
> At the core of this patch set is removing the assumption in Open vSwitch
> datapath that all packets have Ethernet header. Support for layer 3 GRE
> tunnels is also added by this patchset.
>
> The implementation relies on the presence of pop_eth
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote:
> Update Ethernet header only if there is one.
>
> Signed-off-by: Jiri Benc
Acked-by: Pravin B Shelar
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Oct 18, 2016 at 4:47 AM, Jiri Benc wrote:
> Many symbols exported to other modules are really used only by
> openvswitch.ko. Remove the exports.
>
> Tested by loading all 4 openvswitch modules, nothing breaks.
>
> Signed-off-by: Jiri Benc
> ---
> net/openvswitch/datapath.c | 2 --
>
On Tue, Oct 11, 2016 at 8:33 AM, Fischetti, Antonio
wrote:
> Comments inline.
>
> Thanks,
> Antonio
>
>> -Original Message-
>> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Jarno
>> Rajahalme
>> Sent: Friday, October 7, 2016 10:08 PM
>> To: Bodireddy, Bhanuprakash
>> Cc: dev
Sorry for jumping in a bit late. I have couple of high level comments below.
On Thu, Oct 6, 2016 at 10:10 AM, Rony Efraim wrote:
> From: Joe Stringer [mailto:j...@ovn.org] Sent: Thursday, October 06, 2016
> 5:06 AM
>>
>> Subject: Re: [ovs-dev] [PATCH ovs RFC 0/9] Introducing HW offload support
On Wed, Oct 5, 2016 at 8:58 AM, Ben Pfaff wrote:
> On Wed, Oct 05, 2016 at 05:53:14PM +0300, Or Gerlitz wrote:
>> On 10/5/2016 3:27 AM, Ben Pfaff wrote:
>> >On Tue, Sep 27, 2016 at 03:46:04PM +0300, Paul Blakey wrote:
>> >>>Add tc ingress qdisc support so we can add qdisc
>> >>>as a qos on port or
On Thu, Sep 29, 2016 at 1:09 AM, Simon Horman
wrote:
> Hi Or,
>
> On Wed, Sep 28, 2016 at 04:54:40PM +0300, Or Gerlitz wrote:
>> On Wed, Sep 28, 2016 at 3:42 PM, Simon Horman
>> wrote:
>>
>> > A different approach, not implemented by this patch-set, is for user-space
>> > to program flows into ha
On Mon, Sep 26, 2016 at 1:15 PM, pravin shelar wrote:
> On Mon, Sep 26, 2016 at 11:49 AM, Ansis Atteka wrote:
>>
>>
>> On 26 September 2016 at 03:48, Pravin B Shelar wrote:
>>>
>>> OVS GRE IPsec tunnel support has multiple issues, Therefore
>>
>
On Mon, Sep 26, 2016 at 9:53 AM, Jiri Benc wrote:
> Reviving a very old thread, sorry. Simon handed this over to me, I'm
> preparing v12.
>
> On Fri, 15 Jul 2016 14:07:37 -0700, pravin shelar wrote:
>> I am not sure if you can use only mac_len to detect L3 packet. This
>
On Mon, Sep 26, 2016 at 3:08 PM, Joe Stringer wrote:
> On 26 September 2016 at 13:24, Pravin B Shelar wrote:
>> Fixes test failure seen due to the IPsec tunnel deprecation
>> messages in test logs.
>>
>> Fixes: 9e9d0384910e ("openvswitch: deprecates support for IPsec tunnel
>> port.").
>> Report
On Mon, Sep 26, 2016 at 11:49 AM, Ansis Atteka wrote:
>
>
> On 26 September 2016 at 03:48, Pravin B Shelar wrote:
>>
>> OVS GRE IPsec tunnel support has multiple issues, Therefore
>
> s/issues,/issues.
>>
>> it was deprecated in OVS 2.6.
>>
>> Following patch removes support GRE IPsec and allow e
On Fri, Sep 23, 2016 at 11:27 PM, Ansis Atteka wrote:
>
>
> On 21 September 2016 at 03:26, Pravin B Shelar wrote:
>>
>> OVS IPsec tunnel support has issues:
>> 1. It only works for GRE.
>> 2. only works on Debian.
>> 3. It does not allow user to match on packet-mark
>>on packet received on tu
On Fri, Sep 23, 2016 at 12:54 PM, Ansis Atteka wrote:
> On Fri, Sep 23, 2016 at 1:12 AM, pravin shelar wrote:
>> On Thu, Sep 22, 2016 at 11:59 AM, Ansis Atteka wrote:
>>>
>>>
>>> On 20 September 2016 at 20:52, Pravin B Shelar wrote:
>>>>
>
On Thu, Sep 22, 2016 at 11:59 AM, Ansis Atteka wrote:
>
>
> On 20 September 2016 at 20:52, Pravin B Shelar wrote:
>>
>> OVS IPsec tunnel support has issues:
>> 1. It only works for GRE.
>>
>> 2. only works on Debian.
>>
>> 3. It does not allow user to match on packet-mark
>>on packet received
mes a non-issue
> for currently failing scenarios because it is no longer used when
> there are three or fewer recursions through ovs_execute_actions().
>
> Suggested-by: Pravin Shelar
>
> Signed-off-by: Lance Richardson
I pushed patch to master and branc
t; ~15Mpps when forwarding between two 40GbE ports with a single flow
> configured on the datapath.
>
> This has been tested on a system with possible CPUs 0-7,16-23. After
> module removal, there were no corruption on the slab cache.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo
On Thu, Sep 15, 2016 at 3:11 PM, Thadeu Lima de Souza Cascardo
wrote:
> On a system with only node 1 as possible, all statistics is going to be
> accounted on node 0 as it will have a single writer.
>
> However, when getting and clearing the statistics, node 0 is not going
> to be considered, as i
On Thu, Sep 15, 2016 at 4:26 PM, Joe Stringer wrote:
> Signed-off-by: Joe Stringer
> ---
> Pravin, does the GRE note look correct?
> ---
> NEWS | 19 +++
> 1 file changed, 19 insertions(+)
>
> diff --git a/NEWS b/NEWS
> index 8c78b3676cf3..19570b96816f 100644
> --- a/NEWS
> +++ b
On Thu, Sep 15, 2016 at 3:24 PM, Jesse Gross wrote:
> On Thu, Sep 15, 2016 at 2:57 PM, Pravin B Shelar wrote:
>> At present OVS compat tunneling can fail due to conflict with
>> already loaded tunneling kernel module. In this case openvswitch
>> kernel module loading fails silently. Following pat
gt; With this change, the deferred action fifo size becomes a non-issue
> for currently failing scenarios because it is no longer used when
> there are three or fewer recursions through ovs_execute_actions().
>
> Suggested-by: Pravin Shelar
> Signed-off-by: Lance
I pushed patch to master and branch-2.6.
Thanks.
On Mon, Sep 12, 2016 at 4:03 PM, Joe Stringer wrote:
> On 12 September 2016 at 14:55, Jesse Gross wrote:
>> On Mon, Sep 12, 2016 at 2:48 PM, Pravin B Shelar wrote:
>>> This allows openvswitch and geneve module co-exist kernel on newer
>>> kernel
On Fri, Sep 9, 2016 at 1:41 PM, Thadeu Lima de Souza Cascardo
wrote:
> Instead of using flow stats per NUMA node, use it per CPU. When using
> megaflows, the stats lock can be a bottleneck in scalability.
>
> On a E5-2690 12-core system, usual throughput went from ~4Mpps to
> ~15Mpps when forwardi
On Fri, Sep 9, 2016 at 1:42 PM, Thadeu Lima de Souza Cascardo
wrote:
> When userspace tries to create datapaths and the module is not loaded,
> it will simply fail. With this patch, the module will be automatically
> loaded.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo
Acked-by: Pravin B She
On Wed, Sep 7, 2016 at 9:56 AM, Eric Garver wrote:
> Add support for 802.1ad including the ability to push and pop double
> tagged vlans. Add support for 802.1ad to netlink parsing and flow
> conversion. Uses double nested encap attributes to represent double
> tagged vlan. Inner TPID encoded alon
On Wed, Sep 7, 2016 at 9:56 AM, Eric Garver wrote:
> This is to simplify using double tagged vlans. This function allows all
> valid vlan ethertypes to be checked in a single function call.
> Also replace some instances that check for both ETH_P_8021Q and
> ETH_P_8021AD.
>
> Patch based on one ori
On Wed, Sep 7, 2016 at 9:56 AM, Eric Garver wrote:
> From: Thomas F Herbert
>
> openvswitch: Add support for 8021.AD
>
> Change the description of the VLAN tpid field.
>
> Signed-off-by: Thomas F Herbert
Acked-by: Pravin B Shelar
___
dev mailing list
On Fri, Sep 2, 2016 at 2:42 PM, pravin shelar wrote:
> On Thu, Sep 1, 2016 at 1:45 PM, Eric Garver wrote:
>> Add support for 802.1ad including the ability to push and pop double
>> tagged vlans. Add support for 802.1ad to netlink parsing and flow
>> conversion. Use
On Thu, Sep 1, 2016 at 1:45 PM, Eric Garver wrote:
> With 802.1ad support these are parsed and set upfront by
> parse_vlan_from_nlattrs() before ovs_key_from_nlattrs() is ever called.
> As such we should never see a VLAN attribute in ovs_key_from_nlattrs().
>
> Signed-off-by: Eric Garver
> ---
>
On Thu, Sep 1, 2016 at 1:45 PM, Eric Garver wrote:
> Add support for 802.1ad including the ability to push and pop double
> tagged vlans. Add support for 802.1ad to netlink parsing and flow
> conversion. Uses double nested encap attributes to represent double
> tagged vlan. Inner TPID encoded alon
On Thu, Sep 1, 2016 at 1:45 PM, Eric Garver wrote:
> This is to simplify using double tagged vlans. This function allows all
> valid vlan ethertypes to be checked in a single function call.
> Also replace some instances that check for both ETH_P_8021Q and
> ETH_P_8021AD.
>
> Patch based on one ori
On Thu, Sep 1, 2016 at 1:45 PM, Eric Garver wrote:
> From: Thomas F Herbert
>
> openvswitch: Add support for 8021.AD
>
> Change the description of the VLAN tpid field.
>
> Signed-off-by: Thomas F Herbert
Acked-by: Pravin B Shelar
___
dev mailing list
On Mon, Aug 22, 2016 at 2:40 PM, Jesse Gross wrote:
> On Mon, Aug 22, 2016 at 2:24 PM, Pravin B Shelar wrote:
>> Signed-off-by: Pravin B Shelar
>> ---
>> .travis.yml| 1 +
>> .travis/linux-build.sh | 12
>> FAQ.md | 2 +-
>> NEWS | 2
On Thu, Aug 18, 2016 at 12:26 PM, Jesse Gross wrote:
> These tests dump the flows currently in the datapath but they aren't
> the first to run and might have existing flows left over. We don't
> really care if there are others flows present so filter on the ones
> we want to avoid being affected b
On Thu, Aug 18, 2016 at 2:35 PM, Jesse Gross wrote:
> On Wed, Aug 17, 2016 at 10:17 PM, pravin shelar wrote:
>> On Wed, Aug 17, 2016 at 5:26 PM, Jesse Gross wrote:
>>> On Wed, Aug 17, 2016 at 10:23 AM, Pravin B Shelar wrote:
>>>> diff --git a/datapath/linux/compat
On Wed, Aug 17, 2016 at 5:26 PM, Jesse Gross wrote:
> On Wed, Aug 17, 2016 at 10:23 AM, Pravin B Shelar wrote:
>> diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c
>> index 89df07f..48a56b9 100644
>> --- a/datapath/linux/compat/gso.c
>> +++ b/datapath/linux/compat/gso.c
>> @@
On Tue, Aug 16, 2016 at 6:31 PM, Jesse Gross wrote:
> On Mon, Aug 15, 2016 at 2:11 PM, Pravin B Shelar wrote:
>> diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c
>> index 89df07f..f973fb4 100644
>> --- a/datapath/linux/compat/gso.c
>> +++ b/datapath/linux/compat/gso.c
>> @@
On Tue, Aug 16, 2016 at 6:32 PM, Jesse Gross wrote:
> On Mon, Aug 15, 2016 at 2:11 PM, Pravin B Shelar wrote:
>> With use of LCO support we can finally enable SG and CSUM
>> features for GSO backport.
>>
>> Signed-off-by: Pravin B Shelar
>
> I don't know if this is safe. The kernels where this f
On Mon, Aug 15, 2016 at 10:04 AM, Jesse Gross wrote:
> On Mon, Aug 15, 2016 at 9:57 AM, Pravin B Shelar wrote:
>> Upstream commit:
>> commit 4b5b9ba553f9aa5f484ab972fc9b58061885ceca
>> Author: Martynas Pumputis
>> Date: Tue Aug 9 16:24:50 2016 +0100
>>
>> openvswitch: do not ig
On Sat, Aug 13, 2016 at 10:11 AM, Jesse Gross wrote:
> On Fri, Aug 12, 2016 at 10:49 AM, Pravin B Shelar wrote:
>> Upstream commit:
>> commit 4b5b9ba553f9aa5f484ab972fc9b58061885ceca
>> Author: Martynas Pumputis
>> Date: Tue Aug 9 16:24:50 2016 +0100
>>
>> openvswitch: do not i
On Sat, Aug 13, 2016 at 10:08 AM, Jesse Gross wrote:
> On Fri, Aug 12, 2016 at 10:49 AM, Pravin B Shelar wrote:
>> Upstream commit:
>> commit 5ef9f289c4e698054e5687edb54f0da3cdc9173a
>> Author: Ian Wienand
>> Date: Wed Aug 3 15:44:57 2016 +1000
>>
>> OVS: Ignore negative headro
On Thu, Aug 11, 2016 at 10:33 PM, Joe Stringer wrote:
> On 11 August 2016 at 19:43, Pravin B Shelar wrote:
>> Older kernel skb_scrub_packet() has bug which resets skb mark for
>> all packet. It is fixed during 3.18 release where it is reset
>> only for packets crossing namespace. So OVS is forced
On Thu, Aug 11, 2016 at 2:23 PM, Jesse Gross wrote:
> On Thu, Aug 11, 2016 at 2:12 PM, Pravin B Shelar wrote:
>> When using compat GSO there is no need to turn on skb
>> encapsulation bit since OVS does not use any tunnel GSO
>> functionality from the networking stack.
>>
>> Signed-off-by: Pravin
On Thu, Aug 11, 2016 at 1:54 PM, Jesse Gross wrote:
> On Wed, Aug 10, 2016 at 10:34 AM, Pravin B Shelar wrote:
>> Same as earlier patch this fixes vxlan recieve offload implementation.
>>
>> Signed-off-by: Pravin B Shelar
>
> Acked-by: Jesse Gross
Thanks for review, I have pushed these GRO re
On Thu, Aug 11, 2016 at 1:17 PM, Jesse Gross wrote:
> On Wed, Aug 10, 2016 at 10:34 AM, Pravin B Shelar wrote:
>> When using compat GSO there is no need to turn on skb
>> encapsulation bit since OVS does not use any tunnel GSO
>> functionality from the networking stack.
>>
>> Signed-off-by: Pravi
On Tue, Aug 9, 2016 at 8:24 AM, Martynas Pumputis wrote:
> The creation of a tunnel vport (geneve, gre, vxlan) brings up a
> corresponding netdev, a multi-step operation which can fail.
>
> For example, changing a vxlan vport's netdev state to 'up' binds the
> vport's socket to a UDP port - if the
On Tue, Aug 9, 2016 at 10:51 AM, Jesse Gross wrote:
> On Mon, Aug 8, 2016 at 2:54 PM, Pravin B Shelar wrote:
>> Upstream commit:
>> commit 272d96a5ab10662691b4ec90c4a66fdbf30ea7ba
>> Author: pravin shelar
>> Date: Fri Aug 5 17:45:36 2016 -0700
>>
&
On Mon, Aug 8, 2016 at 8:32 PM, Zhangkun (K) wrote:
> diff --git a/datapath/linux/compat/flow_dissector.c
> b/datapath/linux/compat/flow_dissector.c
> index 3f42dba..4c5d023 100644
> --- a/datapath/linux/compat/flow_dissector.c
> +++ b/datapath/linux/compat/flow_dissector.c
> @@ -77,7 +77,7 @@ ag
On Mon, Aug 8, 2016 at 8:17 AM, Simon Horman wrote:
> On Wed, Jul 20, 2016 at 11:06:37AM -0700, pravin shelar wrote:
>> On Tue, Jul 19, 2016 at 5:02 PM, Simon Horman
>> wrote:
>> > On Mon, Jul 18, 2016 at 03:34:52PM -0700, pravin shelar wrote:
>> >> On Sun, J
On Wed, Aug 3, 2016 at 12:48 PM, Jesse Gross wrote:
> On Wed, Aug 3, 2016 at 10:08 AM, Pravin B Shelar wrote:
>> Few function can be compiled out for non GSO case. This
>> patch make it bit cleaner to understand GSO compat code.
>>
>> Signed-off-by: Pravin B Shelar
>
> Acked-by: Jesse Gross
Th
On Wed, Aug 3, 2016 at 2:08 PM, Jesse Gross wrote:
> On Wed, Aug 3, 2016 at 10:08 AM, Pravin B Shelar wrote:
>> udp_set_csum() has bug fix that is not relevant for upstream
>> (commit c77d947191b0).
>> So OVS need to use compat function. This function is also
>> used from UDP xmit path so we have
On Wed, Aug 3, 2016 at 2:07 PM, Jesse Gross wrote:
> On Wed, Aug 3, 2016 at 9:00 AM, pravin shelar wrote:
>> On Tue, Aug 2, 2016 at 4:55 PM, Jesse Gross wrote:
>>> On Tue, Aug 2, 2016 at 3:55 PM, pravin shelar wrote:
>>>> On Tue, Aug 2, 2016 at 3:11 PM, Jesse Gro
On Tue, Aug 2, 2016 at 3:08 PM, Jesse Gross wrote:
> On Tue, Aug 2, 2016 at 2:17 PM, Pravin B Shelar wrote:
>> OVS turns on tunnel GSO backport statically for kernel older than
>> 3.18. Some distributions kernels could backport tunnel GSO. To make
>> use of device tunnel offload on such kernel de
On Tue, Aug 2, 2016 at 4:55 PM, Jesse Gross wrote:
> On Tue, Aug 2, 2016 at 3:55 PM, pravin shelar wrote:
>> On Tue, Aug 2, 2016 at 3:11 PM, Jesse Gross wrote:
>>> On Tue, Aug 2, 2016 at 2:17 PM, Pravin B Shelar wrote:
>>>> Signed-off-by: Pravin B Shelar
>&g
On Tue, Aug 2, 2016 at 4:40 PM, Jesse Gross wrote:
> On Tue, Aug 2, 2016 at 2:18 PM, Pravin B Shelar wrote:
>> Signed-off-by: Pravin B Shelar
>> ---
>> FAQ.md | 2 +-
>> NEWS | 2 +-
>> acinclude.m4 | 4 ++--
>> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> Should we also a
On Tue, Aug 2, 2016 at 3:11 PM, Jesse Gross wrote:
> On Tue, Aug 2, 2016 at 2:17 PM, Pravin B Shelar wrote:
>> Signed-off-by: Pravin B Shelar
>> ---
>> datapath/linux/compat/include/net/udp.h | 2 +-
>> datapath/linux/compat/udp.c | 19 ++-
>> datapath/linux/compat/
On Mon, Aug 1, 2016 at 2:25 PM, Joe Stringer wrote:
> On 1 August 2016 at 14:08, Joe Stringer wrote:
>> In kernels <=3.16 there is an LRU for managing fragment queues for IPv4
>> and IPv6. Because the backport code comes from more recent upstream
>> versions of Linux, this LRU management was miss
On Mon, Aug 1, 2016 at 2:14 PM, Joe Stringer wrote:
> On 1 August 2016 at 14:06, Pravin B Shelar wrote:
>> Patch fixes following compilation error.
>>
>> CHECK /home/travis/build/openvswitch/ovs/datapath/linux/gso.c \
>> /home/travis/build/openvswitch/ovs/datapath/linux/gso.c:222:12:
On Fri, Jul 29, 2016 at 5:49 PM, Joe Stringer wrote:
> On 26 July 2016 at 15:24, Pravin B Shelar wrote:
>> First two patches fixes to issues related to geneva and vxlan tunnel.
>> Third patch is just code improvement.
>
> It looks like this patch series introduced breakage for kernels < 3.10
> (f
On Mon, Aug 1, 2016 at 11:46 AM, Joe Stringer wrote:
> On 1 August 2016 at 10:21, pravin shelar wrote:
>> On Tue, Jul 12, 2016 at 3:26 PM, Joe Stringer wrote:
>>> The core fragmentation handling logic is exported on all supported
>>> kernels, so it's not necessar
On Tue, Jul 12, 2016 at 3:26 PM, Joe Stringer wrote:
> This was previously backported to fix issues with our inet_fragment
> backport; with that largely gone, we can get rid of this too.
>
> Signed-off-by: Joe Stringer
Acked-by: Pravin B Shelar
___
de
On Tue, Jul 12, 2016 at 3:26 PM, Joe Stringer wrote:
> If a user sends some fragments of an IPv6 message through OVS, but OVS
> fails to assemble the IPv6 message and the OVS module is then unloaded
> before the fragments expire, it could lead to a kernel panic like the
> following:
>
> Call Trace
On Tue, Jul 12, 2016 at 3:26 PM, Joe Stringer wrote:
> Remove a couple of functions that are available on all supported kernel
> versions.
>
> Signed-off-by: Joe Stringer
Acked-by: Pravin B Shelar
___
dev mailing list
dev@openvswitch.org
http://openvs
On Tue, Jul 12, 2016 at 3:26 PM, Joe Stringer wrote:
> This function is just a dummy to ensure that the corresponding netfilter
> fragment module is loaded, to initialize the shared structures. But it
> doesn't need to be invoked once per namespace; one call per protocol
> should do the trick.
>
>
On Tue, Jul 12, 2016 at 3:26 PM, Joe Stringer wrote:
> Kernel 3.7 and lower are now unsupported, remove this fragment.
>
> Signed-off-by: Joe Stringer
Acked-by: Pravin B Shelar
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/li
On Tue, Jul 12, 2016 at 3:26 PM, Joe Stringer wrote:
> The core fragmentation handling logic is exported on all supported
> kernels, so it's not necessary to backport the latest version of this.
> This greatly simplifies the code due to inconsistencies between the old
> per-lookup garbage collecti
On Thu, Jul 28, 2016 at 5:09 PM, Joe Stringer wrote:
> Out-of-tree modules are installed into the kernel's "extra" modules
> directory for the version that kmod-openvswitch is compiled against. For
> all other kernels on the system at install time, a symlink is created in
> the "weak-updates" dire
On Thu, Jul 28, 2016 at 5:09 PM, Joe Stringer wrote:
> We've done the same for openvswitch.ko previously, but we really should
> be doing this for vport modules as well; otherwise, depmod may try to
> pair upstream vport modules with the out-of-tree openvswitch module
> (leading to depmod warnings
On Tue, Jul 26, 2016 at 4:37 PM, Amitabha Biswas wrote:
> Typo in the previous ack
>
> Acked-by: Amitabha Biswas
>
> On Jul 26, 2016, at 4:22 PM, Amitabha Biswas wrote:
>
> I was able to compile the openvswitch modules on Linux 4.6 kernel and
> stacked using OpenStack networking-ovn.
>
> The bas
On Tue, Jul 26, 2016 at 4:03 PM, Jesse Gross wrote:
> On Tue, Jul 26, 2016 at 3:59 PM, pravin shelar wrote:
>> On Tue, Jul 26, 2016 at 3:53 PM, Jesse Gross wrote:
>>> On Tue, Jul 26, 2016 at 3:24 PM, Pravin B Shelar wrote:
>>>> diff --git a/datapath/linux/co
On Tue, Jul 26, 2016 at 3:53 PM, Jesse Gross wrote:
> On Tue, Jul 26, 2016 at 3:24 PM, Pravin B Shelar wrote:
>> diff --git a/datapath/linux/compat/include/net/udp.h
>> b/datapath/linux/compat/include/net/udp.h
>> index fa49fa5..266e70a 100644
>> --- a/datapath/linux/compat/include/net/udp.h
>>
On Tue, Jul 26, 2016 at 11:14 AM, Jesse Gross wrote:
> On Tue, Jul 26, 2016 at 10:56 AM, pravin shelar wrote:
>> On Tue, Jul 26, 2016 at 10:06 AM, Jesse Gross wrote:
>>> On Mon, Jul 25, 2016 at 5:49 PM, Pravin B Shelar wrote:
>>>> OVS compat layer can handle t
1 - 100 of 1602 matches
Mail list logo
