On Thu, Aug 11, 2016 at 10:33 PM, Joe Stringer <j...@ovn.org> wrote:
> On 11 August 2016 at 19:43, Pravin B Shelar <pshe...@ovn.org> wrote:
>> Older kernel skb_scrub_packet() has bug which resets skb mark for
>> all packet. It is fixed during 3.18 release where it is reset
>> only for packets crossing namespace. So OVS is forced to use
>> compat skb_scrub_packet() on older kernel.
>> This is related to upstream bug fix commit ca7c7b9059e3
>> ("skbuff: Do not scrub skb mark within the same name space").
>>
>> VMware-BZ: #1710701
>> Signed-off-by: Pravin B Shelar <pshe...@ovn.org>
>> ---
>
> This looks good to me, although the original upstream commit seems to
> be in Linus' tree only from v4.1:
> https://github.com/torvalds/linux/commit/213dd74aee765d4e5f3f4b9607fef0cf97faa2af
>
> I guess it was backported to some kernel versions, but it would be
> more consistent to use this number if in doubt.
>I only worry about latest stable kernel release. If ovs starts to support all point releases our compatibility footprint would balloon up. In this case the code is already there, so it does not matter much win this case. So I changed the version check. > Acked-by: Joe Stringer <j...@ovn.org> Thanks for review, pushed to master and branch 2.5. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
