On Thu, Aug 11, 2016 at 1:17 PM, Jesse Gross <je...@kernel.org> wrote: > On Wed, Aug 10, 2016 at 10:34 AM, Pravin B Shelar <pshe...@ovn.org> wrote: >> When using compat GSO there is no need to turn on skb >> encapsulation bit since OVS does not use any tunnel GSO >> functionality from the networking stack. >> >> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> > > I'm not sure that this is the best place to clear the flag. It's not > entirely obvious why it's being done as it makes it seem like it's > related having inner and outer checksums. > > What if we clear it in rpl_ip_local_out() instead? It seems like > that's closer to where might actually be used and is already > specialized for !USE_UPSTREAM_TUNNEL_GSO. Note that we're currently > clearing it in tnl_skb_gso_segment().
ok, I will update the patch. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
