Re: [ovs-dev] [PATCH] stream-tcp: Remove extra initializer in pwindows_pstream_class.

No problem. Thanks for applying. Saurabh From: Ben Pfaff Date: Monday, February 23, 2015 at 8:46 PM To: Saurabh Shah Cc: "dev@openvswitch.org" Subject: Re: [ovs-dev] [PATCH] stream-tcp: Remove extra initializer in pwindows_pstream_class. >On Mon, Feb 23, 2015 at 04:

[ovs-dev] [PATCH] stream-tcp: Remove extra initializer in pwindows_pstream_class.

commit c2e3cbaf ("stream: Eliminate pstream_set_dscp().") removed the set_dscp() callback from pstream_class. Signed-off-by: Saurabh Shah --- lib/stream-tcp.c |1 - 1 file changed, 1 deletion(-) diff --git a/lib/stream-tcp.c b/lib/stream-tcp.c index 1f53e86..ac42924 100644 --- a/

[ovs-dev] [PATCH] Fix build break in ofproto/tunnel.c for windows platform.

The breakage was introduced by commit: a36de779 ("openvswitch: Userspace tunneling."). Reported-by: Edwin Chiu Signed-off-by: Saurabh Shah Acked-by: Nithin Raju --- include/windows/netinet/ip.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/windows/netinet/ip.h

[ovs-dev] [PATCH] Fix build break in ofproto/tunnel.c for windows platform.

The breakage was introduced by commit: a36de779 ("openvswitch: Userspace tunneling."). Reported-by: Edwin Chiu Signed-off-by: Saurabh Shah --- include/windows/netinet/ip.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/windows/netinet/ip.h b/include/windows/netinet/

Re: [ovs-dev] [PATCH 3/3] Avoid uninitialized variable warnings with OBJECT_OFFSETOF() in MSVC.

macros, the OVS build >on Windows gets littered with "uninitialized variable" warnings. >This patch attempts to workaround the problem. > >Signed-off-by: Gurucharan Shetty Acked-by: Saurabh Shah ___ dev mailing list dev@op

Re: [ovs-dev] [PATCH] Create a NBL for each NB when required

> > This function has become a bit too long now, can you please refactor it? > > One obvious thing you could do is to extract the processing of an > > single NB into a separate function and the parent function can take > > care of splitting the NBL (if required) & creating the right forwarding ct

Re: [ovs-dev] [PATCH v2 2/2] cccl: Ability to enable compiler optimization.

dn.microsoft.com/en-us/library/k1ack8f1.aspx Otherwise looks good, Acked-by: Saurabh Shah Saurabh ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2 1/2] cccl: Enable ability to parallel build.

release. > >Signed-off-by: Gurucharan Shetty Acked-by: Saurabh Shah >--- > build-aux/cccl |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/build-aux/cccl b/build-aux/cccl >index d6915aa..c18629a 100644 >--- a/build-aux/cccl >+++ b/build-aux/cc

Re: [ovs-dev] [PATCH] Windows NetLink Socket - Support for asynchronous event notification

>We keep an outstanding, out of band, I/O request in the driver at all >time. >Once an event generated the driver queues the event message, completes the >pending I/O and unblocks the calling thread through setting the event in >the >overlapped structure n the NL socket. The thread will read all

Re: [ovs-dev] [PATCH 4/4 v4] datapath-windows: add support for GET_DP command to dump datpaths

ork on Windows, > dpif_linux_enumerate() successfully enumerated the datapaths in the > kernel. > >Signed-off-by: Nithin Raju >Signed-off-by: Ankur Sharma Acked-by: Saurabh Shah ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/4 v4] datapath-windows: make NL version a UIN8 and add a validateDp arg

>I didn't realize earlier that version in a netlink message was a >UINT8. So, fixing that here. > >Also, some of the commands don't pass a valid DP value. Hence adding >a field to identify such commands. > >Signed-off-by: Nithin Raju >Signed-off-by: Ank

Re: [ovs-dev] [PATCH 3/4 v4] datapath-windows: add a context structure for user parameters

ents, but >this >approach keeps the code clean, IMO. > >Signed-off-by: Nithin Raju >Signed-off-by: Ankur Sharma Acked-by: Saurabh Shah ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/4 v4] datapath-windows: Data structures and functions for dump state

I am fine with either approach - index array or separate variables. So this works. >Signed-off-by: Nithin Raju Acked-by: Saurabh Shah ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] FW: [PATCH] Create a NBL for each NB when required

> > --- > > */ > > static __inline VOID * > > -GetStartAddrNBL(const NET_BUFFER_LIST *_pNB) > > +GetStartAddrNB(const NET_BUFFER *_pNB) > > Generally, we have not used '_' prefix for function parameter names. We > use them for macros etc, but not for functions. Do you prefer it this way? I > a

Re: [ovs-dev] [PATCH 9/9 v2] datapath-windows: refactor code to setup dump start state

response. Saurabh > -Original Message- > From: Ankur Sharma > Sent: Friday, August 29, 2014 12:26 PM > To: Saurabh Shah; Eitan Eliahu; Samuel Ghinet; dev@openvswitch.org; Nithin > Raju > Subject: RE: [ovs-dev] [PATCH 9/9 v2] datapath-windows: refactor code to > setup dum

Re: [ovs-dev] [PATCH 9/9 v2] datapath-windows: refactor code to setup dump start state

> > I have talked to ben and he is fine with the approach of handling the review > comment in another patch in the same series. But yes ideally we should try > to keep the review comment fix in the same patch. > I would go with the reviewers preference. No one likes to block reviews unnecesaril

Re: [ovs-dev] [PATCH 9/9 v2] datapath-windows: refactor code to setup dump start state

I would really like to discourage this practice of - "Lets commit this code and we will take your comments in separate reviews". I just replied with a similar comment to one of Samuel's review where he took care of comments in a separate review. This does not make for a high quality code that we

Re: [ovs-dev] [PATCH] Create a NBL for each NB when required

Hi Samuel, > > >All NET_BUFFERs of a NET_BUFFER_LIST must go through the pipeline: > >extract, find flow, execute. Previously, only the first NET_BUFFER of a > >NET_BUFFER_LIST was going through this pipeline, which was erroneous. > > comments here. > > It might make the reading clearer, and st

Re: [ovs-dev] [PATCH 2/2] cccl: Enable compiler optimization by default.

> -Original Message- > From: Gurucharan Shetty [mailto:shet...@nicira.com] > Sent: Thursday, August 28, 2014 12:10 PM > To: Saurabh Shah > Cc: Eitan Eliahu; dev@openvswitch.org; Gurucharan Shetty > Subject: Re: [ovs-dev] [PATCH 2/2] cccl: Enable compiler optimiz

Re: [ovs-dev] [PATCH 2/2] cccl: Enable compiler optimization by default.

> -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Gurucharan > Shetty > Sent: Thursday, August 28, 2014 10:54 AM > To: Eitan Eliahu > Cc: dev@openvswitch.org; Gurucharan Shetty > Subject: Re: [ovs-dev] [PATCH 2/2] cccl: Enable compiler optimization by > defa

Re: [ovs-dev] [PATCH 3/4] Changes needed to compile dpif-linux.c with MSVC

That would be very helpful. Thanks! Saurabh >Hi, > >Will send the patch until the end of the day. > >Alin. > >-Mesaj original- >De la: Saurabh Shah [mailto:ssaur...@vmware.com] >Trimis: Thursday, August 28, 2014 9:31 PM >Către: Alin Serdean; dev@openvswit

Re: [ovs-dev] [PATCH 3/4] Changes needed to compile dpif-linux.c with MSVC

Hi Alin, We are getting to a point where we need this change. Do you plan to send a V2 soon? Thanks! Saurabh >Hi Saurabh, > >If Ben is ok with the name change I would be glad to send out a V2 of the >patch. > >Thanks, >Alin. > >-Mesaj original- >De

Re: [ovs-dev] [PATCH] Add build of ovsext.sln using MSBuild

-vstudioddk="Win8.1 Release" > >Documentation will be updated in another patch. > >Signed-off-by: Alin Gabriel Serdean Thanks for working on this! Just one minor nit below. Acked-by: Saurabh Shah >--- > Makefile.am | 10 ++ > configure.ac

Re: [ovs-dev] [PATCH] Rename files under datapath-windows

st 27, 2014 7:34 AM > To: Saurabh Shah; Samuel Ghinet; dev@openvswitch.org > Cc: Nithin Raju > Subject: RE: [ovs-dev] [PATCH] Rename files under datapath-windows > > Hi Saurabh, > > Could you please try to do the autoreconf again. > ./boot.sh > ./configure > > Th

Re: [ovs-dev] [PATCH] Rename files under datapath-windows

> -Original Message- > From: Ben Pfaff [mailto:b...@nicira.com] > Sent: Tuesday, August 26, 2014 5:03 PM > To: Saurabh Shah > Cc: Samuel Ghinet; dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] Rename files under datapath-windows > > On Wed, Aug 27, 2014 at 1

Re: [ovs-dev] [PATCH] lib/flow.h: Improve struct miniflow comment and definition.

> -Original Message- > From: Ben Pfaff [mailto:b...@nicira.com] > Sent: Tuesday, August 26, 2014 4:56 PM > To: Saurabh Shah > Cc: Jarno Rajahalme; dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] lib/flow.h: Improve struct miniflow comment > and definition. > &

Re: [ovs-dev] [PATCH] Rename files under datapath-windows

e. Thanks for working on this. Saurabh > -Original Message- > From: Samuel Ghinet [mailto:sghi...@cloudbasesolutions.com] > Sent: Tuesday, August 26, 2014 1:04 PM > To: dev@openvswitch.org > Cc: Alin Serdean; Saurabh Shah; Nithin Raju > Subject: [ovs-dev] [PATCH] Renam

Re: [ovs-dev] [PATCH] Add build of ovsext.sln using MSBuild

Hey Alin, Are you planning on re-spinning this patch? Saurabh >This commit adds to the automake build system the full build required by >the >forwarding extension solution. > >It will help a lot in the future CI to check the full build of the >project. > >Also the documentation was updated. > >Si

Re: [ovs-dev] [PATCH] lib/flow.h: Improve struct miniflow comment and definition.

>Miniflows can nowadays be dynamically allocated to different inline >sizes, as done by lib/classifier.c, but this had not been documented >at the struct miniflow definition. > >Also, MINI_N_INLINE had a different value for 32-bit and 64-bit builds >due to a historical reason. Now we use 8 for b

Re: [ovs-dev] [PATCH] netlink-socket.c: fix typo to get_sock_pid_from_kernel()

>A typo crept in while respinning get_sock_pid_from_kernel() in the >previous >patch. Fixing it now. Also, get_sock_pid_from_kernel() doesn't need an OUT >argument. Fixing that too. >--- > lib/netlink-socket.c | 10 +- > 1 files changed, 5 insertions(+), 5 delet

Re: [ovs-dev] [PATCH] datapath-windows: trivial formatting changes in Netlink.c

>--- > datapath-windows/ovsext/Netlink.c | 16 +--- > 1 files changed, 9 insertions(+), 7 deletions(-) Acked-by: Saurabh Shah ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] Cloning packets for "action: set field"

Hi Samuel, > -Original Message- > From: Samuel Ghinet [mailto:sghi...@cloudbasesolutions.com] > Sent: Tuesday, August 26, 2014 10:40 AM > To: Saurabh Shah > Cc: dev@openvswitch.org > Subject: RE: Cloning packets for "action: set field" > > Hi Saurabh

Re: [ovs-dev] Cloning packets for "action: set field"

clone1, set ipv4 dest addr1, out to port 1; >then >clone to clone2, set ipv4 dest addr2, out to port 2; >clone2 will be a clone of clone1? Yes. > >Thanks! >Sam > >From: Saurabh Shah [ssaur...@vmware.com] >Sent: Friday, August

Re: [ovs-dev] [PATCH] Create a NBL for each NB when required

Hi Alin, Thanks for working on it! I am almost done reviewing the change. I have a few comments below. >ovs/ovs-issues#15 > >All NET_BUFFERs of a NET_BUFFER_LIST must go through >the pipeline: extract, find flow, execute. Previously, >only the first NET_BUFFER of a NET_BUFFER_LIST was going >thro

Re: [ovs-dev] [PATCH 1/3 v2] datapath-windows: add netlink message parsing APIs

Hey Ankur, Something to be careful of in future. You should wait for the reviewers to give an actual 'Acked-by' for a patch. If its a private Ack, it would be a good idea to mention it and then put an Ack for them. For example, Nithin & Samuel reviewed your V1 patch and gave comments, but that doe

Re: [ovs-dev] [PATCH 1/3] datapath-windows: add netlink message parsing APIs

>In this change we introduce Netlink.c, Netlink.h and NetlinkProto.h >in datapath-windows. These files will provide netlink message >data structures and parsing APIs. > >Changes are on similar lines to userspace netlink code. > >Change-Id: Ic225504eff3a25c0619ce3b27d8f54155d8af409 Not a review. I

Re: [ovs-dev] [PATCH v3] datapath-windows: Use OVS_DEFAULT_PORT_NO instead of 0 in a few places

Acked-by: Saurabh Shah From: Nithin Raju Date: Thursday, August 14, 2014 at 9:02 PM To: "dev@openvswitch.org" Subject: [ovs-dev] [PATCH v3] datapath-windows: Use OVS_DEFAULT_PORT_NO instead of 0 in a few places >Signed-off-by: Nithin Raju >--- > datapath-windows/

Re: [ovs-dev] [PATCH 1/4 v2] Add extentions to the standard datapath interface

>On Tue, Aug 19, 2014 at 02:10:50AM +0000, Saurabh Shah wrote: >> Hi Ben, >> >> >On Thu, Aug 14, 2014 at 08:35:36PM -0700, Nithin Raju wrote: >> >> The datapath interface defined in odp-netlink.h needs some extensions >> >> that are platf

Re: [ovs-dev] [PATCH 1/4 v2] Add extentions to the standard datapath interface

Hi Ben, >On Thu, Aug 14, 2014 at 08:35:36PM -0700, Nithin Raju wrote: >> The datapath interface defined in odp-netlink.h needs some extensions >> that are platform dependent. Some examples are the name of the >>communication >> device on Windows and a set of commands that are specific to Windows.

Re: [ovs-dev] Cloning packets for "action: set field"

to work. If you still think that this approach has holes, then let me know and we can do a separate IRC session just to discuss this. :) Thanks, Saurabh From: Samuel Ghinet Date: Thursday, August 7, 2014 at 10:45 AM To: Saurabh Shah Cc: "dev@openvswitch.org" Su

Re: [ovs-dev] [PATCH] datapath-windows: define a OVS_VPORTNO_DEFAULT instead of using 0

Can your rename OVS_VPORTNO_DEFAULT to something else? Having two defaults with similar name, but different value is confusing. Thanks, Saurabh > -Original Message- > From: Nithin Raju > Sent: Thursday, August 14, 2014 6:16 PM > To: Saurabh Shah > Cc: dev@openvswitch.or

Re: [ovs-dev] [PATCH] Use local time for Inf2Cat

On a related note, while I see the log which says its stamping the local time in INF file. The actual DriverVer in the INF remains unchanged. Not sure why. I don't know what the build problem is. But if it fixes your problem. :) Acked-by: Saurabh Shah > -Original Message- >

Re: [ovs-dev] [PATCH 3/4] Changes needed to compile dpif-linux.c with MSVC

We should change the name of the class to dpif_netlink_class and rename dpif-linux to dpif-netlink. Saurabh > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin > Serdean > Sent: Wednesday, August 13, 2014 8:17 AM > To: dev@openvswitch.org > Subject: [o

Re: [ovs-dev] [PATCH 1/4] Add extentions to the standard datapath interface

Hi Nithin, > -Original Message- > From: Nithin Raju > Sent: Thursday, August 14, 2014 5:56 PM > To: Saurabh Shah > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 1/4] Add extentions to the standard datapath > interface > > On Aug 14, 2014, at 5:01

Re: [ovs-dev] [PATCH 2/4] datapath-windows: Add OvsDatapath.[ch] and OVS_USE_NL_INTERFACE CPP

Naming the file OvsIoctl.[ch] seems much clearer to me. I don't know why these files are being renamed. Also, if these are not going to be shared with the userspace, you should drop the Ovs prefix from the file name. Thanks, Saurabh > -Original Message- > From: dev [mailto:dev-boun...@o

Re: [ovs-dev] [PATCH 1/4] Add extentions to the standard datapath interface

> -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Nithin Raju > Sent: Wednesday, August 13, 2014 7:12 PM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH 1/4] Add extentions to the standard datapath > interface > > The datapath interface defined in o

Re: [ovs-dev] [PATCH] datapath-windows: define a OVS_VPORTNO_DEFAULT instead of using 0

The naming is a little confusing - $ grep PORT_NO datapath-windows/include/OvsPub.h #define OVS_DEFAULT_PORT_NO 0x Looks good otherwise. Thanks, Saurabh > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Nithin Raju > Sent: Thursday, August 14, 2

Re: [ovs-dev] [PATCH] datapath-windows: check source port during tunnel Tx

Hi Nithin, I saw that Ben already applied this patch yesterday. However, I just have one comment below. > -Original Message- > From: Nithin Raju [mailto:nit...@vmware.com] > Sent: Tuesday, August 12, 2014 10:59 PM > To: dev@openvswitch.org; Saurabh Shah > Cc: Nithin

Re: [ovs-dev] datapath-windows: Renaming files proposal

Yes, that is also shared between um-km. Thanks! Saurabh From: Samuel Ghinet mailto:sghi...@cloudbasesolutions.com>> Date: Thursday, August 14, 2014 at 5:10 AM To: Saurabh Shah mailto:ssaur...@vmware.com>>, Nithin Raju mailto:nit...@vmware.com>>, Ankur Sharma mailto:ankursha.

Re: [ovs-dev] datapath-windows: Renaming files proposal

Hi Samuel, > >OvsNetlink.h -> Netlink.h >OvsPub.h -> Pub.h > >The following will be left intact: >OvsDpInterface.h >Because it is a userspace interaction file and it is a generated file. I think I tried to tell this earlier, so this will be a repeat. If you want to nuke ŒOvs¹ please remove it fro

Re: [ovs-dev] datapath-windows: Renaming files proposal

prefix, that's fine with me. -- Saurabh From: Ankur Sharma Sent: Wednesday, August 13, 2014 4:31 PM To: Saurabh Shah; Samuel Ghinet; Nithin Raju Cc: dev@openvswitch.org Subject: RE: [ovs-dev] datapath-windows: Renaming files proposal Correct, i think userspace interaction heade

Re: [ovs-dev] datapath-windows: Renaming files proposal

If that’s the case, we should also keep the ‘Ovs’ prefix for OvsPub.h. :) Thanks! Saurabh From: Ankur Sharma mailto:ankursha...@vmware.com>> Date: Wednesday, August 13, 2014 at 4:20 PM To: Saurabh Shah mailto:ssaur...@vmware.com>>, Samuel Ghinet mailto:sghi...@cloudbasesolutions.co

Re: [ovs-dev] datapath-windows: Renaming files proposal

+1 for dropping the 'Ovs' prefix for OvsDpInterface. It is odd to have just one file prefixed with Ovs. Thanks! Saurabh From: Samuel Ghinet mailto:sghi...@cloudbasesolutions.com>> Date: Wednesday, August 13, 2014 at 8:29 AM To: Nithin Raju mailto:nit...@vmware.com>> Cc: "dev@openvswitch.org

Re: [ovs-dev] [PATCH 04/15] datapath-windows: We don't need wrappers for Interlocked ops

; -- Saurabh > -Original Message- > From: Samuel Ghinet [mailto:sghi...@cloudbasesolutions.com] > Sent: Friday, August 08, 2014 6:27 AM > To: Saurabh Shah; dev@openvswitch.org > Subject: RE: [ovs-dev] [PATCH 04/15] datapath-windows: We don't need > wrappers for Interloc

Re: [ovs-dev] Recent series of patches

> Since our issue tracker is in a different repo from the code, I think you need > to reference issues in the following way: > >     ovs/ovs-issues#42 > This is good to know. I wasn't aware about this. Thanks Justin! -- Saurabh ___ dev mailing

Re: [ovs-dev] [PATCH 02/15] datapath-windows: Move and Rename files

sy to identify what is an "implmented functionality", and what is a "native platform provided functionality". -- Saurabh > -Original Message- > From: Alin Serdean [mailto:aserd...@cloudbasesolutions.com] > Sent: Wednesday, August 06, 2014 12:54 PM &g

Re: [ovs-dev] [PATCH 02/15] datapath-windows: Move and Rename files

entions. :) Common naming convention would make it so much easier to look at code. > >Alin. > >-Mesaj original- >De la: dev [mailto:dev-boun...@openvswitch.org] În numele Saurabh Shah >Trimis: Wednesday, August 6, 2014 9:52 PM >Către: Samuel Ghinet; dev@openvswitch.o

Re: [ovs-dev] [PATCH 14/15] datapath-windows: Add functionality for dp ports, hv nics, hv ports

>Add functionality for dp ports, hv nics, hv ports This is a little ahead of its time. Adding functional changes when we can¹t even test it with the upstream code is not the way to go. This should be resurrected once the Netlink-integration is complete and we have a OVS working on HyperV. > >In

Re: [ovs-dev] [PATCH 06/15] datapath-windows: Add List.h

>Add List.h > >Macros to be used for operating over a list. >Other possible macros & functions to operate on lists should be added >here. Can you also put these macros to use with some existing code? I am a little wary of making/using new utilities till we have a working user/kernel communication

Re: [ovs-dev] [PATCH 04/15] datapath-windows: We don't need wrappers for Interlocked ops

Hi Samuel, I like the wrapper because it keeps the code looking tidy. With the long names & casting the code line typically ends up way to long & unwieldy. InterlockedAdd64((LONGLONG volatile *) BasePointer->ChildObject->SomeStatVariable, (LONGLONG) val); Vs atomic_add64(BasePointer->ChildObject

Re: [ovs-dev] [PATCH 02/15] datapath-windows: Move and Rename files

Hi Samuel, >Move and rename files: These are two separate changes. Renaming the files to drop ŒOvs¹ is fine. But, I am not in favor of redoing the directory structure (as expressed in the another thread). If you can separate these out, we could apply the renaming patch while we discuss the need

Re: [ovs-dev] datapath-windows: Could we rename the files please?

My 2 cents, I am not in favor of redoing the directory structure in the anticipation of it becoming more complex. When/If it becomes complex, we can do the re-structuring. I don¹t see any need to do it right now. Thanks! Saurabh From: Nithin Raju Date: Wednesday, August 6, 2014 at 10:52 AM T

Re: [ovs-dev] Recent series of patches

Some of the changes say "we may use this in future". Unless there is an immediate patch that is using that functionality, it shouldn't be posted for review. OVS should not be used to park dead code in my opinion. Thanks! Saurabh From: Justin Pettit mailto:jpet...@nicira.com>> Date: Wednesday, A

Re: [ovs-dev] [PATCH] Update to the ovsext.sln

e3b23e935e29320f1d81 >0f35c3d4ed > >Signed-off-by: Alin Gabriel Serdean Acked-by: Saurabh Shah ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] Cloning packets for "action: set field"

Hi Samuel, > -Original Message- > From: Samuel Ghinet [mailto:sghi...@cloudbasesolutions.com] > Sent: Tuesday, August 05, 2014 5:00 AM > To: Saurabh Shah > Cc: dev@openvswitch.org > Subject: RE: Cloning packets for "action: set field" > > Hello Saur

Re: [ovs-dev] Items to discuss for 8/4 IRC meeting

4. Discuss implementation of netlink-windows.c. Thanks! Saurabh From: Nithin Raju mailto:nit...@vmware.com>> Date: Monday, August 4, 2014 at 7:11 PM To: "dev@openvswitch.org" mailto:dev@openvswitch.org>> Subject: [ovs-dev] Items to discuss for 8/4 IRC meeting hi Ales

Re: [ovs-dev] Cloning packets for "action: set field"

Hi Samuel, This is a bug. As you rightfully pointed, we shouldn't modify the original packet but instead copy out the relevant bits before modifying them. Copying the entire data buffer is simpler, but sub-optimal. We should only copy out the headers that are being modified. We already have the

Re: [ovs-dev] [PATCH] [PATCH] datapath-windows - fix crash when internal port is removed

latest one. Thanks! Saurabh From: Eitan Eliahu Date: Thursday, July 31, 2014 at 4:46 PM To: Saurabh Shah , "dev@openvswitch.org" Subject: RE: [ovs-dev] [PATCH] [PATCH] datapath-windows - fix crash when internal port is removed >Hi Saurabh, I removed the assert in the next

Re: [ovs-dev] [PATCH] [PATCH] datapath-windows - fix crash when internal port is removed

Hey Eitan, >BSOD while setting AllowManagementOS on $false #13 >https://urldefense.proofpoint.com/v1/url?u=https://github.com/openvswitch/ >ovs/issues/13&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=pEkjsHfytvHEWufeZPpgqS >OJMdMjuZPbesVsNhCUc0E%3D%0A&m=HCvhWNhGzijQI9QgNS1Zm2FCfEDPf3DswRG1vK1p1xA% >3D%0A&

Re: [ovs-dev] [PATCH] datapath-windows: Add temporary files to gitignore.

+Alin. From: Gurucharan Shetty mailto:shet...@nicira.com>> Date: Wednesday, July 30, 2014 at 2:58 PM To: Saurabh Shah mailto:ssaur...@vmware.com>> Cc: dev mailto:dev@openvswitch.org>> Subject: Re: [ovs-dev] [PATCH] datapath-windows: Add temporary files to gitignore. On Wed, Ju

Re: [ovs-dev] [PATCH] Change ovsext.inf Extension Name and GUID

JMdMjuZPbesVsNhCUc0E%3D%0A&m=S0skvYEXPWVOPeQSEcDcFmROoadXLCcAs9GHHy4UEg8% >3D%0A&s=37c5f4c4d5a856129e40eca233b5464221712d279b27f642b78ff3e50b8e3977 >by Saurabh Shah . > >Signed-off-by: Alin Gabriel Serdean >Reported-by: Saurabh Shah >--- > datapath-windows/ovsex

Re: [ovs-dev] Meeting summary and action items (7/29)

I just sent out the change myself, before I saw your mail. :) Thanks! Saurabh From: Alin Serdean mailto:aserd...@cloudbasesolutions.com>> Date: Wednesday, July 30, 2014 at 3:53 PM To: Saurabh Shah mailto:ssaur...@vmware.com>>, Justin Pettit mailto:jpet...@nicira.com>>, Nithi

[ovs-dev] [PATCH] datapath-windows: Rename the extension & vendor in the INF file.

Github issue: #14 Signed-off-by: Saurabh Shah Reported-by: Alessandro Pilotti --- datapath-windows/ovsext/OvsDriver.c |2 +- datapath-windows/ovsext/ovsext.inf | 18 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/datapath-windows/ovsext/OvsDriver.c

Re: [ovs-dev] Meeting summary and action items (7/29)

>On July 30, 2014 at 1:43:47 PM, Alessandro Pilotti >(apilo...@cloudbasesolutions.com) wrote: >> Hi guys, >> >> One small nit: >> >> Being this a community effort, can we rename the kernel extension from >>"VMWare OVS extension" >> to "Open vSwitch extension" or just "openvswitch"? The same a

Re: [ovs-dev] Meeting summary and action items (7/29)

Hi Alessandro, Hi guys, One small nit: Being this a community effort, can we rename the kernel extension from "VMWare OVS extension" to "Open vSwitch extension" or just "openvswitch"? The same applies to the vendor name. Sure. :) I created an issue to track this - https://github.com/openvswi

Re: [ovs-dev] [PATCH] datapath-windows: Fix compilation for kernel module.

> -Original Message- > From: Jesse Gross [mailto:je...@nicira.com] > Sent: Wednesday, July 30, 2014 12:28 PM > To: Saurabh Shah > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] datapath-windows: Fix compilation for kernel > module. > > On Wed, Jul 3

[ovs-dev] [PATCH] datapath-windows: Add temporary files to gitignore.

Github Issue: #12 Signed-off-by: Saurabh Shah Reported-by: Alin Serdean --- datapath-windows/.gitignore |5 + 1 file changed, 5 insertions(+) create mode 100644 datapath-windows/.gitignore diff --git a/datapath-windows/.gitignore b/datapath-windows/.gitignore new file mode 100644

[ovs-dev] [PATCH] datapath-windows: Fix compilation for kernel module.

These have the common structures that are shared with the windows kernel extension. Bug - https://github.com/openvswitch/ovs/issues/11. Signed-off-by: Saurabh Shah Reported-by: Alin Seardean --- include/linux/openvswitch.h |2 ++ lib/netlink-protocol.h |2 ++ 2 files changed, 4

[ovs-dev] [PATCH] datapath-windows: Fix compilation for kernel module.

These have the common structures that are shared with the windows kernel extension. Bug - https://github.com/openvswitch/ovs/issues/11. Signed-off-by: Saurabh Shah Reported-by: aserd...@cloudbasesolutions.com --- include/linux/openvswitch.h |2 ++ lib/netlink-protocol.h |2 ++ 2

[ovs-dev] [PATCH] datapath-windows: Fix compilation for kernel module.

These have the common structures that are shared with the windows kernel extension. Bug - https://github.com/openvswitch/ovs/issues/11. Signed-off-by: Saurabh Shah --- include/linux/openvswitch.h |2 ++ lib/netlink-protocol.h |2 ++ 2 files changed, 4 insertions(+) diff --git a

Re: [ovs-dev] [PATCH] netlink-socket: Add conceptual documentation.

This is excellent. Thanks, Ben. > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Monday, July 28, 2014 11:35 PM > To: dev@openvswitch.org > Cc: Ben Pfaff > Subject: [ovs-dev] [PATCH] netlink-socket: Add conceptual documentation. > > Base

[ovs-dev] [PATCH 0/1] OVS datapath support (kernel only) for HyperV.

which i posted a few minutes back) * The kernel does not include the Netlink integration yet. * From our experience, this has been a relatively stable kernel extension with no known BSOD issues. * Basic ping test works. Saurabh Shah (1): datapath-windows: Kernel module for Hyp

[ovs-dev] [PATCH] OVS datapath support (kernel only) for HyperV.

which i posted a few minutes back) * The kernel does not include the Netlink integration yet. * From our experience, this has been a relatively stable kernel extension with no known BSOD issues. * Basic ping test works. Saurabh Shah (1): datapath-windows: Kernel module for Hyp

[ovs-dev] [PATCH v3 0/3] Support for OVS datapath on Windows platform.

Cloudbase has been fixed - http://paste.openstack.org/show/84911/. Saurabh Shah (3): odp-util: Add utility function, odp_flow_key_to_flow_verbose. dpif-windows: Implement datapath interface for windows. datapath-windows: Implement the virtual switch forwarding ex

[ovs-dev] [PATCH v3 1/3] odp-util: Add utility function, odp_flow_key_to_flow_verbose.

Signed-off-by: Saurabh Shah --- lib/dpif-netdev.c | 17 + lib/odp-util.c| 24 lib/odp-util.h|2 ++ 3 files changed, 27 insertions(+), 16 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index fce2650..01ebcec 100644 --- a

Re: [ovs-dev] [PATCH v2 0/3] Support for OVS datapath on Windows platform.

4 at 8:30 PM To: Saurabh Shah mailto:ssaur...@vmware.com>>, Alessandro Pilotti mailto:apilo...@cloudbasesolutions.com>> Cc: "dev@openvswitch.org<mailto:dev@openvswitch.org>" mailto:dev@openvswitch.org>> Subject: RE: [ovs-dev] [PATCH v2 0/3] Support for OVS datapat

Re: [ovs-dev] [PATCH v2 0/3] Support for OVS datapath on Windows platform.

> >I disabled RX/TX >(02) works >(03) works > >Here is a flow with a tun_id maybe it will help: >PS C:\ovs_guys\binaries> .\ovs-dpctl.exe dump-flows | findstr tun >2014-07-26T02:10:30Z|1|socket_util|ERR|4789:0.0.0.0: bind: Only one >usage of each socket address (protocol/network a >ddress/port

Re: [ovs-dev] [PATCH v2 0/3] Support for OVS datapath on Windows platform.

M To: Saurabh Shah , Alessandro Pilotti Cc: "dev@openvswitch.org" Subject: RE: [ovs-dev] [PATCH v2 0/3] Support for OVS datapath on Windows platform. >Sorry forgot to restart the other hypervisor think this is the correct >output: > >PS C:\ovs_guys\binaries> .\ovs-vsctl.exe

Re: [ovs-dev] [PATCH v2 0/3] Support for OVS datapath on Windows platform.

From: Alessandro Pilotti Date: Friday, July 25, 2014 at 6:13 PM To: Saurabh Shah Cc: "dev@openvswitch.org" , Ankur Sharma , Rajiv Krishnamurthy , Guolin Yang Subject: Re: [ovs-dev] [PATCH v2 0/3] Support for OVS datapath on Windows platform. >Hi Saurabh, > >On 26

Re: [ovs-dev] [PATCH v2 0/3] Support for OVS datapath on Windows platform.

y 25, 2014 at 4:10 PM >To: Alessandro Pilotti >mailto:apilo...@cloudbasesolutions.com>>, > Saurabh Shah mailto:ssaur...@vmware.com>> >Cc: "dev@openvswitch.org<mailto:dev@openvswitch.org>" >mailto:dev@openvswitch.org>>, Ankur Sharma >mailto:ankursha

Re: [ovs-dev] [PATCH v2 0/3] Support for OVS datapath on Windows platform.

:apilo...@cloudbasesolutions.com>>, Saurabh Shah mailto:ssaur...@vmware.com>> Cc: "dev@openvswitch.org<mailto:dev@openvswitch.org>" mailto:dev@openvswitch.org>>, Ankur Sharma mailto:ankursha...@vmware.com>>, Rajiv Krishnamurthy mailto:krishnamurt...@vmware.com>>, Guol

Re: [ovs-dev] [PATCH v2 0/3] Support for OVS datapath on Windows platform.

Hi Alessandro, >Hi Saurabh, > >I¹d suggest that before doing a full review of the kernel driver we need >to have: > >* Userspace Netlink interface support (which means that patches 1 and 2 >in this >set can be skipped) There is some dependence between patches 2 & 3. In my V3 change I will drop ou

Re: [ovs-dev] plan to integrate Hyper-V support

Hi Alessandro, >>> >>> In short, both implementations have strengths and weaknesses. Each of >>> them could evolve by eliminating their weaknesses and adding the >>> strengths of the other, converging to meet somewhere in the middle, >>> but this would duplicate work and waste developer time. A

Re: [ovs-dev] plan to integrate Hyper-V support

> >On 26 Jul 2014, at 00:35, Ben Pfaff wrote: > >> On Thu, Jul 24, 2014 at 05:03:33PM -0700, Ben Pfaff wrote: >>> Here is what I want to do: >>> >>>* Apply the next version of Alin's series to support Netlink >>> userspace for Windows (as long as it doesn't break other >>> platforms

Re: [ovs-dev] plan to integrate Hyper-V support

>After thinking about the two Hyper-V ports of Open vSwitch, I have a >proposal to make progress on upstreaming. > >After reviewing code, following the on-list discussions, and >discussing both implementations with various people, I believe that >the following are important points of comparision

[ovs-dev] [PATCH v2 1/3] odp-util: Add utility function, odp_flow_key_to_flow_verbose.

Signed-off-by: Saurabh Shah --- lib/dpif-netdev.c | 17 + lib/odp-util.c| 24 lib/odp-util.h|2 ++ 3 files changed, 27 insertions(+), 16 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index fce2650..01ebcec 100644 --- a

[ovs-dev] [PATCH v2 0/3] Support for OVS datapath on Windows platform.

e of the major things that are addressed by this v2 patch: 01. Complete rewrite of the base code, so there is no dependency on MS-LPL license any more. 02. The following crash-report by Cloudbase has been fixed - http://paste.openstack.org/show/84911/. Saurabh Shah (3): odp-uti

Re: [ovs-dev] [PATCH 3/4] dpif-windows: Implement datapath interface for windows.

>On Fri, Jul 18, 2014 at 5:27 PM, Saurabh Shah wrote: >> Ben Pfaff writes: >> > The logging in dpif_windows_flow_del() seems like a debugging stray. >> >> Do you mean in do_put? > >I mean the one here: > >+static int >+dpif_windows_flow_del(struc

Re: [ovs-dev] [PATCH 3/4] dpif-windows: Implement datapath interface for windows.

Converted to plain text. Hopefully this will make my inline comments more apparent. > > >From: Ben Pfaff mailto:b...@nicira.com>> >Date: Wednesday, June 25, 2014 at 4:54 PM >To: Saurabh Shah mailto:ssaur...@vmware.com>> >Cc: "dev@openvswitch.org<ma

Re: [ovs-dev] [PATCH 4/4] datapath-windows: Implement the virtual switch forwarding extension.

On Mon, Jun 23, 2014 at 05:34:59PM -0700, Saurabh Shah wrote: With this implementation we support bridge backed forwarding (with VLAN tagging) & tunneling over VXLAN. Co-Authored-By: Eitan Eliahu mailto:elia...@vmware.com>> Signed-off-by: Eitan Eliahu mailto:elia...@vmware.com>>

  1   2   >