Some of the changes say "we may use this in future". Unless there is an immediate patch that is using that functionality, it shouldn't be posted for review. OVS should not be used to park dead code in my opinion.
Thanks! Saurabh From: Justin Pettit <jpet...@nicira.com<mailto:jpet...@nicira.com>> Date: Wednesday, August 6, 2014 at 9:49 AM To: Samuel Ghinet <sghi...@cloudbasesolutions.com<mailto:sghi...@cloudbasesolutions.com>> Cc: "dev@openvswitch.org<mailto:dev@openvswitch.org>" <dev@openvswitch.org<mailto:dev@openvswitch.org>> Subject: Re: [ovs-dev] Recent series of patches Thanks, Samuel, for posting those patches. As Eitan mentioned, it's helpful to reference the issue number for tracking purposes. It looks like Github is pretty smart about updating the issue tracker, too, when a commit goes in. Since our issue tracker is in a different repo from the code, I think you need to reference issues in the following way: ovs/ovs-issues#42 Obviously, that would link the patch with issue number 42. --Justin On August 6, 2014 at 9:36:41 AM, Eitan Eliahu (elia...@vmware.com<mailto:elia...@vmware.com>) wrote: Hi Sam, I was wondering if you could add an explanation for how (or if) each patch is related to the open issues or enhancements that we filed in Github. I think we need to see a motivation which is aligned with the priority we assigned to the open issues we filed. Otherwise, it would be hard to review or to understand the correct context. I am not saying that each patch must to be correlated to a Github issue but we would like to understand the context or the problem it solves. Thank you! Eitan _______________________________________________ dev mailing list dev@openvswitch.org<mailto:dev@openvswitch.org> https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/mailman/listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=pEkjsHfytvHEWufeZPpgqSOJMdMjuZPbesVsNhCUc0E%3D%0A&m=XZxgeMSTAJSLVkztoB9LEQPW3uzuCWSRJ0X6FmOgrv8%3D%0A&s=28abf337e3e1439d2b452c55934a028ae74db08fa79f889e98a967e8193d3768 _______________________________________________ dev mailing list dev@openvswitch.org<mailto:dev@openvswitch.org> https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/mailman/listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=pEkjsHfytvHEWufeZPpgqSOJMdMjuZPbesVsNhCUc0E%3D%0A&m=XZxgeMSTAJSLVkztoB9LEQPW3uzuCWSRJ0X6FmOgrv8%3D%0A&s=28abf337e3e1439d2b452c55934a028ae74db08fa79f889e98a967e8193d3768 _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
