Re: [ovs-dev] [PATCH 1/2] ovn-northd: Ability to loop-back in a router.

-Guru Shetty wrote: - >To: Mickey Spiegel/San Jose/IBM@IBMUS >From: Guru Shetty >Date: 07/07/2016 09:34PM >Cc: ovs dev >Subject: Re: [ovs-dev] [PATCH 1/2] ovn-northd: Ability to loop-back >in a router. > > > >On 7 July 2016 at 21:28, Guru Shetty wrote: > > >On 7 July 2016 at 20:30, Mic

Re: [ovs-dev] [PATCH v4 18/28] datapath: compat: Use dst-cache for Geneve and VxLAN tunnels.

On Thu, Jul 7, 2016 at 5:23 PM, Pravin B Shelar wrote: > It partialy backport commit: > commit d71785ffc7e7cae3fbdc4ea8a9d05b7a1c59f7b8 > Author: Paolo Abeni > > net: add dst_cache to ovs vxlan lwtunnel > > In case of UDP traffic with datagram length > below MTU this give abou

Re: [ovs-dev] [PATCH] ovn: Support chassis option in "l2gateway" logical ports

Thanks for the review Russel. Please see comments inline. On Fri, Jul 8, 2016 at 1:19 AM, Russell Bryant wrote: > Thanks for working on this! A few comments ... > > On Mon, Jul 4, 2016 at 7:10 AM, Numan Siddique > wrote: > >> ovn-controller will now bind the l2gateway logical ports. >> >> Sign

[ovs-dev] c’est juste une bombe!

Salut, Avez-vous déjà vu quelque chose comme ça? C’est une bombe que vous devez voir! Regardez le ici Affectueusement... bunker...@tiscali.it ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailm

Re: [ovs-dev] [patch_v1] ovn: Remove unreferenced patched datapaths

> > > > Its worrisome to have features that cannot be properly tested. > I suggest to prioritize the test support. > No testability -> No feature > That is fair. I am working on adding OVN tests to system-traffic.at so that I can add NAT related tests. > > > > > > > > > >> > >> > >> > >> > > >> >

Re: [ovs-dev] [PATCH 1/2] ovn-northd: Ability to loop-back in a router.

On 7 July 2016 at 21:28, Guru Shetty wrote: > > > On 7 July 2016 at 20:30, Mickey Spiegel wrote: > >> >To: dev@openvswitch.org >> >From: Gurucharan Shetty >> >Sent by: "dev" >> >Date: 07/05/2016 11:15AM >> >Subject: [ovs-dev] [PATCH 1/2] ovn-northd: Ability to loop-back in a >> router. >> > >> >

Re: [ovs-dev] [PATCH 1/2] ovn-northd: Ability to loop-back in a router.

On 7 July 2016 at 20:30, Mickey Spiegel wrote: > >To: dev@openvswitch.org > >From: Gurucharan Shetty > >Sent by: "dev" > >Date: 07/05/2016 11:15AM > >Subject: [ovs-dev] [PATCH 1/2] ovn-northd: Ability to loop-back in a > router. > > > >Currently, when a client looks at a load balancer VIP, > >it

Re: [ovs-dev] [PATCH 1/2] ovn-northd: Ability to loop-back in a router.

>To: dev@openvswitch.org >From: Gurucharan Shetty >Sent by: "dev" >Date: 07/05/2016 11:15AM >Subject: [ovs-dev] [PATCH 1/2] ovn-northd: Ability to loop-back in a router. > >Currently, when a client looks at a load balancer VIP, >it notices that it is in a different subnet than itself >and sends t

Re: [ovs-dev] [PATCH v4 10/28] datapath: compat: Update udp_sock_create

On Thu, Jul 7, 2016 at 7:17 PM, pravin shelar wrote: > On Thu, Jul 7, 2016 at 7:16 PM, Jesse Gross wrote: >> On Thu, Jul 7, 2016 at 7:13 PM, Jesse Gross wrote: >>> On Thu, Jul 7, 2016 at 5:23 PM, Pravin B Shelar wrote: diff --git a/datapath/linux/compat/include/linux/udp.h b/datapath

Re: [ovs-dev] [PATCH v4] dpif-netdev: Move setting of queue number to netdev layer.

Thanks for the patch, I think this moves in the right direction. I like how this patch removes "real_n_txq", as you pointed out it was confusing and, as proven here, unnecessary. I don't like very much that the netdev implementation decides to create max_tx_queue_id + 1 queues. I still think the

Re: [ovs-dev] [PATCH v4 10/28] datapath: compat: Update udp_sock_create

On Thu, Jul 7, 2016 at 7:16 PM, Jesse Gross wrote: > On Thu, Jul 7, 2016 at 7:13 PM, Jesse Gross wrote: >> On Thu, Jul 7, 2016 at 5:23 PM, Pravin B Shelar wrote: >>> diff --git a/datapath/linux/compat/include/linux/udp.h >>> b/datapath/linux/compat/include/linux/udp.h >>> new file mode 100644 >

Re: [ovs-dev] [PATCH v4 10/28] datapath: compat: Update udp_sock_create

On Thu, Jul 7, 2016 at 7:13 PM, Jesse Gross wrote: > On Thu, Jul 7, 2016 at 5:23 PM, Pravin B Shelar wrote: >> diff --git a/datapath/linux/compat/include/linux/udp.h >> b/datapath/linux/compat/include/linux/udp.h >> new file mode 100644 >> index 000..31ae022 >> --- /dev/null >> +++ b/datapat

[ovs-dev] [patch_v3] ovn: Remove unreferenced patched datapaths.

Patched datapaths that are no longer referenced should be removed from the patched_datapaths map; otherwise incorrect state references for a patched datapath may be used and also datapaths that are absent will be interpreted as present. There is some additional work to do for NAT support for the p

[ovs-dev] [patch_v3] ovn: Remove unreferenced patched datapaths.

Patched datapaths that are no longer referenced should be removed from the patched_datapaths map; otherwise incorrect state references for a patched datapath may be used and also datapaths that are absent will be interpreted as present. Signed-off-by: Darrell Ball --- ovn/controller/ovn-controll

Re: [ovs-dev] [PATCH v4 10/28] datapath: compat: Update udp_sock_create

On Thu, Jul 7, 2016 at 5:23 PM, Pravin B Shelar wrote: > diff --git a/datapath/linux/compat/include/linux/udp.h > b/datapath/linux/compat/include/linux/udp.h > new file mode 100644 > index 000..31ae022 > --- /dev/null > +++ b/datapath/linux/compat/include/linux/udp.h > @@ -0,0 +1,33 @@ > +#if

Re: [ovs-dev] [PATCH v4 04/28] datapath: backport: net: add dst_cache support

On Thu, Jul 7, 2016 at 6:44 PM, Jesse Gross wrote: > On Thu, Jul 7, 2016 at 6:38 PM, pravin shelar wrote: >> On Thu, Jul 7, 2016 at 6:04 PM, Jesse Gross wrote: >>> On Thu, Jul 7, 2016 at 5:23 PM, Pravin B Shelar wrote: This backports dst-cache implementation from upstream implementation. >

Re: [ovs-dev] [PATCH v4 05/28] datapath: backport: ip_tunnel_core: iptunnel_handle_offloads returns int and doesn't free skb

On Thu, Jul 7, 2016 at 5:23 PM, Pravin B Shelar wrote: > There is return type change in upstream handle-offload functions. > Following patch brings these changes in. > This is backport of aed069df ("ip_tunnel_core: > iptunnel_handle_offloads returns int and doesn't free skb") > I have also removed

[ovs-dev] [patch_v2] ovn: Remove unreferenced patched datapaths.

Patched datapaths that are no longer referenced should be removed from the patched_datapaths map; otherwise incorrect state references for a patched datapath may be used and also datapaths that are absent will be interpreted as present. There is some additional work to do for NAT support for the

[ovs-dev] [patch_v2] ovn: Remove unreferenced patched datapaths.

Patched datapaths that are no longer referenced should be removed from the patched_datapaths map; otherwise incorrect state references for a patched datapath may be used and also datapaths that are absent will be interpreted as present. Signed-off-by: Darrell Ball --- ovn/controller/ovn-controll

Re: [ovs-dev] [PATCH v4 04/28] datapath: backport: net: add dst_cache support

On Thu, Jul 7, 2016 at 6:38 PM, pravin shelar wrote: > On Thu, Jul 7, 2016 at 6:04 PM, Jesse Gross wrote: >> On Thu, Jul 7, 2016 at 5:23 PM, Pravin B Shelar wrote: >>> This backports dst-cache implementation from upstream implementation. >>> >>> commit 911362c70df5b766c243dc297fadeaced786ffd

Re: [ovs-dev] [PATCH v4 13/28] datapath: backport: ip_tunnel: Move stats update to iptunnel_xmit()

On Thu, Jul 7, 2016 at 5:23 PM, Pravin B Shelar wrote: > Upstream commit: > commit 039f50629b7f860f36644ed1f34b27da9aa62f43 > Author: Pravin B Shelar > > ip_tunnel: Move stats update to iptunnel_xmit() > > By moving stats update into iptunnel_xmit(), we can simplify > iptunnel

Re: [ovs-dev] [PATCH v4 04/28] datapath: backport: net: add dst_cache support

On Thu, Jul 7, 2016 at 6:04 PM, Jesse Gross wrote: > On Thu, Jul 7, 2016 at 5:23 PM, Pravin B Shelar wrote: >> This backports dst-cache implementation from upstream implementation. >> >> commit 911362c70df5b766c243dc297fadeaced786ffd8 >> Author: Paolo Abeni >> >> net: add dst_cache s

Re: [ovs-dev] [PATCH v4 01/28] datapath: compat: Refactor egress tunnel info

On Thu, Jul 7, 2016 at 5:23 PM, Pravin B Shelar wrote: > diff --git a/datapath/linux/compat/dev-openvswitch.c > b/datapath/linux/compat/dev-openvswitch.c > index 0d2088b..544c5e1 100644 > --- a/datapath/linux/compat/dev-openvswitch.c > +++ b/datapath/linux/compat/dev-openvswitch.c > +#ifndef HAVE

[ovs-dev] [PATCH] Windows: Add support for handling protocol (netlink family)

Windows datapath currently has no notion of netlink family. It assumes all netlink messages to belong to NETLINK_GENERIC family. This patch adds support for handling other protocols if the userspace sends it down to kernel. This patch introduces a new NETLINK_CMD - OVS_CTRL_CMD_SOCK_PROP to manag

Re: [ovs-dev] [PATCH v4 04/28] datapath: backport: net: add dst_cache support

On Thu, Jul 7, 2016 at 5:23 PM, Pravin B Shelar wrote: > This backports dst-cache implementation from upstream implementation. > > commit 911362c70df5b766c243dc297fadeaced786ffd8 > Author: Paolo Abeni > > net: add dst_cache support > This patch add a generic, lockless dst cache im

Re: [ovs-dev] [PATCH v2] ovn-controller: eliminate stall in ofctrl state machine

Oops, had intended to cc: Justin. - Original Message - > From: "Lance Richardson" > To: dev@openvswitch.org > Sent: Thursday, July 7, 2016 8:31:08 PM > Subject: [ovs-dev] [PATCH v2] ovn-controller: eliminate stall in ofctrl > state machine > > The "ovn -- 2 HVs, 3 LRs connected via

[ovs-dev] [PATCH v2] ovn-controller: eliminate stall in ofctrl state machine

The "ovn -- 2 HVs, 3 LRs connected via LS, static routes" test case currently exhibits frequent failures. These failures occur because, at the time that the test packets are sent to verify forwarding, no flows have been installed in the vswitch for one of the hypervisors. Investigation shows that,

[ovs-dev] [PATCH v4 26/28] datapath: backport: ovs/geneve: fix rtnl notifications on iface deletion

Upstream Commit: commit 41009481b690493c169ce85f591b9d32c6fd9422 Author: Nicolas Dichtel ovs/geneve: fix rtnl notifications on iface deletion The function geneve_dev_create_fb() (only used by ovs) never calls rtnl_configure_link(). The consequence is that dev->rtnl_link_state

[ovs-dev] [PATCH v4 28/28] datapath: backport: iptunnel: make rx/tx bytes counters consistent

Upstream commit: commit bc22a0e2ea03b75b51a1f722f93821744b5b5ff1 Author: Nicolas Dichtel iptunnel: make rx/tx bytes counters consistent This was already done a long time ago in commit 64194c31a0b6 ("inet: Make tunnel RX/TX byte counters more consistent") but tx path was broken (

[ovs-dev] [PATCH v4 27/28] datapath: backport: ovs/vxlan: fix rtnl notifications on iface deletion

At this point OVS tunneling is insync with upstream net branch (commit 9a0fee2b552b1). upstream commit: commit cf5da330bbdd0c06b05c525a3d1d58ccd82c87a6 Author: Nicolas Dichtel ovs/vxlan: fix rtnl notifications on iface deletion The function vxlan_dev_create() (only used by ovs)

[ovs-dev] [PATCH v4 22/28] datapath: backport: udp_offload: Set encapsulation before inner completes.

Upstream commit: commit 229740c63169462a838a8b8e16391ed000934631 Author: Jarno Rajahalme udp_offload: Set encapsulation before inner completes. UDP tunnel segmentation code relies on the inner offsets being set for an UDP tunnel GSO packet, but the inner *_complete() function

[ovs-dev] [PATCH v4 24/28] datapath: backport: geneve: fix tx_errors statistics

Upstream commit: commit efeb2267bba8aa893afdadfc9bae4790777c600c Author: Haishuang Yan geneve: fix tx_errors statistics Tx errors present summation of errors encountered while transmitting packets. Signed-off-by: Haishuang Yan Signed-off-by: David S. Miller Signed

[ovs-dev] [PATCH v4 20/28] datapath: compat: get rid of OVS_CB inner header offsets.

OVS has GSO compat functionality which needs inner offset of the packet to segment a packet. older kernel did not include these offsets in skb, therefore these were stored in OVS_GSO_CB. Now OVS has dropped support for these old kernel, So none of the supported kernel needs this comapt code. Follow

[ovs-dev] [PATCH v4 00/28] datapath: compat: Add support for IPv6 Geneve and VxLAN tunnels.

This patch series update OVS compat layer to handle IPv6 UDP based tunnels. While doing this various fixes and updates to tunnel code are also brought in. This series sync OVS tunnel compat codebase upto latest net branch (commit 9a0fee2b552b1235fb1706ae1fc664ae74573be8). v3-v4: Fixed according to

[ovs-dev] [PATCH v4 25/28] datapath: backport: ovs/gre, geneve: fix error path when creating an iface

Upstream commit: commit 106da663ff495e0aea3ac15b8317aa410754fcac Author: Nicolas Dichtel ovs/gre,geneve: fix error path when creating an iface After ipgre_newlink()/geneve_configure() call, the netdev is registered. Fixes: 7e059158d57b ("vxlan, gre, geneve: Set a large MTU o

[ovs-dev] [PATCH v4 23/28] datapath: backport: udp: prevent skbs lingering in tunnel socket queues

Upstream commit: commit e5aed006be918af163eb397e45aa5ea6cefd5e01 Author: Hannes Frederic Sowa udp: prevent skbs lingering in tunnel socket queues In case we find a socket with encapsulation enabled we should call the encap_recv function even if just a udp header without paylo

[ovs-dev] [PATCH v4 21/28] datapath: backport: geneve: add IPv6 bits to geneve_fill_metadata_dst

Upstream commit: commit b8812fa88371ae567c907448d9a7ba62d09b90c9 Author: John W. Linville geneve: add IPv6 bits to geneve_fill_metadata_dst Signed-off-by: John W. Linville Reviewed-by: Jesse Gross Signed-off-by: David S. Miller Signed-off-by: Pravin B Shelar Acked-by

[ovs-dev] [PATCH v4 19/28] datapath: backport: openvswitch: correct encoding of set tunnel action attributes

upstream commit: commit e905eabc90a5b787d8708df164543ee295bea5f2 Author: Simon Horman openvswitch: correct encoding of set tunnel action attributes In a set action tunnel attributes should be encoded in a nested action. I noticed this because ovs-dpctl was reporting an e

[ovs-dev] [PATCH v4 17/28] datapath: Add support for IPv6 tunnels.

Mostly backports upstream commit along with other pieces to make IPv6 tunneling work. commit 6b26ba3a7d952e611dcde1f3f77ce63bcc70540a Author: Jiri Benc openvswitch: netlink attributes for IPv6 tunneling Add netlink attributes for IPv6 tunnel addresses. This enables IPv6 support

[ovs-dev] [PATCH v4 11/28] datapath: compat: Update IPv6 in setup_udp_tunnel_sock()

Update setup_udp_tunnel_sock() to handle ipv6 sockets. Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross --- datapath/linux/compat/include/net/udp_tunnel.h | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/datapath/linux/compat/include/net/udp_tunnel.h b/d

[ovs-dev] [PATCH v4 18/28] datapath: compat: Use dst-cache for Geneve and VxLAN tunnels.

It partialy backport commit: commit d71785ffc7e7cae3fbdc4ea8a9d05b7a1c59f7b8 Author: Paolo Abeni net: add dst_cache to ovs vxlan lwtunnel In case of UDP traffic with datagram length below MTU this give about 2% performance increase when tunneling over ipv4 and about 60% w

[ovs-dev] [PATCH v4 15/28] datapath: compat: Add support for IPv6 UDP tunnel segmentation.

Next patch adds support for IPV6 Geneve and VXLAN, But support for UDP segmentation is available on all supported kernel. Following patch adds support for UDP tunnels over IPv6 for such kernels. Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross --- datapath/linux/compat/gso.c

[ovs-dev] [PATCH v4 14/28] datapath: compat: Prepare tnl-segmentation for ipv6.

Current tnl_skb_gso_segment() is written for ipv4 tunnels. Following patch make it generic so that it can also handle ipv6 tunnels. Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross --- datapath/linux/compat/gso.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a

[ovs-dev] [PATCH v4 10/28] datapath: compat: Update udp_sock_create

Update udp-socket-create to create ipv6 socket currectly. Partially backports commit fd384412e199b ("udp_tunnel: Seperate ipv6 functions into its own file.") Signed-off-by: Pravin B Shelar --- acinclude.m4 | 2 + datapath/linux/Modules.mk

[ovs-dev] [PATCH v4 13/28] datapath: backport: ip_tunnel: Move stats update to iptunnel_xmit()

Upstream commit: commit 039f50629b7f860f36644ed1f34b27da9aa62f43 Author: Pravin B Shelar ip_tunnel: Move stats update to iptunnel_xmit() By moving stats update into iptunnel_xmit(), we can simplify iptunnel_xmit() usage. With this change there is no need to call another f

[ovs-dev] [PATCH v4 12/28] datapath: backport: udp: Add socket based GRO and config

Upstream commit: commit 38fd2af24fcfda93f9fea3e53f26e48775ae9e09 Author: Tom Herbert udp: Add socket based GRO and config Add gro_receive and gro_complete to struct udp_tunnel_sock_cfg. Signed-off-by: Tom Herbert Signed-off-by: David S. Miller Signed-off-by: Pravin B

[ovs-dev] [PATCH v4 09/28] datapath: compat: rename HAVE_METADATA_DST to USE_UPSTREAM_TUNNEL

To better represent the meaning of symbol. Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross --- acinclude.m4 | 2 +- datapath/linux/compat/geneve.c | 2 +- datapath/linux/compat/gre.c | 4 ++-- datapath/linux/compat/

[ovs-dev] [PATCH v4 07/28] datapath: compat: Remove unnecessary iptunnel_xmit() declaration.

Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross --- datapath/linux/compat/include/net/ip_tunnels.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/datapath/linux/compat/include/net/ip_tunnels.h b/datapath/linux/compat/include/net/ip_tunnels.h index cea75a1..b9fa76f 100644 --

[ovs-dev] [PATCH v4 06/28] datapath: backport: tunnel: introduce ipv6_tun_rx_dst()

Update ovs_udp_tun_rx_dst() to handle ipv6 tunnels. This commit partially backports c29a70d2c ("tunnel: introduce udp_tun_rx_dst()") Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross --- datapath/linux/compat/include/net/dst_metadata.h | 46 ++-- datapath/linux/compat/in

[ovs-dev] [PATCH v4 08/28] datapath: backport: ip_tunnel: add support for setting flow label via collect metadata

Update udp_tunnel6_xmit_skb(). Specificaly changes are related to setting ipv6 label. Upstream commit: commit 134611446dc657e1bbc73ca0e4e6b599df687db0 Author: Daniel Borkmann ip_tunnel: add support for setting flow label via collect metadata This patch extends udp_tunnel6_xmit_s

[ovs-dev] [PATCH v4 03/28] datapath: backport: tunnels: Remove encapsulation offloads on decap.

Following patch backports updated iptunnel pull function. Also brings in following upstream fix: commit a09a4c8dd1ec7f830e1fb9e59eb72bddc965d168 Author: Jesse Gross tunnels: Remove encapsulation offloads on decap. If a packet is either locally encapsulated or processed through G

[ovs-dev] [PATCH v4 05/28] datapath: backport: ip_tunnel_core: iptunnel_handle_offloads returns int and doesn't free skb

There is return type change in upstream handle-offload functions. Following patch brings these changes in. This is backport of aed069df ("ip_tunnel_core: iptunnel_handle_offloads returns int and doesn't free skb") I have also removed duplicate definitions of tunnel_handle_offloads() from ip-tunnel

[ovs-dev] [PATCH v4 04/28] datapath: backport: net: add dst_cache support

This backports dst-cache implementation from upstream implementation. commit 911362c70df5b766c243dc297fadeaced786ffd8 Author: Paolo Abeni net: add dst_cache support This patch add a generic, lockless dst cache implementation. The need for lock is avoided updating the dst cach

[ovs-dev] [PATCH v4 01/28] datapath: compat: Refactor egress tunnel info

upstream tunnel egress info is retrieved using ndo_fill_metadata_dst. Since we do not have it on older kernel we need to keep vport operation to do same on these kernels. Following patch try to merge these to operations into one to avoid code duplication. This commit backports fc4099f1 ("openvswitc

[ovs-dev] [PATCH v4 02/28] datapath: backport: iptunnel: scrub packet in iptunnel_pull_header

Upstream Commit: commit 7f290c94352e59b1d720055fce760a69a63bd0a1 Author: Jiri Benc iptunnel: scrub packet in iptunnel_pull_header Part of skb_scrub_packet was open coded in iptunnel_pull_header. Let it call skb_scrub_packet directly instead. Signed-off-by: Jiri Benc

[ovs-dev] Delivery failed

___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [patch_v1] ovn: Remove unreferenced patched datapaths

On Thu, Jul 7, 2016 at 3:55 PM, Guru Shetty wrote: > >> >> I don't testcases for OVN NAT at all - did I miss them ? >> How can a feature be committed without testcases ? >> > > We currently do not have NAT in userspace datapath to test OVN NAT. I > think this is the same case with OVN firewall. B

Re: [ovs-dev] [patch_v1] ovn: Remove unreferenced patched datapaths

On Thu, Jul 7, 2016 at 4:09 PM, Darrell Ball wrote: > > > On Thu, Jul 7, 2016 at 3:38 PM, Guru Shetty wrote: > >> >> >> On 6 July 2016 at 18:37, Darrell Ball wrote: >> >>> Patched datapaths that are no longer referenced should be removed from >>> the patched_datapaths map; otherwise incorrect s

Re: [ovs-dev] [PATCH] ovn-controller: eliminate stall in ofctrl state machine

- Original Message - > From: "Justin Pettit" > To: "Lance Richardson" > Cc: dev@openvswitch.org > Sent: Thursday, July 7, 2016 5:25:52 PM > Subject: Re: [ovs-dev] [PATCH] ovn-controller: eliminate stall in ofctrl > state machine > > > > On Jul 5, 2016, at 5:58 AM, Lance Richardson wro

Re: [ovs-dev] [patch_v1] ovn: Remove unreferenced patched datapaths

On Thu, Jul 7, 2016 at 3:38 PM, Guru Shetty wrote: > > > On 6 July 2016 at 18:37, Darrell Ball wrote: > >> Patched datapaths that are no longer referenced should be removed from >> the patched_datapaths map; otherwise incorrect state references for a >> patched datapath may be used and also data

Re: [ovs-dev] [patch_v1] ovn: Remove unreferenced patched datapaths

> > > > I don't testcases for OVN NAT at all - did I miss them ? > How can a feature be committed without testcases ? > We currently do not have NAT in userspace datapath to test OVN NAT. I think this is the same case with OVN firewall. Both of them are currently dependent on OpenStack testing. We

Re: [ovs-dev] [patch_v1] ovn: Remove unreferenced patched datapaths

On Thu, Jul 7, 2016 at 3:45 PM, Guru Shetty wrote: > > > On 7 July 2016 at 14:15, Darrell Ball wrote: > >> On Thu, Jul 7, 2016 at 1:17 PM, Russell Bryant wrote: >> >> > >> > >> > On Wed, Jul 6, 2016 at 8:37 PM, Darrell Ball wrote: >> > >> >> Patched datapaths that are no longer referenced shou

Re: [ovs-dev] [patch_v1] ovn: Remove unreferenced patched datapaths

On 7 July 2016 at 14:15, Darrell Ball wrote: > On Thu, Jul 7, 2016 at 1:17 PM, Russell Bryant wrote: > > > > > > > On Wed, Jul 6, 2016 at 8:37 PM, Darrell Ball wrote: > > > >> Patched datapaths that are no longer referenced should be removed from > >> the patched_datapaths map; otherwise incorr

Re: [ovs-dev] [patch_v1] ovn: Remove unreferenced patched datapaths

On 6 July 2016 at 18:37, Darrell Ball wrote: > Patched datapaths that are no longer referenced should be removed from > the patched_datapaths map; otherwise incorrect state references for a > patched datapath may be used and also datapaths that are absent will be > interpreted as present. > > Sig

[ovs-dev] [PATCH v3] OVN: Fix ARP request flow in router ingress table

TPA in arp requests generated for unknown MAC-to-IP bindings is currently set to DST_IP of the original packet. These arps will not be resolved when the DST_IP is rechable via the default gateway. This patch fixes the issue by setting the TPA to reg0. In routing stage reg0 is set to IP of the defau

[ovs-dev] [PATCH v2] ovn-sbctl: eliminate a spurious test case error cause

The "ovn-sbctl" test fails occasionally due to log messages similar to these: jsonrpc|WARN|unix: receive error: Connection reset by peer reconnect|WARN|unix: connection dropped (Connection reset by peer) Since we're already ignoring "Broken pipe" messages in this test case, and the difference

Re: [ovs-dev] [PATCH] ovn-controller: eliminate stall in ofctrl state machine

> On Jul 5, 2016, at 5:58 AM, Lance Richardson wrote: > > --- a/ovn/controller/ofctrl.c > +++ b/ovn/controller/ofctrl.c > @@ -410,36 +410,36 @@ ofctrl_run(const struct ovsrec_bridge *br_int) > default: > OVS_NOT_REACHED(); > } > -} while (state != old_state); > >

Re: [ovs-dev] [patch_v1] ovn: Remove unreferenced patched datapaths

On Thu, Jul 7, 2016 at 1:17 PM, Russell Bryant wrote: > > > On Wed, Jul 6, 2016 at 8:37 PM, Darrell Ball wrote: > >> Patched datapaths that are no longer referenced should be removed from >> the patched_datapaths map; otherwise incorrect state references for a >> patched datapath may be used and

Re: [ovs-dev] [PATCH V2] ovn test: Skip "send gratuitous arp on localnet" if no Python installed

Thanks for the patch and ACK. I applied this to master. On Mon, Jul 4, 2016 at 9:03 AM, Alin Serdean < aserd...@cloudbasesolutions.com> wrote: > Acked-by: Alin Gabriel Serdean > > Thanks, > Alin. > > > -Mesaj original- > > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul B

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

On Wed, Jul 6, 2016 at 10:59 AM, Simon Horman wrote: > From: Lorand Jakab > > Implementation of the pop_eth and push_eth actions in the kernel, and > layer 3 flow support. > > This doesn't actually do anything yet as no layer 2 tunnel ports are > supported yet. The original patch by Lorand was ag

Re: [ovs-dev] [PATCH net-next v11 4/6] openvswitch: add support to push and pop mpls for layer3 packets

On Wed, Jul 6, 2016 at 10:59 AM, Simon Horman wrote: > Allow push and pop mpls actions to act on layer 3 packets by teaching > them not to access non-existent L2 headers of such packets. > > Signed-off-by: Simon Horman > --- > v11 > * group l2 code in pop_mpls() > > v10 > * Limit scope of hdr in

Re: [ovs-dev] [PATCH net-next v11 2/6] gre: unset mac header for non-TEB packets received by ipgre device

On Wed, Jul 6, 2016 at 10:59 AM, Simon Horman wrote: > unset rather than reset mach header for non-TEB packets received by an > ipgre device. This allows skb_transport_header_was_set to be subsequently > used to differentiate TEB and non-TEB packets recieved on an ipgre device. > > Signed-off-by:

Re: [ovs-dev] [PATCH net-next v11 3/6] openvswitch: set skb protocol and mac_len when receiving on internal device

On Wed, Jul 6, 2016 at 10:59 AM, Simon Horman wrote: > * Set skb protocol based on contents of packet. I have observed this is > necessary to get actual protocol of a packet when it is injected into an > internal device e.g. by libnet in which case skb protocol will be set to > ETH_ALL. > I

Re: [ovs-dev] [PATCH net-next v11 1/6] net: introduce skb_transport_header_was_set()

On Wed, Jul 6, 2016 at 10:59 AM, Simon Horman wrote: > This helper resets the mac_header of an skb to a state where > skb_transport_header_was_set() will return false. > > This is intended to be used with packets received on > ARPHRD_NONE devices without an Ethernet header in the inner packet. > I

[ovs-dev] [PATCH v2] OVN: Fix ARP request flow in router ingress table

TPA in arp requests generated for unknown MAC-to-IP bindings is currently set to DST_IP of the original packet. These arps will not be resolved when the DST_IP is rechable via the default gateway. This patch fixes the issue by setting the TPA to reg0. In routing stage reg0 is set to IP of the defau

Re: [ovs-dev] [patch_v1] ovn: Remove unreferenced patched datapaths

On Wed, Jul 6, 2016 at 8:37 PM, Darrell Ball wrote: > Patched datapaths that are no longer referenced should be removed from > the patched_datapaths map; otherwise incorrect state references for a > patched datapath may be used and also datapaths that are absent will be > interpreted as present.

Re: [ovs-dev] [PATCH] ovn-sbctl: Change lport-(un)bind to lsp-(un)bind.

On Sat, Jul 2, 2016 at 12:27 PM, Ben Pfaff wrote: > On Fri, Jun 24, 2016 at 04:37:58PM -0400, Russell Bryant wrote: > > A previous commit changed the command names in ovn-nbctl from lport-* to > > lsp-*. Change lport-bind and lport-unbind in ovn-sbctl to match. > > > > Signed-off-by: Russell Bry

Re: [ovs-dev] [PATCH] ovn: Support chassis option in "l2gateway" logical ports

Thanks for working on this! A few comments ... On Mon, Jul 4, 2016 at 7:10 AM, Numan Siddique wrote: > ovn-controller will now bind the l2gateway logical ports. > > Signed-Off-by: Numan Siddique > --- > ovn/TODO | 9 - > ovn/controller/binding.c | 33 +

Re: [ovs-dev] [PATCH v1] Fix IPFIX test cases issue

Thanks! Acked-by: Paul Boca > -Original Message- > From: Benli Ye [mailto:dani...@vmware.com] > Sent: Thursday, July 7, 2016 6:18 PM > To: b...@ovn.org; wen...@vmware.com; wqi...@vmware.com; Paul Boca; > dev@openvswitch.org > Cc: Benli Ye > Subject: [PATCH v1] Fix IPFIX test cases issue

Re: [ovs-dev] [PATCH] ovn-sbctl: eliminate a spurious test case error cause

Self-NAK, this is needed in two other locations and a typo needs to be fixed. V2 is in progress. - Original Message - > From: "Lance Richardson" > To: dev@openvswitch.org > Sent: Thursday, July 7, 2016 2:49:14 PM > Subject: [ovs-dev] [PATCH] ovn-sbctl: eliminate a spurious test case error

[ovs-dev] [PATCH] OVN-Tutorial: Update sample output.

A previous patch made some additions to section 1 of this tutorial. This patch includes updates to the sample output that I got while testing the additions to the tutorial. Signed-off-by: Russell Bryant --- tutorial/OVN-Tutorial.md | 93 +--- 1 file ch

Re: [ovs-dev] [PATCH] ovn: improve OVN tutorial.

On Mon, Jul 4, 2016 at 4:31 PM, Ben Pfaff wrote: > Russell, would you mind reviewing this? Sure! > On Mon, Jul 04, 2016 at 08:03:49AM -0700, Ben Pfaff wrote: > > From: nickcooper-zhangtonghao > > > > Improve the tutorial of the basic OVN features. The addresses and > port_security > > column

Re: [ovs-dev] [PATCH] INSTALL.Docker.md: Clarify OVS python library path.

On Thu, Jul 7, 2016 at 3:32 AM, Gurucharan Shetty wrote: > Reported-by: Taekho Nam > Signed-off-by: Gurucharan Shetty > --- > AUTHORS | 1 + > INSTALL.Docker.md | 23 +++ > 2 files changed, 20 insertions(+), 4 deletions(-) > > diff --git a/AUTHORS b/AUTHORS > ind

Re: [ovs-dev] [PATCH v2] ovn-controller: Remove old address set after change.

On Thu, Jul 7, 2016 at 1:52 PM, Flaviof wrote: > On Thu, Jul 7, 2016 at 2:37 PM, Ryan Moats wrote: > > > Currently, when address set value changes, ovn controller > > doesn't remove the old entry from the tracking hash, it > > just adds the new one, leading to multiple entries for the > > same s

Re: [ovs-dev] [PATCH v2] ovn-controller: Remove old address set after change.

On Thu, Jul 7, 2016 at 2:37 PM, Ryan Moats wrote: > Currently, when address set value changes, ovn controller > doesn't remove the old entry from the tracking hash, it > just adds the new one, leading to multiple entries for the > same symbol. > > Fix this behavior and add a smoke test to avoid a

[ovs-dev] [PATCH] ovn-sbctl: eliminate a spurious test case error cause

The "ovn-sbctl" test fails occasionally due to log messages similar to these: jsonrpc|WARN|unix: receive error: Connection reset by peer reconnect|WARN|unix: connection dropped (Connection reset by peer) Since we're already ignoring "Broken pipe" messages in this test case, and the difference

Re: [ovs-dev] [PATCH] [RFC Patch] ovn-controller: ignore lflow matching remote VM port

On Thu, Jul 7, 2016 at 12:07 PM, Zong Kai Li wrote: > Currently, ovn-controller will install all lflows for a logical > switch, when ovn-controller determines not to skip processing of > that logical switch. > > This will install too many OVS flows. We have 11 tables for logical > switch ingress p

[ovs-dev] [PATCH v2] ovn-controller: Remove old address set after change.

Currently, when address set value changes, ovn controller doesn't remove the old entry from the tracking hash, it just adds the new one, leading to multiple entries for the same symbol. Fix this behavior and add a smoke test to avoid a regression in the future. Signed-off-by: Ryan Moats --- ovn

[ovs-dev] [PATCH] INSTALL.Docker.md: Clarify OVS python library path.

Reported-by: Taekho Nam Signed-off-by: Gurucharan Shetty --- AUTHORS | 1 + INSTALL.Docker.md | 23 +++ 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/AUTHORS b/AUTHORS index 704ba40..5d86dc6 100644 --- a/AUTHORS +++ b/AUTHORS @@ -432,6 +432,7 @@ S

Re: [ovs-dev] [PATCH v6 1/1] ovn: Apply ACL changes to existing connections.

On Thu, Jul 7, 2016 at 12:13 PM, Justin Pettit wrote: > > > On Jun 30, 2016, at 10:14 PM, Russell Bryant wrote: > > > > diff --git a/ovn/northd/ovn-northd.8.xml b/ovn/northd/ovn-northd.8.xml > > index 260cc14..d2bddcb 100644 > > --- a/ovn/northd/ovn-northd.8.xml > > +++ b/ovn/northd/ovn-northd.8

Re: [ovs-dev] [PATCH] Remove old address set after change.

On Thu, Jul 7, 2016 at 1:04 PM, Russell Bryant wrote: > > > On Thu, Jul 7, 2016 at 12:18 PM, Thadeu Lima de Souza Cascardo < > casca...@redhat.com> wrote: > >> On Thu, Jul 07, 2016 at 11:24:25AM -0500, Ryan Moats wrote: >> > Currently, when address set value changes, ovn controller >> > doesn't r

Re: [ovs-dev] [PATCH] Remove old address set after change.

On Thu, Jul 7, 2016 at 12:18 PM, Thadeu Lima de Souza Cascardo < casca...@redhat.com> wrote: > On Thu, Jul 07, 2016 at 11:24:25AM -0500, Ryan Moats wrote: > > Currently, when address set value changes, ovn controller > > doesn't remove the old entry from the tracking hash, it > > just adds the new

Re: [ovs-dev] [PATCH] Remove old address set after change.

On Thu, Jul 07, 2016 at 11:24:25AM -0500, Ryan Moats wrote: > Currently, when address set value changes, ovn controller > doesn't remove the old entry from the tracking hash, it > just adds the new one, leading to multiple entries for the > same symbol. > > Fix this behavior. > > ToDo: figure out

Re: [ovs-dev] [PATCH v6 1/1] ovn: Apply ACL changes to existing connections.

> On Jun 30, 2016, at 10:14 PM, Russell Bryant wrote: > > diff --git a/ovn/northd/ovn-northd.8.xml b/ovn/northd/ovn-northd.8.xml > index 260cc14..d2bddcb 100644 > --- a/ovn/northd/ovn-northd.8.xml > +++ b/ovn/northd/ovn-northd.8.xml > > > @@ -282,20 +299,37 @@ > > > > -

Re: [ovs-dev] [PATCH] [RFC Patch] ovn-controller: ignore lflow matching remote VM port

"dev" wrote on 07/07/2016 12:07:16 PM: > From: Zong Kai Li > To: ovs dev > Date: 07/07/2016 12:07 PM > Subject: [ovs-dev] [PATCH] [RFC Patch] ovn-controller: ignore lflow > matching remote VM port > Sent by: "dev" > > Currently, ovn-controller will install all lflows for a logical > switch, wh

[ovs-dev] [PATCH] [RFC Patch] ovn-controller: ignore lflow matching remote VM port

Currently, ovn-controller will install all lflows for a logical switch, when ovn-controller determines not to skip processing of that logical switch. This will install too many OVS flows. We have 11 tables for logical switch ingress pipeline, 8 tables for logical switch egress pipeline now, and mo

[ovs-dev] [PATCH] Remove old address set after change.

Currently, when address set value changes, ovn controller doesn't remove the old entry from the tracking hash, it just adds the new one, leading to multiple entries for the same symbol. Fix this behavior. ToDo: figure out a test to avoid this in the future. Signed-off-by: Ryan Moats --- ovn/co

Re: [ovs-dev] [RFC Patch] dpif-netdev: dpcls per in_port with sorted subtables

> From: Jan Scheurich > Sent: Thursday, 07 July, 2016 10:28 > > I actually have some doubts about thread safety of the dpcls complex. My > understanding is that dpcls rules are inserted only by the owning PMD thread > itself as result of processing upcalls. But dplcs rules are removed by > revalid

Re: [ovs-dev] Salary [$900 /week]

Hello Let me present to you one of the largest worldwide enterprises where I work as a permanent manager of HR department. Our enterprise is connected with a great number of various activities, like: - real estate - companies setting-up and winding-up - supporting business in Europe and othe

[ovs-dev] [PATCH v1] Fix IPFIX test cases issue

IPFIX statistics 'tx pkts' means the number of successfully sending IPFIX packets, while 'tx errs' means sending error IPFIX packets. These two parameters can be affected by whether listening on port 4739 on local host. This case should be solved entirely by introducing PARSE_LISTENING_PORT as sFlo

  1   2   >