On Mon, Jul 4, 2016 at 4:31 PM, Ben Pfaff <b...@ovn.org> wrote: > Russell, would you mind reviewing this?
Sure! > On Mon, Jul 04, 2016 at 08:03:49AM -0700, Ben Pfaff wrote: > > From: nickcooper-zhangtonghao <nickcooper-zhangtong...@opencloud.tech> > > > > Improve the tutorial of the basic OVN features. The addresses and > port_security > > columns of the logical port is described in more detail. > > > > Signed-off-by: nickcooper-zhangtonghao > <nickcooper-zhangtong...@opencloud.tech> > Thanks for adding more docs! I think this is an improvement, so I applied this to master. One thought I had while reviewing it was that the "port security" example could have been applied to existing ports instead of adding 2 more ports for that. I also briefly considered whether any of this should be a new section since the first section was intended as the simplest possible example. None of that is a big deal, I just wanted to share some thoughts in case you want to keep working on this. I'm also going to post a follow-up patch that updates some out of date sample output. -- Russell Bryant _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
