Self-NAK, this is needed in two other locations and a typo 
needs to be fixed. V2 is in progress.
----- Original Message -----
> From: "Lance Richardson" <lrich...@redhat.com>
> To: dev@openvswitch.org
> Sent: Thursday, July 7, 2016 2:49:14 PM
> Subject: [ovs-dev] [PATCH] ovn-sbctl: eliminate a spurious test case error    
> cause
> 
> The "ovn-sbctl" test fails occasionally due to log messages
> similar to these:
> 
>   jsonrpc|WARN|unix: receive error: Connection reset by peer
>   reconnect|WARN|unix: connection dropped (Connection reset by peer)
> 
> Since we're already ignoring "Broken pipe" messages in this test
> case, and the difference between EPIPE and ECONNRESET on send
> is simply a matter of whether the peer had unconsumed data
> in its receive buffer when the peer socket was closed, it should
> be OK to ignore "reset by peer" logs as well.
> 
> Signed-off-by: Lance Richardson <lrich...@redhat.com>
> ---
>  tests/ovn-sbctl.at | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/ovn-sbctl.at b/tests/ovn-sbctl.at
> index 5232933..5151d5f 100644
> --- a/tests/ovn-sbctl.at
> +++ b/tests/ovn-sbctl.at
> @@ -33,8 +33,12 @@ m4_define([OVN_SBCTL_TEST_STOP],
>     # may immediately update the database.  this later update may cause
>     database
>     # sending update back to *ctl command if *ctl has not proceeded to exit
>     yet.
>     # and if *ctl command exits before database calling send, the send from
> -   # database will fail with 'Broken pipe' error.
> +   # database will fail with 'Broken pipe' error. Also removes all
> "connection
> +   # reset" warning logs by a similar rationale (either EPIPE or ECONNRESET
> can
> +   # be returned on a send depending on whether the peer had unconsumed data
> when
> +   # it closed the socket).
>     AT_CHECK([check_logs "$1
> +/connection reset/d
>  /Broken pipe/d"])
>     OVS_APP_EXIT_AND_WAIT([ovn-northd])
>     OVS_APP_EXIT_AND_WAIT_BY_TARGET([$OVS_RUNDIR/ovnnb_db.ctl],
>     [$OVS_RUNDIR/ovnnb_db.pid])
> --
> 2.5.5
> 
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
> 
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to