[ovs-dev] You have the experience now get the Degree to go with it!

2016-01-11 Thread Antony Steiner
EL0R'S, MASTER'S & DOCT0RATE DEGREES Add Bache1or's, Master's or Doctorate Degrees to your resume in just a few weeks and open avenues to promotion and better jobs! At your Own Pace! At your Own Schedule! At your Own Convenience! No Examination! No Study! No Class! Regardless of your age, sex,

Re: [ovs-dev] [PATCH 2/2] openvswitch: make auto-attach logic disable-able

2016-01-11 Thread Alexandru Ardelean
On Tue, Jan 12, 2016 at 9:26 AM, Alexandru Ardelean wrote: > On Tue, Jan 12, 2016 at 1:09 AM, Ben Pfaff wrote: > >> On Sat, Jan 09, 2016 at 08:49:44PM +0200, Alexandru Ardelean wrote: >> > This is the first in a series of attempts to trim the fat >> > off of OVS, to make it friendlier for embedd

Re: [ovs-dev] [PATCH 2/2] openvswitch: make auto-attach logic disable-able

2016-01-11 Thread Alexandru Ardelean
On Tue, Jan 12, 2016 at 1:09 AM, Ben Pfaff wrote: > On Sat, Jan 09, 2016 at 08:49:44PM +0200, Alexandru Ardelean wrote: > > This is the first in a series of attempts to trim the fat > > off of OVS, to make it friendlier for embedded systems. > > > > Signed-off-by: Alexandru Ardelean > > I don't

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix build by removing thread_is_pmd().

2016-01-11 Thread Ilya Maximets
On 12.01.2016 07:13, Ben Pfaff wrote: > On Mon, Jan 11, 2016 at 06:24:10PM -0800, Joe Stringer wrote: >> DPDK build was broken after commit 2f8932e8403a ("poll: Suppress logging >> for pmd threads.") due to the following error: >> >> lib/netdev-dpdk.c:245:13: error: static declaration of ‘thread_is

Re: [ovs-dev] [PATCH 1/2] poll: Suppress logging for pmd threads.

2016-01-11 Thread Ilya Maximets
On 12.01.2016 05:26, Joe Stringer wrote: > On 11 January 2016 at 10:11, Ben Pfaff wrote: >> On Tue, Dec 22, 2015 at 05:26:47PM +0300, Ilya Maximets wrote: >>> 'Unreasonably long poll interval's are reasonable for PMD threads. >>> Also reporting of high CPU usage is not necessary. >>> >>> Signed-of

Re: [ovs-dev] [PATCH] datapath: Fix deadlock on STT device destroy.

2016-01-11 Thread Pravin Shelar
On Mon, Jan 11, 2016 at 6:53 PM, Joe Stringer wrote: > On 11 January 2016 at 16:23, Pravin B Shelar wrote: >> STT unregisters nf-hook when there are no other STT devices >> left in the namespace. On some kernel versions the nf-unreg API >> take RTNL lock, but it is already taken in the tunnel dev

[ovs-dev] [PATCH v2] datapath: Fix deadlock on STT device destroy.

2016-01-11 Thread Pravin B Shelar
STT unregisters nf-hook when there are no other STT devices left in the namespace. On some kernel versions the nf-unreg API take RTNL lock, but it is already taken in the tunnel device destroy code path which results in deadlock. To fix the issue I moved the unreg call into net-exit. Bug: #1582410

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix build by removing thread_is_pmd().

2016-01-11 Thread Ben Pfaff
On Mon, Jan 11, 2016 at 06:24:10PM -0800, Joe Stringer wrote: > DPDK build was broken after commit 2f8932e8403a ("poll: Suppress logging > for pmd threads.") due to the following error: > > lib/netdev-dpdk.c:245:13: error: static declaration of ‘thread_is_pmd’ > follows non-static declaration > li

Re: [ovs-dev] why drop multicast packets on inactive slaves ?

2016-01-11 Thread Ben Pfaff
On Tue, Jan 12, 2016 at 11:17:32AM +0800, Huanle Han wrote: > I can't quit understand the code below in function "bond_check_admissibility". > Could you do some explanation for me? vswitchd/INTERNALS say: SLB Bonding --- SLB bonding allows a limited form of load balancing without the rem

[ovs-dev] why drop multicast packets on inactive slaves ?

2016-01-11 Thread Huanle Han
hi, guys, I can't quit understand the code below in function "bond_check_admissibility". Could you do some explanation for me? Why drop the multicast packet on inactive slaves? Will upstream switch output multicast packet to each interface in aggregation? If not, will ovs lose the packet? Because

Re: [ovs-dev] possible memory leak at add_monitored_table()

2016-01-11 Thread Andy Zhou
Not a big deal, William :-) Don't worry about it. On Mon, Jan 11, 2016 at 4:07 PM, William Tu wrote: > Hi Andy and Ben, > > Sorry for making this mistake. I will be careful next time. > > Regards, > William > > > On Mon, Jan 11, 2016 at 3:18 PM, Ben Pfaff wrote: > >> It looks like William roll

Re: [ovs-dev] [PATCH] datapath: Fix deadlock on STT device destroy.

2016-01-11 Thread Joe Stringer
On 11 January 2016 at 16:23, Pravin B Shelar wrote: > STT unregisters nf-hook when there are no other STT devices > left in the namespace. On some kernel versions the nf-unreg API > take RTNL lock, but it is already taken in the tunnel device > destroy code path which results in deadlock. To fix t

Re: [ovs-dev] [PATCH v3 0/4] Meter implementation for userspace datapath.

2016-01-11 Thread Jarno Rajahalme
> On Jan 11, 2016, at 9:35 AM, Ben Pfaff wrote: > > On Mon, Dec 21, 2015 at 11:38:33PM -0800, Ben Pfaff wrote: >> On Mon, Nov 30, 2015 at 10:03:11AM -0800, Jarno Rajahalme wrote: >>> On Nov 29, 2015, at 17:12, Ben Pfaff wrote: > On Mon, Nov 23, 2015 at 08:54:31PM -0800, Jarno Ra

Re: [ovs-dev] [PATCH 1/2] poll: Suppress logging for pmd threads.

2016-01-11 Thread Joe Stringer
On 11 January 2016 at 10:11, Ben Pfaff wrote: > On Tue, Dec 22, 2015 at 05:26:47PM +0300, Ilya Maximets wrote: >> 'Unreasonably long poll interval's are reasonable for PMD threads. >> Also reporting of high CPU usage is not necessary. >> >> Signed-off-by: Ilya Maximets > > Thanks, applied to mast

[ovs-dev] [PATCH] netdev-dpdk: Fix build by removing thread_is_pmd().

2016-01-11 Thread Joe Stringer
DPDK build was broken after commit 2f8932e8403a ("poll: Suppress logging for pmd threads.") due to the following error: lib/netdev-dpdk.c:245:13: error: static declaration of ‘thread_is_pmd’ follows non-static declaration lib/ovs-thread.h:526:6: note: previous declaration of ‘thread_is_pmd’ was he

Re: [ovs-dev] [PATCH 6/9] python: Stop using xrange().

2016-01-11 Thread Ben Pfaff
On Wed, Jan 06, 2016 at 03:50:26PM -0500, Russell Bryant wrote: > Python 2 had range() and xrange(). xrange() is more efficient, but > behaves differently so range() was retained for compatibility. Python 3 > only has range() and it behaves like Python 2's xrange(). > > Remove explicit use of xr

Re: [ovs-dev] [PATCH] flow: fix compilation of MINIFLOW_ASSERT

2016-01-11 Thread Jarno Rajahalme
Simon, Thanks for the fix. Pushed to master, Jarno > On Jan 10, 2016, at 9:00 PM, Simon Horman wrote: > > Often MINIFLOW_ASSERT is a no-op and compilation of code that uses > it is optimised out. This patch fixes compilation errors that occur > when that is not the case: > > * FLOWMAP_MAX

[ovs-dev] [PATCH 11/13] compat: Detect and use nf_ct_frag6_gather().

2016-01-11 Thread Joe Stringer
This function is a likely candidate for backporting, and currently relies on version checks to include the source or not. Grep for the appropriate functions instead, and include the backport based on that. Signed-off-by: Joe Stringer --- acinclude.m4

[ovs-dev] [PATCH 12/13] datapath: Re-designate OVS_FRAGMENT_BACKPORT.

2016-01-11 Thread Joe Stringer
Typically the way that we include backported code is by testing for existence of the feature in the upstream codebase via header checks, then attempt to use the upstream code as much as possible. However, for the IP fragmentation handling backport we have an additional constraint which is that we c

[ovs-dev] [PATCH 13/13] travis: Update kernel matrix.

2016-01-11 Thread Joe Stringer
Remove v4.2 as it is EOL; Add v4.3 as we support this version in OVS-2.5. Update other versions to the latest listed on kernel.org. Signed-off-by: Joe Stringer --- .travis.yml | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.travis.yml b/.travis.yml index ea1

[ovs-dev] [PATCH 07/13] compat: Detect and use nf_connlabels_get().

2016-01-11 Thread Joe Stringer
Signed-off-by: Joe Stringer --- acinclude.m4 | 2 ++ datapath/linux/compat/include/net/netfilter/nf_conntrack_labels.h | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index bb1d94e2187d..2d66

[ovs-dev] [PATCH 05/13] compat: Detect and use struct nf_conntrack_zone.

2016-01-11 Thread Joe Stringer
Rather than relying on version checks, detect the presence of this structure and use it if available. Signed-off-by: Joe Stringer --- acinclude.m4 | 2 ++ datapath/linux/compat/include/net/netfilter/nf_conntrack_expect.h | 4 ++-- datapath/lin

[ovs-dev] [PATCH 00/13] Remove conntrack backport version checks

2016-01-11 Thread Joe Stringer
Broadly, for the conntrack and ip_fragment backport in the OVS tree, we have until now depended on a macro to include the entire backport based on kernel version. Any kernel that the backport is compiled against from version v3.10 up to v4.3 ends up using the backported version of all functions, ra

[ovs-dev] [PATCH 01/13] compat: Detect and use inet_frag_queue->last_in.

2016-01-11 Thread Joe Stringer
Kernels 3.17 and older have this field, while newer kernels use the 'flags' field. Detect this in the build in case anyone backports this change to an older kernel. Signed-off-by: Joe Stringer --- acinclude.m4 | 3 +++ datapath/linux/compat/include/net/inet_frag.

[ovs-dev] [PATCH 08/13] compat: Detect and use __skb_dst_copy().

2016-01-11 Thread Joe Stringer
Signed-off-by: Joe Stringer --- acinclude.m4| 1 + datapath/linux/compat/include/net/dst.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/acinclude.m4 b/acinclude.m4 index 2d6653d1b8dd..5c758a641e1e 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@

[ovs-dev] [PATCH 03/13] compat: Detect and use inet_frags->frags_work.

2016-01-11 Thread Joe Stringer
Kernels 3.17 and newer have a work queue to evict old fragments, while older kernel versions use an LRU in the fast path; see upstream commit b13d3cbfb8e8 ("inet: frag: move eviction of queues to work queue"). This commit fixes the version checking so that rather than enabling the code for either o

[ovs-dev] [PATCH 09/13] compat: Detect and use inet_getpeer_v4().

2016-01-11 Thread Joe Stringer
Signed-off-by: Joe Stringer --- acinclude.m4 | 2 ++ datapath/linux/compat/include/net/inetpeer.h | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/acinclude.m4 b/acinclude.m4 index 5c758a641e1e..245267a26679 100644 --- a/acinclude.m4 +++ b/aci

[ovs-dev] [PATCH 10/13] compat: Detect and use upstream ip_fragment().

2016-01-11 Thread Joe Stringer
Previously a version check was used to determine whether the upstream ip_fragment() should be used or the backported version. The actual test is for whether upstream commit d6b915e29f4a ("ip_fragment: don't forward defragmented DF packet") is present, so test for that instead. Signed-off-by: Joe S

[ovs-dev] [PATCH 02/13] compat: Detect and use inet_frag_queue->list_evictor.

2016-01-11 Thread Joe Stringer
Kernels 3.17 to 4.2 have a work queue to evict old fragments, but do not track these fragments in an eviction list. On these kernels, we detect the absence of the list_evictor and provide one. This commit fixes the reliance on kernel versions in the case that this functionality is backported. Sign

[ovs-dev] [PATCH 06/13] compat: Detect and use nf_ipv6_ops->fragment.

2016-01-11 Thread Joe Stringer
Signed-off-by: Joe Stringer --- acinclude.m4 | 2 ++ datapath/compat.h| 5 + datapath/linux/compat/include/linux/netfilter_ipv6.h | 6 +++--- datapath/linux/compat/include/net/ip6_route.h| 13 +++--

[ovs-dev] [PATCH 04/13] compat: Detect and use inet_frags->lock.

2016-01-11 Thread Joe Stringer
Prior to ab1c724f6330 ("inet: frag: use seqlock for hash rebuild") upstream, a rwlock was used when rebuilding inet_frags. Rather than using a version check to detect this, search for it in the header and enable the code based on whether it exists. Signed-off-by: Joe Stringer --- acinclude.m4

[ovs-dev] [PATCH] OVN: Support bcast/mcast/unknown from gateway towards HV

2016-01-11 Thread Darrell Ball
--- ovn/controller-vtep/vtep.c | 207 - tests/ovn.at | 6 +- vtep/ovs-vtep | 18 +++- 3 files changed, 204 insertions(+), 27 deletions(-) diff --git a/ovn/controller-vtep/vtep.c b/ovn/controller-vtep/vtep.c index 016c2e0..0

[ovs-dev] [PATCH 1/1] OVN: Support bcast/mcast/unknown from gateway

2016-01-11 Thread Darrell Ball
From: Darrell Ball The following patch adds support for bcast/mcast/unknown ucast for OVN gateway for the direction from gateway towards HVs The includes adding unknown-dst entries from the OVN VTEP controller, adding flow programming support to the ovn gateway emulator, in case of flood port set

Re: [ovs-dev] [PATCH 5/9] python: Fix xmlrpclib imports.

2016-01-11 Thread Ben Pfaff
On Wed, Jan 06, 2016 at 03:50:25PM -0500, Russell Bryant wrote: > Fix imports of xmlrpclib to be compatible with Python 3. Python 2 had > xmlrpclib (client) and SimpleXMLRPCServer (server). In Python 3, these > have been renamed to xmlrpc.client and xmlrpc.server. > > The solution implemented he

Re: [ovs-dev] [PATCH 4/9] python: Fix print function compatibility.

2016-01-11 Thread Ben Pfaff
On Wed, Jan 06, 2016 at 03:50:24PM -0500, Russell Bryant wrote: > The print statement from Python 2 is a function in Python 3. Enable > print function support for Python 2 and convert print statements to > function calls. > > Enable the H233 flake8 warning. If the hacking plugin is installed, >

Re: [ovs-dev] [PATCH 3/9] python: Fix exception handler compatibility.

2016-01-11 Thread Ben Pfaff
On Wed, Jan 06, 2016 at 03:50:23PM -0500, Russell Bryant wrote: > Python 3 dropped exception handlers of the deprecated form: > > except Exception, e: > > You must use the newer syntax of: > > except Exception as e: > > This patch also enables a flake8 warning for this. > > H231 Python 3

Re: [ovs-dev] [PATCH 2/9] python: Stop use of tuple parameter unpacking

2016-01-11 Thread Ben Pfaff
On Wed, Jan 06, 2016 at 03:50:22PM -0500, Russell Bryant wrote: > Python 3 removed support for tuple parameter unpacking. > > https://www.python.org/dev/peps/pep-3113/ > > Instead of: > > def foo((a, b)): > print(a) > print(b) > > you should do: > > def foo(a_b): >

Re: [ovs-dev] [PATCH 1/9] python: Start fixing some Python 3 issues.

2016-01-11 Thread Ben Pfaff
On Wed, Jan 06, 2016 at 03:50:21PM -0500, Russell Bryant wrote: > From: Terry Wilson > > This patch fixes just the Python 3 problems found by running: > > python3 setup.py install > > There are still many other issues to be fixed, but this is a start. > > Signed-off-by: Terry Wilson > [russ

Re: [ovs-dev] [PATCH 0/3] QOS support in OVN

2016-01-11 Thread Ben Pfaff
On Tue, Jan 05, 2016 at 07:33:16PM +0530, bscha...@redhat.com wrote: > This patch series enables QOS support in OVN. Only two parameters > (policing_rate and policing_burst) are enabled through this patch series. > > Babu Shanmugam (3): > ovn: ovn-controller changes for qos settings > ovn: Qos

Re: [ovs-dev] [PATCH] net: preserve IP control block during GSO segmentation

2016-01-11 Thread Cong Wang
On Sun, Jan 10, 2016 at 11:45 PM, Zang MingJie wrote: > On 01/08/2016 08:13 PM, David Laight wrote: >> >> You could set SKB_SGO_CB_OFFSET to sizeof ((skb)->cb) - sizeof (struct >> skb_gso_cb) >> so that the end of 'cb' is always used. >> (Assuming the former is a multiple of 4.) >> >> It might be

[ovs-dev] [PATCH] ovs-ofctl.8.in: Fix indentation.

2016-01-11 Thread Joe Stringer
This extraneous .RE caused the indentation for the subsequent actions to drop back an extra step, fix it. Fixes: 8e53fe8cf7a1 ("Add connection tracking mark support.") Signed-off-by: Joe Stringer --- utilities/ovs-ofctl.8.in | 2 -- 1 file changed, 2 deletions(-) diff --git a/utilities/ovs-ofct

[ovs-dev] [PATCH] datapath: Fix deadlock on STT device destroy.

2016-01-11 Thread Pravin B Shelar
STT unregisters nf-hook when there are no other STT devices left in the namespace. On some kernel versions the nf-unreg API take RTNL lock, but it is already taken in the tunnel device destroy code path which results in deadlock. To fix the issue I moved the unreg call into net-exit. Bug: #1582410

Re: [ovs-dev] possible memory leak at add_monitored_table()

2016-01-11 Thread William Tu
Hi Andy and Ben, Sorry for making this mistake. I will be careful next time. Regards, William On Mon, Jan 11, 2016 at 3:18 PM, Ben Pfaff wrote: > It looks like William rolled this into his series and that I applied it > earlier today. > > (William, when you do that, please be careful to retai

[ovs-dev] OVS PatchWork Update

2016-01-11 Thread Ubuntu
30+ Day Old Patches === ID State Date Name -- - 547819 New2015-11-24 04:54:32 [ovs-dev,v3,1/4] dpif: Meter framework. 547817 New2015-11-24 04:54:33 [ovs-dev,v3,2/4] odp-execute: Support dropping packets. 5478

Re: [ovs-dev] [PATCH] flow: fix compilation of MINIFLOW_ASSERT

2016-01-11 Thread Ben Pfaff
On Mon, Jan 11, 2016 at 02:00:25PM +0900, Simon Horman wrote: > Often MINIFLOW_ASSERT is a no-op and compilation of code that uses > it is optimised out. This patch fixes compilation errors that occur > when that is not the case: > > * FLOWMAP_MAX does not exist. Use MAP_MAP instead. > * FLOWMAP_I

[ovs-dev] [PATCH] datapath: Fix datapath build on Centos 6.5 (2.6.31-431) kernels

2016-01-11 Thread Ben Pfaff
From: Sabyasachi Sengupta The build was failing with following error: CC [M] /home/sabyasse/Linux/src/sandbox/ovs_v1/datapath/linux/vport.o /home/sabyasse/Linux/src/sandbox/ovs_v1/datapath/linux/vport.c: In function ‘ovs_vport_get_stats’: /home/sabyasse/Linux/src/sandbox/ovs_v1/datapath/

Re: [ovs-dev] possible memory leak at add_monitored_table()

2016-01-11 Thread Ben Pfaff
It looks like William rolled this into his series and that I applied it earlier today. (William, when you do that, please be careful to retain the original author in the commit; this time it looks like you accidentally changed it to yourself.) On Thu, Jan 07, 2016 at 02:01:32PM -0800, Andy Zhou w

Re: [ovs-dev] [PATCH] dp-packet: remove unused helper dp_packet_to_string()

2016-01-11 Thread Ben Pfaff
On Mon, Jan 11, 2016 at 02:00:39PM +0900, Simon Horman wrote: > dp_packet_to_string() does not appear to be used. > > Signed-off-by: Simon Horman I assume this was meant for use during debugging but even then it seems like it has limited usefulness. Applied to master, thanks. __

Re: [ovs-dev] [PATCH 2/2] openvswitch: make auto-attach logic disable-able

2016-01-11 Thread Ben Pfaff
On Sat, Jan 09, 2016 at 08:49:44PM +0200, Alexandru Ardelean wrote: > This is the first in a series of attempts to trim the fat > off of OVS, to make it friendlier for embedded systems. > > Signed-off-by: Alexandru Ardelean I don't like this idea. This is going to turn into a slippery slope of

[ovs-dev] [PATCH] netdev-dpdk: Consistently use xstrdup() instead of strdup().

2016-01-11 Thread Ben Pfaff
This avoids a segmentation fault in case of memory allocation failure. Found by inspection. Signed-off-by: Ben Pfaff --- lib/netdev-dpdk.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index b209df2..eb52730 100644 --- a/lib/ne

Re: [ovs-dev] [PATCH] ofp-parse: Use xstrdup() instead of strdup().

2016-01-11 Thread Ben Pfaff
On Mon, Jan 11, 2016 at 01:07:06PM -0500, Russell Bryant wrote: > On 01/11/2016 12:21 PM, Ben Pfaff wrote: > > This avoids a null pointer dereference in the case of memory allocation > > failure. > > > > Found by inspection. > > > > Signed-off-by: Ben Pfaff > > --- > > lib/ofp-parse.c | 2 +- >

Re: [ovs-dev] [PATCH] Removed: missing blank after decaration, line over 80 characters.

2016-01-11 Thread David Miller
There is no way I am applying any of these patches. Improper Subject: prefixes, entire commit messages in the Subject line, etc. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] Multiple blank lines removed

2016-01-11 Thread Janusz Wolak
Signed-off-by: Janusz Wolak --- net/openvswitch/conntrack.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c index e004067..fab7b55 100644 --- a/net/openvswitch/conntrack.c +++ b/net/openvswitch/conntrack.c @@ -201,7 +201,6 @@ static int

[ovs-dev] [PATCH] Removed: missing blank after decaration, line over 80 characters.

2016-01-11 Thread Janusz Wolak
Signed-off-by: Janusz Wolak --- net/openvswitch/datapath.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/openvswitch/datapath.h b/net/openvswitch/datapath.h index 67bdecd..9c27de1 100644 --- a/net/openvswitch/datapath.h +++ b/net/openvswitch/datapath.h @@ -102,6 +102,

[ovs-dev] [PATCH] Removed: block comments trailing without separate line, missing blanks after decarations, comparasion to NULL, assignment in if condition, not necessary spaces after casts, multiple

2016-01-11 Thread Janusz Wolak
Signed-off-by: Janusz Wolak --- net/openvswitch/datapath.c | 72 +- 1 file changed, 40 insertions(+), 32 deletions(-) diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c index 91a8b00..fb9cb80 100644 --- a/net/openvswitch/datapath.c ++

Re: [ovs-dev] ovn-controller appears to be in a tight loop

2016-01-11 Thread Kyle Mestery
On Mon, Jan 11, 2016 at 1:22 PM, Russell Bryant wrote: > On 01/10/2016 09:39 PM, Kyle Mestery wrote: > > Jan 10 20:38:00 oc-syd01-prod-compute-191 ovs-vswitchd: > > ovs|110086385|netlink_socket|ERR|fcntl: Too many open files > > After looking around, I think this was the root of the problem. "ul

Re: [ovs-dev] [PATCH net-next v6 0/7] openvswitch: NAT support.

2016-01-11 Thread David Miller
From: Pablo Neira Ayuso Date: Mon, 11 Jan 2016 19:50:33 +0100 > On Fri, Jan 08, 2016 at 10:29:53AM -0800, Jarno Rajahalme wrote: >> This series adds NAT support to openvswitch kernel module. A few >> changes are needed to the netfilter code to facilitate this (patches >> 1-2/8). Patches 3-6 mak

Re: [ovs-dev] [PATCH monitor_cond 00/12] Implement conditional monitoring

2016-01-11 Thread Andy Zhou
On Mon, Jan 11, 2016 at 5:05 AM, Liran Schour wrote: > Andy Zhou wrote on 09/01/2016 02:02:32 AM: > > > > On Fri, Jan 8, 2016 at 8:58 AM, Liran Schour wrote: > > Andy Zhou wrote on 07/01/2016 01:04:17 AM: > > > > > > I have some comments on the patch series. > > > > > > Instead of "monitor_con

Re: [ovs-dev] ovn-controller appears to be in a tight loop

2016-01-11 Thread Russell Bryant
On 01/10/2016 09:39 PM, Kyle Mestery wrote: > Jan 10 20:38:00 oc-syd01-prod-compute-191 ovs-vswitchd: > ovs|110086385|netlink_socket|ERR|fcntl: Too many open files After looking around, I think this was the root of the problem. "ulimit -n" was at the default of 1024. After setting it to be much

Re: [ovs-dev] [PATCH] utilities/ovs-vsctl.c: honor 'help' as ovs-ofctl and dpctl

2016-01-11 Thread Aaron Conole
Ben Pfaff writes: > On Tue, Jan 05, 2016 at 01:58:50PM -0500, Aaron Conole wrote: >> Currently, ovs-ofctl and ovs-dpctl allow a 'help' keyword, in addition to -h >> and --help. However, ovs-vsctl does not honor the same 'help' keyword. This >> change adds a 'help' which redirects to usage(), bring

Re: [ovs-dev] [PATCH v2 2/3] netdev-dpdk: Convert initialization from cmdline to db

2016-01-11 Thread Aaron Conole
Zoltan Kiss writes: > On 08/01/16 16:31, Aaron Conole wrote: >> Panu Matilainen writes: >>> On 01/04/2016 11:46 PM, Aaron Conole wrote: Existing DPDK integration is provided by use of command line options which must be split out and passed to librte in a special manner. However, this >>

Re: [ovs-dev] [PATCH net-next v6 0/7] openvswitch: NAT support.

2016-01-11 Thread Pablo Neira Ayuso
Hi Jarno, On Fri, Jan 08, 2016 at 10:29:53AM -0800, Jarno Rajahalme wrote: > This series adds NAT support to openvswitch kernel module. A few > changes are needed to the netfilter code to facilitate this (patches > 1-2/8). Patches 3-6 make the openvswitch kernel module ready for the > patch 7 th

Re: [ovs-dev] [PATCH 1/2] ofctl: This patch add support for setting the first egress table for egress processing.

2016-01-11 Thread Ben Pfaff
On Wed, Dec 23, 2015 at 01:37:12PM +0530, niti1...@gmail.com wrote: > From: Niti Rohilla > > "ovs-ofctl set-first-egress-table " can be used to set > first egress > table. > This patch enhances TABLE_FEATURES_REQUEST message to set the first egress > table and > TABLE_FEATURES_REPLY to identif

[ovs-dev] Matching TCP header fields such as the checksum field

2016-01-11 Thread Kashyap Thimmaraju
Hi, I would like to create flow rules on an OvS switch that can match certain TCP checksum values sent by an OpenFlow controller. So far, I have been able to extend the OpenFlow 1.0 Flow-mod to include the necessary checksum value. I have also modified OvS to receive the Flow-mod. I used POX to re

Re: [ovs-dev] [PATCH] ofp-parse: Use xstrdup() instead of strdup().

2016-01-11 Thread Russell Bryant
On 01/11/2016 12:21 PM, Ben Pfaff wrote: > This avoids a null pointer dereference in the case of memory allocation > failure. > > Found by inspection. > > Signed-off-by: Ben Pfaff > --- > lib/ofp-parse.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/ofp-parse.c b

Re: [ovs-dev] [PATCH 1/2] poll: Suppress logging for pmd threads.

2016-01-11 Thread Ben Pfaff
On Tue, Dec 22, 2015 at 05:26:47PM +0300, Ilya Maximets wrote: > 'Unreasonably long poll interval's are reasonable for PMD threads. > Also reporting of high CPU usage is not necessary. > > Signed-off-by: Ilya Maximets Thanks, applied to master and branch-2.5.

Re: [ovs-dev] [PATCH] Do not add ARP replies in the lswitch pipeline to all the lports

2016-01-11 Thread Ben Pfaff
On Mon, Dec 21, 2015 at 07:57:16PM +0530, Numan Siddique wrote: > Instead add only if > - the port is up or > - if port type is router > > Signed-off-by: Numan Siddique Following the discussion, I applied this to master. I updated ovn-northd(8) to describe the new behavior.

Re: [ovs-dev] [PATCH v2] datapath-windows: Add LSOv2 support for VXLAN

2016-01-11 Thread Ben Pfaff
On Fri, Dec 11, 2015 at 10:29:38PM +, Alin Serdean wrote: > This patch adds LSO version 2 support for the windows datapath. > (https://msdn.microsoft.com/en-us/library/windows/hardware/ff568840%28v=vs.85%29.aspx) > > Tested using psping and iperf3. > > Signed-off-by: Alin Gabriel Serdean > -

Re: [ovs-dev] [PATCH] datapath-windows: Fix bug small bug in GRE

2016-01-11 Thread Ben Pfaff
On Fri, Dec 11, 2015 at 10:24:49PM +, Alin Serdean wrote: > Allow GRE encapsulation to take place in the case we have a TCP payload > without LSO. > > Signed-off-by: Alin Gabriel Serdean Thanks, applied to master and branch-2.5. ___ dev mailing lis

Re: [ovs-dev] [PATCH v3 0/4] Meter implementation for userspace datapath.

2016-01-11 Thread Ben Pfaff
On Mon, Dec 21, 2015 at 11:38:33PM -0800, Ben Pfaff wrote: > On Mon, Nov 30, 2015 at 10:03:11AM -0800, Jarno Rajahalme wrote: > > > > > On Nov 29, 2015, at 17:12, Ben Pfaff wrote: > > > > > >> On Mon, Nov 23, 2015 at 08:54:31PM -0800, Jarno Rajahalme wrote: > > >> Back by popular demand, here is

Re: [ovs-dev] [RFC v3] ipv6 tunneling: Fix for performance drop introduced by ipv6 tunnel support.

2016-01-11 Thread Jiri Benc
On Wed, 30 Dec 2015 14:59:01 +, Sugesh Chandran wrote: > Adding a new field called protocol in flow tunnel structure to verify the > validity > of tunnel metadata. This field avoids the need of resetting and validating > the > entire ipv4/ipv6 tunnel destination address which caused a serio

Re: [ovs-dev] [PATCH] utilities/ovs-vsctl.c: honor 'help' as ovs-ofctl and dpctl

2016-01-11 Thread Ben Pfaff
On Tue, Jan 05, 2016 at 01:58:50PM -0500, Aaron Conole wrote: > Currently, ovs-ofctl and ovs-dpctl allow a 'help' keyword, in addition to -h > and --help. However, ovs-vsctl does not honor the same 'help' keyword. This > change adds a 'help' which redirects to usage(), bringing ovs-vsctl in line >

[ovs-dev] [PATCH] ofp-parse: Use xstrdup() instead of strdup().

2016-01-11 Thread Ben Pfaff
This avoids a null pointer dereference in the case of memory allocation failure. Found by inspection. Signed-off-by: Ben Pfaff --- lib/ofp-parse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ofp-parse.c b/lib/ofp-parse.c index 6fb43f5..5ef3892 100644 --- a/lib/ofp-pa

Re: [ovs-dev] [PATCH 2/3] rstp: fix memory leak reported by valgrind

2016-01-11 Thread Ben Pfaff
On Tue, Jan 05, 2016 at 01:38:42PM -0800, William Tu wrote: > test case: 1650 RSTP Single bridge, call stacks > hmap_insert_at (hmap.h:235) > rstp_port_set_port_number__ (rstp.c:744) > rstp_add_port (rstp.c:1164) > new_bridge (test-rstp.c:123) > test_rstp_main (test-rstp.c:514)

Re: [ovs-dev] [PATCH 3/3] ofproto: fix memory leak reported by valgrind

2016-01-11 Thread Ben Pfaff
On Tue, Jan 05, 2016 at 01:38:43PM -0800, William Tu wrote: > Test case 757: ofproto - table description (OpenFlow 1.4) > Call stacks: > parse_ofp_table_vacancy (ofp-parse.c:896) > parse_ofp_table_mod (ofp-parse.c:978) > ofctl_mod_table (ovs-ofctl.c:2011) > ovs_cmdl_run_command (com

Re: [ovs-dev] [PATCH 1/3] ovs-ofctl: fix memory leak reported by valgrind

2016-01-11 Thread Ben Pfaff
On Tue, Jan 05, 2016 at 01:38:41PM -0800, William Tu wrote: > Reported by 348: ovs-ofctl parse-flows (skb_priority) > Reason: return without freeing memory > > Signed-off-by: William Tu > Signed-off-by: Daniele Di Proietto > Co-authored-by: Daniele Di Proietto Thanks, applied to master, branch

Re: [ovs-dev] [PATCH 2/2] ovsdb-client: fix memory leak reported by valgrind

2016-01-11 Thread Ben Pfaff
On Thu, Jan 07, 2016 at 03:53:09PM -0800, William Tu wrote: > testc ase 1427: ovsdb-server combines updates on backlogged connections. > valgrind reports two leaks: > unixctl_server_create (unixctl.c:250) > do_monitor__ (ovsdb-client.c:918) > and > json_create (json.c:1406) > json_i

Re: [ovs-dev] [PATCH] stream-ssl.c: fix memory leak reported by valgrind

2016-01-11 Thread Ben Pfaff
On Thu, Jan 07, 2016 at 03:59:34PM -0800, William Tu wrote: > test case 1628: peer ca cert > ASN1_item_dup > do_ca_cert_bootstrap (stream-ssl.c:413) > ssl_connect (stream-ssl.c:468) > scs_connecting (stream.c:297) > stream_connect (stream.c:320) > Fix by removing the X509_dup().

Re: [ovs-dev] [PATCH 1/2] ovsdb-client: fix memory leak reported by valgrind

2016-01-11 Thread Ben Pfaff
On Thu, Jan 07, 2016 at 03:53:08PM -0800, William Tu wrote: > test case 1427: ovsdb-server combines updates on backlogged connections. > ovsdb_column_set_add (column.c:233) > add_column (ovsdb-client.c:730) > parse_monitor_columns (ovsdb-client.c:787) > add_monitored_table (ovsdb-cl

Re: [ovs-dev] [PATCH] test-aa: fix memory leak reported by valgrind

2016-01-11 Thread Ben Pfaff
On Wed, Jan 06, 2016 at 06:35:23PM -0800, William Tu wrote: > test case 1698: auto-attach - packet tests > Report several leaks at lldp_create_dummy(), the patch fixes the > following 3 leaks: > {lldp_send (lldp.c:334), lldp_decode (lldp.c:374), > lldp_create_dummy (ovs-lldp.c:890)} >

Re: [ovs-dev] [PATCH 4/4] test-ovsdb.c: fix memory leak reported by valgrind

2016-01-11 Thread Ben Pfaff
On Wed, Jan 06, 2016 at 10:49:38AM -0800, William Tu wrote: > Test case 1205: generate and apply diff -- set -- size (ovsdb-data.at:827) > Call stack: > ovsdb_error_valist (ovsdb-error.c:40) > ovsdb_error (ovsdb-error.c:55) > do_diff_data (test-ovsdb.c:427) > ovs_cmdl_run_command (c

Re: [ovs-dev] [PATCH 3/4] ovsdb-client: fix memory leak reported by valgrind

2016-01-11 Thread Ben Pfaff
On Wed, Jan 06, 2016 at 10:49:37AM -0800, William Tu wrote: > Test case 1508-1514: OVSDB -- ovsdb-server monitors, call stacks: > ovsdb_schema_create (ovsdb.c:34) > ovsdb_schema_from_json (ovsdb.c:196) > fetch_schema (ovsdb-client.c:375) > do_monitor__ (ovsdb-client.c:920) > mai

Re: [ovs-dev] [PATCH 1/4] test-netflow.c: Fix memory leak reported by valgrind

2016-01-11 Thread Ben Pfaff
On Wed, Jan 06, 2016 at 10:49:35AM -0800, William Tu wrote: > Test case 890: ofproto-dpif - NetFlow flow expiration - IPv4 collector > Valgrind reports two leaks below: > unixctl_server_create (unixctl.c:250) > test_netflow_main (test-netflow.c:200) > ovstest_wrapper_test_netflow_main__

Re: [ovs-dev] OVS PatchWork Update

2016-01-11 Thread Ben Pfaff
On Mon, Jan 11, 2016 at 10:39:24AM -0500, Russell Bryant wrote: > On 01/11/2016 10:33 AM, ALeX Wang wrote: > > my old understanding is that it won't do that automatically, > > > > you can turn on the ACK detector which will set the flag. > > > > other project uses that, > > OK, so should I be ma

Re: [ovs-dev] OVS PatchWork Update

2016-01-11 Thread Russell Bryant
On 01/11/2016 10:33 AM, ALeX Wang wrote: > my old understanding is that it won't do that automatically, > > you can turn on the ACK detector which will set the flag. > > other project uses that, OK, so should I be marking patches as accepted when I push them? I just wasn't aware that I should b

Re: [ovs-dev] OVS PatchWork Update

2016-01-11 Thread ALeX Wang
my old understanding is that it won't do that automatically, you can turn on the ACK detector which will set the flag. other project uses that, Thanks, Alex Wang, On 11 January 2016 at 06:30, Russell Bryant wrote: > On 01/11/2016 02:01 AM, ALeX Wang wrote: > > Marked "Committed Patches" as Ac

Re: [ovs-dev] OVS PatchWork Update

2016-01-11 Thread Russell Bryant
On 01/11/2016 02:01 AM, ALeX Wang wrote: > Marked "Committed Patches" as Accepted Is this usually automatic? -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] netdev_open and dpdk

2016-01-11 Thread Safka, JaroslavX
Hi all, I have question regarding function netdev_open and dpdk. I’m trying to get stats from dpdk interface by: My example code: struct netdev_stats stats; const char *mtype = "dpdk"; struct netdev *dev = 0; if(0 != netdev_open("dpdk0", mtype, &dev)) { printf("port o

Re: [ovs-dev] [PATCH v2] lib/netdev-dpdk: increase ring name length for dpdkr ports

2016-01-11 Thread Traynor, Kevin
> -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Mauricio Vasquez > B > Sent: Sunday, January 10, 2016 6:28 PM > To: dev@openvswitch.org > Cc: acon...@bytheb.org > Subject: [ovs-dev] [PATCH v2] lib/netdev-dpdk: increase ring name length for > dpdkr ports >

Re: [ovs-dev] [PATCH monitor_cond 00/12] Implement conditional monitoring

2016-01-11 Thread Liran Schour
Andy Zhou wrote on 09/01/2016 02:02:32 AM: > > On Fri, Jan 8, 2016 at 8:58 AM, Liran Schour wrote: > Andy Zhou wrote on 07/01/2016 01:04:17 AM: > > > > I have some comments on the patch series. > > > > Instead of "monitor_cond_change", why not just have a more generic > > "monitor_update" messa

Re: [ovs-dev] [PATCH v2 2/3] netdev-dpdk: Convert initialization from cmdline to db

2016-01-11 Thread Zoltan Kiss
On 08/01/16 16:31, Aaron Conole wrote: Panu Matilainen writes: On 01/04/2016 11:46 PM, Aaron Conole wrote: Existing DPDK integration is provided by use of command line options which must be split out and passed to librte in a special manner. However, this forces any configuration to be passe

[ovs-dev] Mail System Error - Returned Mail

2016-01-11 Thread Post Office
Your message was undeliverable due to the following reason: Your message could not be delivered because the destination server was not reachable within the allowed queue period. The amount of time a message is queued before it is returned depends on local configura- tion parameters. Most likely t

[ovs-dev] [PATCH RFC v2] dpif-netdev: Allow different numbers of rx queues for different ports.

2016-01-11 Thread Ilya Maximets
Currently, all of the PMD netdevs can only have the same number of rx queues, which is specified in other_config:n-dpdk-rxqs. Fix that by introducing of new option for PMD interfaces: 'n_rxq', which specifies the maximum number of rx queues to be created for this interface. Example: ovs-v

Re: [ovs-dev] [PATCH] python: Fix the TypeError exception seen when idl.Idl parses lock reply

2016-01-11 Thread Numan Siddique
On 01/09/2016 01:08 AM, Russell Bryant wrote: >> Thanks for the fix! I pushed this to master and branch-2.5. >> > > I meant to say this earlier. This looks like a good candidate for a new > test case if you'd be interested in writing one. Sure. I will work on the test cases for this. Thanks Num

[ovs-dev] Without a Degree you are going nowhere!

2016-01-11 Thread Serena Judd
Don’t like the job you work at and you think about changing it for something better? You have a great chance to do it right now! Best diplomas in every field of knowledge are now available for your order. Hurry up to start the new better life with the competitive salary. Best universities and co