On Wed, Jan 06, 2016 at 03:50:25PM -0500, Russell Bryant wrote:
> Fix imports of xmlrpclib to be compatible with Python 3.  Python 2 had
> xmlrpclib (client) and SimpleXMLRPCServer (server).  In Python 3, these
> have been renamed to xmlrpc.client and xmlrpc.server.
> 
> The solution implemented here is to use the six library.  It may seem
> excessive for this particular issue, but the six library provides
> helpers for Python 2 and 3 compatibility for many different issues.
> This is just the first of many uses of the six library.
> 
> Signed-off-by: Russell Bryant <russ...@ovn.org>

I guess that the intent is for python-six to be installed at build time
and at runtime, right?

I guess we should add Python 2.7+ and Python six to the "Installation
Requirements" section in INSTALL.md (so far they're only in the build
requirements section, which I guess is an existing oversight).

Also we should update the various packaging to require python-six.
Here's an appropriate patch for Debian (I think; it's untested because
I've had patch conflicts):

diff --git a/debian/control b/debian/control
index a71c8fb..2918d06 100644
--- a/debian/control
+++ b/debian/control
@@ -16,7 +16,8 @@ Build-Depends: graphviz,
                python-all (>= 2.7),
                python-qt4,
                python-twisted-conch,
-               python-zopeinterface
+               python-zopeinterface,
+               python-six
 Standards-Version: 3.9.3
 Homepage: http://openvswitch.org/
 
@@ -57,8 +58,8 @@ Description: Open vSwitch datapath module source - DKMS 
version
 Package: openvswitch-common
 Architecture: linux-any
 Depends: openssl,
-         python,
-         python (>= 2.7) | python-argparse,
+         python (>= 2.7),
+         python-six,
          ${misc:Depends},
          ${shlibs:Depends}
 Suggests: ethtool
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to