[ovs-dev] [PATCH ovn v5 10/15] ovn-controller: Don't log every interface missing "iface-id".

From: Justin Pettit Tunnels create a lot of interfaces without an "external-id:iface-id", so logging each interface missing one (even at debug) seems unnecessary. Signed-off-by: Justin Pettit Signed-off-by: Ben Pfaff --- ovn/controller/bindings.c | 1 - 1 file changed, 1 deletion(-) diff --g

[ovs-dev] [PATCH ovn v5 09/15] ovn-controller: Clarify that some config changes require a restart.

From: Justin Pettit Signed-off-by: Justin Pettit Signed-off-by: Ben Pfaff --- ovn/controller/ovn-controller.8.xml | 5 + ovn/controller/ovn-controller.c | 6 -- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/ovn/controller/ovn-controller.8.xml b/ovn/controller/ovn-

[ovs-dev] [PATCH ovn v5 08/15] ovs-architecture: Recommend disable-in-band=true for integration bridge.

Also implement in ovs-sandbox. Signed-off-by: Ben Pfaff --- ovn/ovn-architecture.7.xml | 27 +++ tutorial/ovs-sandbox | 3 ++- 2 files changed, 25 insertions(+), 5 deletions(-) diff --git a/ovn/ovn-architecture.7.xml b/ovn/ovn-architecture.7.xml index f1dfa5f..6aa

[ovs-dev] [PATCH ovn v5 07/15] ovn-controller: Install generated pipeline flows into OVS via OpenFlow.

This implementation is really simple, but it seems effective enough in my minimal testing. We still need code to generate flows for logical-to-physical and physical-to-logical translation. With that, plus code to set up tunnels, we should be able to start end-to-end testing. Signed-off-by: Ben P

[ovs-dev] [PATCH ovn v5 06/15] match: Add MATCH_CATCHALL_INITIALIZER.

An upcoming patch will add the first user. Signed-off-by: Ben Pfaff --- lib/match.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/match.h b/lib/match.h index 6633304..638c49d 100644 --- a/lib/match.h +++ b/lib/match.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2009, 2010

[ovs-dev] [PATCH ovn v5 05/15] ovs-sandbox: Use "secure" mode for br-int, in OVN mode.

This is documented in ovn-architecture(7). Signed-off-by: Ben Pfaff --- tutorial/ovs-sandbox | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tutorial/ovs-sandbox b/tutorial/ovs-sandbox index 8aa2ddd..4ab960b 100755 --- a/tutorial/ovs-sandbox +++ b/tutorial/ovs-sandbox @@ -291

[ovs-dev] [PATCH ovn v5 04/15] rconn: Only increment seqno when connection actually drops or reconnects.

rconn_get_connection_seqno() is documented to change only when an rconn connects or disconnnects, but in fact it was also changing whenever an rconn went into or out of the "idle" state (following sending an echo request). This fixes the problem. rconn_get_connection_seqno() didn't have any exist

[ovs-dev] [PATCH ovn v5 03/15] ovn-controller: Make integration bridge config part of general context.

From: Justin Pettit The integration bridge will be needed by other components soon, so make it part of the general ovn-controller context. Signed-off-by: Justin Pettit Signed-off-by: Ben Pfaff --- ovn/controller/bindings.c | 33 +++ ovn/controller/ovn-control

[ovs-dev] [PATCH ovn v5 02/15] ovn-controller: Implement translation of OVN flows into OpenFlow.

Signed-off-by: Ben Pfaff --- ovn/controller/automake.mk | 4 +- ovn/controller/ovn-controller.c | 4 + ovn/controller/pipeline.c | 373 ovn/controller/pipeline.h | 26 +++ ovn/ovn-sb.ovsschema| 2 +- 5 files changed, 407

[ovs-dev] [PATCH ovn v5 01/15] ovn: New module for parsing OVN actions as OpenFlow.

Signed-off-by: Ben Pfaff --- ovn/lib/actions.c | 242 ovn/lib/actions.h | 38 + ovn/lib/automake.mk | 2 + ovn/lib/expr.c | 179 ++ ovn/lib/expr.h | 15 +++- ovn/ovn-sb.xml |

[ovs-dev] [PATCH ovn v5 00/15] complete end-to-end OVN system

v1->v2: Add patch 5. v2->v3: Break patch 5 into a series of 6 patches, each of which actually makes sense and is ready for review. v3->v4: Drop patches 1 to 6 because they were applied. Update patch 3 based on Justin's comments (changing "resubmit" to "next"). Add patches 5 through 9 (patch

Re: [ovs-dev] [ovn 5/6] ovn: Constrain supported tunnel types.

On Wed, Apr 29, 2015 at 11:10:49PM -0700, Justin Pettit wrote: > > > On Apr 28, 2015, at 3:07 PM, Ben Pfaff wrote: > > > > On Mon, Apr 27, 2015 at 10:14:50PM -0700, Justin Pettit wrote: > >> Limit the supported tunnel types to Geneve and STT on hypervisors, and > >> VXLAN, Geneve, and STT on gat

Re: [ovs-dev] [ovn 5/6] ovn: Constrain supported tunnel types.

> On Apr 28, 2015, at 3:07 PM, Ben Pfaff wrote: > > On Mon, Apr 27, 2015 at 10:14:50PM -0700, Justin Pettit wrote: >> Limit the supported tunnel types to Geneve and STT on hypervisors, and >> VXLAN, Geneve, and STT on gateways. This commit adds "DESIGN.md" that >> describes the reasoning. >> >

Re: [ovs-dev] [ovn 3/6] ovn-controller: Don't log every interface missing "iface-id".

> On Apr 28, 2015, at 2:59 PM, Ben Pfaff wrote: > > On Mon, Apr 27, 2015 at 10:14:48PM -0700, Justin Pettit wrote: >> Tunnels create a lot of interfaces without an "external-id:iface-id", so >> logging each interface missing one (even at debug) seems unnecessary. >> >> Signed-off-by: Justin Pet

Re: [ovs-dev] [ovn 2/6] ovn-controller: Clarify that some config changes require a restart.

> On Apr 28, 2015, at 2:58 PM, Ben Pfaff wrote: > > On Mon, Apr 27, 2015 at 10:14:47PM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > Wouldn't it be better to support this? I agree with documenting current > behavior but I'd prefer to fix it in the long term (i.e. leave in th

Re: [ovs-dev] [ovn 1/6] ovn-controller: Make integration bridge config part of general context.

> On Apr 28, 2015, at 2:56 PM, Ben Pfaff wrote: > > On Mon, Apr 27, 2015 at 10:14:46PM -0700, Justin Pettit wrote: >> The integration bridge will be needed by other components soon, so make >> it part of the general ovn-controller context. >> >> Signed-off-by: Justin Pettit > > This solves a

Re: [ovs-dev] [PATCHv3] DPDK: add support for v2.0.0

On Mon, Apr 20, 2015 at 12:37 PM, Mark Kavanagh wrote: > Update relevant artifacts to add support for DPDK v2.0.0 > - INSTALL.DPDK.md > - travis build script > - acinclude.m4: add 'mssse3' flag to OVS_CFLAGS > - netdev-dpdk: fix build with unified offload types in DPDK v2.0.0 > > Note that thi

Re: [ovs-dev] [PATCH ovn v4 2/9] expr: Make expr_to_flows() include conj_id flows.

On Wed, Apr 29, 2015 at 06:19:48PM -0700, Justin Pettit wrote: > > > On Apr 29, 2015, at 10:12 AM, Ben Pfaff wrote: > > > > When I wrote expr_to_flows() originally, I assumed that the caller could > > simply add an appropriate conj_id=X flow for each of the conjunctive > > matches. I forgot tha

Re: [ovs-dev] [PATCH ovn v4 2/9] expr: Make expr_to_flows() include conj_id flows.

> On Apr 29, 2015, at 10:12 AM, Ben Pfaff wrote: > > When I wrote expr_to_flows() originally, I assumed that the caller could > simply add an appropriate conj_id=X flow for each of the conjunctive > matches. I forgot that the conj_id=X flows also need to include > prerequisites for actions, e.g

Re: [ovs-dev] [PATCH ovn v4 1/9] ovn: Add tunnel_key concept to Bindings table, assign in ovn-northd.

> On Apr 29, 2015, at 10:12 AM, Ben Pfaff wrote: > > When packets travel among nodes in OVN over tunnels, a tunnel key value is > needed to convey the logical port to which the packet is destined. This > commit adds a tunnel_key column to the Bindings table and adds code to > ovn-northd to assi

Re: [ovs-dev] [PATCH ovn v3 08/10] expr: Make expr_to_flows() include conj_id flows.

> On Apr 24, 2015, at 3:34 PM, Ben Pfaff wrote: > > When I wrote expr_to_flows() originally, I assumed that the caller could > simply add an appropriate conj_id=X flow for each of the conjunctive > matches. I forgot that the conj_id=X flows also need to include > prerequisites for actions, e.g.

[ovs-dev] OVN: Use of Tunnel Keys

In one of the review threads, we were discussing how we should make use of the metadata in the tunnels. The patches that Ben has sent out goes the route of having each logical port have a unique tunnel key. I had envisioned a different approach, so I thought it would be worth starting a thread

Re: [ovs-dev] [PATCH v2 1/3] Windows installer

6.40 filter will fail to register itself on Windows Server 2012 and will get unloaded. Eitan -Original Message- From: Nithin Raju Sent: Wednesday, April 29, 2015 3:12 PM To: Eitan Eliahu Cc: Alin Serdean; Gurucharan Shetty; dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v2 1/3] Wind

Re: [ovs-dev] [PATCH] datapath: Tidy up duplicate symbol detection.

On 29 April 2015 at 13:52, Ben Pfaff wrote: > On Wed, Apr 29, 2015 at 01:35:44PM -0700, Joe Stringer wrote: >> Don't print each symbol that is iterated. >> Make the error message more clear by prefixing "error: ". >> >> Signed-off-by: Joe Stringer > > Thanks! > > Acked-by: Ben Pfaff > > (I didn'

Re: [ovs-dev] [PATCH v2 3/3] Add file to .gitignore

On Tue, Apr 28, 2015 at 10:03 AM, Alin Serdean wrote: > Add testsuite.tmp.orig to .gitignore > > Signed-off-by: Alin Gabriel Serdean I applied just this patch to master. Thanks! > --- > .gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.gitignore b/.gitignore > index e37a690..

Re: [ovs-dev] [PATCH v2 1/3] Windows installer

> On Apr 29, 2015, at 3:04 PM, Eitan Eliahu wrote: > > Actually, both version should be available for the installer. It should query > the OS type and install the appropriate driver. > > But, unless there is a good reason for registering as 6.40 we could register > as 6.30 with the 8.1 driver.

Re: [ovs-dev] [PATCH v2 1/3] Windows installer

> On Apr 29, 2015, at 2:52 PM, Eitan Eliahu wrote: > > > Hi Alin, > We would like to run on Windows Server too. In this case the installer should > install the Win 8.0 driver. > I don’t recall why we bumped the minor version. Unless we use 6.40 NDIS both > 8.0 and 8.1 should register as 6.30 f

Re: [ovs-dev] [PATCH v3 1/4] Windows installer

On Wed, Apr 29, 2015 at 2:07 PM, Gurucharan Shetty wrote: > On Tue, Apr 28, 2015 at 3:33 PM, Alin Serdean > wrote: >> From: Alessandro Pilotti >> >> This commit adds the windows installer to the OVS tree. >> >> Requirements are the following: >> Visual Studio Community 2013 >> WiX Toolset 3.9 >>

Re: [ovs-dev] [PATCH v2 3/3] Add file to .gitignore

On Wed, Apr 29, 2015 at 1:14 PM, Alin Serdean wrote: > No ignore v2/v3. V4 is the latest now. I see. For some reason, I got a bunch of duplicate v3s yesterday. Just so that we are clear, I meant to say whether ignoring testsuite.tmp.orig is still needed if you clone the latest master. > > I will

Re: [ovs-dev] [PATCH] test-ovsdb: Fix conditional statement.

Applied to master~ We'll discuss more over dropping the support of those old os~ Thanks, Alex Wang, On Wed, Apr 29, 2015 at 12:15 PM, Ben Pfaff wrote: > On Wed, Apr 29, 2015 at 02:37:43PM -0400, Russell Bryant wrote: > > On 04/29/2015 01:45 PM, Alex Wang wrote: > > > Old version of python does

Re: [ovs-dev] [PATCH] datapath: Tidy up duplicate symbol detection.

On Wed, Apr 29, 2015 at 01:35:44PM -0700, Joe Stringer wrote: > Don't print each symbol that is iterated. > Make the error message more clear by prefixing "error: ". > > Signed-off-by: Joe Stringer Thanks! Acked-by: Ben Pfaff (I didn't test it.) ___

[ovs-dev] [PATCH RFC v3 1/1] netdev-dpdk: add dpdk vhost-user ports

This patch adds support for a new port type to the userspace datapath called dpdkvhostuser. It adds to the existing infrastructure of vhost-cuse, however disables vhost-cuse ports as the default port type, in favour of vhost-user ports. vhost-cuse 'dpdkvhost' ports are still available and can be en

[ovs-dev] [PATCH RFC v3 0/1] netdev-dpdk: add dpdk vhost-user ports

This RFC patch makes use of the vhost-user implementation that is available in DPDK 2.0. Submitting as RFC as this implementation depends on OVS support for DPDK 2.0. As such, this patch can be considered experimental. Since DPDK 2.0 support is necessary for vhost-user, please use this patch to en

Re: [ovs-dev] [PATCH 4/4 V7] 802.1AD: Test pushing vlans with both TPIDs

On 4/26/15 2:34 PM, Thomas F Herbert wrote: From: "Thomas F. Herbert" This test tests the user space actions for 802.1q and 802.1ad. This test was originally contributed by Dave Benson. Dave, Could you please review the following and if it is OK, add your signoff to the following patch. This

Re: [ovs-dev] new build spew?

I sent a patch: http://openvswitch.org/pipermail/dev/2015-April/054820.html On 29 April 2015 at 07:43, Ben Pfaff wrote: > When I do a "make" in a clean build directory, I now get a lot of extra > spew, quoted below. I assume this is an unintentional side effect of > the export checks? > > ov

[ovs-dev] [PATCH] datapath: Tidy up duplicate symbol detection.

Don't print each symbol that is iterated. Make the error message more clear by prefixing "error: ". Signed-off-by: Joe Stringer --- datapath/Makefile.am |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/datapath/Makefile.am b/datapath/Makefile.am index a8e9be4..458fa

Re: [ovs-dev] [PATCH v4 4/4] Modify documentation

On Tue, Apr 28, 2015 at 3:36 PM, Alin Serdean wrote: > Change the documentation for the possible vaues of WDK. > > Signed-off-by: Alin Gabriel Serdean The documentation has to be changed at the same place that you modify the code. > --- > INSTALL.Windows.md | 2 +- > 1 file changed, 1 insertion

Re: [ovs-dev] [PATCH v2 3/3] Add file to .gitignore

No ignore v2/v3. V4 is the latest now. I will wait for Nithin comments and spin v5 together with the comments you pointed out also. Thanks, Alin. From: Gurucharan Shetty Sent: ‎4/‎29/‎2015 11:04 PM To: Alin Serdean

Re: [ovs-dev] [PATCH v3 1/4] Windows installer

> A 'git am' of this patch does not apply at my end. It is corrupted. > Does it apply at your end? I figured out the reason for the corruption. > >> --- >> v3: use git commit --amend --author to change the author >> v2: Change author to Alessandro Pilotti. Add windows/automake.mk You need to add a

Re: [ovs-dev] [PATCH v2 3/3] Add file to .gitignore

On Tue, Apr 28, 2015 at 10:03 AM, Alin Serdean wrote: > Add testsuite.tmp.orig to .gitignore > > Signed-off-by: Alin Gabriel Serdean Do you still need this patch on tip of the master? > --- > .gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.gitignore b/.gitignore > index e37

Re: [ovs-dev] [PATCH v2 2/3] Sample to automate build installer

On Tue, Apr 28, 2015 at 10:03 AM, Alin Serdean wrote: > This commit is a POC on how to build the installer from the command line. > > One could issue the following commands to build the binaries, driver and > installer. > > ./boot.sh;./configure CC=./build-aux/cccl LD="`which link`" LIBS="-lws2_32

Re: [ovs-dev] [PATCH] test-ovsdb: Fix conditional statement.

On Wed, Apr 29, 2015 at 02:37:43PM -0400, Russell Bryant wrote: > On 04/29/2015 01:45 PM, Alex Wang wrote: > > Old version of python does not support the following conditional > > statement syntax in one assignment: > > > >var = value1 if cond1 else value2 > > > > This commit fixes it by conv

[ovs-dev] Lose weight easy! lose 20kg (44 lb) per month!

Obesity should be stopped at initiatory stage before it brings harm to your health! There's no better product on the market. Our most popular pharmacy products are sold out at unbelievable prices! Hurry up! http://zzb.bz/yZPJu ___ dev mailing list dev

[ovs-dev] Unique goods for effective weight loss! Indeed, 1kg (2 lb) a day!

You won't marry a real prince until you get rid of some kilos of your weight! It is better that the other processed rubbish on the market. Our Giant Sale season Starts today! http://zzb.bz/afcGB ___ dev mailing list dev@openvswitch.org http://openvswit

[ovs-dev] (no subject)

___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] test-ovsdb: Fix conditional statement.

On 04/29/2015 01:45 PM, Alex Wang wrote: > Old version of python does not support the following conditional > statement syntax in one assignment: > >var = value1 if cond1 else value2 > > This commit fixes it by convert it back to use two assignments. > > Signed-off-by: Alex Wang The code l

Re: [ovs-dev] [PATCH] utilities: Add new pipeline generator script.

I've been using the script successfully for the past few days, so Acked-by: Daniele Di Proietto I have a few comments (I feel ridiculous being so picky about a python script, so feel free to apply/ignore them). Would we care about making it run also with python3? Only 3 changes are required (se

[ovs-dev] [PATCH] test-ovsdb: Fix conditional statement.

Old version of python does not support the following conditional statement syntax in one assignment: var = value1 if cond1 else value2 This commit fixes it by convert it back to use two assignments. Signed-off-by: Alex Wang --- tests/test-ovsdb.py |5 - 1 file changed, 4 insertions(

Re: [ovs-dev] [PATCH ovn v3 07/10] ovn: Add tunnel_key concept to Bindings table, assign in ovn-northd.

On Wed, Apr 29, 2015 at 09:34:42AM -0400, Russell Bryant wrote: > On 04/28/2015 09:11 PM, Ben Pfaff wrote: > > On Tue, Apr 28, 2015 at 05:36:50PM -0700, Justin Pettit wrote: > >> > >>> On Apr 28, 2015, at 5:21 PM, Ben Pfaff wrote: > >>> > >>> On Tue, Apr 28, 2015 at 03:53:03PM -0400, Russell Bryan

[ovs-dev] [PATCH ovn v4 3/9] ovn: New module for parsing OVN actions as OpenFlow.

Signed-off-by: Ben Pfaff --- ovn/lib/actions.c | 242 ovn/lib/actions.h | 38 + ovn/lib/automake.mk | 2 + ovn/lib/expr.c | 179 ++ ovn/lib/expr.h | 15 +++- ovn/ovn-sb.xml |

Re: [ovs-dev] [PATCH ovn v3 00/10] first flows out of ovn-controller

On Tue, Apr 28, 2015 at 06:31:57PM -0700, Ben Pfaff wrote: > On Fri, Apr 24, 2015 at 03:34:50PM -0700, Ben Pfaff wrote: > > v1->v2: Add patch 5. > > v2->v3: Break patch 5 into a series of 6 patches, each of which actually > > makes sense and is ready for review. > > I've applied patches 1 throug

[ovs-dev] [PATCH ovn v4 0/9] make ovn-controller generate flows and install into OVS

v1->v2: Add patch 5. v2->v3: Break patch 5 into a series of 6 patches, each of which actually makes sense and is ready for review. v3->v4: Drop patches 1 to 6 because they were applied. Update patch 3 based on Justin's comments (changing "resubmit" to "next"). Add patches 5 through 9 (patch

[ovs-dev] [PATCH ovn v4 8/9] match: Add MATCH_CATCHALL_INITIALIZER.

An upcoming patch will add the first user. Signed-off-by: Ben Pfaff --- lib/match.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/match.h b/lib/match.h index 6633304..638c49d 100644 --- a/lib/match.h +++ b/lib/match.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2009, 2010

[ovs-dev] [PATCH ovn v4 6/9] rconn: Only increment seqno when connection actually drops or reconnects.

rconn_get_connection_seqno() is documented to change only when an rconn connects or disconnnects, but in fact it was also changing whenever an rconn went into or out of the "idle" state (following sending an echo request). This fixes the problem. rconn_get_connection_seqno() didn't have any exist

[ovs-dev] [PATCH ovn v4 1/9] ovn: Add tunnel_key concept to Bindings table, assign in ovn-northd.

When packets travel among nodes in OVN over tunnels, a tunnel key value is needed to convey the logical port to which the packet is destined. This commit adds a tunnel_key column to the Bindings table and adds code to ovn-northd to assign a unique tunnel_key value to each logical port. Signed-off

[ovs-dev] [PATCH ovn v4 9/9] ovn-controller: Install generated pipeline flows into OVS via OpenFlow.

This implementation is really simple, but it seems effective enough in my minimal testing. We still need code to generate flows for logical-to-physical and physical-to-logical translation. With that, plus code to set up tunnels, we should be able to start end-to-end testing. Signed-off-by: Ben P

[ovs-dev] [PATCH ovn v4 5/9] ovn-controller: Make integration bridge config part of general context.

From: Justin Pettit The integration bridge will be needed by other components soon, so make it part of the general ovn-controller context. Signed-off-by: Justin Pettit Signed-off-by: Ben Pfaff --- ovn/controller/bindings.c | 33 +++ ovn/controller/ovn-control

[ovs-dev] [PATCH ovn v4 7/9] ovs-sandbox: Use "secure" mode for br-int, in OVN mode.

This is documented in ovn-architecture(7). Signed-off-by: Ben Pfaff --- tutorial/ovs-sandbox | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tutorial/ovs-sandbox b/tutorial/ovs-sandbox index 8aa2ddd..4ab960b 100755 --- a/tutorial/ovs-sandbox +++ b/tutorial/ovs-sandbox @@ -291

[ovs-dev] [PATCH ovn v4 2/9] expr: Make expr_to_flows() include conj_id flows.

When I wrote expr_to_flows() originally, I assumed that the caller could simply add an appropriate conj_id=X flow for each of the conjunctive matches. I forgot that the conj_id=X flows also need to include prerequisites for actions, e.g. if the OpenFlow actions manipulate TCP fields, then the conj

[ovs-dev] [PATCH ovn v4 4/9] ovn-controller: Implement translation of OVN flows into OpenFlow.

Signed-off-by: Ben Pfaff --- ovn/controller/automake.mk | 4 +- ovn/controller/ovn-controller.c | 4 + ovn/controller/pipeline.c | 373 ovn/controller/pipeline.h | 26 +++ ovn/ovn-sb.ovsschema| 2 +- 5 files changed, 407

Re: [ovs-dev] [PATCH v9] datapath: Add Stateless TCP Tunneling protocol.

On Tue, Apr 28, 2015 at 4:28 PM, Jesse Gross wrote: > On Mon, Apr 27, 2015 at 2:04 PM, Pravin B Shelar wrote: >> diff --git a/datapath/linux/compat/include/net/stt.h >> b/datapath/linux/compat/include/net/stt.h >> new file mode 100644 >> index 000..96181fd >> --- /dev/null >> +++ b/datapath/

Re: [ovs-dev] [PATCH ovn v3 07/10] ovn: Add tunnel_key concept to Bindings table, assign in ovn-northd.

> On Apr 29, 2015, at 6:34 AM, Russell Bryant wrote: > > I wonder how realistic it would be to have 65k ports and hit this as a > limit. If your deployment has many containers in each VM, it seems like > we could hit that much more quickly than traditionally seen before. I had the same thought

Re: [ovs-dev] [PATCH ovn v3 07/10] ovn: Add tunnel_key concept to Bindings table, assign in ovn-northd.

On 04/29/2015 12:22 PM, Justin Pettit wrote: > >> On Apr 29, 2015, at 6:34 AM, Russell Bryant wrote: >> >> I wonder how realistic it would be to have 65k ports and hit this as a >> limit. If your deployment has many containers in each VM, it seems like >> we could hit that much more quickly than

Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk: add dpdk vhost-user ports

On Thu Mar 19 11:48:13 PDT 2015, Ciara Loftus wrote: -`ovs-vsctl add-port br0 dpdkvhost0 -- set Interface dpdkvhost0 type=dpdkvhost` + - For vhost-user (default), the name of the port type is `dpdkvhostuser` -Unlike DPDK ring ports, DPDK vhost ports can have arbitrary names: + `ovs-

Re: [ovs-dev] [PATCH v3] ovs-hyperv: make kernel return values netlink socket like

>> As you know, the Windows kernel is synchronous in terms of netlink >> messages. Transaction semantics are implemented in one call that >> includes both the “request” and the “reply” in one shot. So, if >> there’s a mismatch, it implies the kernel bungled the ‘nlmsg_seq’. So, >> the assert was ad

Re: [ovs-dev] [PATCH v3] ovs-hyperv: make kernel return values netlink socket like

>> I agree with your comment. >> >> The error handling was in place since we were doing the whole “netlink >> emulation” with any OS support unlike Linux, and we wanted to catch issues >> in release builds also. >> >> If you are not very particular, can I let the code be? Once the code matures

Re: [ovs-dev] [PATCH v3] ovs-hyperv: make kernel return values netlink socket like

On Wed, Apr 29, 2015 at 03:41:00PM +, Nithin Raju wrote: > >> As you know, the Windows kernel is synchronous in terms of netlink > >> messages. Transaction semantics are implemented in one call that > >> includes both the “request” and the “reply” in one shot. So, if > >> there’s a mismatch, it

Re: [ovs-dev] [PATCH v3] ovs-hyperv: make kernel return values netlink socket like

We will fix the transaction error message copy in the kernel in a separate change. Thanks, Eitan -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff Sent: Wednesday, April 29, 2015 7:45 AM To: Nithin Raju Cc: dev@openvswitch.org Subject: Re: [ovs-dev]

Re: [ovs-dev] [PATCH v3] ovs-hyperv: make kernel return values netlink socket like

Besides that LG. Thanks, Eitan -Original Message- From: Nithin Raju Sent: Wednesday, April 29, 2015 7:38 AM To: Eitan Eliahu Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v3] ovs-hyperv: make kernel return values netlink socket like Thanks for the review. > On Apr 29, 2015, at

Re: [ovs-dev] [PATCH v3] ovs-hyperv: make kernel return values netlink socket like

On Wed, Apr 29, 2015 at 02:50:24PM +, Nithin Raju wrote: > > On Apr 29, 2015, at 7:45 AM, Ben Pfaff wrote: > > > > On Tue, Apr 28, 2015 at 02:35:37PM -0700, Nithin Raju wrote: > >> In this patch, we make changes to usersapce as well as > >> kernel datapath on hyperv to make it more netlink so

Re: [ovs-dev] [PATCH v3] ovs-hyperv: make kernel return values netlink socket like

> On Apr 29, 2015, at 7:45 AM, Ben Pfaff wrote: > > On Tue, Apr 28, 2015 at 02:35:37PM -0700, Nithin Raju wrote: >> In this patch, we make changes to usersapce as well as >> kernel datapath on hyperv to make it more netlink socket >> like. Previously, the kernel datapath did not distinguish >> be

Re: [ovs-dev] [PATCH] xenserver: Use kernel uname version for XenServer 6.5

It seems that GosenChien (CCed) deserves credit for reporting this problem; he has been discussing it on the list for a while. GosenChien, will you test that this fixes the problem you see? Thanks, Ben. On Tue, Apr 28, 2015 at 03:34:26PM -0700, Alex Wang wrote: > From: Edwin Chiu > > In XenSe

Re: [ovs-dev] [PATCH v3] ovs-hyperv: make kernel return values netlink socket like

Thanks for the review. > On Apr 29, 2015, at 6:06 AM, Eitan Eliahu wrote: > > > Hi Nithin, > Sorry, I come late on this one, change looks good. > > We need to check if the IRP output buffer is big enough to fit the > transaction message before copying it. Otherwise, we need to return error an

Re: [ovs-dev] [PATCH] ovn-sb: Fix reference to "port" that should have been "flow".

On Tue, Apr 28, 2015 at 03:29:29PM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v3] ovs-hyperv: make kernel return values netlink socket like

On Tue, Apr 28, 2015 at 02:35:37PM -0700, Nithin Raju wrote: > In this patch, we make changes to usersapce as well as > kernel datapath on hyperv to make it more netlink socket > like. Previously, the kernel datapath did not distinguish > between "transport errors" and other errors. Netlink > seman

[ovs-dev] new build spew?

When I do a "make" in a clean build directory, I now get a lot of extra spew, quoted below. I assume this is an unintentional side effect of the export checks? ovs-build-all _build make: Entering directory '/home/blp/nicira/ovs/_build' make all-recursive make[1]: Entering directo

Re: [ovs-dev] [PATCH v3] datapath-windows: Removed duplicate instance pid removal

> On Apr 29, 2015, at 7:27 AM, Gurucharan Shetty wrote: > > On Tue, Apr 28, 2015 at 11:49 PM, Sorin Vinturis > wrote: >> Instance PID is already deleted in the OvsCleanupPacketQueue function. >> >> Signed-off-by: Sorin Vinturis >> Acked-by: Nithin Raju > This patch had already been applied. D

Re: [ovs-dev] [PATCH v3] datapath-windows: Removed duplicate instance pid removal

Guru, No, nothing changed. Just added acked. After I sent the mail I saw that the patch was already pushed. Please ignore this version. Thanks, Sorin -Original Message- From: Gurucharan Shetty [mailto:shet...@nicira.com] Sent: Wednesday, 29 April, 2015 17:28 To: Sorin Vinturis Cc: dev@

Re: [ovs-dev] [PATCH v3] datapath-windows: Removed duplicate instance pid removal

On Tue, Apr 28, 2015 at 11:49 PM, Sorin Vinturis wrote: > Instance PID is already deleted in the OvsCleanupPacketQueue function. > > Signed-off-by: Sorin Vinturis > Acked-by: Nithin Raju This patch had already been applied. Did anything change? > --- > v2: Rebased the patch. > > v3: Added ack.

Re: [ovs-dev] [PATCH v4 1/2] datapath-windows: Enable extension after rrestart

On Wed, Apr 29, 2015 at 5:58 AM, Sorin Vinturis wrote: > The extension failed to be activated during booting due to the > failure to initialize tunnel filter. This happened because the Base > Filtering Engine (BFE) is not started and no session to the engine > could be acquired. > > The solution f

Re: [ovs-dev] [PATCH ovn v3 07/10] ovn: Add tunnel_key concept to Bindings table, assign in ovn-northd.

On 04/28/2015 09:11 PM, Ben Pfaff wrote: > On Tue, Apr 28, 2015 at 05:36:50PM -0700, Justin Pettit wrote: >> >>> On Apr 28, 2015, at 5:21 PM, Ben Pfaff wrote: >>> >>> On Tue, Apr 28, 2015 at 03:53:03PM -0400, Russell Bryant wrote: The code here looks correct and I also tested it. I was

Re: [ovs-dev] [PATCH ovn v3 05/10] lex: New functions lex_lookahead() and lexer_match_id().

On 04/28/2015 08:05 PM, Ben Pfaff wrote: > On Tue, Apr 28, 2015 at 03:34:31PM -0400, Russell Bryant wrote: >> On 04/24/2015 06:34 PM, Ben Pfaff wrote: >>> These functions will have their first users in upcoming commits. >>> >>> Signed-off-by: Ben Pfaff >>> --- >>> ovn/lib/lex.c | 28 +++

Re: [ovs-dev] [PATCH v3] ovs-hyperv: make kernel return values netlink socket like

Hi Nithin, Sorry, I come late on this one, change looks good. We need to check if the IRP output buffer is big enough to fit the transaction message before copying it. Otherwise, we need to return error and break the NetLink connection. Thanks, Eitan -Original Message- From: dev [mail

[ovs-dev] [PATCH v4 1/2] datapath-windows: Enable extension after rrestart

The extension failed to be activated during booting due to the failure to initialize tunnel filter. This happened because the Base Filtering Engine (BFE) is not started and no session to the engine could be acquired. The solution for this was to registered a BFE notification callback that is calle