On Wed, Apr 29, 2015 at 2:07 PM, Gurucharan Shetty <shet...@nicira.com> wrote: > On Tue, Apr 28, 2015 at 3:33 PM, Alin Serdean > <aserd...@cloudbasesolutions.com> wrote: >> From: Alessandro Pilotti <apilo...@cloudbasesolutions.com> >> >> This commit adds the windows installer to the OVS tree. >> >> Requirements are the following: >> Visual Studio Community 2013 >> WiX Toolset 3.9 >> Microsoft_VC120_CRT_x86.msm >> >> More detailed information on the requirements and build instructions >> can be found under: >> https://github.com/cloudbase/ovs-windows-installer/blob/master/README.rst >> >> Signed-off-by: Alessandro Pilotti <apilo...@cloudbasesolutions.com> > > Nice work! Thank you so much for doing this. > > There are a few whitespace errors that this patch introduces (you can > see them when you 'git am'). Atleast some of them look fixable. > > I apply this patch and do a 'make' and it fails on both Windows and Linux > with: > The following files are in git but not the distribution: > windows/LICENSE > windows/README.rst > windows/automake.mk > windows/ovs-windows-installer.sln > windows/ovs-windows-installer/Actions/OVSActions.js > windows/ovs-windows-installer/CustomActions.wxs > windows/ovs-windows-installer/Dialogs/ExitDialog.wxs > windows/ovs-windows-installer/Dialogs/MaintenanceWelcomeDlg.wxs > windows/ovs-windows-installer/Dialogs/UserExit.wxs > windows/ovs-windows-installer/Dialogs/WelcomeDlg.wxs > windows/ovs-windows-installer/License.rtf > windows/ovs-windows-installer/Product.wxs > windows/ovs-windows-installer/UI.wxs > windows/ovs-windows-installer/images/bannrbmp.bmp > windows/ovs-windows-installer/images/dlgbmp.bmp > windows/ovs-windows-installer/ovs-windows-installer.wixproj > make[2]: *** [dist-hook-git] Error 1 > make[2]: Leaving directory `/c/Shares/openvswitch' > make[1]: *** [all-recursive] Error 1 > make[1]: Leaving directory `/c/Shares/openvswitch' > make: *** [all] Error 2 > > > We need each patch compilable. So if you fixed it later, then that fix > has to come as part of this patch. > > The windows/README.rst misses mentioning a few needed executables. It > probably makes sense to make the language generic. That way, you don't > have to keep updating this document whenever we have to add new > executables. Since "make installer" does the copying automatically it > should be okay not to mention all the executables by name in > README.rst. > > It probably makes sense to mention the location where the msi file is created? > > The installer completely ignores ssl related arguments needed for > ovsdb-server and ovs-vswitchd, but I don't mind that being added > sometime later. > > End User License agreement has "Copyright 2014 Open vSwitch". I have > not seen that one before used in OVS repo before. I will ask for Ben's > opinion on what is the right thing to do there. I had a quick chat with Ben on this. Open vSwitch is not an organization, so it does not make sense to add a copyright that states "Open vSwitch". We have a long list of copyright holders in debian/copyright.in file, but it does not make sense to list all of it in the installer. So we thought that the easiest solution is to not have any copyright holders added there.
> > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
