On Wed, Apr 29, 2015 at 03:41:00PM +0000, Nithin Raju wrote: > >> As you know, the Windows kernel is synchronous in terms of netlink > >> messages. Transaction semantics are implemented in one call that > >> includes both the “request” and the “reply” in one shot. So, if > >> there’s a mismatch, it implies the kernel bungled the ‘nlmsg_seq’. So, > >> the assert was added to catch this. As the code matures, we can nuke > >> it perhaps, but we have not seen this fire so far. > >> > >> Pls. let me know if I’m missing anything. > > > > In a case like that I'd usually just put a bare ovs_assert, instead of a > > whole error-handling block, since the ovs_assert by itself should cover > > it. > > > > At any rate, it's harmless. > > hi Ben, > I agree with your comment. > > The error handling was in place since we were doing the whole “netlink > emulation” with any OS support unlike Linux, and we wanted to catch issues in > release builds also. > > If you are not very particular, can I let the code be? Once the code matures > more, we can start removing stuff like this.
It's OK for now. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
